buffered_syslogger 0.1.0 → 0.1.1

data/README.rdoc

@@ -1,11 +1,12 @@
 = BufferedSyslogger
 
 A drop-in replacement for the Rails 3 default BufferedLogger library,
-that logs to syslog instead of a log file. Builds on the `syslogger` gem.
+that logs to syslog instead of a log file. Builds on the
+{syslogger}[http://github.com/crohr/syslogger] gem.
 
 == Installation
 
-Put it into your Gemfile:
+Put this into your Gemfile:
 
   gem 'buffered_syslogger'
 
@@ -24,7 +25,8 @@ Put it into your Gemfile:
 
 == Copyright
 
-Copyright (c) 2010 László Bács, Secret Sauce Partners, Inc.
+Copyright (c) 2010 László Bácsi, Secret Sauce Partners, Inc.
+
 Copyright (c) 2010 Cyril, INRIA Rennes-Bretagne Atlantique.
 
 See LICENSE for details.

data/lib/buffered_syslogger.rb

@@ -67,7 +67,7 @@ class BufferedSyslogger < ActiveSupport::BufferedLogger
         Syslog.open(@ident, @options, @facility) do |s|
           s.mask = Syslog::LOG_UPTO(MAPPING[@level])
           old_buffer.each do |severity, message|
-            message.split(/[\r\f\n]/).each { |m| s.log(MAPPING[severity], m) }
+            message.split(/[\r\f\n]/).each { |m| s.log(MAPPING[severity], m.gsub('%', '%%')) }
           end
         end
       end

data/spec/buffered_syslogger_spec.rb

@@ -19,33 +19,31 @@ describe BufferedSyslogger do
   end
 
   %w{debug info warn error fatal unknown}.each do |logger_method|
-    it "should respond to the #{logger_method.inspect} method" do
-      BufferedSyslogger.new.should respond_to logger_method.to_sym
-    end
+    it { should respond_to :"#{logger_method}" }
+    it { should respond_to :"#{logger_method}?" }
   end
 
-  %w{debug info warn error fatal unknown}.each do |logger_method|
-    it "should respond to the #{logger_method.inspect}? method" do
-      BufferedSyslogger.new.should respond_to "#{logger_method}?".to_sym
-    end
+  it "should escape % characters" do
+    Syslog.should_receive(:open).and_yield(syslog)
+    syslog.should_receive(:log).with(Syslog::LOG_INFO, "IE6 is at 5.6%% out of 31.1%% total IE share")
+    subject.info "IE6 is at 5.6% out of 31.1% total IE share"
   end
 
-  describe "add" do
-    before do
-      @logger = BufferedSyslogger.new("my_app", Syslog::LOG_PID, Syslog::LOG_USER)
-    end
-    it "should respond to add" do
-      @logger.should respond_to(:add)
-    end
-    it "should correctly log" do
-      Syslog.should_receive(:open).with("my_app", Syslog::LOG_PID, Syslog::LOG_USER).and_yield(syslog)
+  describe '#add' do
+    subject { BufferedSyslogger.new("my_app", Syslog::LOG_PID, Syslog::LOG_USER) }
+
+    it { should respond_to(:add) }
+
+    it "should correctly log a simple message" do
+      Syslog.should_receive(:open).and_yield(syslog)
       syslog.should_receive(:log).with(Syslog::LOG_INFO, "message")
-      @logger.add(Logger::INFO, "message")
+      subject.add(Logger::INFO, "message")
     end
+
     it "should take the message from the block if :message is nil" do
-      Syslog.should_receive(:open).with("my_app", Syslog::LOG_PID, Syslog::LOG_USER).and_yield(syslog)
+      Syslog.should_receive(:open).and_yield(syslog)
       syslog.should_receive(:log).with(Syslog::LOG_INFO, "my message")
-      @logger.add(Logger::INFO) { "my message" }
+      subject.add(Logger::INFO) { "my message" }
     end
   end
 

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: buffered_syslogger
 version: !ruby/object:Gem::Version 
-  hash: 27
+  hash: 25
   prerelease: false
   segments: 
   - 0
   - 1
-  - 0
-  version: 0.1.0
+  - 1
+  version: 0.1.1
 platform: ruby
 authors: 
 - !binary |
@@ -18,7 +18,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2010-10-11 00:00:00 +02:00
+date: 2010-10-12 00:00:00 +02:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency