buddy_translatable 1.0.2 → 1.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 4e189cdc05da2e42b02d5863d2b936003417be87ec79076a111c7c96278fab31
-  data.tar.gz: 3cc54ac8f488cdb2318fcc624b1a2719c7db976b8b270d274788eae73ab25dd4
+  metadata.gz: 14a66ca05f9355589a0a39d41e9432fc4f71bc52d7c6fbd686dfd941b1e867fb
+  data.tar.gz: e41a1b0f34843838a4dd6af3d6db262f721d97fdcf666f5419570b1c443f1829
 SHA512:
-  metadata.gz: d83e39ffa2db864154bb58cbebef361034c20c9f7388b6191bbce7b0fcd030b3250f608e0ed8dd5cb66262fad941e5bc6b758b7358cb18e5b3207b8bd1124415
-  data.tar.gz: 7b97f4bdce0772d5fd170bc195110b445eb211754e18fbd99edac3ad6a34795ca6632ffa892f10d594497a2aee99702ae8ae43c3bbae7e6bd625d8e9b26b2ea9
+  metadata.gz: 4e6176e0b6865bc9c0eea329c6585536b2d6ac7ff0790201dac09aab63d72c1527575790f0dd4e7a5cf630b6702f3db3f6edaf942b6199bc3f5332bd611d698f
+  data.tar.gz: abecbd30c7f980eeafe4325a8ff9994a4700da8f8d8a45ffeb66a627266ab5a59db83cbfbd3401c5a2bad008578970eccc8127ec496790ff3eec58f1720af8c7

data/CHANGELOG.md

@@ -1,3 +1,6 @@
+# 1.0.2 (02-02-2023)
+- Fix: fix postgres migration error "current transaction is aborted, commands ignored until end of transaction block"
+
 # 1.0.1 (18-06-2021)
 - Fix: fix error when running rails db:migrate
 

data/Dockerfile

@@ -1,6 +1,6 @@
 FROM ruby:2.5
 RUN apt-get update -qq
-RUN gem install bundler
+RUN gem install bundler -v 2.3.26
 WORKDIR /app
 COPY . /app
 RUN bundle install

data/Gemfile.lock

@@ -21,6 +21,7 @@ GEM
       tzinfo (~> 2.0)
       zeitwerk (~> 2.3)
     ast (2.4.2)
+    byebug (11.1.3)
     concurrent-ruby (1.1.9)
     diff-lcs (1.3)
     i18n (1.8.10)
@@ -70,6 +71,7 @@ PLATFORMS
 DEPENDENCIES
   buddy_translatable!
   bundler
+  byebug
   pg
   rake
   rspec

data/README.md

@@ -90,41 +90,24 @@ class AddTitleToPosts < ActiveRecord::Migration
 end
 ```
 
-### Queries
+### Filters
 
-For searching you can use the following concern (Only `jsonb` format attributes):
+- Filter for an item with exact value in any locale
 ```ruby
-module JsonbQuerable
-  extend ActiveSupport::Concern
-
-  included do
-    scope :where_jsonb_value, lambda { |attr, value|
-      attr_query = sanitize_sql("#{table_name}.#{attr}")
-      where("EXISTS (SELECT 1 FROM jsonb_each_text(#{attr_query}) j
-                              WHERE j.value = ?)", value)
-    }
-
-    scope :where_jsonb_value_like, lambda { |attr, value, case_sens = false|
-      attr_query = sanitize_sql("#{table_name}.#{attr}")
-      condition = case_sens ? 'j.value LIKE ?' : 'lower(j.value) LIKE lower(?)'
-      where("EXISTS (SELECT 1
-                     FROM jsonb_each_text(#{attr_query}) j
-                     WHERE #{condition})", "%#{value}%")
-    }
-  end
-end
-
-class Post < ActiveRecord::Base
-  #...
-  include JsonbQuerable
-  #...
-end
+# where_<attr_name>_with(value: String)
+Post.where_key_with('ebay')
+```
 
-Post.where_jsonb_value_like(:key, 'ebay')
+- Filter for items with any locale that contains the provided value
+```ruby
+# where_<attr_name>_like(value: String)
+Post.where_key_like('bay')
 ```
-Simple queries:
+
+- Filter for items where current locale has the exact provided value
 ```ruby
-Post.where("title->>'en' = ?", 'hello')
+# where_<attr_name>_eq(value: String, locale?: Symbol)
+Post.where_key_eq('ebay')
 ```
 
 ## Development

data/lib/buddy_translatable/core.rb

@@ -10,24 +10,23 @@ module BuddyTranslatable
       end
     end
 
-    # rubocop:disable Style/RescueModifier
     def define_translatable_methods(attr, fallback_locale)
-      format = (try(:column_types) || try(:attribute_types))[attr.to_s].type rescue :text
-      define_translatable_setters(attr, format)
+      is_json = BuddyTranslatable.translatable_attr_json?(self, attr)
+      define_translatable_setters(attr, is_json)
       define_translatable_key_getters(attr, fallback_locale)
       define_translatable_getters(attr)
+      define_translatable_finders(attr, is_json)
     end
-    # rubocop:enable Style/RescueModifier
 
     # Sample:
     #   model.title_data = { de: 'de val', en: 'en val' } # ==> replace value data
     #   model.title = { de: 'de val', en: 'en val' } # replace value data
     #   model.title = 'custom value' # sets new value for current locale
-    def define_translatable_setters(attr, format)
+    def define_translatable_setters(attr, is_json)
       define_method("#{attr}_data=") do |arg|
         data = send("#{attr}_data")
         data = arg.is_a?(Hash) ? arg.symbolize_keys : data.merge(I18n.locale => arg)
-        self[attr] = %i[string text].include?(format) ? data.to_json : data
+        self[attr] = is_json ? data : data.to_json
       end
 
       define_method("#{attr}=") do |arg|
@@ -41,7 +40,7 @@ module BuddyTranslatable
     def define_translatable_key_getters(attr, fallback_locale)
       define_method("#{attr}_data_for") do |key|
         value = send("#{attr}_data")
-        value[key] ||
+        value[key].presence ||
           value[fallback_locale].presence ||
           value.values.find(&:present?)
       end
@@ -82,5 +81,27 @@ module BuddyTranslatable
         end
       end
     end
+
+    # Sample string value: {\"en\":\"key-1\"}
+    def define_translatable_finders(attr, is_json) # rubocop:disable Metrics/MethodLength Metrics/AbcSize
+      attr_query = sanitize_sql("#{table_name}.#{attr}")
+      scope :"where_#{attr}_with", (lambda do |value|
+        return where("#{attr_query} like ?", "%\":\"#{value}\"%") unless is_json
+
+        where("EXISTS (SELECT 1 FROM jsonb_each_text(#{attr_query}) j WHERE j.value = ?)", value)
+      end)
+
+      scope :"where_#{attr}_like", (lambda do |value|
+        return where("#{attr_query} like ?", "%#{value}%") unless is_json
+
+        where("EXISTS (SELECT 1 FROM jsonb_each_text(#{attr_query}) j WHERE j.value LIKE ?)", "%#{value}%")
+      end)
+
+      scope :"where_#{attr}_eq", (lambda do |value, locale = I18n.locale|
+        return where("#{attr_query} like ?", "%\"#{locale}\":\"#{value}\"%") unless is_json
+
+        where("#{attr}->>'#{locale}' = ?", value)
+      end)
+    end
   end
 end

data/lib/buddy_translatable/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module BuddyTranslatable
-  VERSION = '1.0.2'
+  VERSION = '1.1.1'
 end

data/lib/buddy_translatable.rb

@@ -6,4 +6,13 @@ module BuddyTranslatable
   def self.included(base)
     base.extend BuddyTranslatable::Core
   end
+
+  def self.translatable_attr_json?(model_class, attr)
+    migrated = ActiveRecord::Base.connection.tables.include?(model_class.table_name) rescue nil
+    return :text unless migrated
+
+    columns_data = model_class.try(:column_types) || model_class.try(:attribute_types)
+    format = (columns_data[attr.to_s].type rescue :text) # rubocop:disable Style/RescueModifier
+    %i[string text].exclude?(format)
+  end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: buddy_translatable
 version: !ruby/object:Gem::Version
-  version: 1.0.2
+  version: 1.1.1
 platform: ruby
 authors:
 - Owen
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2021-08-03 00:00:00.000000000 Z
+date: 2023-05-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler