buckaruby 1.2.0 → 1.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: d4513790fda002b5a98011b97768f0e4daad118822dc2d8acfbb0eabe259f86b
-  data.tar.gz: 86fcda3eaf10ff9129d074c236e0e1b4037a3c905ab48cc72c8769e1bae22fd2
+  metadata.gz: 855a453200b91387930947cdd68b6d315e5cf3072f0f96af43c9aedd602d2a19
+  data.tar.gz: 811de69c1218ab1e5a10c8f9d3ca1ddf8e8e01bea31da9157bc6203fde9a3a1a
 SHA512:
-  metadata.gz: b50d76de5cebb6bae5c698b7f052619657a2afb9745e1c7dcf235d9be21e83ca4f05dc23be13dede2881c82fda4b47a1d117dfe90629a7b3d942b54dbab9a2ab
-  data.tar.gz: d6a9032e3b38d91ff1d4353aec269c558dbb0a034282ece2fbd512f69e000ccb65e2c738c0f2992bf040b0315bb8024bb932c7000c212a8c62846aff178dd75c
+  metadata.gz: 4ce0ce26ff6272ccd8fa73d95c7af0078b1f68a20723a6c8214cb1a1fafe1e2a8755ee8ccf05202f921904f8d54b603daed3d378f0465467be958da346fe756d
+  data.tar.gz: c569a0978c2723ba373a00f620a08dc8593f6fb9a0e4e8e21a1804fbf34e3163f0cb06ff8802b588e020bb92fcbae96e5d20a6a00f84a1c6f48e0f76764590b1

data/CHANGELOG.md

@@ -1,6 +1,10 @@
 # Buckaruby changelog
 
-## 1.2.0 (2019-08-11)
+## 1.3.0 (2019-10-08)
+
+- Added payment method American Express.
+
+## 1.2.0 (2019-08-06)
 
 - Added support for sending custom & additional variables with the request.
 

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    buckaruby (1.2.0)
+    buckaruby (1.3.0)
 
 GEM
   remote: https://rubygems.org/

data/lib/buckaruby/gateway.rb

@@ -151,7 +151,7 @@ module Buckaruby
 
       valid_payment_methods = [
         PaymentMethod::IDEAL, PaymentMethod::IDEAL_PROCESSING, PaymentMethod::VISA, PaymentMethod::MASTER_CARD, PaymentMethod::MAESTRO,
-        PaymentMethod::SEPA_DIRECT_DEBIT, PaymentMethod::PAYPAL, PaymentMethod::BANCONTACT_MISTER_CASH
+        PaymentMethod::AMERICAN_EXPRESS, PaymentMethod::SEPA_DIRECT_DEBIT, PaymentMethod::PAYPAL, PaymentMethod::BANCONTACT_MISTER_CASH
       ]
       validate_payment_method!(options, valid_payment_methods)
 
@@ -191,7 +191,7 @@ module Buckaruby
       validate_amount!(options)
 
       valid_payment_methods = [
-        PaymentMethod::VISA, PaymentMethod::MASTER_CARD, PaymentMethod::MAESTRO,
+        PaymentMethod::VISA, PaymentMethod::MASTER_CARD, PaymentMethod::MAESTRO, PaymentMethod::AMERICAN_EXPRESS,
         PaymentMethod::SEPA_DIRECT_DEBIT, PaymentMethod::PAYPAL
       ]
       validate_payment_method!(options, valid_payment_methods)

data/lib/buckaruby/payment_method.rb

@@ -14,5 +14,6 @@ module Buckaruby
     VISA = "visa"
     MASTER_CARD = "mastercard"
     MAESTRO = "maestro"
+    AMERICAN_EXPRESS = "amex"
   end
 end

data/lib/buckaruby/response.rb

@@ -177,18 +177,38 @@ module Buckaruby
       if params[:brq_transaction_type] && !params[:brq_transaction_type].empty?
         # See http://support.buckaroo.nl/index.php/Transactietypes
         case params[:brq_transaction_type]
-        when 'C001', 'C002', 'C004', 'C021', 'C043', 'C044', 'C046', 'C089', 'C090', 'C192', 'C251', 'V001', 'V002', 'V010', 'V021', 'V032', 'V034', 'V043', 'V044', 'V046', 'V089', 'V090', 'V192', 'V245'
+        when 'C021', 'V021',                                  # iDEAL
+             'C002', 'C004', 'C005',                          # (SEPA) Direct Debit
+             'V010', 'V014',                                  # PayPal
+             'C090', 'V090',                                  # Bancontact
+             'C001',                                          # Transfer
+             'C044', 'C192', 'V002', 'V032', 'V044', 'V192',  # Visa
+             'C043', 'C089', 'V001', 'V043', 'V089', 'V031',  # MasterCard
+             'C046', 'C251', 'V034', 'V046', 'V245', 'V094',  # Maestro
+             'V003', 'V030', 'V036', 'V042'                   # American Express
+
           # Check the recurring flag to detect a normal or recurring transaction.
           if params[:brq_recurring] && params[:brq_recurring].casecmp("true").zero?
             TransactionType::PAYMENT_RECURRENT
           else
             TransactionType::PAYMENT
           end
-        when 'C005', 'V014', 'V031', 'V094'
-          TransactionType::PAYMENT_RECURRENT
-        when 'C079', 'C080', 'C082', 'C092', 'C101', 'C102', 'C121', 'C194', 'C197', 'C252', 'C500', 'V067', 'V068', 'V070', 'V079', 'V080', 'V082', 'V092', 'V101', 'V102', 'V110', 'V149', 'V194', 'V197', 'V246'
+        when 'C121',                                                  # iDEAL
+             'C102', 'C500',                                          # (SEPA) Direct Debit
+             'V110',                                                  # PayPal
+             'C092', 'V092',                                          # Bancontact
+             'C101',                                                  # Transfer
+             'C080', 'C194', 'V068', 'V080', 'V102', 'V194',          # Visa
+             'C079', 'C197', 'V067', 'V079', 'V101', 'V149', 'V197',  # MasterCard
+             'C082', 'C252', 'V070', 'V082', 'V246',                  # Maestro
+             'V066', 'V072', 'V078', 'V103'                           # American Express
           TransactionType::REFUND
-        when 'C501', 'C502', 'C546', 'C551', 'C553', 'C554', 'C562', 'C589', 'C593', 'V111', 'V131', 'V132', 'V134', 'V143', 'V144', 'V146', 'V543', 'V544', 'V545', 'V546', 'V589', 'V592'
+        when 'C501', 'C502', 'C562',                                  # (SEPA) Direct Debit
+             'V111',                                                  # PayPal
+             'C554', 'C593', 'V132', 'V144', 'V544', 'V592',          # Visa
+             'C553', 'C589', 'V131', 'V143', 'V543', 'V589',          # MasterCard
+             'C546', 'C551', 'V134', 'V146', 'V545', 'V546',          # Maestro
+             'V130', 'V136', 'V142'                                   # American Express
           TransactionType::REVERSAL
         end
       else

data/lib/buckaruby/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Buckaruby
-  VERSION = "1.2.0"
+  VERSION = "1.3.0"
 end

data/spec/buckaruby/gateway_spec.rb

@@ -215,7 +215,7 @@ RSpec.describe Buckaruby::Gateway do
         expect(response.custom[:quux]).to eq("42")
 
         expect(WebMock).to have_requested(:post, "https://testcheckout.buckaroo.nl/nvp/?op=TransactionRequest")
-          .with(body: "brq_websitekey=12345678&brq_payment_method=ideal&brq_culture=nl-NL&brq_currency=EUR&brq_amount=10.0&brq_invoicenumber=12345&brq_service_ideal_action=Pay&brq_service_ideal_issuer=ABNANL2A&brq_service_ideal_version=2&brq_return=http%3A%2F%2Fwww.return.url%2F&cust_foo=bar&cust_quux=42&add_buckaruby=Buckaruby+#{Buckaruby::VERSION}&brq_signature=0fb3ff3c1f140b5aede33a0fdacbc5675830120d")
+          .with(body: "brq_websitekey=12345678&brq_payment_method=ideal&brq_culture=nl-NL&brq_currency=EUR&brq_amount=10.0&brq_invoicenumber=12345&brq_service_ideal_action=Pay&brq_service_ideal_issuer=ABNANL2A&brq_service_ideal_version=2&brq_return=http%3A%2F%2Fwww.return.url%2F&cust_foo=bar&cust_quux=42&add_buckaruby=Buckaruby+#{Buckaruby::VERSION}&brq_signature=e185c8a1bce030a3e0d001f0c09fbf6b0c8f88ab")
       end
     end
 
@@ -227,7 +227,7 @@ RSpec.describe Buckaruby::Gateway do
         expect(response.additional[:myreference]).to eq("12345")
 
         expect(WebMock).to have_requested(:post, "https://testcheckout.buckaroo.nl/nvp/?op=TransactionRequest")
-          .with(body: "brq_websitekey=12345678&brq_payment_method=ideal&brq_culture=nl-NL&brq_currency=EUR&brq_amount=10.0&brq_invoicenumber=12345&brq_service_ideal_action=Pay&brq_service_ideal_issuer=ABNANL2A&brq_service_ideal_version=2&brq_return=http%3A%2F%2Fwww.return.url%2F&add_myreference=12345&add_buckaruby=Buckaruby+#{Buckaruby::VERSION}&brq_signature=f7996840436bdd55dada28b80c62ed88af10cd23")
+          .with(body: "brq_websitekey=12345678&brq_payment_method=ideal&brq_culture=nl-NL&brq_currency=EUR&brq_amount=10.0&brq_invoicenumber=12345&brq_service_ideal_action=Pay&brq_service_ideal_issuer=ABNANL2A&brq_service_ideal_version=2&brq_return=http%3A%2F%2Fwww.return.url%2F&add_myreference=12345&add_buckaruby=Buckaruby+#{Buckaruby::VERSION}&brq_signature=40ee09a9b7ccac816318c9e9bc81493fcee183f7")
       end
     end
   end
@@ -573,6 +573,20 @@ RSpec.describe Buckaruby::Gateway do
         expect(response.timestamp).to be_an_instance_of(Time)
         expect(response.to_h).to be_an_instance_of(Hash)
       end
+
+      it 'sets the transaction type to payment and payment method to American Express for amex callback' do
+        params = File.read("spec/fixtures/responses/callback_payment_amex.txt")
+
+        response = subject.callback(params)
+        expect(response.transaction_status).to eq(Buckaruby::TransactionStatus::SUCCESS)
+        expect(response.transaction_type).to eq(Buckaruby::TransactionType::PAYMENT)
+        expect(response.payment_method).to eq(Buckaruby::PaymentMethod::AMERICAN_EXPRESS)
+        expect(response.transaction_id).to eq("41C48B55FA9164E123CC73B1157459E840BE5D24")
+        expect(response.payment_id).to eq("E86256B2787EE7FF0C33D0D4C6159CD922227B79")
+        expect(response.invoicenumber).to eq("12345")
+        expect(response.timestamp).to be_an_instance_of(Time)
+        expect(response.to_h).to be_an_instance_of(Hash)
+      end
     end
 
     context 'when callback is a payment recurrent response' do
@@ -635,6 +649,21 @@ RSpec.describe Buckaruby::Gateway do
         expect(response.timestamp).to be_an_instance_of(Time)
         expect(response.to_h).to be_an_instance_of(Hash)
       end
+
+      it 'recognizes an amex refund response' do
+        params = File.read("spec/fixtures/responses/callback_refund_amex.txt")
+
+        response = subject.callback(params)
+        expect(response.transaction_status).to eq(Buckaruby::TransactionStatus::SUCCESS)
+        expect(response.transaction_type).to eq(Buckaruby::TransactionType::REFUND)
+        expect(response.payment_method).to eq(Buckaruby::PaymentMethod::AMERICAN_EXPRESS)
+        expect(response.transaction_id).to eq("B51118F58785274E117EFE1BF99D4D50CCB96949")
+        expect(response.payment_id).to be nil
+        expect(response.invoicenumber).to eq("12345")
+        expect(response.refund_transaction_id).to eq("41C48B55FA9164E123CC73B1157459E840BE5D24")
+        expect(response.timestamp).to be_an_instance_of(Time)
+        expect(response.to_h).to be_an_instance_of(Hash)
+      end
     end
 
     context 'when callback is a reversal response' do

data/spec/fixtures/responses/callback_payment_amex.txt

@@ -0,0 +1 @@
+brq_amount=1.00&brq_currency=EUR&brq_customer_name=Test&brq_description=Test+American+Express&brq_invoicenumber=12345&brq_issuing_country=NL&brq_mutationtype=Processing&brq_payer_hash=ec4dcf6c815f12bd75b7f5a2ef61d0307c868bd2a48a7af4ab5425c4abd475bb9c5c85f279baed6e4e4576a59b9d16311dcc1c9dd6be100386876905d909c99e&brq_payment=E86256B2787EE7FF0C33D0D4C6159CD922227B79&brq_SERVICE_amex_Authentication=Y&brq_SERVICE_amex_CardExpirationDate=2019-10&brq_SERVICE_amex_CardNumberEnding=8084&brq_SERVICE_amex_Enrolled=Y&brq_SERVICE_amex_MaskedCreditcardNumber=375317%2A%2A%2A%2A%2A8084&brq_statuscode=190&brq_statuscode_detail=S001&brq_statusmessage=Transaction+successfully+processed&brq_test=true&brq_timestamp=2019-10-08+10%3A02%3A31&brq_transaction_method=amex&brq_transaction_type=V036&brq_transactions=41C48B55FA9164E123CC73B1157459E840BE5D24&brq_websitekey=12345678&brq_signature=495dbdbb3c87c04351bec97cd40bafe0addec0f3

data/spec/fixtures/responses/callback_refund_amex.txt

@@ -0,0 +1 @@
+brq_amount_credit=1.00&brq_currency=EUR&brq_invoicenumber=12345&brq_mutationtype=Processing&brq_relatedtransaction_refund=41C48B55FA9164E123CC73B1157459E840BE5D24&brq_statuscode=190&brq_statusmessage=Success&brq_test=true&brq_timestamp=2019-10-08+10%3A21%3A28&brq_transaction_method=amex&brq_transaction_type=V072&brq_transactions=B51118F58785274E117EFE1BF99D4D50CCB96949&brq_websitekey=1234567&brq_signature=feccc64fd8bdf9c17b1dd48961513f2361991439

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: buckaruby
 version: !ruby/object:Gem::Version
-  version: 1.2.0
+  version: 1.3.0
 platform: ruby
 authors:
 - Kentaa
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-08-06 00:00:00.000000000 Z
+date: 2019-10-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -108,6 +108,7 @@ files:
 - spec/buckaruby/signature_spec.rb
 - spec/buckaruby/support/case_insensitive_hash_spec.rb
 - spec/fixtures/responses/callback_invalid_signature.txt
+- spec/fixtures/responses/callback_payment_amex.txt
 - spec/fixtures/responses/callback_payment_cancelled.txt
 - spec/fixtures/responses/callback_payment_empty_transaction_type.txt
 - spec/fixtures/responses/callback_payment_failed.txt
@@ -117,6 +118,7 @@ files:
 - spec/fixtures/responses/callback_payment_success.txt
 - spec/fixtures/responses/callback_recurrent_sepa.txt
 - spec/fixtures/responses/callback_recurrent_visa.txt
+- spec/fixtures/responses/callback_refund_amex.txt
 - spec/fixtures/responses/callback_refund_ideal.txt
 - spec/fixtures/responses/callback_refund_paypal.txt
 - spec/fixtures/responses/callback_reversal_paypal.txt
@@ -151,8 +153,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.7.9
+rubygems_version: 3.0.6
 signing_key: 
 specification_version: 4
 summary: Ruby library for communicating with the Buckaroo Payment Engine 3.0.
@@ -163,6 +164,7 @@ test_files:
 - spec/buckaruby/signature_spec.rb
 - spec/buckaruby/support/case_insensitive_hash_spec.rb
 - spec/fixtures/responses/callback_invalid_signature.txt
+- spec/fixtures/responses/callback_payment_amex.txt
 - spec/fixtures/responses/callback_payment_cancelled.txt
 - spec/fixtures/responses/callback_payment_empty_transaction_type.txt
 - spec/fixtures/responses/callback_payment_failed.txt
@@ -172,6 +174,7 @@ test_files:
 - spec/fixtures/responses/callback_payment_success.txt
 - spec/fixtures/responses/callback_recurrent_sepa.txt
 - spec/fixtures/responses/callback_recurrent_visa.txt
+- spec/fixtures/responses/callback_refund_amex.txt
 - spec/fixtures/responses/callback_refund_ideal.txt
 - spec/fixtures/responses/callback_refund_paypal.txt
 - spec/fixtures/responses/callback_reversal_paypal.txt