bsv-sdk 0.2.0 → 0.2.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 83e581aac74bb9865acd4dac19b8e7422f8a018f7fea7cd9085eb6ad58add6ca
-  data.tar.gz: 7f9bd7d2b7902dc080943a4b4ac30526e82ba38a0d278be14b07d575a8f52ade
+  metadata.gz: d8f24ed29fd0a8beb572b3737c3bbfaba5bf939c5fe20d485306e5e4374587c1
+  data.tar.gz: 53746a1cdad1370718892805b76c763fbe58a73ef057bd65a1eaa4b1b120c7bd
 SHA512:
-  metadata.gz: a2ad1b26a36e2c052f4109b4ec3649bfdc1f3efd08d0e0e8b08b054a7f61b0a0ae2f777f0da3d4445259681e06b0dd31dc74b252ae0ed8c10f5ff11f67963917
-  data.tar.gz: '08955c85b4bee8ffcc1c7e84e775c3306ccf8e573103f2347072f86bcd67633abd96193fe516484e94f4cd047edaad5cda52b6612dabbceade6b05dd272acd09'
+  metadata.gz: 93590d116e66151f51af5167bb405b2d91cd2997f685fad0d684cd07f5231aa1387d57d71852e5464f3f222d1b471534d22ab6633c75d188f9080c1718f834a0
+  data.tar.gz: b26e9a26837af3ce9426311050c0e2fbbdaac9ce4d04a7987c123ef189ec6528e779c69bd7b77605e25df70c1510327a71b7843151f50eb710b2b63a788eeae2

data/CHANGELOG.md

@@ -5,6 +5,22 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## [0.2.1] - 2026-03-07
+
+### Fixed
+
+- Truncated OP_PUSHDATA1/2/4 scripts now raise `ArgumentError` instead of crashing with `TypeError`
+- `Transaction#to_beef` uses `merge_bump` to correctly handle multiple ancestors at the same block height
+- `PrivateKey#derive_child` uses `BN.mod_add` instead of Integer roundtrip for modular addition
+- Fixed txid byte-order documentation (display order, not internal order)
+
+### Testing
+
+- FORKID enforcement spec verifying interpreter rejects signatures without SIGHASH_FORKID
+- ExtendedKey fingerprint chain integrity across 3-generation derivation
+- Mnemonic entropy round-trip across all 5 valid entropy lengths
+- BEEF spec for multiple ancestors at the same block height
+
 ## [0.2.0] - 2026-03-07
 
 ### Added

data/lib/bsv/primitives/private_key.rb

@@ -158,8 +158,7 @@ module BSV
         shared = derive_shared_secret(public_key)
         hmac = Digest.hmac_sha256(shared.compressed, invoice_number.encode('UTF-8'))
         hmac_bn = OpenSSL::BN.new(hmac.unpack1('H*'), 16)
-        child_bn = (@bn + hmac_bn).to_i % Curve::N.to_i
-        PrivateKey.new(OpenSSL::BN.new(child_bn.to_s))
+        PrivateKey.new(@bn.mod_add(hmac_bn, Curve::N))
       end
 
       # Sign a 32-byte hash using deterministic ECDSA (RFC 6979).

data/lib/bsv/script/script.rb

@@ -391,22 +391,26 @@ module BSV
           pos += 1
 
           if opcode.positive? && opcode <= 0x4b
+            raise ArgumentError, "truncated script: need #{opcode} data bytes at offset #{pos}" if pos + opcode > raw.bytesize
             data = raw.byteslice(pos, opcode)
             pos += opcode
             result << Chunk.new(opcode: opcode, data: data)
           elsif opcode == Opcodes::OP_PUSHDATA1
+            raise ArgumentError, "truncated script: OP_PUSHDATA1 missing length byte at offset #{pos}" if pos >= raw.bytesize
             len = raw.getbyte(pos)
             pos += 1
             data = raw.byteslice(pos, len)
             pos += len
             result << Chunk.new(opcode: opcode, data: data)
           elsif opcode == Opcodes::OP_PUSHDATA2
+            raise ArgumentError, "truncated script: OP_PUSHDATA2 needs 2 length bytes at offset #{pos}" if pos + 2 > raw.bytesize
             len = raw.byteslice(pos, 2).unpack1('v')
             pos += 2
             data = raw.byteslice(pos, len)
             pos += len
             result << Chunk.new(opcode: opcode, data: data)
           elsif opcode == Opcodes::OP_PUSHDATA4
+            raise ArgumentError, "truncated script: OP_PUSHDATA4 needs 4 length bytes at offset #{pos}" if pos + 4 > raw.bytesize
             len = raw.byteslice(pos, 4).unpack1('V')
             pos += 4
             data = raw.byteslice(pos, len)

data/lib/bsv/transaction/beef.rb

@@ -63,7 +63,7 @@ module BSV
 
         # The transaction ID for this entry.
         #
-        # @return [String, nil] 32-byte txid in internal byte order
+        # @return [String, nil] 32-byte txid in display byte order
         def txid
           case @format
           when FORMAT_TXID_ONLY
@@ -210,7 +210,7 @@ module BSV
 
       # Find a transaction in the bundle by its transaction ID.
       #
-      # @param txid [String] 32-byte txid in internal byte order
+      # @param txid [String] 32-byte txid in display byte order
       # @return [Transaction, nil] the matching transaction, or nil
       def find_transaction(txid)
         @transactions.each do |beef_tx|
@@ -221,7 +221,7 @@ module BSV
 
       # Find the merkle path (BUMP) for a transaction by its txid.
       #
-      # @param txid [String] 32-byte txid in internal byte order
+      # @param txid [String] 32-byte txid in display byte order
       # @return [MerklePath, nil] the merkle path, or nil if not found
       def find_bump(txid)
         bt = @transactions.find { |entry| entry.txid == txid && entry.format == FORMAT_RAW_TX_AND_BUMP }
@@ -232,7 +232,7 @@ module BSV
 
       # Find a transaction with all source_transactions wired for signing.
       #
-      # @param txid [String] 32-byte txid in internal byte order
+      # @param txid [String] 32-byte txid in display byte order
       # @return [Transaction, nil] the transaction with wired inputs, or nil
       def find_transaction_for_signing(txid)
         tx = find_transaction(txid)
@@ -245,7 +245,7 @@ module BSV
       # Find a transaction and recursively wire its ancestry (source transactions
       # and merkle paths) for atomic proof validation.
       #
-      # @param txid [String] 32-byte txid in internal byte order
+      # @param txid [String] 32-byte txid in display byte order
       # @return [Transaction, nil] the transaction with full proof tree, or nil
       def find_atomic_transaction(txid)
         tx = find_transaction(txid)
@@ -381,7 +381,7 @@ module BSV
 
       # Convert a transaction entry to TXID-only format.
       #
-      # @param txid [String] 32-byte txid in internal byte order
+      # @param txid [String] 32-byte txid in display byte order
       # @return [BeefTx, nil] the converted entry, or nil if not found
       def make_txid_only(txid)
         idx = @transactions.index { |bt| bt.txid == txid }
@@ -557,7 +557,7 @@ module BSV
 
             # Wire inputs to ancestors already in the map (BEEF is dependency-ordered)
             beef_tx.transaction.inputs.each do |input|
-              # prev_tx_id is internal byte order; txid keys are display order (reversed)
+              # prev_tx_id is wire byte order; txid keys are display byte order (reversed)
               source = tx_map[input.prev_tx_id.reverse]
               input.source_transaction = source if source
             end

data/lib/bsv/transaction/transaction.rb

@@ -296,25 +296,15 @@ module BSV
       # @return [String] raw BEEF V2 binary
       def to_beef
         beef = Beef.new
-        bump_map = {}
         ancestors = collect_ancestors
 
         ancestors.each do |tx|
-          # Collect BUMPs
-          if tx.merkle_path
-            height = tx.merkle_path.block_height
-            unless bump_map.key?(height)
-              bump_map[height] = beef.bumps.length
-              beef.bumps << tx.merkle_path
-            end
-          end
-
-          # Add transaction in dependency order
           entry = if tx.merkle_path
+                    bump_idx = beef.merge_bump(tx.merkle_path)
                     Beef::BeefTx.new(
                       format: Beef::FORMAT_RAW_TX_AND_BUMP,
                       transaction: tx,
-                      bump_index: bump_map[tx.merkle_path.block_height]
+                      bump_index: bump_idx
                     )
                   else
                     Beef::BeefTx.new(
@@ -356,9 +346,13 @@ module BSV
 
       # --- Transaction ID ---
 
-      # Compute the transaction ID (double-SHA-256 of the serialised tx, reversed).
+      # Compute the transaction ID (double-SHA-256 of the serialised tx, byte-reversed).
+      #
+      # Returns display byte order (reversed from the natural hash).
+      # Compare with {TransactionInput#prev_tx_id} which stores wire byte
+      # order (natural hash). Use +.reverse+ to convert between the two.
       #
-      # @return [String] 32-byte transaction ID in internal byte order
+      # @return [String] 32-byte transaction ID in display byte order
       def txid
         BSV::Primitives::Digest.sha256d(to_binary).reverse
       end

data/lib/bsv/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module BSV
-  VERSION = '0.2.0'
+  VERSION = '0.2.1'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: bsv-sdk
 version: !ruby/object:Gem::Version
-  version: 0.2.0
+  version: 0.2.1
 platform: ruby
 authors:
 - Simon Bettison