bsv-sdk 0.18.0 → 0.19.0

data/lib/bsv/network/protocols/ordinals.rb

@@ -88,16 +88,16 @@ module BSV
         #
         # @param pos_txid [String, nil] transaction ID (positional form)
         # @param txid     [String, nil] transaction ID (keyword form)
-        # @return [Result::Success<String>, Result::Error, Result::NotFound]
+        # @return [ProtocolResponse]
         def call_get_tx(pos_txid = nil, txid: nil)
           resolved = pos_txid || txid
           raise ArgumentError, 'txid is required' if resolved.nil? || resolved.empty?
 
           result = default_call(:get_tx, resolved)
-          return result unless result.success?
-          return Result::Error.new(message: 'empty response body') if result.data.nil? || result.data.empty?
+          return result unless result.http_success?
+          return result.with(http_success: false, error_message: 'empty response body') if result.data.nil? || result.data.empty?
 
-          Result::Success.new(data: result.data.unpack1('H*'))
+          result.with(data: result.data.unpack1('H*'))
         end
 
         # Normalises the spend status response from the Ordinals API.
@@ -111,22 +111,22 @@ module BSV
         #
         # @param pos_outpoint [String, nil] outpoint in +"txid_vout"+ format (positional form)
         # @param outpoint     [String, nil] outpoint in +"txid_vout"+ format (keyword form)
-        # @return [Result::Success<Hash>, Result::Error, Result::NotFound]
+        # @return [ProtocolResponse]
         def call_get_spend(pos_outpoint = nil, outpoint: nil)
           resolved = pos_outpoint || outpoint
           raise ArgumentError, 'outpoint is required' if resolved.nil? || resolved.empty?
 
           result = default_call(:get_spend, resolved)
-          return result unless result.success?
+          return result unless result.http_success?
 
           spending_txid = JSON.parse(result.data).to_s.strip
           if spending_txid.empty?
-            Result::Success.new(data: { spent: false })
+            result.with(data: { spent: false })
           else
-            Result::Success.new(data: { spent: true, spending_txid: spending_txid })
+            result.with(data: { spent: true, spending_txid: spending_txid })
           end
-        rescue JSON::ParserError => e
-          Result::Error.new(message: "spend response parse error: #{e.message}")
+        rescue JSON::ParserError, TypeError => e
+          result.with(http_success: false, error_message: "spend response parse error: #{e.message}")
         end
       end
     end

data/lib/bsv/network/protocols/taal_binary.rb

@@ -19,7 +19,7 @@ module BSV
       #     auth: { api_key: 'mainnet_your_key_here' }
       #   )
       #   result = protocol.call(:broadcast, tx)
-      #   puts result.data[:txid] if result.success?
+      #   puts result.data[:txid] if result.http_success?
       #
       # @see https://docs.taal.com TAAL API documentation
       class TAALBinary < BSV::Network::Protocol
@@ -42,7 +42,7 @@ module BSV
         # TAAL-specific headers and applies TAAL-specific response quirk handling.
         #
         # @param tx [#to_binary, String] transaction object or raw binary string
-        # @return [Result::Success, Result::Error]
+        # @return [ProtocolResponse]
         def call_broadcast(tx)
           body = tx.respond_to?(:to_binary) ? tx.to_binary : tx
 
@@ -57,27 +57,26 @@ module BSV
           parse_broadcast_response(response)
         end
 
-        # Maps the HTTP response from TAAL broadcast to a Result, applying the
-        # +txn-already-known+ idempotency quirk.
+        # Maps the HTTP response from TAAL broadcast to a ProtocolResponse, applying
+        # the +txn-already-known+ idempotency quirk.
         #
         # @param response [Net::HTTPResponse]
-        # @return [Result::Success, Result::Error]
+        # @return [ProtocolResponse]
         def parse_broadcast_response(response)
           code = response.code.to_i
           body = parse_json_body(response.body)
 
-          # TAAL API boundary: display-order hex txid from the TAAL broadcast response
-          return Result::Success.new(data: { txid: body['txid'] }) if already_known?(body) && body['txid']
-
-          retryable = code == 429 || (500..599).cover?(code)
+          # TAAL API boundary: display-order hex txid from the TAAL broadcast response.
+          # The HTTP response class is non-2xx here, so we must pass http_success: true explicitly.
+          return ProtocolResponse.new(response, data: { txid: body['txid'] }, http_success: true) if already_known?(body) && body['txid']
 
           if (200..299).cover?(code)
-            return Result::Error.new(message: 'TAAL returned a malformed 2xx response', retryable: false) unless body['txid']
+            return ProtocolResponse.new(response, http_success: false, error_message: 'TAAL returned a malformed 2xx response') unless body['txid']
 
-            Result::Success.new(data: { txid: body['txid'] })
+            ProtocolResponse.new(response, data: { txid: body['txid'] })
           else
             message = (body.is_a?(Hash) && body['error']) || "HTTP #{code}"
-            Result::Error.new(message: message, retryable: retryable)
+            ProtocolResponse.new(response, http_success: false, error_message: message)
           end
         end
 

data/lib/bsv/network/protocols/woc_rest.rb

@@ -21,7 +21,7 @@ module BSV
       #
       #   woc = BSV::Network::Protocols::WoCREST.new(network: :main)
       #   result = woc.call(:get_tx, 'abc123...')
-      #   puts result.data if result.success?
+      #   puts result.data if result.http_success?
       #
       # @see https://developers.whatsonchain.com/ WhatsOnChain API documentation
       class WoCREST < Protocol
@@ -169,18 +169,18 @@ module BSV
         # @param txid        [String]  WoC API boundary: display-order hex transaction ID
         # @param vout        [Integer] output index
         # @param script_hash [String, nil] ignored
-        # @return [Result::Success<Boolean>, Result::Error]
+        # @return [ProtocolResponse<Boolean>]
         def call_is_utxo(txid, vout, script_hash: nil) # rubocop:disable Lint/UnusedMethodArgument
           result = default_call(:is_utxo, txid, vout)
 
           # 404 = no spending tx found = output is unspent
-          return Result::Success.new(data: true) if result.not_found?
+          return result.with(data: true, http_success: true, error_message: nil) if result.http_not_found?
 
           # Non-success, non-404 = genuine error
-          return result unless result.success?
+          return result unless result.http_success?
 
           # 200 with spending tx details = output is spent
-          Result::Success.new(data: false)
+          result.with(data: false)
         end
 
         # Bulk-checks whether a set of outputs are unspent.
@@ -192,15 +192,15 @@ module BSV
         # Entries absent from the response (unknown outputs) are treated as spent.
         #
         # @param outpoints [Array<Hash>] array of +{ txid:, vout: }+ hashes
-        # @return [Result::Success<Hash{String => Boolean}>, Result::Error]
+        # @return [ProtocolResponse<Hash{String => Boolean}>]
         #   On success, data is a hash mapping +"txid.vout"+ keys to booleans
         #   (+true+ = unspent, +false+ = spent).
         def call_is_utxo_bulk(outpoints)
-          return Result::Success.new(data: {}) if outpoints.empty?
+          return ProtocolResponse.new(nil, data: {}, http_success: true) if outpoints.empty?
 
           body = JSON.generate(utxos: outpoints.map { |op| { 'txid' => op[:txid].to_s, 'vout' => op[:vout].to_i } })
           result = default_call(:is_utxo_bulk, body: body)
-          return result unless result.success?
+          return result unless result.http_success?
 
           # Build a lookup from the response entries
           # spentIn present and non-empty → spent (false); absent or empty → unspent (true)
@@ -219,7 +219,7 @@ module BSV
             normalised[key] = false unless normalised.key?(key)
           end
 
-          Result::Success.new(data: normalised)
+          result.with(data: normalised)
         end
 
         # Broadcasts a raw transaction to WhatsOnChain.
@@ -229,17 +229,17 @@ module BSV
         # stripped and wrapped in a Hash for caller convenience.
         #
         # @param tx [#to_hex, String] transaction object or raw hex string
-        # @return [Result::Success<{ txid: String }>, Result::Error]
+        # @return [ProtocolResponse<{ txid: String }>]
         def call_broadcast(tx)
           hex  = tx.respond_to?(:to_hex) ? tx.to_hex : tx.to_s
           body = JSON.generate(txhex: hex)
 
           result = default_call(:broadcast, body: body)
-          return result unless result.success?
+          return result unless result.http_success?
 
           # WoC returns plain-text txid — result.data is the raw body string
           # WoC API boundary: display-order hex txid returned as plain text
-          Result::Success.new(data: { txid: result.data.to_s.strip })
+          result.with(data: { txid: result.data.to_s.strip })
         end
 
         # Decodes a raw transaction hex by posting to the WoC decode endpoint.
@@ -248,7 +248,7 @@ module BSV
         # full decoded transaction object.
         #
         # @param txhex [String] raw transaction hex string
-        # @return [Result::Success<Hash>, Result::Error]
+        # @return [ProtocolResponse]
         def call_decode_tx(txhex)
           body = JSON.generate(txhex: txhex.to_s)
           default_call(:decode_tx, body: body)
@@ -259,7 +259,7 @@ module BSV
         # WoC expects +{ "txids": [...] }+ as the request body.
         #
         # @param txids [Array<String>] list of transaction IDs
-        # @return [Result::Success<Array>, Result::Error]
+        # @return [ProtocolResponse]
         def call_get_tx_hex_bulk(txids)
           body = JSON.generate(txids: txids)
           default_call(:get_tx_hex_bulk, body: body)
@@ -270,7 +270,7 @@ module BSV
         # WoC expects +{ "scripts": [...] }+ as the request body.
         #
         # @param script_hashes [Array<String>] list of script hashes
-        # @return [Result::Success<Hash>, Result::Error]
+        # @return [ProtocolResponse]
         def call_get_script_unspent_bulk(script_hashes)
           body = JSON.generate(scripts: script_hashes)
           default_call(:get_script_unspent_bulk, body: body)
@@ -281,7 +281,7 @@ module BSV
         # WoC expects +{ "txids": [...] }+ as the request body.
         #
         # @param txids [Array<String>] list of transaction IDs
-        # @return [Result::Success<Array>, Result::Error]
+        # @return [ProtocolResponse]
         def call_get_bulk_tx_details(txids)
           body = JSON.generate(txids: txids)
           default_call(:get_bulk_tx_details, body: body)
@@ -292,7 +292,7 @@ module BSV
         # WoC expects +{ "txids": [{ "txid": "...", "vouts": [0, 1] }, ...] }+ as the request body.
         #
         # @param tx_vouts [Array<Hash>] array of +{ txid:, vouts: [Integer] }+ hashes
-        # @return [Result::Success<Array>, Result::Error]
+        # @return [ProtocolResponse]
         def call_get_bulk_output_scripts(tx_vouts)
           body = JSON.generate(txids: tx_vouts.map { |tv| { 'txid' => tv[:txid].to_s, 'vouts' => tv[:vouts] } })
           default_call(:get_bulk_output_scripts, body: body)
@@ -303,7 +303,7 @@ module BSV
         # WoC expects +{ "addresses": [...] }+ as the request body.
         #
         # @param addresses [Array<String>] list of addresses
-        # @return [Result::Success<Array>, Result::Error]
+        # @return [ProtocolResponse]
         def call_get_bulk_address_utxos(addresses)
           body = JSON.generate(addresses: addresses)
           default_call(:get_bulk_address_utxos, body: body)
@@ -314,7 +314,7 @@ module BSV
         # WoC expects +{ "addresses": [...] }+ as the request body.
         #
         # @param addresses [Array<String>] list of addresses
-        # @return [Result::Success<Array>, Result::Error]
+        # @return [ProtocolResponse]
         def call_get_bulk_address_unconfirmed_utxos(addresses)
           body = JSON.generate(addresses: addresses)
           default_call(:get_bulk_address_unconfirmed_utxos, body: body)
@@ -325,7 +325,7 @@ module BSV
         # WoC expects +{ "scripts": [...] }+ as the request body.
         #
         # @param script_hashes [Array<String>] list of script hashes
-        # @return [Result::Success<Hash>, Result::Error]
+        # @return [ProtocolResponse]
         def call_get_bulk_script_unconfirmed_unspent(script_hashes)
           body = JSON.generate(scripts: script_hashes)
           default_call(:get_bulk_script_unconfirmed_unspent, body: body)
@@ -336,7 +336,7 @@ module BSV
         # WoC expects +{ "query": "..." }+ as the request body.
         #
         # @param query [String] search term
-        # @return [Result::Success<Hash>, Result::Error]
+        # @return [ProtocolResponse]
         def call_search_links(query)
           body = JSON.generate(query: query)
           default_call(:search_links, body: body)
@@ -351,7 +351,7 @@ module BSV
         #
         # @param txids [Array<String>, nil] list of transaction IDs (positional)
         # @param body  [String, nil] pre-serialised request body (keyword)
-        # @return [Result::Success<Array>, Result::Error]
+        # @return [ProtocolResponse]
         # @raise [ArgumentError] when neither txids nor body is provided
         def call_get_tx_status(txids = nil, body: nil)
           raise ArgumentError, 'provide txids array or body: keyword' if txids.nil? && body.nil?
@@ -368,13 +368,13 @@ module BSV
         #
         # @param root   [String]  expected merkle root as hex
         # @param height [Integer] block height
-        # @return [Result::Success<Boolean>, Result::Error, Result::NotFound]
+        # @return [ProtocolResponse<Boolean>]
         def call_valid_root(root, height)
           result = default_call(:valid_root, height)
-          return result unless result.success?
+          return result unless result.http_success?
 
           actual = result.data['merkleroot']
-          Result::Success.new(data: actual.to_s.downcase == root.to_s.downcase)
+          result.with(data: actual.to_s.downcase == root.to_s.downcase)
         end
       end
     end

data/lib/bsv/network/protocols.rb

@@ -3,9 +3,8 @@
 module BSV
   module Network
     # Protocols is a namespace module for concrete Protocol subclasses.
-    #
-    # Protocol implementations (e.g. ARC, WhatsOnChain adapters built on
-    # the Protocol base class) will be autoloaded here in Phase B.
+    # Each class maps a service's commands to HTTP endpoints: ARC, Chaintracks,
+    # JungleBus, Ordinals, TAALBinary, and WoCREST.
     module Protocols
       autoload :ARC,         'bsv/network/protocols/arc'
       autoload :Chaintracks, 'bsv/network/protocols/chaintracks'

data/lib/bsv/network/provider.rb

@@ -20,7 +20,7 @@ module BSV
     #   end
     #
     #   result = gorillapool.call(:broadcast, tx)
-    #   result.success?  # => true
+    #   result.http_success?  # => true
     class Provider
       attr_reader :name, :auth, :rate_limit
 
@@ -124,7 +124,7 @@ module BSV
       # @param command_name [Symbol, String] command to invoke
       # @param args   [Array]  positional arguments forwarded to the protocol
       # @param kwargs [Hash]   keyword arguments forwarded to the protocol
-      # @return [Result::Success, Result::Error, Result::NotFound]
+      # @return [ProtocolResponse]
       # @raise [ArgumentError] when no registered protocol serves the command
       def call(command_name, *args, **kwargs)
         sym      = command_name.to_sym

data/lib/bsv/network.rb

@@ -2,16 +2,11 @@
 
 module BSV
   module Network
-    autoload :Result,             'bsv/network/result'
+    autoload :ProtocolResponse,   'bsv/network/protocol_response'
     autoload :Protocol,           'bsv/network/protocol'
     autoload :Protocols,          'bsv/network/protocols'
     autoload :Providers,          'bsv/network/providers'
     autoload :Provider,           'bsv/network/provider'
-    autoload :BroadcastError,     'bsv/network/broadcast_error'
-    autoload :BroadcastResponse,  'bsv/network/broadcast_response'
-    autoload :ChainProviderError, 'bsv/network/chain_provider_error'
     autoload :UTXO,               'bsv/network/utxo'
-    autoload :ARC,                'bsv/network/arc'
-    autoload :WhatsOnChain,       'bsv/network/whats_on_chain'
   end
 end

data/lib/bsv/transaction/chain_tracker.rb

@@ -2,22 +2,40 @@
 
 module BSV
   module Transaction
-    # Base class for chain trackers that verify merkle roots against the blockchain.
+    # Duck type for block header lookups used by the SDK's verify methods.
     #
-    # Chain trackers confirm that a given merkle root corresponds to a valid block
-    # at a specific height. This is essential for SPV verification — without it,
-    # merkle proofs cannot be validated against the actual blockchain.
+    # {Beef#verify}, {MerklePath#verify}, and {Transaction#verify} define
+    # what a valid structure *is* — they walk trees, check proofs, and
+    # compare roots. But they have no data source of their own. The
+    # chain tracker is the data source: an object the consumer provides
+    # that can answer "is this merkle root valid for this block height?"
     #
-    # Subclasses must implement {#valid_root_for_height?} and {#current_height}.
+    # The SDK is deliberately unopinionated about where that answer comes
+    # from. A chain tracker backed by an in-memory hash is declarative.
+    # One that fetches from the network on cache miss and writes to a
+    # database is imperative. The verify methods don't care — they just
+    # ask the question. All imperative behaviour (fetching, caching,
+    # persisting) lives in the consumer's chain tracker implementation,
+    # not in the SDK.
     #
-    # @example Implementing a custom chain tracker
-    #   class MyTracker < BSV::Transaction::ChainTracker
-    #     def valid_root_for_height?(root, height)
-    #       # query your block header source
-    #     end
+    # Any object responding to +valid_root_for_height?+ and
+    # +current_height+ satisfies this interface. Inheriting from this
+    # class is optional — it exists to document the contract and provide
+    # clear error messages when methods are missing.
     #
-    #     def current_height
-    #       # return current chain tip height
+    # @example In-memory chain tracker (test / declarative)
+    #   class HashTracker < BSV::Transaction::ChainTracker
+    #     def initialize(headers)  @headers = headers end
+    #     def valid_root_for_height?(root, h) @headers[h] == root end
+    #     def current_height() @headers.keys.max end
+    #   end
+    #   tracker = HashTracker.new(800_000 => 'abcd...')
+    #
+    # @example Cache-aware chain tracker (production / imperative)
+    #   class WalletChainTracker < BSV::Transaction::ChainTracker
+    #     def valid_root_for_height?(root, height)
+    #       header = @db.find_header(height) || fetch_and_store(height)
+    #       header.merkle_root == root
     #     end
     #   end
     class ChainTracker

data/lib/bsv/transaction/chain_trackers/chaintracks.rb

@@ -54,17 +54,12 @@ module BSV
         # @param root [String] merkle root as a hex string
         # @param height [Integer] block height
         # @return [Boolean]
-        # @raise [BSV::Network::ChainProviderError] on network or API error
+        # @raise [StandardError] on network or API error
         def valid_root_for_height?(root, height)
           result = @protocol.call(:get_block_header, height)
-          return false if result.not_found?
+          return false if result.http_not_found?
 
-          if result.error?
-            raise BSV::Network::ChainProviderError.new(
-              result.message.to_s,
-              status_code: result.metadata[:status_code]
-            )
-          end
+          raise result.message.to_s unless result.http_success?
 
           merkle_root = result.data['merkleRoot']
           return false unless merkle_root
@@ -75,15 +70,12 @@ module BSV
         # Return the current blockchain height.
         #
         # @return [Integer]
-        # @raise [BSV::Network::ChainProviderError] on network or API error
+        # @raise [StandardError] on network or API error
         def current_height
           result = @protocol.call(:current_height)
-          return result.data if result.success?
+          return result.data if result.http_success?
 
-          raise BSV::Network::ChainProviderError.new(
-            result.message.to_s,
-            status_code: result.metadata[:status_code]
-          )
+          raise result.message.to_s
         end
       end
     end

data/lib/bsv/transaction/chain_trackers/whats_on_chain.rb

@@ -47,17 +47,12 @@ module BSV
         # @param root [String] merkle root as a hex string
         # @param height [Integer] block height
         # @return [Boolean]
-        # @raise [BSV::Network::ChainProviderError] on network or API error
+        # @raise [StandardError] on network or API error
         def valid_root_for_height?(root, height)
           result = @protocol.call(:valid_root, root, height)
-          return false if result.not_found?
+          return false if result.http_not_found?
 
-          if result.error?
-            raise BSV::Network::ChainProviderError.new(
-              result.message.to_s,
-              status_code: result.metadata[:status_code]
-            )
-          end
+          raise result.message.to_s unless result.http_success?
 
           result.data == true
         end
@@ -65,15 +60,12 @@ module BSV
         # Return the current blockchain height.
         #
         # @return [Integer]
-        # @raise [BSV::Network::ChainProviderError] on network or API error
+        # @raise [StandardError] on network or API error
         def current_height
           result = @protocol.call(:current_height)
-          return result.data if result.success?
+          return result.data if result.http_success?
 
-          raise BSV::Network::ChainProviderError.new(
-            result.message.to_s,
-            status_code: result.metadata[:status_code]
-          )
+          raise result.message.to_s
         end
 
         # Wraps an injectable HTTP client to set a raw Authorization header value

data/lib/bsv/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module BSV
-  VERSION = '0.18.0'
+  VERSION = '0.19.0'
 end

data/lib/bsv/wallet/proto_wallet.rb

@@ -8,15 +8,51 @@ module BSV
   module Wallet
     # Minimal cryptographic wallet implementing the BRC-100 interface.
     #
-    # ProtoWallet provides signing, encryption, HMAC, and key derivation
-    # without transactions, storage, or blockchain interaction. It is the
-    # direct implementation of the BRC-100 crypto methods, not a delegating
-    # client. This makes it suitable for use in the SDK's Auth module without
-    # depending on the bsv-wallet gem.
+    # ProtoWallet is a direct, in-process implementation of the BRC-100 crypto
+    # operations. It requires no external gem, no storage, and no blockchain
+    # access — making it suitable for use inside the SDK itself (e.g. the Auth
+    # module) as well as lightweight applications that need cryptographic
+    # operations without full wallet infrastructure.
     #
-    # Includes +BSV::Wallet::Interface::BRC100+ — methods it supports are
-    # overridden; unsupported methods (transactions, blockchain, authentication)
-    # fall through to +NotImplementedError+.
+    # == Supported BRC-100 areas
+    #
+    # - *Public key management* — {#get_public_key}, {#reveal_counterparty_key_linkage},
+    #   {#reveal_specific_key_linkage}
+    # - *Cryptography* — {#encrypt}, {#decrypt}, {#create_hmac}, {#verify_hmac},
+    #   {#create_signature}, {#verify_signature}
+    # - *Certificates (read-only stub)* — {#list_certificates} returns an empty list;
+    #   {#prove_certificate} raises {UnsupportedActionError}
+    #
+    # == NOT supported
+    #
+    # The following BRC-100 areas are not implemented and will raise
+    # +NotImplementedError+:
+    #
+    # - Transactions (+create_action+, +sign_action+, +list_actions+, etc.)
+    # - Output management (+list_outputs+, +relinquish_output+, etc.)
+    # - Authentication (+authenticated?+, +wait_for_authentication+)
+    # - Blockchain / network data (+get_height+, +get_header_for_height+, etc.)
+    # - Certificate acquisition / discovery (+acquire_certificate+,
+    #   +discover_by_identity_key+, etc.)
+    #
+    # For full wallet functionality, use the +bsv-wallet+ gem. See
+    # +docs/sdk/wallet.md+ for usage guidance.
+    #
+    # == Construction
+    #
+    # Pass a {BSV::Primitives::PrivateKey} or the special string <tt>'anyone'</tt>.
+    # The <tt>'anyone'</tt> variant uses a well-known key (private key = 1) and is
+    # suitable for verifying or encrypting data that should be readable by
+    # any party — it must not be used where secrecy is required.
+    #
+    # @example Normal usage
+    #   wallet = BSV::Wallet::ProtoWallet.new(BSV::Primitives::PrivateKey.generate)
+    #   sig = wallet.create_signature(protocol_id: [1, 'my-app'], key_id: 'msg-1',
+    #                                 data: 'hello'.bytes)
+    #
+    # @example Anyone wallet
+    #   wallet = BSV::Wallet::ProtoWallet.new('anyone')
+    #   pub = wallet.get_public_key(identity_key: true)
     #
     class ProtoWallet
       include Interface::BRC100

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: bsv-sdk
 version: !ruby/object:Gem::Version
-  version: 0.18.0
+  version: 0.19.0
 platform: ruby
 authors:
 - Simon Bettison
@@ -96,11 +96,8 @@ files:
 - lib/bsv/mcp/tools/generate_key.rb
 - lib/bsv/mcp/tools/helpers.rb
 - lib/bsv/network.rb
-- lib/bsv/network/arc.rb
-- lib/bsv/network/broadcast_error.rb
-- lib/bsv/network/broadcast_response.rb
-- lib/bsv/network/chain_provider_error.rb
 - lib/bsv/network/protocol.rb
+- lib/bsv/network/protocol_response.rb
 - lib/bsv/network/protocols.rb
 - lib/bsv/network/protocols/arc.rb
 - lib/bsv/network/protocols/chaintracks.rb
@@ -113,9 +110,7 @@ files:
 - lib/bsv/network/providers/gorilla_pool.rb
 - lib/bsv/network/providers/taal.rb
 - lib/bsv/network/providers/whats_on_chain.rb
-- lib/bsv/network/result.rb
 - lib/bsv/network/utxo.rb
-- lib/bsv/network/whats_on_chain.rb
 - lib/bsv/overlay.rb
 - lib/bsv/overlay/admin_token_template.rb
 - lib/bsv/overlay/broadcast_facilitator.rb

data/lib/bsv/network/arc.rb

@@ -1,26 +0,0 @@
-# frozen_string_literal: true
-
-module BSV
-  module Network
-    # @deprecated Use {BSV::Network::Protocols::ARC} directly instead.
-    #   The facade converted clean Result objects into exceptions — every
-    #   consumer immediately caught them and converted back to data.
-    #   Use the protocol layer, which returns Result objects natively.
-    class ARC
-      # Raised when deprecated facade classes are instantiated.
-      class DeprecationError < StandardError; end
-
-      MESSAGE = 'BSV::Network::ARC is deprecated. ' \
-                'Use BSV::Network::Protocols::ARC directly — it returns Result objects ' \
-                'instead of raising exceptions. See BSV::Network::Protocols::ARC for usage.'
-
-      def self.default(**)
-        raise DeprecationError, MESSAGE
-      end
-
-      def initialize(*)
-        raise DeprecationError, MESSAGE
-      end
-    end
-  end
-end

data/lib/bsv/network/broadcast_error.rb

@@ -1,18 +0,0 @@
-# frozen_string_literal: true
-
-module BSV
-  module Network
-    class BroadcastError < StandardError
-      # ARC API boundary: display-order hex txid as returned by the ARC error response.
-      attr_reader :status_code, :txid, :arc_status
-
-      def initialize(message, status_code: nil, txid: nil, arc_status: nil)
-        @status_code = status_code
-        BSV::Primitives::Hex.validate_dtxid_hex!(txid, name: 'ARC error txid') if txid
-        @txid = txid
-        @arc_status = arc_status
-        super(message)
-      end
-    end
-  end
-end

data/lib/bsv/network/broadcast_response.rb

@@ -1,31 +0,0 @@
-# frozen_string_literal: true
-
-module BSV
-  module Network
-    class BroadcastResponse
-      # ARC API boundary: display-order hex txid as returned by the ARC broadcast endpoint.
-      attr_reader :txid, :tx_status, :message, :extra_info, :block_hash, :block_height, :timestamp, :competing_txs
-
-      def initialize(attrs = {})
-        txid = attrs[:txid]
-        BSV::Primitives::Hex.validate_dtxid_hex!(txid, name: 'ARC broadcast txid') if txid
-        @txid = txid
-        @tx_status = attrs[:tx_status]
-        @message = attrs[:message]
-        @extra_info = attrs[:extra_info]
-        @block_hash = attrs[:block_hash]
-        @block_height = attrs[:block_height]
-        @timestamp = attrs[:timestamp]
-        @competing_txs = attrs[:competing_txs]
-      end
-
-      def success?
-        true
-      end
-
-      def mined?
-        tx_status == 'MINED'
-      end
-    end
-  end
-end