bson 4.15.0 → 5.0.2

data/spec/bson/decimal128_spec.rb

@@ -1,3 +1,4 @@
+# rubocop:todo all
 # Copyright (C) 2016-2020 MongoDB Inc.
 #
 # Licensed under the Apache License, Version 2.0 (the "License");
@@ -28,10 +29,10 @@ describe BSON::Decimal128 do
 
     context 'when the argument is neither a BigDecimal or String' do
 
-      it 'raises an ArgumentError' do
+      it 'raises an InvalidDecimal128Argument error' do
         expect {
           described_class.new(:invalid)
-        }.to raise_exception(ArgumentError)
+        }.to raise_exception(BSON::Error::InvalidDecimal128Argument, /A Decimal128 can only be created from a String or BigDecimal./ )
       end
     end
 
@@ -46,7 +47,7 @@ describe BSON::Decimal128 do
       end
 
       let(:from_bson) do
-        described_class.from_bson(buffer)
+        described_class.from_bson(buffer, mode: :bson)
       end
 
       let(:expected_bson) do
@@ -314,7 +315,7 @@ describe BSON::Decimal128 do
       it 'raises InvalidRange' do
         lambda do
           described_class.new('1e10000')
-        end.should raise_error(BSON::Decimal128::InvalidRange, /Value out of range/)
+        end.should raise_error(BSON::Error::InvalidDecimal128Range, /Value out of range/)
       end
     end
 
@@ -322,7 +323,7 @@ describe BSON::Decimal128 do
       it 'raises UnrepresentablePrecision' do
         lambda do
           described_class.new('1.000000000000000000000000000000000000000000000000001')
-        end.should raise_error(BSON::Decimal128::UnrepresentablePrecision, /The value contains too much precision/)
+        end.should raise_error(BSON::Error::UnrepresentablePrecision, /The value contains too much precision/)
       end
     end
   end
@@ -344,7 +345,7 @@ describe BSON::Decimal128 do
       end
 
       let(:decimal128) do
-        BSON::Document.from_bson(buffer)['d']
+        BSON::Document.from_bson(buffer, mode: :bson)['d']
       end
 
       let(:object_from_string) do
@@ -1270,13 +1271,39 @@ describe BSON::Decimal128 do
       described_class.new(BigDecimal('1.23'))
     end
 
-    it "returns the decimal128 with $numberDecimal key" do
-      expect(object.as_json).to eq({ "$numberDecimal" => object.to_s })
+    it "returns the decimal128 as a string" do
+      expect(object.as_json).to eq('1.23')
+    end
+
+    %w[NaN -NaN SNaN -SNaN Infinity -Infinity].each do |value|
+      context "when special value #{value}" do
+
+        let(:object) do
+          described_class.new(value)
+        end
+
+        it "returns nil to be consistent with ActiveSupport" do
+          expect(object.as_json).to eq(nil)
+        end
+      end
     end
 
     it_behaves_like "a JSON serializable object"
   end
 
+  describe "#as_extended_json" do
+
+    let(:object) do
+      described_class.new(BigDecimal('1.23'))
+    end
+
+    it "returns the decimal128 with $numberDecimal key" do
+      expect(object.as_extended_json).to eq({ "$numberDecimal" => '1.23' })
+    end
+
+    it_behaves_like "an Extended JSON serializable object"
+  end
+
   describe "::BSON_TYPE" do
 
     it "returns 0x13" do
@@ -1361,7 +1388,7 @@ describe BSON::Decimal128 do
     end
   end
 
-  describe "#to_big_decimal" do
+  describe "#to_d" do
 
     shared_examples_for 'a decimal128 convertible to a Ruby BigDecimal' do
 
@@ -1370,6 +1397,10 @@ describe BSON::Decimal128 do
       end
 
       it 'properly converts the Decimal128 to a BigDecimal' do
+        expect(decimal128.to_d).to eq(expected_big_decimal)
+      end
+
+      it 'permits the alias #to_big_decimal' do
         expect(decimal128.to_big_decimal).to eq(expected_big_decimal)
       end
     end
@@ -1592,17 +1623,6 @@ describe BSON::Decimal128 do
     end
   end
 
-  context "when the class is loaded" do
-
-    let(:registered) do
-      BSON::Registry.get(described_class::BSON_TYPE, 'field')
-    end
-
-    it "registers the type" do
-      expect(registered).to eq(described_class)
-    end
-  end
-
   %w(== ===).each do |eq_op|
     let(:lhs) { described_class.new('1.2e12') }
 

data/spec/bson/document_as_spec.rb

@@ -1,3 +1,4 @@
+# rubocop:todo all
 # Copyright (C) 2021 MongoDB Inc.
 #
 # Licensed under the Apache License, Version 2.0 (the "License");

data/spec/bson/document_spec.rb

@@ -1,4 +1,4 @@
-# encoding: utf-8
+# rubocop:todo all
 
 # Copyright (C) 2009-2020 MongoDB Inc.
 #

data/spec/bson/ext_json_parse_spec.rb

@@ -1,3 +1,4 @@
+# rubocop:todo all
 # Copyright (C) 2020 MongoDB Inc.
 #
 # Licensed under the Apache License, Version 2.0 (the "License");

data/spec/bson/false_class_spec.rb

@@ -1,3 +1,4 @@
+# rubocop:todo all
 # Copyright (C) 2009-2020 MongoDB Inc.
 #
 # Licensed under the Apache License, Version 2.0 (the "License");
@@ -25,4 +26,11 @@ describe FalseClass do
     it_behaves_like "a bson element"
     it_behaves_like "a serializable bson element"
   end
+
+  describe '#as_extended_json' do
+    let(:object) { false }
+
+    it_behaves_like '#as_extended_json returns self'
+    it_behaves_like 'an Extended JSON serializable object'
+  end
 end

data/spec/bson/float_spec.rb

@@ -1,3 +1,4 @@
+# rubocop:todo all
 # Copyright (C) 2009-2020 MongoDB Inc.
 #
 # Licensed under the Apache License, Version 2.0 (the "License");
@@ -34,15 +35,17 @@ describe Float do
   end
 
   describe '#as_extended_json' do
+    let(:object) { 42.0 }
+
     context 'canonical mode' do
       it 'returns $numberDouble' do
-        42.0.as_extended_json.should == {'$numberDouble' => '42.0'}
+        object.as_extended_json.should == {'$numberDouble' => '42.0'}
       end
     end
 
     context 'relaxed mode' do
       let(:serialized) do
-        42.0.as_extended_json(mode: :relaxed)
+        object.as_extended_json(mode: :relaxed)
       end
 
       it 'returns float' do
@@ -53,7 +56,7 @@ describe Float do
 
     context 'legacy mode' do
       let(:serialized) do
-        42.0.as_extended_json(mode: :legacy)
+        object.as_extended_json(mode: :legacy)
       end
 
       it 'returns float' do
@@ -61,5 +64,7 @@ describe Float do
         serialized.should be_within(0.00001).of(42)
       end
     end
+
+    it_behaves_like "an Extended JSON serializable object"
   end
 end

data/spec/bson/hash_as_spec.rb

@@ -1,3 +1,4 @@
+# rubocop:todo all
 # Copyright (C) 2021 MongoDB Inc.
 #
 # Licensed under the Apache License, Version 2.0 (the "License");

data/spec/bson/hash_spec.rb

@@ -1,3 +1,4 @@
+# rubocop:todo all
 # Copyright (C) 2009-2020 MongoDB Inc.
 #
 # Licensed under the Apache License, Version 2.0 (the "License");
@@ -52,93 +53,36 @@ describe Hash do
       end
     end
 
-    context "when the hash has invalid keys" do
+    context "when the hash has dollar keys" do
 
       let(:obj) do
         { "$testing" => "value" }
       end
 
-      context "when validating keys" do
 
-        context "when validating globally" do
-
-          before do
-            BSON::Config.validating_keys = true
-          end
-
-          after do
-            BSON::Config.validating_keys = false
-          end
-
-          it "raises an error" do
-            expect {
-              obj.to_bson
-            }.to raise_error(BSON::String::IllegalKey)
-          end
-
-          context "when the hash contains an array of documents containing invalid keys" do
-
-            let(:obj) do
-              { "array" =>  [{ "$testing" => "value" }] }
-            end
-
-            it "raises an error" do
-              expect {
-                obj.to_bson
-              }.to raise_error(BSON::String::IllegalKey)
-            end
-          end
-        end
-
-        context "when validating locally" do
-
-          it "raises an error" do
-            expect {
-              obj.to_bson(BSON::ByteBuffer.new, true)
-            }.to raise_error(BSON::String::IllegalKey)
-          end
+      let(:bson) do
+        "#{25.to_bson.to_s}#{String::BSON_TYPE}$testing#{BSON::NULL_BYTE}" +
+        "#{6.to_bson.to_s}value#{BSON::NULL_BYTE}#{BSON::NULL_BYTE}"
+      end
 
-          context "when the hash contains an array of documents containing invalid keys" do
+      it "serializes the hash" do
+        expect(obj.to_bson.to_s).to eq(bson)
+      end
 
-            let(:obj) do
-              { "array" =>  [{ "$testing" => "value" }] }
-            end
+      context "when the hash contains an array of documents containing invalid keys" do
 
-            it "raises an error" do
-              expect {
-                obj.to_bson(BSON::ByteBuffer.new, true)
-              }.to raise_error(BSON::String::IllegalKey)
-            end
-          end
+        let(:obj) do
+          { "array" =>  [{ "$testing" => "value" }] }
         end
-      end
-
-      context "when not validating keys" do
 
         let(:bson) do
-          "#{25.to_bson.to_s}#{String::BSON_TYPE}$testing#{BSON::NULL_BYTE}" +
-          "#{6.to_bson.to_s}value#{BSON::NULL_BYTE}#{BSON::NULL_BYTE}"
+          "#{45.to_bson.to_s}#{Array::BSON_TYPE}array#{BSON::NULL_BYTE}" +
+          "#{[{ "$testing" => "value" }].to_bson.to_s}#{BSON::NULL_BYTE}"
         end
 
         it "serializes the hash" do
           expect(obj.to_bson.to_s).to eq(bson)
         end
-
-        context "when the hash contains an array of documents containing invalid keys" do
-
-          let(:obj) do
-            { "array" =>  [{ "$testing" => "value" }] }
-          end
-
-          let(:bson) do
-            "#{45.to_bson.to_s}#{Array::BSON_TYPE}array#{BSON::NULL_BYTE}" +
-              "#{[{ "$testing" => "value" }].to_bson.to_s}#{BSON::NULL_BYTE}"
-          end
-
-          it "serializes the hash" do
-            expect(obj.to_bson.to_s).to eq(bson)
-          end
-        end
       end
     end
 
@@ -270,8 +214,28 @@ describe Hash do
         end.to_not raise_error
       end
 
-      it 'deserializes as a BSON::Decimal128' do
-        expect(from_bson).to eq({"x" => BSON::Decimal128.new('1')})
+      it 'deserializes as a BigDecimal' do
+        expect(from_bson).to eq({"x" => BigDecimal(1)})
+      end
+    end
+
+    context 'when deserializing round-tripping a Decimal128' do
+      let(:to_bson) do
+        {x:BSON::Decimal128.new('1')}.to_bson
+      end
+
+      let(:from_bson) do
+        Hash.from_bson(to_bson)
+      end
+
+      it 'doesn\'t raise on serialization' do
+        expect do
+          to_bson
+        end.to_not raise_error
+      end
+
+      it 'deserializes as a BigDecimal' do
+        expect(from_bson).to eq({"x" => BigDecimal(1)})
       end
     end
   end
@@ -348,7 +312,7 @@ describe Hash do
       it 'works' do
         expect do
           hash.to_bson
-        end.not_to raise_error
+        end.to_not raise_error
       end
     end
   end
@@ -372,7 +336,7 @@ describe Hash do
       let(:doc) { Hash.from_bson(buf) }
 
       it 'overwrites first value with second value' do
-        doc.should == {'foo' => 'overwrite'}
+        expect(doc).to eq({ 'foo' => 'overwrite' })
       end
     end
 
@@ -394,8 +358,56 @@ describe Hash do
       let(:doc) { Hash.from_bson(buf) }
 
       it 'overwrites first value with second value' do
-        doc.should == {'foo' => :bar}
+        expect(doc).to eq({ 'foo' => :bar })
       end
     end
+
+    context 'when deserializing a hash with a BigDecimal' do
+      let(:to_bson) do
+        {x: BigDecimal('1')}.to_bson
+      end
+
+      context 'when it has mode: :bson' do
+
+        let(:from_bson) do
+          Hash.from_bson(to_bson, mode: :bson)
+        end
+
+        it 'deserializes as a BigDecimal' do
+          expect(from_bson).to eq({"x" => BSON::Decimal128.new('1')})
+        end
+      end
+
+      context 'when it doesn\'t have mode: :bson' do
+
+        let(:from_bson) do
+          Hash.from_bson(to_bson)
+        end
+
+        it 'deserializes as a BigDecimal' do
+          expect(from_bson).to eq({"x" => BigDecimal(1)})
+        end
+      end
+    end
+  end
+
+  describe '#as_extended_json' do
+    let(:object) do
+      { 'foo' => :bar, 'baz' => ['qux', 1, 2.0, { 'lorem' => 1 }] }
+    end
+
+    let(:expected) do
+      { "foo" => { "$symbol" => "bar" },
+        "baz" => [ "qux",
+                   { "$numberInt" => "1" },
+                   { "$numberDouble" => "2.0" },
+                   { "lorem" => { "$numberInt" => "1" } } ] }
+    end
+
+    it "returns the binary data plus type" do
+      expect(object.as_extended_json).to eq(expected)
+    end
+
+    it_behaves_like 'an Extended JSON serializable object'
   end
 end

data/spec/bson/int32_spec.rb

@@ -1,3 +1,4 @@
+# rubocop:todo all
 # Copyright (C) 2009-2020 MongoDB Inc.
 #
 # Licensed under the Apache License, Version 2.0 (the "License");
@@ -254,23 +255,37 @@ describe BSON::Int32 do
     end
   end
 
+  describe '#as_json' do
+    let(:object) { described_class.new(42) }
+
+    it 'returns an Integer' do
+      expect(object.as_json).to eq 42
+    end
+
+    it_behaves_like "a JSON serializable object"
+  end
+
   describe '#as_extended_json' do
+    let(:object) { described_class.new(42) }
+
     context 'canonical mode' do
-      it 'returns $numberInt' do
-        described_class.new(42).as_extended_json.should == {'$numberInt' => '42'}
+      it 'returns a Hash with key $numberInt' do
+        expect(object.as_extended_json).to eq({ '$numberInt' => '42' })
       end
     end
 
     context 'relaxed mode' do
-      it 'returns integer' do
-        described_class.new(42).as_extended_json(mode: :relaxed).should == 42
+      it 'returns an Integer' do
+        expect(object.as_extended_json(mode: :relaxed)).to eq 42
       end
     end
 
     context 'legacy mode' do
-      it 'returns integer' do
-        described_class.new(42).as_extended_json(mode: :legacy).should be 42
+      it 'returns an Integer' do
+        expect(object.as_extended_json(mode: :legacy)).to eq 42
       end
     end
+
+    it_behaves_like "an Extended JSON serializable object"
   end
 end

data/spec/bson/int64_spec.rb

@@ -1,3 +1,4 @@
+# rubocop:todo all
 # Copyright (C) 2009-2020 MongoDB Inc.
 #
 # Licensed under the Apache License, Version 2.0 (the "License");
@@ -298,23 +299,37 @@ describe BSON::Int64 do
     end
   end
 
+  describe '#as_json' do
+    let(:object) { described_class.new(42) }
+
+    it 'returns an Integer' do
+      expect(object.as_json).to eq 42
+    end
+
+    it_behaves_like "a JSON serializable object"
+  end
+
   describe '#as_extended_json' do
+    let(:object) { described_class.new(42) }
+
     context 'canonical mode' do
-      it 'returns $numberLong' do
-        described_class.new(42).as_extended_json.should == {'$numberLong' => '42'}
+      it 'returns a Hash with key $numberLong' do
+        expect(object.as_extended_json).to eq({ '$numberLong' => '42' })
       end
     end
 
     context 'relaxed mode' do
-      it 'returns integer' do
-        described_class.new(42).as_extended_json(mode: :relaxed).should == 42
+      it 'returns an Integer' do
+        expect(object.as_extended_json(mode: :relaxed)).to eq 42
       end
     end
 
     context 'legacy mode' do
-      it 'returns integer' do
-        described_class.new(42).as_extended_json(mode: :legacy).should be 42
+      it 'returns an Integer' do
+        expect(object.as_extended_json(mode: :legacy)).to eq 42
       end
     end
+
+    it_behaves_like "an Extended JSON serializable object"
   end
 end

data/spec/bson/integer_spec.rb

@@ -1,3 +1,4 @@
+# rubocop:todo all
 # Copyright (C) 2009-2020 MongoDB Inc.
 #
 # Licensed under the Apache License, Version 2.0 (the "License");
@@ -69,29 +70,60 @@ describe Integer do
     end
   end
 
-  describe '#to_json' do
-    it 'returns integer' do
-      42.to_json.should == '42'
+  describe '#as_json' do
+    it 'returns an integer string' do
+      expect(42.to_json).to eq '42'
     end
   end
 
   describe '#as_extended_json' do
-    context 'canonical mode' do
-      it 'returns $numberInt' do
-        42.as_extended_json.should == {'$numberInt' => '42'}
+
+    context 'when 32-bit representable' do
+      let(:object) { 42 }
+
+      context 'canonical mode' do
+        it 'returns $numberInt when small' do
+          expect(object.as_extended_json).to eq({ '$numberInt' => '42' })
+        end
       end
-    end
 
-    context 'relaxed mode' do
-      it 'returns integer' do
-        42.as_extended_json(mode: :relaxed).should be 42
+      context 'relaxed mode' do
+        it 'returns integer' do
+          expect(object.as_extended_json(mode: :relaxed)).to eq 42
+        end
       end
+
+      context 'legacy mode' do
+        it 'returns integer' do
+          expect(object.as_extended_json(mode: :legacy)).to eq 42
+        end
+      end
+
+      it_behaves_like "an Extended JSON serializable object"
     end
 
-    context 'legacy mode' do
-      it 'returns integer' do
-        42.as_extended_json(mode: :legacy).should be 42
+    context 'when not 32-bit representable' do
+      let(:object) { 18014398241046527 }
+
+      context 'canonical mode' do
+        it 'returns $numberInt when small' do
+          expect(object.as_extended_json).to eq({ '$numberLong' => '18014398241046527' })
+        end
+      end
+
+      context 'relaxed mode' do
+        it 'returns integer' do
+          expect(object.as_extended_json(mode: :relaxed)).to eq 18014398241046527
+        end
       end
+
+      context 'legacy mode' do
+        it 'returns integer' do
+          expect(object.as_extended_json(mode: :legacy)).to eq 18014398241046527
+        end
+      end
+
+      it_behaves_like "an Extended JSON serializable object"
     end
   end
 end

data/spec/bson/json_spec.rb

@@ -1,3 +1,4 @@
+# rubocop:todo all
 # Copyright (C) 2009-2020 MongoDB Inc.
 #
 # Licensed under the Apache License, Version 2.0 (the "License");

data/spec/bson/max_key_spec.rb

@@ -1,3 +1,4 @@
+# rubocop:todo all
 # Copyright (C) 2009-2020 MongoDB Inc.
 #
 # Licensed under the Apache License, Version 2.0 (the "License");
@@ -49,17 +50,18 @@ describe BSON::MaxKey do
     end
   end
 
-  describe "#as_json" do
+  describe "#as_extended_json" do
 
     let(:object) do
       described_class.new
     end
 
     it "returns the binary data plus type" do
-      expect(object.as_json).to eq({ "$maxKey" => 1 })
+      expect(object.as_extended_json).to eq({ "$maxKey" => 1 })
     end
 
-    it_behaves_like "a JSON serializable object"
+    it_behaves_like 'an Extended JSON serializable object'
+    it_behaves_like '#as_json calls #as_extended_json'
   end
 
   describe "#to_bson/#from_bson" do

data/spec/bson/min_key_spec.rb

@@ -1,3 +1,4 @@
+# rubocop:todo all
 # Copyright (C) 2009-2020 MongoDB Inc.
 #
 # Licensed under the Apache License, Version 2.0 (the "License");
@@ -16,17 +17,18 @@ require "spec_helper"
 
 describe BSON::MinKey do
 
-  describe "#as_json" do
+  describe "#as_extended_json" do
 
     let(:object) do
       described_class.new
     end
 
     it "returns the binary data plus type" do
-      expect(object.as_json).to eq({ "$minKey" => 1 })
+      expect(object.as_extended_json).to eq({ "$minKey" => 1 })
     end
 
-    it_behaves_like "a JSON serializable object"
+    it_behaves_like 'an Extended JSON serializable object'
+    it_behaves_like '#as_json calls #as_extended_json'
   end
 
   describe "#==" do

data/spec/bson/nil_class_spec.rb

@@ -1,3 +1,4 @@
+# rubocop:todo all
 # Copyright (C) 2009-2020 MongoDB Inc.
 #
 # Licensed under the Apache License, Version 2.0 (the "License");