bson 4.0.0.rc0 → 4.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 50450bf61d6b631052b5a15fe98bcd5f572679d8
-  data.tar.gz: 079657ee59b117dcabc37e762642a90d5890f235
+  metadata.gz: 1da958014f886d3397ae3f00264fc2785bd1189b
+  data.tar.gz: cf112e2192dbf457e3dbea275c2b154a67611aa0
 SHA512:
-  metadata.gz: 5981ca13936db57eda138264169994bfa188cf0d79cb8808d1e7e1182dcf7de604017fa1b37e9c3179ed9154383b3ff2d0d449a72899e754b4e9b788235e0df9
-  data.tar.gz: 7142366162a5ac4648887be40a77285cff05f9e6c7198d47e36c37c298e26dba9c6b0ba11d429dea917460df304eeb88e5bbcc9f17443ae85ca31217c7f65f67
+  metadata.gz: 1f78c538b5b3e003a880cd93780f45f389163c629b519284b77ca5304f69a682d15d7cdfdae195e65c1e41e0c5ba85798c2433d283db35b301b64cfec2f14750
+  data.tar.gz: 9fb5768b82318f3bc316d7e9be975441aa0163ea574111141687972d4bcbb2e4a43905674fa30216a56d914337b5414b033fa131bd2488f60519d9527bbe1bf6

data/lib/bson/binary.rb

@@ -132,7 +132,7 @@ module BSON
     def to_bson(buffer = ByteBuffer.new)
       position = buffer.length
       buffer.put_int32(0)
-      buffer.put_byte(SUBTYPES.fetch(type))
+      buffer.put_byte(SUBTYPES[type])
       buffer.put_int32(data.bytesize) if type == :old
       buffer.put_bytes(data.force_encoding(BINARY))
       buffer.replace_int32(position, buffer.length - position - 5)

data/lib/bson/hash.rb

@@ -74,7 +74,7 @@ module BSON
       # @since 2.0.0
       def from_bson(buffer)
         hash = Document.allocate
-        buffer.get_int32 # Throw away the size - todo: just move read position?
+        buffer.get_int32 # Throw away the size.
         while (type = buffer.get_byte) != NULL_BYTE
           field = buffer.get_cstring
           hash.store(field, BSON::Registry.get(type).from_bson(buffer))

data/lib/bson/integer.rb

@@ -145,8 +145,8 @@ module BSON
       encoded << ((self >> 56) & 255)
     end
 
-    def to_bson_key(buffer = ByteBuffer.new)
-      buffer.put_cstring(to_s)
+    def to_bson_key
+      to_s
     end
 
     private
@@ -161,7 +161,6 @@ module BSON
     def out_of_range!
       raise RangeError.new("#{self} is not a valid 8 byte integer value.")
     end
-
   end
 
   # Enrich the core Integer class with this module.

data/lib/bson/registry.rb

@@ -40,7 +40,7 @@ module BSON
     #
     # @since 2.0.0
     def get(byte)
-      MAPPINGS.fetch(byte)
+      MAPPINGS[byte]
     end
 
     # Register the Ruby type for the corresponding single byte.

data/lib/bson/symbol.rb

@@ -30,6 +30,22 @@ module BSON
     # @since 2.0.0
     BSON_TYPE = 14.chr.force_encoding(BINARY).freeze
 
+    # Symbols are serialized as strings as symbols are now removed from the
+    # BSON specification. Therefore the bson_type when serializing must be a
+    # string.
+    #
+    # @example Get the BSON type for the symbol.
+    #   :test.bson_type
+    #
+    # @return [ String ] The single byte BSON type.
+    #
+    # @see http://bsonspec.org/#/specification
+    #
+    # @since 4.0.0
+    def bson_type
+      String::BSON_TYPE
+    end
+
     # Get the symbol as encoded BSON.
     #
     # @example Get the symbol as encoded BSON.
@@ -89,7 +105,7 @@ module BSON
     # Register this type when the module is loaded.
     #
     # @since 2.0.0
-    Registry.register(BSON_TYPE, ::Symbol)
+    Registry::MAPPINGS.store(BSON_TYPE, ::Symbol)
   end
 
   # Enrich the core Symbol class with this module.

data/lib/bson/version.rb

@@ -13,5 +13,5 @@
 # limitations under the License.
 
 module BSON
-  VERSION = "4.0.0.rc0"
+  VERSION = "4.0.0"
 end

data/spec/bson/document_spec.rb

@@ -840,15 +840,6 @@ describe BSON::Document do
       end
     end
 
-    context "when the symbols are utf-8" do
-
-      let(:document) do
-        described_class["type", "gültig".to_sym]
-      end
-
-      it_behaves_like "a document able to handle utf-8"
-    end
-
     context "when utf-8 string values are in an array" do
 
       let(:document) do
@@ -896,7 +887,7 @@ describe BSON::Document do
       end
     end
 
-    context "when binary strings with utf-8 values exist", if: BSON::Environment.jruby? && !(ENV['RUBY_VERSION'] =~ /jruby-9/) do
+    context "when binary strings with utf-8 values exist", if: BSON::Environment.jruby? && (JRUBY_VERSION !~ /9.0/) do
 
       let(:string) { "europäisch" }
       let(:document) do

data/spec/bson/hash_spec.rb

@@ -37,6 +37,21 @@ describe Hash do
       it_behaves_like "a deserializable bson element"
     end
 
+    context "when the hash has non-string keys" do
+
+      let(:obj) do
+        { 1 => "value" }
+      end
+
+      let(:expected) do
+        { "1" => "value" }
+      end
+
+      it "properly converts to bson" do
+        expect(BSON::Document.from_bson(BSON::ByteBuffer.new(obj.to_bson.to_s))).to eq(expected)
+      end
+    end
+
     context "when the hash is embedded" do
 
       let(:obj) do

data/spec/bson/integer_spec.rb

@@ -62,10 +62,10 @@ describe Integer do
   describe "#to_bson_key" do
 
     let(:obj)  { Integer::MAX_32BIT - 1 }
-    let(:encoded) { obj.to_s + BSON::NULL_BYTE }
+    let(:encoded) { obj.to_s }
 
-    it "returns the encoded string" do
-      expect(obj.to_bson_key.to_s).to eq(encoded)
+    it "returns the key as a string" do
+      expect(obj.to_bson_key).to eq(encoded)
     end
   end
 end

data/spec/bson/registry_spec.rb

@@ -35,10 +35,8 @@ describe BSON::Registry do
 
     context "when the type has no corresponding class" do
 
-      it "raises an error" do
-        expect {
-          described_class.get("test")
-        }.to raise_error(KeyError)
+      it "returns nil" do
+        expect(described_class.get("test")).to be_nil
       end
     end
   end

data/spec/bson/symbol_spec.rb

@@ -16,16 +16,22 @@ require "spec_helper"
 
 describe Symbol do
 
+  describe "#bson_type" do
+
+    it "returns the type for a string" do
+      expect(:type.bson_type).to eq("type".bson_type)
+    end
+  end
+
   describe "#to_bson/#from_bson" do
 
-    let(:type) { 14.chr }
+    let(:type) { 2.chr }
     let(:obj)  { :test }
     let(:bson) { "#{5.to_bson.to_s}test#{BSON::NULL_BYTE}" }
 
     it_behaves_like "a bson element"
     it_behaves_like "a serializable bson element"
     it_behaves_like "a deserializable bson element"
-
   end
 
   describe "#to_bson_key" do

data/spec/spec_helper.rb

@@ -15,15 +15,6 @@
 $LOAD_PATH.unshift(File.dirname(__FILE__))
 $LOAD_PATH.unshift(File.join(File.dirname(__FILE__), "..", "lib"))
 
-if ENV["CI"] && !ENV["WITH_EXT"]
-  require "simplecov"
-  require "coveralls"
-  SimpleCov.formatter = Coveralls::SimpleCov::Formatter
-  SimpleCov.start do
-    add_filter "spec"
-  end
-end
-
 require "bson"
 require "json"
 require "rspec"

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: bson
 version: !ruby/object:Gem::Version
-  version: 4.0.0.rc0
+  version: 4.0.0
 platform: ruby
 authors:
 - Tyler Brock
@@ -34,7 +34,7 @@ cert_chain:
   XZOS48LlWh15EG4yZo/gRzqNAW2LUIkYA5eMS2Kp6r+KV8IBUO/LaHdrXbdilpa8
   BRsuCo7UZDbFVRns04HLyjVvkj+K/ywIcdKdS0csz5M=
   -----END CERTIFICATE-----
-date: 2015-11-10 00:00:00.000000000 Z
+date: 2015-12-07 00:00:00.000000000 Z
 dependencies: []
 description: A full featured BSON specification implementation, in Ruby
 email:
@@ -137,7 +137,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: 1.3.6
 requirements: []
 rubyforge_project: bson
-rubygems_version: 2.4.5.1
+rubygems_version: 2.4.8
 signing_key: 
 specification_version: 4
 summary: Ruby Implementation of the BSON specification