brut 0.9.0 → 0.9.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 1b2e311013cbdc55775be537b348e78a8c94d12842bff7fcdc09973f88be7eb9
-  data.tar.gz: 648599f601bbf5fa34ed21f7223b4cf82dcf1f12f58b7b60bdf28d5d56c191b2
+  metadata.gz: 4b580e8b69cc722fb2d84c090f7848b9c45623de2faaa996a14914d52773c48a
+  data.tar.gz: 37b84eb37ac974c48c054be0305086622fab712345d7ef581b7bd58f3ec7a79e
 SHA512:
-  metadata.gz: 913cb4f1328ce98454004702f7e8ded76fcc18d44e090b6b96a50840b54519dcc1cde3f3746d9a772c2e33da8554d8485c28ccc35fd65ca98c154b6693c4ac07
-  data.tar.gz: c4ae0693b14b42f3ba58b10b83f6e98f6e300ddeafd40f89028f42eb1b2c534857d69de5917ff7a4234380fb2123815242ac7a2c805f1939f2f1cee033fa2744
+  metadata.gz: 43f5d19e8bb88c0e0956757b1826224f18f68eed46ef34d5a7e8df73b7a8638fb674f499c5e335edae84bd42fb2266fbb19ec347c7e14cbb18027c832e66f33b
+  data.tar.gz: 7b12806b7ce2164e6d1dd2eb85dc3d01902113fadb6762babcd265d8cca3659dc3bf2913db160c518c6ade57624d2e4558d779a62151807a6c0a9f7e4f2c72e9

data/.gitignore

@@ -49,5 +49,5 @@
 # to be placed in hell, and waiting for Alan Dye when he arrives.
 .DS_Store
 
-# Don't want tmp checked in, but want to dump stuff there for sure
+# tmp is nice to have, but not nice to check in.
 /tmp

data/CHANGELOG.md

@@ -1,5 +1,11 @@
 # Brut CHANGELOG
 
+## v0.9.1 - Aug 12, 2025
+
+* Changed `<brut-confirm-submit>` to not ask for confirmation if the form is invalid
+* Changed default production loggin to STDOUT as this is more correct + it cannot be changed by apps
+currently due to https://github.com/thirdtank/brut/issues/51
+
 ## v0.9.0 - Aug 7, 2025
 
 * Added `Brut::FrontEnd::CsrfProtector` and the `csrf_protector` configuration option to allow some customization

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    brut (0.9.0)
+    brut (0.9.1)
       concurrent-ruby
       i18n
       irb
@@ -23,7 +23,7 @@ PATH
 GEM
   remote: https://rubygems.org/
   specs:
-    activesupport (8.0.0)
+    activesupport (8.0.2)
       base64
       benchmark (>= 0.3)
       bigdecimal
@@ -37,131 +37,135 @@ GEM
       tzinfo (~> 2.0, >= 2.0.5)
       uri (>= 0.13.1)
     ast (2.4.3)
-    base64 (0.2.0)
-    benchmark (0.4.0)
-    bigdecimal (3.1.8)
-    concurrent-ruby (1.3.4)
-    connection_pool (2.4.1)
+    base64 (0.3.0)
+    benchmark (0.4.1)
+    bigdecimal (3.2.2)
+    concurrent-ruby (1.3.5)
+    connection_pool (2.5.3)
     date (3.4.1)
-    diff-lcs (1.5.1)
-    dotenv (3.1.4)
-    drb (2.2.1)
-    factory_bot (6.5.0)
-      activesupport (>= 5.0.0)
-    faker (3.5.1)
+    diff-lcs (1.6.2)
+    dotenv (3.1.8)
+    drb (2.2.3)
+    erb (5.0.2)
+    factory_bot (6.5.4)
+      activesupport (>= 6.1.0)
+    faker (3.5.2)
       i18n (>= 1.8.11, < 2)
-    google-protobuf (4.29.3)
+    google-protobuf (4.31.1)
       bigdecimal
       rake (>= 13)
-    google-protobuf (4.29.3-aarch64-linux)
+    google-protobuf (4.31.1-aarch64-linux-gnu)
       bigdecimal
       rake (>= 13)
-    google-protobuf (4.29.3-arm64-darwin)
+    google-protobuf (4.31.1-arm64-darwin)
       bigdecimal
       rake (>= 13)
-    google-protobuf (4.29.3-x86-linux)
+    google-protobuf (4.31.1-x86-linux-gnu)
       bigdecimal
       rake (>= 13)
-    google-protobuf (4.29.3-x86_64-darwin)
+    google-protobuf (4.31.1-x86_64-darwin)
       bigdecimal
       rake (>= 13)
-    google-protobuf (4.29.3-x86_64-linux)
+    google-protobuf (4.31.1-x86_64-linux-gnu)
       bigdecimal
       rake (>= 13)
-    googleapis-common-protos-types (1.18.0)
+    googleapis-common-protos-types (1.20.0)
       google-protobuf (>= 3.18, < 5.a)
-    i18n (1.14.6)
+    i18n (1.14.7)
       concurrent-ruby (~> 1.0)
-    io-console (0.8.0)
-    irb (1.15.1)
+    io-console (0.8.1)
+    irb (1.15.2)
       pp (>= 0.6.0)
       rdoc (>= 4.0.0)
       reline (>= 0.4.2)
-    json (2.13.0)
+    json (2.13.2)
     language_server-protocol (3.17.0.5)
     lint_roller (1.1.0)
-    logger (1.6.1)
+    logger (1.7.0)
     mini_portile2 (2.8.9)
-    minitest (5.25.1)
-    mustermann (3.0.3)
+    minitest (5.25.5)
+    mustermann (3.0.4)
       ruby2_keywords (~> 0.0.1)
-    nokogiri (1.18.8)
+    nokogiri (1.18.9)
       mini_portile2 (~> 2.8.2)
       racc (~> 1.4)
-    nokogiri (1.18.8-aarch64-linux-gnu)
+    nokogiri (1.18.9-aarch64-linux-gnu)
       racc (~> 1.4)
-    nokogiri (1.18.8-arm-linux-gnu)
+    nokogiri (1.18.9-arm-linux-gnu)
       racc (~> 1.4)
-    nokogiri (1.18.8-arm64-darwin)
+    nokogiri (1.18.9-arm64-darwin)
       racc (~> 1.4)
-    nokogiri (1.18.8-x86_64-darwin)
+    nokogiri (1.18.9-x86_64-darwin)
       racc (~> 1.4)
-    nokogiri (1.18.8-x86_64-linux-gnu)
+    nokogiri (1.18.9-x86_64-linux-gnu)
       racc (~> 1.4)
-    opentelemetry-api (1.4.0)
-    opentelemetry-common (0.21.0)
+    opentelemetry-api (1.5.0)
+    opentelemetry-common (0.22.0)
       opentelemetry-api (~> 1.0)
-    opentelemetry-exporter-otlp (0.29.1)
+    opentelemetry-exporter-otlp (0.30.0)
       google-protobuf (>= 3.18)
       googleapis-common-protos-types (~> 1.3)
       opentelemetry-api (~> 1.1)
       opentelemetry-common (~> 0.20)
       opentelemetry-sdk (~> 1.2)
       opentelemetry-semantic_conventions
-    opentelemetry-registry (0.3.1)
+    opentelemetry-registry (0.4.0)
       opentelemetry-api (~> 1.1)
-    opentelemetry-sdk (1.7.0)
+    opentelemetry-sdk (1.8.0)
       opentelemetry-api (~> 1.1)
       opentelemetry-common (~> 0.20)
       opentelemetry-registry (~> 0.2)
       opentelemetry-semantic_conventions
-    opentelemetry-semantic_conventions (1.10.1)
+    opentelemetry-semantic_conventions (1.11.0)
       opentelemetry-api (~> 1.0)
-    ostruct (0.6.1)
+    ostruct (0.6.3)
     parallel (1.27.0)
-    parser (3.3.8.0)
+    parser (3.3.9.0)
       ast (~> 2.4.1)
       racc
-    phlex (2.2.1)
+    phlex (2.3.1)
       zeitwerk (~> 2.7)
     pp (0.6.2)
       prettyprint
     prettyprint (0.2.0)
-    prism (1.2.0)
-    psych (5.2.3)
+    prism (1.4.0)
+    psych (5.2.6)
       date
       stringio
     racc (1.8.1)
-    rack (3.1.8)
-    rack-protection (4.0.0)
+    rack (3.2.0)
+    rack-protection (4.1.1)
       base64 (>= 0.1.0)
+      logger (>= 1.6.0)
       rack (>= 3.0.0, < 4)
-    rack-session (2.0.0)
+    rack-session (2.1.1)
+      base64 (>= 0.1.0)
       rack (>= 3.0.0)
     rackup (2.2.1)
       rack (>= 3)
     rainbow (3.1.1)
-    rake (13.2.1)
+    rake (13.3.0)
     rdiscount (2.2.7.3)
-    rdoc (6.12.0)
+    rdoc (6.14.2)
+      erb
       psych (>= 4.0.0)
-    regexp_parser (2.10.0)
-    reline (0.6.0)
+    regexp_parser (2.11.1)
+    reline (0.6.2)
       io-console (~> 0.5)
-    rspec (3.13.0)
+    rspec (3.13.1)
       rspec-core (~> 3.13.0)
       rspec-expectations (~> 3.13.0)
       rspec-mocks (~> 3.13.0)
-    rspec-core (3.13.2)
+    rspec-core (3.13.5)
       rspec-support (~> 3.13.0)
-    rspec-expectations (3.13.3)
+    rspec-expectations (3.13.5)
       diff-lcs (>= 1.2.0, < 2.0)
       rspec-support (~> 3.13.0)
-    rspec-mocks (3.13.2)
+    rspec-mocks (3.13.5)
       diff-lcs (>= 1.2.0, < 2.0)
       rspec-support (~> 3.13.0)
-    rspec-support (3.13.1)
-    rubocop (1.74.0)
+    rspec-support (3.13.4)
+    rubocop (1.79.2)
       json (~> 2.3)
       language_server-protocol (~> 3.17.0.2)
       lint_roller (~> 1.1.0)
@@ -169,39 +173,41 @@ GEM
       parser (>= 3.3.0.2)
       rainbow (>= 2.2.2, < 4.0)
       regexp_parser (>= 2.9.3, < 3.0)
-      rubocop-ast (>= 1.38.0, < 2.0)
+      rubocop-ast (>= 1.46.0, < 2.0)
       ruby-progressbar (~> 1.7)
       unicode-display_width (>= 2.4.0, < 4.0)
-    rubocop-ast (1.42.0)
+    rubocop-ast (1.46.0)
       parser (>= 3.3.7.2)
+      prism (~> 1.4)
     rubocop-disable_syntax (0.2.0)
       lint_roller
       rubocop (>= 1.72.0)
     ruby-progressbar (1.13.0)
     ruby2_keywords (0.0.5)
-    securerandom (0.3.2)
-    semantic_logger (4.16.1)
+    securerandom (0.4.1)
+    semantic_logger (4.17.0)
       concurrent-ruby (~> 1.0)
-    sequel (5.86.0)
+    sequel (5.95.1)
       bigdecimal
-    sinatra (4.0.0)
+    sinatra (4.1.1)
+      logger (>= 1.6.0)
       mustermann (~> 3.0)
       rack (>= 3.0.0, < 4)
-      rack-protection (= 4.0.0)
+      rack-protection (= 4.1.1)
       rack-session (>= 2.0.0, < 3)
       tilt (~> 2.0)
-    stringio (3.1.3)
-    tilt (2.4.0)
+    stringio (3.1.7)
+    tilt (2.6.1)
     tzinfo (2.0.6)
       concurrent-ruby (~> 1.0)
-    tzinfo-data (1.2024.2)
+    tzinfo-data (1.2025.2)
       tzinfo (>= 1.0.0)
     unicode-display_width (3.1.4)
       unicode-emoji (~> 4.0, >= 4.0.4)
     unicode-emoji (4.0.4)
-    uri (1.0.2)
+    uri (1.0.3)
     yard (0.9.37)
-    zeitwerk (2.7.1)
+    zeitwerk (2.7.3)
 
 PLATFORMS
   aarch64-linux

data/brut-css/package-lock.json

@@ -1,12 +1,12 @@
 {
   "name": "brut-css",
-  "version": "0.9.0",
+  "version": "0.9.1",
   "lockfileVersion": 3,
   "requires": true,
   "packages": {
     "": {
       "name": "brut-css",
-      "version": "0.9.0",
+      "version": "0.9.1",
       "license": "Hippocratic-2.1",
       "devDependencies": {
         "comment-parser": "^1.4.1",

data/brut-css/package.json

@@ -1,6 +1,6 @@
 {
   "name": "brut-css",
-  "version": "0.9.0",
+  "version": "0.9.1",
   "description": "Utility CSS Library for Full Stack Developers",
   "keywords": [
     "css"

data/brut-js/package-lock.json

@@ -1,12 +1,12 @@
 {
   "name": "brut-js",
-  "version": "0.9.0",
+  "version": "0.9.1",
   "lockfileVersion": 3,
   "requires": true,
   "packages": {
     "": {
       "name": "brut-js",
-      "version": "0.9.0",
+      "version": "0.9.1",
       "license": "Hippocratic-2.1",
       "devDependencies": {
         "esbuild": "^0.24.0",

data/brut-js/package.json

@@ -1,6 +1,6 @@
 {
   "name": "brut-js",
-  "version": "0.9.0",
+  "version": "0.9.1",
   "type": "module",
   "keywords": [ "WebComponents", "Custom Elements" ],
   "bugs": {

data/brut-js/specs/ConfirmSubmit.spec.js

@@ -7,7 +7,7 @@ describe("<brut-confirm-submit>", () => {
       <input type="text" name="text">
       <brut-confirm-submit message='You sure?'>
         <button>Save</button>
-        <input type="submit" value="Submit">
+        <input type="submit" value="Submit" required minlength="3" value="abcd">
       </brut-confirm-submit>
     </form>
     `).test("uses window.confirm and cancels the click on Cancel", ({window,document,assert}) => {
@@ -82,6 +82,37 @@ describe("<brut-confirm-submit>", () => {
       assert.equal(messageShown,"You sure?")
       assert(submitted)
     })
+    withHTML(`
+    <form>
+      <input type="text" name="text" required minlength="3">
+      <brut-confirm-submit message='You sure?'>
+        <button>Save</button>
+        <input type="submit" value="Submit">
+      </brut-confirm-submit>
+    </form>
+    `).test("Does not show if form is invalid", ({window,document,assert}) => {
+      const form   = document.querySelector("form")
+      const button = document.querySelector("button")
+
+      let submitted = false
+      form.addEventListener("submit", (event) => {
+        event.preventDefault()
+        submitted = true
+      })
+
+      let shown        = false
+      let messageShown = null
+
+      window.confirm = (message) => {
+        shown = true
+        messageShown = message
+        return false // "Cancel"
+      }
+
+      button.click()
+      assert(!shown)
+      assert(!submitted)
+    })
   })
   describe("with an implicit dialog", () => {
     withHTML(`

data/brut-js/src/ConfirmSubmit.js

@@ -2,14 +2,21 @@ import BaseCustomElement from "./BaseCustomElement"
 import RichString from "./RichString"
 import ConfirmationDialog from "./ConfirmationDialog"
 
-/** Confirms form submissions with the user before allowing the form to be submitted. This can be applied per submit
- * button and only affects the behavior of `button` or `input type=submit`, and *only* if no other click handler
- * has been put onto those buttons.  Note that this does not affect links (`a` elements).
+/** Confirms form submissions with the user before allowing the form to be submitted. This is applied
+ * to buttons, not forms, to allow for finer control over the behavior.
  *
- * This can ask for confirmation with {@link external:Window#confirm} or a
- * `brut-confirmation-dialog`. What it will use depends on several factors, all of which
- * are geared toward doing the right thing. Note that setting `show-warnings` will elucidate the reasons
- * this component does what it does.
+ * * This only works for `button` or `input type=submit`
+ * * The elements must have a form, either by being inside a form or having
+ *   a `form` attribute.
+ * * If the form is not valid, it will not show the confirmation dialog.
+ *
+ *
+ * By default, this will use {@link external:Window#confirm}.  if "OK" is pressed,
+ * the button click goes through and the form would be submitted. If "Cancel" is pressed,
+ * the event is prevented.
+ *
+ * If there is a `brut-confirmation-dialog` on the page, this component can use that, possibly
+ * with help from the `dialog` attribute as followed:
  *
  * * If `dialog` is set:
  *   - If that id is on a `<brut-confirmation-dialog>` that is used.
@@ -18,6 +25,9 @@ import ConfirmationDialog from "./ConfirmationDialog"
  *   - If there is exactly one `<brut-confirmation-dialog>` on the page, this is used.
  *   - If there is more than one, or no `<brut-confirmation-dialog>`s, `window.confirm` is used.
  *
+ * If the wrong dialog or notification method is happening, set `show-warnings` on the element, and it will
+ * print out why it's doing what it's doing.
+ *
  * @see ConfirmationDialog
  *
  * @property {string} message - the message to show that asks for confirmation. It should be written such that
@@ -60,6 +70,17 @@ class ConfirmSubmit extends BaseCustomElement {
         this.logger.warn("No message provided, so cannot confirm")
         return
       }
+      const form = event.currentTarget.form
+
+      if (!form) {
+        this.logger.warn("Element was not part of a form, so cannot confirm submission")
+        return
+      }
+
+      if (!form.checkValidity()) {
+        return
+      }
+
       const dialog = this.#findDialog()
       if (dialog) {
         event.preventDefault()