brpm_module_servicenow 0.0.5 → 0.0.6

checksums.yaml

@@ -1,15 +1,15 @@
 ---
 !binary "U0hBMQ==":
   metadata.gz: !binary |-
-    N2M0ZGZhYTlkMjEyZmU1NzVhMjQ4OGU2ZTFiNzhiODhjYmJhYTdhZQ==
+    OWU5OTI3MDdiY2NmNzI4NWRjYzhhMWMxMmMwZmYxMmU1MTAyNGU1NA==
   data.tar.gz: !binary |-
-    YjMzNDJlOGQzNWNmYzg4Yzg3NTM4ZjRhMmU2NzZlOTIxNzJhMjFlYw==
+    MDM1ODY4YWY0YjQzYTc4NGE4Njk4NjViMzE1NTZlNDBiOWRlNTQ1Ng==
 SHA512:
   metadata.gz: !binary |-
-    ODU4MWE2MDAzMWM4ZmJhMDYyNzVlZjExMDIyNTdjYWFiNzVmMmJjMDI5MTc5
-    OTQyZTgzM2YwMDMwYWI2OTJmNTgxYWFkMTA4YzAwN2NkZTRlMjgzMTBkZTU4
-    NjY2ZjI5ZDdiNDA2ZjdlMDgzNWQyMDRlNGQxMDQyYjg2ZjI5OWI=
+    ZTYyYmIyNTVhMzA1MTAzZmU1MTJkMTI0ODgyMzFhMTc4NzYwNjE5ZmVmNGE3
+    NjUxNDE3M2JkYjEwNzc3Mzk1MzViZGQ3MDliZjQ1MjhkMzliMTI5M2I5NTc0
+    OTgwZTIyNjc3NWFlOTE1ODU0ZWMyNjVkMzFjY2VjNTNkOTk4ZDg=
   data.tar.gz: !binary |-
-    YmUxOTkwNzU3N2JjMjY4MzNkNDQ4M2Y4Yzk1ZmM1Y2YyMDE4YjQ4Y2VmN2Q2
-    YWIxNGJjMmRmMmExZmZiODNkOGI4MTRjMjVhMDVjMDY5MTFkODYwNWEwMDll
-    MTc4ZmI0YzRhYzRkNDlmMWY0NWRlZDQ2N2FlY2MzOGY1NTIwMmY=
+    MzY0Zjk2YTY4NWExMjI0N2M0NTVmYjk4OGNkN2VkYmFmNDQ0NDc4MThmMjNm
+    MDYwN2U5NGVlNWQ4MmExODk4NDQ5NGNiZDQ4MWU3NTAwNTM4ZWU2YjEyNWM2
+    YzVjNmI4Yzc1YWRlZmM0ZDE2MjhhNjgwZmUxN2FjNDVkYmJmZGU=

data/config.yml

@@ -1,4 +1,4 @@
-version: 0.0.5
+version: 0.0.6
 
 author: Niek Bartholomeus
 email: niek.bartholomeus@gmail.com

data/lib/snow_rest_client.rb

@@ -26,6 +26,12 @@ class SnowRestClient
   def update_record(table, id, fields)
     url = "#{@api_url}/#{table}/#{id}"
 
-    Rest.put(url, fields, { :username => @username, :password => @password })["response"]
+    result = Rest.put(url, fields, { :username => @username, :password => @password })
+
+    unless result["status"] == "success"
+      raise "Could not update the record: #{result["error_message"]}"
+    end
+
+    result["response"]
   end
 end

data/tests/transition_change_request_spec.rb

@@ -6,7 +6,7 @@ describe 'transition issue' do
   end
 
   describe '' do
-    it 'transition a change request in ServiceNow' do
+    it 'should transition a change request in ServiceNow' do
       params = get_default_params
       params = params.merge(get_integration_params_for_servicenow)
 
@@ -24,6 +24,16 @@ describe 'transition issue' do
       params["target_change_request_status"] = "Closed Complete"
       BrpmScriptExecutor.execute_automation_script("brpm_module_servicenow", "transition_change_request", params)
     end
+
+    it 'should raise an error when transitioning an unknown change request in ServiceNow' do
+      params = get_default_params
+      params = params.merge(get_integration_params_for_servicenow)
+
+      params["change_request_id"] = "blablablaxxx"
+
+      params["target_change_request_status"] = "Pending"
+      expect { BrpmScriptExecutor.execute_automation_script("brpm_module_servicenow", "transition_change_request", params) }.to raise_exception
+    end
   end
 end
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: brpm_module_servicenow
 version: !ruby/object:Gem::Version
-  version: 0.0.5
+  version: 0.0.6
 platform: ruby
 authors:
 - Niek Bartholomeus
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-11-26 00:00:00.000000000 Z
+date: 2015-11-27 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: brpm_content_framework