brpm_module_jira 0.1.14 → 0.1.15

checksums.yaml

@@ -1,15 +1,15 @@
 ---
 !binary "U0hBMQ==":
   metadata.gz: !binary |-
-    MDEzNmE1YTg4MDMxOTU1MDc3MjQyNmZiYjYzN2IwNjI0Mzc4ODM3Zg==
+    Y2RiN2RmODVlZmY1MDEwYjM1MGE5YmMzZjU3YzY3Y2U2ZjQ5MDZhNw==
   data.tar.gz: !binary |-
-    MTY5ZjljNTdjMGE1MTMwMDRiODVmODdhMTM4MjkzYzc1NDUwZGI2ZA==
+    YjUzNjA0NzhlMzMxMjVkZWE5ZDZkY2YwNGMwYzM2OTJjMmE1NTcyZg==
 SHA512:
   metadata.gz: !binary |-
-    N2U4MDM0NTA3NmYyNzEzNTM2MWIwYmEyYzI1OGRlNWQxMDVjZjQyM2VkYTgy
-    YzlhNGQ3M2UzM2E2MmZiYjc1YzRkOTVjMzE5NGM1ZWU3YjdjNzEzN2MyYjA3
-    MWEzYzM3ZWMxMDY3MjYyMTBhZTRhYWI5MjcwYmMxMjNlZWMxNjQ=
+    ZGNhMGU3Y2NjMjliMTQ1NjdjM2RhNzM4NDY3ZjY3NTgyZWVhYTllYjYzMjJj
+    ZTE4ZjMzY2MyNGM2MTViNDc4NmZlNDdjN2JhMDNhODY2Yzg4Y2QwMDRjY2Q4
+    Zjc1YjgzZDBhYmY4ZGQ5NzI0OTc4ODljMjBmMzYwMDcxZjAwNDY=
   data.tar.gz: !binary |-
-    ZDU0MmZmN2E3Y2I4MDAzYzcwNTU1YzExYzc5OGY5M2IxYTU3MjkxZDU3N2Vl
-    NTUxMzc2MTMzNTM1ODBjY2MyMGFhMDM2MTUyMjZhM2MxZjNmN2UzMzgzOGJi
-    ZjM3YWMyZjZkNzYwZmYyNTkyYzk5NjkxZWI2NWY2ZDdhMWExN2I=
+    ODZjZDdlYzJjYWUxODFhMTZhNDIxZjU5MTIxYzMzNTU1YTZmYjQ2OTVjY2Q3
+    ZmEzODE1YTIwODJkMTRmMTI1NWU4NjU5NDJkMzU1ZDU2OTNlM2E3NTM5OGIx
+    NDVlMDllMmFjMjIwYTM0NWZlNzgyZDViYmQ3YjQxYjlmYTcwMGM=

data/automations/transition_issue.rb

@@ -1,4 +1,12 @@
 params = BrpmAuto.params
+jira_rest_client = JiraRestClient.new
 
-BrpmAuto.log "Setting the status of issue #{params["issue_id"]} to #{params["target_issue_status"]}"
-JiraRestClient.new.set_issue_to_status(params["issue_id"], params["target_issue_status"])
+BrpmAuto.log "Getting issue #{params["issue_id"]}..."
+issue = jira_rest_client.get_issue(params["issue_id"])
+
+raise "This issue doesn't exist" unless issue
+
+BrpmAuto.log "Setting the status of issue #{params["issue_id"]} to #{params["target_issue_status"]}..."
+transition = jira_rest_client.set_issue_to_status(params["issue_id"], params["target_issue_status"])
+
+raise "This status is not allowed" unless transition

data/automations/transition_issues_for_request.rb

@@ -24,6 +24,6 @@ if params["target_issue_status"].nil? or params["target_issue_status"].empty?
 end
 
 tickets.each do |ticket|
-  BrpmAuto.log "Setting the status of issue #{ticket["foreign_id"]} to #{params["target_issue_status"]}"
+  BrpmAuto.log "Setting the status of issue #{ticket["foreign_id"]} to #{params["target_issue_status"]}... (non-existing issues or invalid target statuses will be ignored)"
   JiraRestClient.new.set_issue_to_status(ticket["foreign_id"], params["target_issue_status"])
 end

data/automations/transition_issues_for_run.rb

@@ -21,6 +21,6 @@ unless params["target_issue_status"]
 end
 
 tickets.each do |ticket|
-  BrpmAuto.log "Setting the status of issue #{ticket["foreign_id"]} to #{params["target_issue_status"]}"
+  BrpmAuto.log "Setting the status of issue #{ticket["foreign_id"]} to #{params["target_issue_status"]}... (non-existing issues or invalid target statuses will be ignored)"
   JiraRestClient.new.set_issue_to_status(ticket["foreign_id"], params["target_issue_status"])
 end

data/config.yml

@@ -1,7 +1,7 @@
 dependencies:
   - brpm_module_brpm
 
-version: 0.1.14
+version: 0.1.15
 
 author: Niek Bartholomeus
 email: niek.bartholomeus@gmail.com

data/lib/jira_rest_client.rb

@@ -20,7 +20,13 @@ class JiraRestClient
   # POST /rest/api/2/issue/{issueIdOrKey}/comment
   def add_comment(issue_id, comment_body = 'Dummy Comment')
     cmmnt = {:body => comment_body}
-    Rest.post("#{@api_url}/issue/#{issue_id}/comment", cmmnt, { :username => @username, :password => @password })["response"]
+    result = Rest.post("#{@api_url}/issue/#{issue_id}/comment", cmmnt, { :username => @username, :password => @password })
+
+    unless result["status"] == "success"
+      raise "Could not add the comment: #{result["error_message"]}"
+    end
+
+    result["response"]
   end
 
   # GET /rest/api/2/issue/{issueIdOrKey}/transitions[?expand=transitions.fields]
@@ -29,7 +35,17 @@ class JiraRestClient
     if expand_transition
       url = "#{url}?expand=transitions.fields"
     end
-    Rest.get(url, { :username => @username, :password => @password })["response"]
+    result = Rest.get(url, { :username => @username, :password => @password })
+
+    if result["status"] == "success"
+      result["response"]["transitions"]
+    else
+      if result["code"] == 404
+        {}
+      else
+        raise "Error getting the issue transitions: #{result["error_message"]}"
+      end
+    end
   end
 
   # GET /rest/api/2/issue/{issueIdOrKey}/transitions?transitionId={transistion_id}[&expand=transitions.fields]
@@ -38,7 +54,13 @@ class JiraRestClient
     if expand_transition
         url = "#{url}&expand=transitions.fields"
     end
-    Rest.get(url, { :username => @username, :password => @password })["response"]
+    result = Rest.get(url, { :username => @username, :password => @password })
+
+    if result["status"] == "success"
+      result["response"]
+    else
+      raise "Error getting the issue transition: #{result["error_message"]}"
+    end
   end
 
   # POST /rest/api/2/issue/{issueIdOrKey}/transitions[?expand=transitions.fields]
@@ -49,26 +71,42 @@ class JiraRestClient
     end
     transition = {:update=>{:comment =>[{:add => {:body => "#{comment}"}}]}, :transition => {:id => "#{transition_id}"}}
     #Simple post as only return code is returned
-    Rest.post(url, transition, { :username => @username, :password => @password })["response"]
+    result = Rest.post(url, transition, { :username => @username, :password => @password })
+
+    unless result["status"] == "success"
+      raise "Could not add the comment: #{result["error_message"]}"
+    end
+
+    result["response"]
   end
 
   # GET /rest/api/2/project
   def get_projects()
-    Rest.get("#{@api_url}/project", { :username => @username, :password => @password })["response"]
+    result = Rest.get("#{@api_url}/project", { :username => @username, :password => @password })
+
+    if result["status"] == "success"
+      result["response"]
+    else
+      if result["code"] == 404
+        {}
+      else
+        raise "Error getting the projects: #{result["error_message"]}"
+      end
+    end
   end
 
   def set_issue_to_status(issue_id, status)
     BrpmAuto.log "Getting the possible transitions for issue #{issue_id}..."
-    result = get_issue_transitions(issue_id)
-    transitions = result["transitions"]
+    transitions = get_issue_transitions(issue_id)
 
     transition = transitions.find { |transition| transition["to"]["name"] == status }
 
     if transition
       BrpmAuto.log "Issuing transition #{transition["name"]} to update the status of the issue to #{status}..."
-      issues = post_issue_transition(issue_id, transition["id"])
+      post_issue_transition(issue_id, transition["id"])
     else
-      BrpmAuto.log "This ticket does not have a transition to status #{status} currently. Leaving it in its current state."
+      BrpmAuto.log "This issue does not have a transition to status #{status} currently. Leaving it in its current state."
+      nil
     end
   end
 
@@ -80,7 +118,17 @@ class JiraRestClient
     url = "#{url}&fields=#{fields}" unless fields == ''
     url = "#{url}&expand=#{expand}" unless expand == ''
 
-    Rest.get(url, { :username => @username, :password => @password })["response"]
+    Rest.get(url, { :username => @username, :password => @password })
+
+    if result["status"] == "success"
+      result["response"]
+    else
+      if result["code"] == 404
+        {}
+      else
+        raise "Error doing the search: #{result["error_message"]}"
+      end
+    end
   end
 
   # GET /rest/api/2/issue/{issueIdOrKey}[?fields=<field,field,...>&expand=<param,param,...>]
@@ -98,7 +146,13 @@ class JiraRestClient
         url = "#{url}?expand=#{expand}"
       end
     end
-    Rest.get(url, { :username => @username, :password => @password })["response"]
+    result = Rest.get(url, { :username => @username, :password => @password })
+
+    if result["status"] == "success"
+      result["response"]
+    else
+      raise "Error getting the issue: #{result["error_message"]}"
+    end
   end
 
   def get_option_for_dropdown_custom_field(custom_field_id, option_value)
@@ -109,7 +163,7 @@ class JiraRestClient
 
     if result["status"] == "success"
       custom_field_options = result["response"]
-      return custom_field_options.find { |custom_field_option| custom_field_option["optionvalue"] == option_value }
+      custom_field_options.find { |custom_field_option| custom_field_option["optionvalue"] == option_value }
     else
       if result["code"] == 404
         return nil
@@ -135,7 +189,7 @@ class JiraRestClient
     result = Rest.post(url, data, { :username => @username, :password => @password })
 
     if result["status"] == "success"
-      return result["response"]
+      result["response"]
     else
       raise "Could not create option: #{result["error_message"]}"
     end

data/tests/transition_issue_spec.rb

@@ -9,7 +9,7 @@ describe 'transition issue' do
   end
 
   describe '' do
-    it 'transition an issue in JIRA' do
+    it 'should transition an issue in JIRA' do
       params = get_default_params
       params = params.merge(get_integration_params_for_jira)
 
@@ -24,9 +24,19 @@ describe 'transition issue' do
       params["target_issue_status"] = "In development"
       BrpmScriptExecutor.execute_automation_script("brpm_module_jira", "transition_issue", params)
 
-      params["target_issue_status"] = "Deployed to development"
+      params["target_issue_status"] = "Deployed to Development"
       BrpmScriptExecutor.execute_automation_script("brpm_module_jira", "transition_issue", params)
     end
+
+    it 'should raise an error when transitioning an unknown issue in JIRA' do
+      params = get_default_params
+      params = params.merge(get_integration_params_for_jira)
+
+      params["issue_id"] = "XXX-999"
+
+      params["target_issue_status"] = "Done"
+      expect { BrpmScriptExecutor.execute_automation_script("brpm_module_jira", "transition_issue", params) }.to raise_exception
+    end
   end
 end
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: brpm_module_jira
 version: !ruby/object:Gem::Version
-  version: 0.1.14
+  version: 0.1.15
 platform: ruby
 authors:
 - Niek Bartholomeus
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-11-09 00:00:00.000000000 Z
+date: 2015-11-27 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: brpm_content_framework