browserify-rails 4.2.0 → 4.4.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: 07cd114f351548db3e2885f6c99e879aa66ea0c1
-  data.tar.gz: 9a2718ea91ac7dc5e031570bc6da6ae190875cc1
+SHA256:
+  metadata.gz: cad940efd5616a2cd49abc09b559bee472df4ded7c308a21975a2a265b01b74a
+  data.tar.gz: 7bbdcb45126644fdf62358154f1b5bd04712e5ed01caefbc6555500991b1bef6
 SHA512:
-  metadata.gz: e2604d3a6029a830190bd0806c7b3cd926766508d4729553d9a6a054b1c98b66332a4ff3d03b9527281d5c6f13f09ee2c11d699c6245b0e6d742682e3051b402
-  data.tar.gz: 8659b908bfb1a4b72c57c89680c43587e94fe043be1ca36edc9d8725140e43fd71ff8ceba600ddfd346cc542391d5be8db91d11147b7b9ca6be414f56b08fdd0
+  metadata.gz: 6b1be15ad5163e9657e6708134ca7420fbc8b7cad8b4697965424a0d92ced3d639f4cbcb0803fa75e06a32a3c3d542c7a4ecf97f421c308a5440fe4c120ff711
+  data.tar.gz: 40ace03ac65f0a529925fda364c029046b53347baaf3ada01dd69a2795cc945d1da8e5b59390087a07c406f19a9b27f539e42b173afcea9333c853389764173c

data/CHANGELOG.md

@@ -1,6 +1,16 @@
 # Change Log
 All notable changes to this project will be documented in this file going forward.
 
+## [4.4.0] - 2020-05-16
+- sprockets 4 support thanks to dkamenka
+- fix tests
+
+## [4.3.0] - 2018-04-17
+- release 4.3.0.pre as 4.3.0 unchanged
+
+## [4.3.0.pre] - 2018-04-12
+- relax railties requirement to not have an upper limit
+
 ## [4.2.0] - 2017-04-28
 - relax railties requirement to < 5.2
 

data/README.md

@@ -16,6 +16,34 @@ It lets you mix and match  `//= require` directives and `require()` calls for in
 6. Require modules relative to asset paths (ie app/assets/javascript) with non-relative syntax (see below before using)
 7. Configure browserify options for each JavaScript file so you can mark modules with `--require`, `--external`, etc
 
+## Should you use this gem?
+
+As the primary developer, I'm going to offer some opiniated advice. The sweet spot for this
+gem is for Rails projects with legacy JavaScript (not using CommonJS/modules). This gem is
+a great way to make it possible to rewrite that legacy JavaScript to CommonJS on a timeline
+that you dictate. Then consider stepping off the Rails asset pipeline or using another gem.
+
+If you're starting a new Rails project today, I highly recommend looking at alternatives to
+this gem. The primary reason is that this gem, while it works well, is not as efficient as
+most would like for local development. Also a lot has changed over the last couple of years.
+
+An example of that change is this project from Rails:
+
+[rails/webpacker](https://github.com/rails/webpacker)
+
+This is a huge step in the right direction for the Rails community. In the past, it has been
+extremely frustrating working with JavaScript on the asset pipeline. The good news is you have a lot
+of great choices. If I were starting a new Rails project today, I think the safest choice is
+one in which you have a [Procfile](https://mattstauffer.co/blog/using-a-procfile-to-streamline-your-local-development) that kicks off a separate Webpack build and you use zero
+Rails magic. A slightly less safe but maybe more convenient choice would be trying rails/webpacker
+or another gem. The choice is yours.
+
+
+For more discussion on this topic, see issues
+[203](https://github.com/browserify-rails/browserify-rails/issues/203),
+[161](https://github.com/browserify-rails/browserify-rails/issues/161),
+[43](https://github.com/browserify-rails/browserify-rails/issues/43), etc.
+
 ## Getting Started
 
 Add this line to your application's Gemfile:
@@ -235,13 +263,29 @@ buildpacks that run `bundle` and `npm install` on the target machine.
 
 ## Using Browserify Transforms
 
-You can easily use a browserify transform by adding it to your `package.json`, then adding the transform flag to your `application.rb`, using `config.browserify_rails.commandline_options`. For example, here is how you can add ES6 support in your app:
+You can easily use a browserify transform by making some additions to your `package.json` and creating a .babelrc. For example, here is how you can add ES6 support in your app:
 
-1. Add `babelify` and `babel-preset-es2015` to your `package.json` in your app's root directory, then run `npm install`
-2. Add this line to your config/application.rb:
-   `config.browserify_rails.commandline_options = "-t [ babelify --presets [ es2015 ] --extensions .es6 ]"`
-3. Create some `.es6` files and require them with `var m = require('./m.es6')` or `import m from './m.es6'`
-4. Restart your server, and you now have ES6 support!
+1. Add `babelify` and `babel-preset-es2015` to your `package.json` in your app's root directory either by editing the file directly and running `npm install` or using `npm install babelify --save` and `npm install babel-preset-es2015 --save`
+2. Update your `package.json` to contain the babelify transform by adding the following lines
+```
+   "browserify": {
+    "transform": [
+      [
+        "babelify"
+      ]
+    ]
+  }
+```
+3. Create a `.babelrc` file in the project root with the following contents
+```
+{
+  "plugins": [],
+  "presets": ["es2015"]
+}
+```
+   
+4. Create some `.es6` files and require them with `var m = require('./m.es6')` or `import m from './m.es6'`
+5. Restart your server, and you now have ES6 support!
 
 
 ## Troubleshooting

data/browserify-rails.gemspec

@@ -19,7 +19,7 @@ Gem::Specification.new do |spec|
   spec.require_paths = ["lib"]
 
 
-  spec.add_runtime_dependency "railties", ">= 4.0.0", "< 5.2"
+  spec.add_runtime_dependency "railties", ">= 4.0.0"
   spec.add_runtime_dependency "sprockets", ">= 3.6.0"
   spec.add_runtime_dependency "addressable", ">= 2.4.0"
 

data/lib/browserify-rails/browserify_processor.rb

@@ -41,12 +41,12 @@ module BrowserifyRails
         resolved = input[:environment].resolve(path)
 
         if resolved && resolved.is_a?(Array)
-          resolved = resolved[0]
-        elsif config.evaluate_node_modules && !resolved
-          resolved = path
+          dependencies += resolved[1]
+        elsif resolved
+          dependencies << "file-digest://#{Addressable::URI.escape resolved}"
+        elsif config.evaluate_node_modules
+          dependencies << "file-digest://#{Addressable::URI.escape path}"
         end
-
-        dependencies << "file-digest://#{Addressable::URI.escape resolved}" if resolved
       end
 
       new_data = run_browserify(input[:name])

data/lib/browserify-rails/version.rb

@@ -1,3 +1,3 @@
 module BrowserifyRails
-  VERSION = "4.2.0"
+  VERSION = "4.4.0"
 end

data/test/compilation_test.rb

@@ -182,6 +182,7 @@ class BrowserifyTest < ActionDispatch::IntegrationTest
     get "/assets/node_path_based_require.js"
 
     assert_response :success
+
     assert_equal expected_output, @response.body.strip
     assert_equal false, @response.body.include?("Error: Cannot find module 'some_folder/answer'")
   end

data/test/dummy/app/assets/config/manifest.js

@@ -0,0 +1 @@
+{}