browserify-rails 2.0.3 → 2.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 5051cb1b96115f8c8d020164649ca895761caa08
-  data.tar.gz: 0125b5f01c1d25aa75d3955f7736f61788bbd6d4
+  metadata.gz: 23f0a0342f7acba4c60dbb7e5d758713dad4edf9
+  data.tar.gz: 49f6c7c5d5f940270d34d0136039c8ecbfa8a2f0
 SHA512:
-  metadata.gz: 490d690fa6e640f4493bb67183f2e9c4b126736884146b7166675373cf302b9a41b792b8cf3081c0f02608b2ec0dd349dec39f3f91a3611d715c16ec72e914d4
-  data.tar.gz: e69de2ac275ebdaf00f3fd113a196cfcc84f7216d01b81b657bc106bb6364db64b1073cd0ca66cc8ba74a20b599931dba64728d904bf042c1513578038525858
+  metadata.gz: 8d670e6ee82fbb6af5dea6b966d6409f2598caf0f1347fc970d6be2445c9cb581930ba98d350ed4e8e91a57c1284a7ca20ad3f7b1bcd3e155895a2130666e990
+  data.tar.gz: 4e651ad7ab99cf329020a07be46824b016302235ea47febd7f60edac98238251e218937e7f3b2be9435332b43f8417ec31e8e2a6b94dc8ff168fcd7df2b4712a

data/CHANGELOG.md

@@ -1,6 +1,9 @@
 # Change Log
 All notable changes to this project will be documented in this file going forward.
 
+## [2.1.0] - 2015-12-26
+- fix some dependency issues (see PR #130)
+
 ## [2.0.3] - 2015-12-18
 - detection of CommonJS (require(.*)) now more stringent
 - update README about 2.x and react-rails

data/README.md

@@ -54,6 +54,21 @@ var foo = require('./foo');
 console.log(foo(12));
 ```
 
+#### Gotchas with `require` and `module.exports`
+
+Do not put `module.exports` or `require()` in JavaScript comments or strings.
+Doing so will certainly cause issues with compilation that are difficult to
+track down.
+
+This happens because browserify-rails works by parsing your JavaScript files for
+these keywords that indicate whether it is a module, or is requiring a module.
+If a file meets one of these criteria, browserify will compile the modules as
+expected.
+
+Because browserify-rails is working within the restraints of Ruby/Sprockets, the
+parsing is done by Ruby and therefore does not know whether it is a JavaScript
+string, comment, or function.
+
 ## CoffeeScript
 
 For CoffeeScript support, make sure to follow the standard rails

data/lib/browserify-rails/browserify_processor.rb

@@ -34,6 +34,9 @@ module BrowserifyRails
       # Signal dependencies to sprockets to ensure we track changes
       evaluate_dependencies(input[:environment].paths).each do |path|
         resolved = input[:environment].resolve(path)
+        if config.evaluate_node_modules && !resolved
+          resolved = path
+        end
         dependencies << "file-digest://#{resolved}" if resolved
       end
 
@@ -126,6 +129,11 @@ module BrowserifyRails
 
     # @return [<String>] Paths of files, that this file depends on
     def dependencies
+      if (@dependencies_source_file != file)
+        @dependencies = nil
+        @dependencies_source_file = file
+      end
+
       @dependencies ||= begin
         # We forcefully run browserify (avoiding browserifyinc) with the --list
         # option to get a list of files.

data/lib/browserify-rails/version.rb

@@ -1,3 +1,3 @@
 module BrowserifyRails
-  VERSION = "2.0.3"
+  VERSION = "2.1.0"
 end

data/test/compilation_test.rb

@@ -10,7 +10,7 @@ class BrowserifyTest < ActionDispatch::IntegrationTest
   end
 
   setup do
-    Rails.application.assets.cache = nil
+    Rails.application.assets.cache = Sprockets::Cache::MemoryStore.new
 
     # Reset config on each run
     Dummy::Application.config.browserify_rails.force = false
@@ -82,6 +82,9 @@ class BrowserifyTest < ActionDispatch::IntegrationTest
   test "asset pipeline should regenerate application.js when foo.js changes" do
     expected_output = fixture("application.out.js")
 
+    # get another js file before applciation.js to check that it appropriately clears the cached dependencies
+    get "/assets/main.js"
+
     get "/assets/application.js"
 
     assert_response :success

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: browserify-rails
 version: !ruby/object:Gem::Version
-  version: 2.0.3
+  version: 2.1.0
 platform: ruby
 authors:
 - Henry Hsu, Cymen Vig
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-12-18 00:00:00.000000000 Z
+date: 2015-12-27 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: railties
@@ -326,3 +326,4 @@ test_files:
 - test/fixtures/require_in_a_comment.js
 - test/fixtures/secondary.out.js
 - test/test_helper.rb
+has_rdoc: