browserify-rails 2.0.2 → 2.0.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 069dd733ee8b82ce039b8cab493224a3f2766817
-  data.tar.gz: 514b3064cab147c0cf67562fff3a2139a3484ebe
+  metadata.gz: 5051cb1b96115f8c8d020164649ca895761caa08
+  data.tar.gz: 0125b5f01c1d25aa75d3955f7736f61788bbd6d4
 SHA512:
-  metadata.gz: 7a918a61e0974438b877f97de5c04dca1e7f1a046255195bbde529d8ecce3eba6ee26ade6c34170a85e6e52d9dfc12137562ece7a9a59f3d3f3f3fe372ab209e
-  data.tar.gz: e76f0128cb8ae076789884b941eaa2bc4323bca8c3fb9c3d300899bf855b3b295d032d7b9421205714af265fafda464a4e6af78fcc0ea808bd6a01404dcdcc0c
+  metadata.gz: 490d690fa6e640f4493bb67183f2e9c4b126736884146b7166675373cf302b9a41b792b8cf3081c0f02608b2ec0dd349dec39f3f91a3611d715c16ec72e914d4
+  data.tar.gz: e69de2ac275ebdaf00f3fd113a196cfcc84f7216d01b81b657bc106bb6364db64b1073cd0ca66cc8ba74a20b599931dba64728d904bf042c1513578038525858

data/CHANGELOG.md

@@ -1,6 +1,10 @@
 # Change Log
 All notable changes to this project will be documented in this file going forward.
 
+## [2.0.3] - 2015-12-18
+- detection of CommonJS (require(.*)) now more stringent
+- update README about 2.x and react-rails
+
 ## [2.0.2] - 2015-11-23
 - fix bug in dependencies passed to sprockets which broke change detection
 

data/README.md

@@ -1,5 +1,7 @@
 # browserify-rails
 
+**If you are using react-rails or experience any issues with browiserfy-rails 2.x, please use the 1.5.x versions until 2.x is stabilized. Please see the issues for discussions and feel free to post your experience. The use of react-rails with browserify-rails is a bit of an anti-pattern in terms of going to CommonJS so it may never be supported. Consider using a browserify transform for React support.
+
 [![Join the chat at https://gitter.im/browserify-rails/browserify-rails](https://badges.gitter.im/Join%20Chat.svg)](https://gitter.im/browserify-rails/browserify-rails?utm_source=badge&utm_medium=badge&utm_campaign=pr-badge&utm_content=badge)
 [![Gem Version](https://badge.fury.io/rb/browserify-rails.svg)](http://badge.fury.io/rb/browserify-rails)
 

data/lib/browserify-rails/browserify_processor.rb

@@ -106,7 +106,7 @@ module BrowserifyRails
     # Be here as strict as possible, so that non-commonjs files are not
     # preprocessed.
     def commonjs_module?
-      data.to_s.include?("module.exports") || data.present? && data.to_s.include?("require") && dependencies.length > 0
+      data.to_s.include?("module.exports") || data.present? && data.to_s.match(/require\(.*\)/) && dependencies.length > 0
     end
 
     def asset_paths

data/lib/browserify-rails/version.rb

@@ -1,3 +1,3 @@
 module BrowserifyRails
-  VERSION = "2.0.2"
+  VERSION = "2.0.3"
 end

data/test/compilation_test.rb

@@ -25,6 +25,7 @@ class BrowserifyTest < ActionDispatch::IntegrationTest
     copy_example_file "coffee.js.coffee.example"
     copy_example_file "node_path_based_require.js.example"
     copy_example_file "main.js.example"
+    copy_example_file "require_in_a_comment.js.example"
     copy_example_file "secondary.js.example"
     copy_example_file "a_huge_library.js.example"
     copy_example_file "some_folder/answer.js.example"
@@ -163,6 +164,12 @@ class BrowserifyTest < ActionDispatch::IntegrationTest
     assert_equal fixture("plain.js"), @response.body.strip
   end
 
+  test "skip files containing the word require in comments" do
+    get "/assets/require_in_a_comment.js"
+
+    assert_equal fixture("require_in_a_comment.js"), @response.body.strip
+  end
+
   test "browserify even plain files if force == true" do
     Dummy::Application.config.browserify_rails.force = true
 

data/test/dummy/app/assets/javascripts/require_in_a_comment.js.example

@@ -0,0 +1,3 @@
+// I'm a comment with the word require in me!
+
+var hi = "nothing else noteworthy about me.";

data/test/fixtures/require_in_a_comment.js

@@ -0,0 +1,3 @@
+// I'm a comment with the word require in me!
+
+var hi = "nothing else noteworthy about me.";

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: browserify-rails
 version: !ruby/object:Gem::Version
-  version: 2.0.2
+  version: 2.0.3
 platform: ruby
 authors:
 - Henry Hsu, Cymen Vig
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-11-23 00:00:00.000000000 Z
+date: 2015-12-18 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: railties
@@ -180,6 +180,7 @@ files:
 - test/dummy/app/assets/javascripts/node.js.example
 - test/dummy/app/assets/javascripts/node_path_based_require.js.example
 - test/dummy/app/assets/javascripts/plain.js
+- test/dummy/app/assets/javascripts/require_in_a_comment.js.example
 - test/dummy/app/assets/javascripts/secondary.js.example
 - test/dummy/app/assets/javascripts/some_folder/answer.js.example
 - test/dummy/app/assets/stylesheets/application.css
@@ -228,6 +229,7 @@ files:
 - test/fixtures/node_test_package.out.js
 - test/fixtures/plain.js
 - test/fixtures/plain.out.js
+- test/fixtures/require_in_a_comment.js
 - test/fixtures/secondary.out.js
 - test/test_helper.rb
 homepage: https://github.com/browserify-rails/browserify-rails
@@ -272,6 +274,7 @@ test_files:
 - test/dummy/app/assets/javascripts/node.js.example
 - test/dummy/app/assets/javascripts/node_path_based_require.js.example
 - test/dummy/app/assets/javascripts/plain.js
+- test/dummy/app/assets/javascripts/require_in_a_comment.js.example
 - test/dummy/app/assets/javascripts/secondary.js.example
 - test/dummy/app/assets/javascripts/some_folder/answer.js.example
 - test/dummy/app/assets/stylesheets/application.css
@@ -320,6 +323,6 @@ test_files:
 - test/fixtures/node_test_package.out.js
 - test/fixtures/plain.js
 - test/fixtures/plain.out.js
+- test/fixtures/require_in_a_comment.js
 - test/fixtures/secondary.out.js
 - test/test_helper.rb
-has_rdoc: