browserify-rails 0.5.1 → 0.6.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: aeecc403d82b8bdd29c23d5ec203a95eb9af2ba0
-  data.tar.gz: 6c0192837995cb3608bc80200444f864b92bb09a
+  metadata.gz: 31f20bae2702655004904b80da5922dd785b5ba5
+  data.tar.gz: d428590fea987f46fbf6116754d77da5014f8f87
 SHA512:
-  metadata.gz: f37a94233e4b1c76c908b3fcfd4ce1ebe6c698f663beeddfebd05c5b2d2a42be0e08c005aa6ef8204e61df7a83b96dd847baca04e109e2aae9dbd41b63b0e4dd
-  data.tar.gz: 0d4220551f56097e05ef7687fae4ed5ffa0f856a186db0003f85a49c6aee8df6a4ee857bb399e8f79b73978206577d8e66e3943fe6e72d82d426a1768d874f0f
+  metadata.gz: f8bffd09ad1abd12acc2043fb5bc3a530c8c356602aa2d7b28c198a6121f765020737b22eaaad553dbd940113fe50eb581229e71427bccf75ff284e3eec1531f
+  data.tar.gz: 933039714e6ad123741f6a0990c89b581f44e16b05ae66f353006716e30193dbc2d1f87ef5d65390c1bbea487b82655ca8449616ae94d6221c1b3049743ac15b

data/README.md

@@ -17,7 +17,7 @@ It lets you mix and match  `//= require` directives and `require()` calls for in
 
 Add this line to your application's Gemfile:
 
-    gem "browserify-rails", "~> 0.4"
+    gem "browserify-rails", "~> 0.5"
 
 Create `package.json` in your Rails root:
 
@@ -25,7 +25,7 @@ Create `package.json` in your Rails root:
 {
   "name": "something",
   "devDependencies" : {
-    "browserify": "~> 4.1"
+    "browserify": "~> 6.3"
   },
   "license": "MIT",
   "engines": {
@@ -54,7 +54,7 @@ console.log(foo(12));
 For CoffeeScript support, make sure to follow the standard rails
 `.js.coffee` naming convention.  You'll also need to do the following:
 
-Add `coffeify` as a dependency within `package.json`:
+Add `coffeeify` as a dependency within `package.json`:
 
 ```js
 {
@@ -100,6 +100,11 @@ class My::Application < Rails::Application
   # The default is `["development"]`.
   config.browserify_rails.source_map_environments << "production"
 
+  # Should the node_modules directory be evaluated for changes on page load
+  #
+  # The default is `false`
+  config.browserify_rails.evaluate_node_modules = true
+
   # Command line options used when running browserify
   #
   # can be provided as an array:

data/lib/browserify-rails/browserify_processor.rb

@@ -10,7 +10,7 @@ module BrowserifyRails
 
     def evaluate(context, locals, &block)
       if should_browserify?
-        asset_dependencies(context.environment.paths).each do |path|
+        evaluate_dependencies(context.environment.paths).each do |path|
           context.depend_on(path)
         end
 
@@ -60,8 +60,10 @@ module BrowserifyRails
 
     # This primarily filters out required files from node modules
     #
-    # @return [<String>] Paths of dependencies, that are in asset directories
-    def asset_dependencies(asset_paths)
+    # @return [<String>] Paths of dependencies to evaluate
+    def evaluate_dependencies(asset_paths)
+      return dependencies if config.evaluate_node_modules
+
       dependencies.select do |path|
         path.start_with?(*asset_paths)
       end

data/lib/browserify-rails/railtie.rb

@@ -6,6 +6,9 @@ module BrowserifyRails
     config.browserify_rails.paths = [lambda { |p| p.start_with?(Rails.root.join("app").to_s) },
                                      lambda { |p| p.start_with?(Rails.root.join("node_modules").to_s) }]
 
+    # Should node_modules be evaluated assets before run_browserify
+    config.browserify_rails.evaluate_node_modules = false
+
     # Environments to generate source maps in
     config.browserify_rails.source_map_environments = ["development"]
 

data/lib/browserify-rails/version.rb

@@ -1,3 +1,3 @@
 module BrowserifyRails
-  VERSION = "0.5.1"
+  VERSION = "0.6.0"
 end

data/test/compilation_test.rb

@@ -1,9 +1,10 @@
 require "test_helper"
 
 class BrowserifyTest < ActionController::IntegrationTest
-  def copy_example_file(filename)
-    example_file = File.join(Rails.root, "app/assets/javascripts/#{filename}")
-    new_file = File.join(Rails.root, "app/assets/javascripts/#{filename.gsub(/\.example$/, '')}")
+  def copy_example_file(filename, path = nil)
+    path ||= "app/assets/javascripts"
+    example_file = File.join(Rails.root, path, filename)
+    new_file = File.join(Rails.root, path, filename.gsub(/\.example$/, ''))
 
     FileUtils.cp(example_file, new_file)
   end
@@ -22,6 +23,7 @@ class BrowserifyTest < ActionController::IntegrationTest
     copy_example_file "a_huge_library.js.example"
     copy_example_file "some_folder/answer.js.example"
     copy_example_file "browserified.js.example"
+    copy_example_file "index.js.example", "node_modules/node-test-package"
   end
 
   test "asset pipeline should serve application.js" do
@@ -33,9 +35,53 @@ class BrowserifyTest < ActionController::IntegrationTest
   end
 
   test "asset pipeline should serve foo.js" do
-    expected_output = fixture("foo.out.js")
+    expected_output = fixture("application.out.js")
+
+    get "/assets/application.js"
+    assert_response :success
+    assert_equal expected_output, @response.body.strip
+  end
+
+  test "asset pipeline should not regenerate application.js when node_modules changes" do
+    Dummy::Application.config.browserify_rails.evaluate_node_modules = false
+    expected_output = fixture("application.out.js")
+
+    get "/assets/application.js"
+    assert_response :success
+    assert_equal expected_output, @response.body.strip
+
+    # Ensure that Sprockets can detect the change to the file modification time
+    sleep 1
+
+    File.open(File.join(Rails.root, "node_modules/node-test-package/index.js"), "w+") do |f|
+      f.puts 'module.exports = console.log("goodbye friend");'
+    end
+
+    expected_output = fixture("application.out.js")
 
-    get "/assets/foo.js"
+    get "/assets/application.js"
+    assert_response :success
+    assert_equal expected_output, @response.body.strip
+  end
+
+  test "asset pipeline should regenerate application.js when node_modules changes" do
+    Dummy::Application.config.browserify_rails.evaluate_node_modules = true
+    expected_output = fixture("application.out.js")
+
+    get "/assets/application.js"
+    assert_response :success
+    assert_equal expected_output, @response.body.strip
+
+    # Ensure that Sprockets can detect the change to the file modification time
+    sleep 1
+
+    File.open(File.join(Rails.root, "node_modules/node-test-package/index.js"), "w+") do |f|
+      f.puts 'module.exports = console.log("goodbye friend");'
+    end
+
+    expected_output = fixture("application.node_test_package_changed.out.js")
+
+    get "/assets/application.js"
     assert_response :success
     assert_equal expected_output, @response.body.strip
   end

data/test/dummy/app/assets/javascripts/application.js.example

@@ -1 +1,2 @@
 var foo = require('./foo');
+var nodeTestPackage = require('node-test-package');

data/test/dummy/package.json

@@ -4,7 +4,8 @@
   "description": "a dummy Rails application",
   "devDependencies" : {
     "browserify": "~> 6.2",
-    "coffeeify": "~> 0.6"
+    "coffeeify": "~> 0.6",
+    "node-test-package": "~> 0.0.2"
   },
   "license": "MIT",
   "engines": {

data/test/fixtures/application.foo_changed.out.js

@@ -1,11 +1,15 @@
 (function e(t,n,r){function s(o,u){if(!n[o]){if(!t[o]){var a=typeof require=="function"&&require;if(!u&&a)return a(o,!0);if(i)return i(o,!0);var f=new Error("Cannot find module '"+o+"'");throw f.code="MODULE_NOT_FOUND",f}var l=n[o]={exports:{}};t[o][0].call(l.exports,function(e){var n=t[o][1][e];return s(n?n:e)},l,l.exports,e,t,n,r)}return n[o].exports}var i=typeof require=="function"&&require;for(var o=0;o<r.length;o++)s(r[o]);return s})({1:[function(require,module,exports){
 var foo = require('./foo');
+var nodeTestPackage = require('node-test-package');
 
-},{"./foo":2}],2:[function(require,module,exports){
+},{"./foo":2,"node-test-package":4}],2:[function(require,module,exports){
 require('./nested');
 module.exports = function (n) { return n * 12 }
 
 },{"./nested":3}],3:[function(require,module,exports){
 module.exports.NESTED = true;
 
-},{}]},{},[1]);
+},{}],4:[function(require,module,exports){
+module.exports = console.log("hello friend");
+
+},{}]},{},[1]);

data/test/fixtures/application.node_test_package_changed.out.js

@@ -0,0 +1,15 @@
+(function e(t,n,r){function s(o,u){if(!n[o]){if(!t[o]){var a=typeof require=="function"&&require;if(!u&&a)return a(o,!0);if(i)return i(o,!0);var f=new Error("Cannot find module '"+o+"'");throw f.code="MODULE_NOT_FOUND",f}var l=n[o]={exports:{}};t[o][0].call(l.exports,function(e){var n=t[o][1][e];return s(n?n:e)},l,l.exports,e,t,n,r)}return n[o].exports}var i=typeof require=="function"&&require;for(var o=0;o<r.length;o++)s(r[o]);return s})({1:[function(require,module,exports){
+var foo = require('./foo');
+var nodeTestPackage = require('node-test-package');
+
+},{"./foo":2,"node-test-package":4}],2:[function(require,module,exports){
+require('./nested');
+module.exports = function (n) { return n * 11 }
+
+},{"./nested":3}],3:[function(require,module,exports){
+module.exports.NESTED = true;
+
+},{}],4:[function(require,module,exports){
+module.exports = console.log("goodbye friend");
+
+},{}]},{},[1]);

data/test/fixtures/application.out.js

@@ -1,11 +1,15 @@
 (function e(t,n,r){function s(o,u){if(!n[o]){if(!t[o]){var a=typeof require=="function"&&require;if(!u&&a)return a(o,!0);if(i)return i(o,!0);var f=new Error("Cannot find module '"+o+"'");throw f.code="MODULE_NOT_FOUND",f}var l=n[o]={exports:{}};t[o][0].call(l.exports,function(e){var n=t[o][1][e];return s(n?n:e)},l,l.exports,e,t,n,r)}return n[o].exports}var i=typeof require=="function"&&require;for(var o=0;o<r.length;o++)s(r[o]);return s})({1:[function(require,module,exports){
 var foo = require('./foo');
+var nodeTestPackage = require('node-test-package');
 
-},{"./foo":2}],2:[function(require,module,exports){
+},{"./foo":2,"node-test-package":4}],2:[function(require,module,exports){
 require('./nested');
 module.exports = function (n) { return n * 11 }
 
 },{"./nested":3}],3:[function(require,module,exports){
 module.exports.NESTED = true;
 
-},{}]},{},[1]);
+},{}],4:[function(require,module,exports){
+module.exports = console.log("hello friend");
+
+},{}]},{},[1]);

data/test/fixtures/node_test_package.out.js

@@ -0,0 +1,4 @@
+(function e(t,n,r){function s(o,u){if(!n[o]){if(!t[o]){var a=typeof require=="function"&&require;if(!u&&a)return a(o,!0);if(i)return i(o,!0);var f=new Error("Cannot find module '"+o+"'");throw f.code="MODULE_NOT_FOUND",f}var l=n[o]={exports:{}};t[o][0].call(l.exports,function(e){var n=t[o][1][e];return s(n?n:e)},l,l.exports,e,t,n,r)}return n[o].exports}var i=typeof require=="function"&&require;for(var o=0;o<r.length;o++)s(r[o]);return s})({1:[function(require,module,exports){
+module.exports = console.log("hello friend");
+
+},{}]},{},[1]);

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: browserify-rails
 version: !ruby/object:Gem::Version
-  version: 0.5.1
+  version: 0.6.0
 platform: ruby
 authors:
 - Henry Hsu, Cymen Vig
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-11-13 00:00:00.000000000 Z
+date: 2015-01-27 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: sprockets
@@ -181,6 +181,7 @@ files:
 - test/dummy/script/rails
 - test/fixtures/application.changed.out.js
 - test/fixtures/application.foo_changed.out.js
+- test/fixtures/application.node_test_package_changed.out.js
 - test/fixtures/application.out.js
 - test/fixtures/browserified.out.js
 - test/fixtures/empty_module.js
@@ -188,6 +189,7 @@ files:
 - test/fixtures/main.out.js
 - test/fixtures/mocha.js
 - test/fixtures/node_path_based_require.out.js
+- test/fixtures/node_test_package.out.js
 - test/fixtures/secondary.out.js
 - test/test_helper.rb
 homepage: https://github.com/browserify-rails/browserify-rails
@@ -267,6 +269,7 @@ test_files:
 - test/dummy/script/rails
 - test/fixtures/application.changed.out.js
 - test/fixtures/application.foo_changed.out.js
+- test/fixtures/application.node_test_package_changed.out.js
 - test/fixtures/application.out.js
 - test/fixtures/browserified.out.js
 - test/fixtures/empty_module.js
@@ -274,5 +277,6 @@ test_files:
 - test/fixtures/main.out.js
 - test/fixtures/mocha.js
 - test/fixtures/node_path_based_require.out.js
+- test/fixtures/node_test_package.out.js
 - test/fixtures/secondary.out.js
 - test/test_helper.rb