browserify-rails 0.4.2 → 0.5.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: c8fc489be291bbeb57acb5004f86574a3254fe2f
-  data.tar.gz: 3dac86e18f58cf52c91dbe1a8166ff59b5cdf70b
+  metadata.gz: 92cc91320466c3b1392909823b59c6477f3c635a
+  data.tar.gz: 399c280e1430f2c0cda0977cd9e6f25c6c886704
 SHA512:
-  metadata.gz: 923b205738755acb59616ddea742f1cc57f554d3c02c664bd6db905e61b0eeb9ab8f324b193b8963cb56676b93f0542c68cf8fa9e48fa0b3f960cd7cc9514c5f
-  data.tar.gz: defd05b16d32bfd53b3b3831cdd65dd506cdf41f44e6f735bf65dc061c5af18ed76fc1d104f070888c4402b7206c6aebe7e3ad1889ea4b5fe6e31b2423697e00
+  metadata.gz: e1ba97bb7bdce77d0e05dcf65f5f09b68e6375788013cb6de6c675199ec422458ef17396fc345d8c84a7bbe5bb40cb1ec2831874e47ab512ffc11cd4a1ba7a24
+  data.tar.gz: dc5f427060167c6640d71511757a20c81dbb9d5df9080b7bd4896e5868381bb177c59841cd22dc8d17ffb1d97986fe883fed59f85a212fcb2064a39071c10a3d

data/lib/browserify-rails/browserify_processor.rb

@@ -55,7 +55,7 @@ module BrowserifyRails
     # Be here as strict as possible, so that non-commonjs files are not
     # preprocessed.
     def commonjs_module?
-      data.to_s.include?("module.exports") || dependencies.length > 0
+      data.to_s.include?("module.exports") || data.present? && dependencies.length > 0
     end
 
     # This primarily filters out required files from node modules

data/lib/browserify-rails/version.rb

@@ -1,3 +1,3 @@
 module BrowserifyRails
-  VERSION = "0.4.2"
+  VERSION = "0.5.0"
 end

data/test/compilation_test.rb

@@ -120,7 +120,6 @@ class BrowserifyTest < ActionController::IntegrationTest
 
     assert_response :success
     assert_equal expected_output, @response.body.strip
-    assert_equal true, @response.body.include?("ReMerY")     # browserify internal global id for a_huge_library.js module
   end
 
   test "uses config/browserify.yml for browserification options" do
@@ -130,7 +129,6 @@ class BrowserifyTest < ActionController::IntegrationTest
 
     assert_response :success
     assert_equal expected_output, @response.body.strip
-    assert_equal true, @response.body.include?("ReMerY")     # browserify internal global id for a_huge_library.js module
   end
 
   test "throws BrowserifyError if something went wrong while executing browserify" do

data/test/dummy/package.json

@@ -3,7 +3,7 @@
   "author": "Henry Hsu <hhsu@zendesk.com>",
   "description": "a dummy Rails application",
   "devDependencies" : {
-    "browserify": "~> 4.1",
+    "browserify": "~> 6.2",
     "coffeeify": "~> 0.6"
   },
   "license": "MIT",

data/test/fixtures/application.changed.out.js

@@ -1,4 +1,4 @@
-(function e(t,n,r){function s(o,u){if(!n[o]){if(!t[o]){var a=typeof require=="function"&&require;if(!u&&a)return a(o,!0);if(i)return i(o,!0);throw new Error("Cannot find module '"+o+"'")}var f=n[o]={exports:{}};t[o][0].call(f.exports,function(e){var n=t[o][1][e];return s(n?n:e)},f,f.exports,e,t,n,r)}return n[o].exports}var i=typeof require=="function"&&require;for(var o=0;o<r.length;o++)s(r[o]);return s})({1:[function(require,module,exports){
+(function e(t,n,r){function s(o,u){if(!n[o]){if(!t[o]){var a=typeof require=="function"&&require;if(!u&&a)return a(o,!0);if(i)return i(o,!0);var f=new Error("Cannot find module '"+o+"'");throw f.code="MODULE_NOT_FOUND",f}var l=n[o]={exports:{}};t[o][0].call(l.exports,function(e){var n=t[o][1][e];return s(n?n:e)},l,l.exports,e,t,n,r)}return n[o].exports}var i=typeof require=="function"&&require;for(var o=0;o<r.length;o++)s(r[o]);return s})({1:[function(require,module,exports){
 var foo = require('./foo');
 console.log(foo(11));
 
@@ -9,4 +9,4 @@ module.exports = function (n) { return n * 11 }
 },{"./nested":3}],3:[function(require,module,exports){
 module.exports.NESTED = true;
 
-},{}]},{},[1])
+},{}]},{},[1]);

data/test/fixtures/application.foo_changed.out.js

@@ -1,4 +1,4 @@
-(function e(t,n,r){function s(o,u){if(!n[o]){if(!t[o]){var a=typeof require=="function"&&require;if(!u&&a)return a(o,!0);if(i)return i(o,!0);throw new Error("Cannot find module '"+o+"'")}var f=n[o]={exports:{}};t[o][0].call(f.exports,function(e){var n=t[o][1][e];return s(n?n:e)},f,f.exports,e,t,n,r)}return n[o].exports}var i=typeof require=="function"&&require;for(var o=0;o<r.length;o++)s(r[o]);return s})({1:[function(require,module,exports){
+(function e(t,n,r){function s(o,u){if(!n[o]){if(!t[o]){var a=typeof require=="function"&&require;if(!u&&a)return a(o,!0);if(i)return i(o,!0);var f=new Error("Cannot find module '"+o+"'");throw f.code="MODULE_NOT_FOUND",f}var l=n[o]={exports:{}};t[o][0].call(l.exports,function(e){var n=t[o][1][e];return s(n?n:e)},l,l.exports,e,t,n,r)}return n[o].exports}var i=typeof require=="function"&&require;for(var o=0;o<r.length;o++)s(r[o]);return s})({1:[function(require,module,exports){
 var foo = require('./foo');
 
 },{"./foo":2}],2:[function(require,module,exports){
@@ -8,4 +8,4 @@ module.exports = function (n) { return n * 12 }
 },{"./nested":3}],3:[function(require,module,exports){
 module.exports.NESTED = true;
 
-},{}]},{},[1])
+},{}]},{},[1]);

data/test/fixtures/application.out.js

@@ -1,4 +1,4 @@
-(function e(t,n,r){function s(o,u){if(!n[o]){if(!t[o]){var a=typeof require=="function"&&require;if(!u&&a)return a(o,!0);if(i)return i(o,!0);throw new Error("Cannot find module '"+o+"'")}var f=n[o]={exports:{}};t[o][0].call(f.exports,function(e){var n=t[o][1][e];return s(n?n:e)},f,f.exports,e,t,n,r)}return n[o].exports}var i=typeof require=="function"&&require;for(var o=0;o<r.length;o++)s(r[o]);return s})({1:[function(require,module,exports){
+(function e(t,n,r){function s(o,u){if(!n[o]){if(!t[o]){var a=typeof require=="function"&&require;if(!u&&a)return a(o,!0);if(i)return i(o,!0);var f=new Error("Cannot find module '"+o+"'");throw f.code="MODULE_NOT_FOUND",f}var l=n[o]={exports:{}};t[o][0].call(l.exports,function(e){var n=t[o][1][e];return s(n?n:e)},l,l.exports,e,t,n,r)}return n[o].exports}var i=typeof require=="function"&&require;for(var o=0;o<r.length;o++)s(r[o]);return s})({1:[function(require,module,exports){
 var foo = require('./foo');
 
 },{"./foo":2}],2:[function(require,module,exports){
@@ -8,4 +8,4 @@ module.exports = function (n) { return n * 11 }
 },{"./nested":3}],3:[function(require,module,exports){
 module.exports.NESTED = true;
 
-},{}]},{},[1])
+},{}]},{},[1]);

data/test/fixtures/foo.out.js

@@ -1,4 +1,4 @@
-(function e(t,n,r){function s(o,u){if(!n[o]){if(!t[o]){var a=typeof require=="function"&&require;if(!u&&a)return a(o,!0);if(i)return i(o,!0);throw new Error("Cannot find module '"+o+"'")}var f=n[o]={exports:{}};t[o][0].call(f.exports,function(e){var n=t[o][1][e];return s(n?n:e)},f,f.exports,e,t,n,r)}return n[o].exports}var i=typeof require=="function"&&require;for(var o=0;o<r.length;o++)s(r[o]);return s})({1:[function(require,module,exports){
+(function e(t,n,r){function s(o,u){if(!n[o]){if(!t[o]){var a=typeof require=="function"&&require;if(!u&&a)return a(o,!0);if(i)return i(o,!0);var f=new Error("Cannot find module '"+o+"'");throw f.code="MODULE_NOT_FOUND",f}var l=n[o]={exports:{}};t[o][0].call(l.exports,function(e){var n=t[o][1][e];return s(n?n:e)},l,l.exports,e,t,n,r)}return n[o].exports}var i=typeof require=="function"&&require;for(var o=0;o<r.length;o++)s(r[o]);return s})({1:[function(require,module,exports){
 require('./nested');
 module.exports = function (n) { return n * 11 }
 ;
@@ -6,4 +6,4 @@ module.exports = function (n) { return n * 11 }
 },{"./nested":2}],2:[function(require,module,exports){
 module.exports.NESTED = true;
 
-},{}]},{},[1])
+},{}]},{},[1]);

data/test/fixtures/main.out.js

@@ -1,6 +1,11 @@
-require=(function e(t,n,r){function s(o,u){if(!n[o]){if(!t[o]){var a=typeof require=="function"&&require;if(!u&&a)return a(o,!0);if(i)return i(o,!0);throw new Error("Cannot find module '"+o+"'")}var f=n[o]={exports:{}};t[o][0].call(f.exports,function(e){var n=t[o][1][e];return s(n?n:e)},f,f.exports,e,t,n,r)}return n[o].exports}var i=typeof require=="function"&&require;for(var o=0;o<r.length;o++)s(r[o]);return s})({"a_huge_library":[function(require,module,exports){
-module.exports=require('ReMerY');
-},{}],"ReMerY":[function(require,module,exports){
+require=(function e(t,n,r){function s(o,u){if(!n[o]){if(!t[o]){var a=typeof require=="function"&&require;if(!u&&a)return a(o,!0);if(i)return i(o,!0);var f=new Error("Cannot find module '"+o+"'");throw f.code="MODULE_NOT_FOUND",f}var l=n[o]={exports:{}};t[o][0].call(l.exports,function(e){var n=t[o][1][e];return s(n?n:e)},l,l.exports,e,t,n,r)}return n[o].exports}var i=typeof require=="function"&&require;for(var o=0;o<r.length;o++)s(r[o]);return s})({1:[function(require,module,exports){
+var library = require('./a_huge_library');
+
+module.exports = function() {
+  console.log('library', library);
+};
+
+},{"./a_huge_library":2}],2:[function(require,module,exports){
 // pretend this file is 1 MB
 //
 // app_main.js is going to require() it and browserify.yml is going to tell it to use --require on it
@@ -16,11 +21,4 @@ module.exports=require('ReMerY');
 
 module.exports = "THIS IS A HUGE LIBRARY";
 
-},{}],3:[function(require,module,exports){
-var library = require('./a_huge_library');
-
-module.exports = function() {
-  console.log('library', library);
-};
-
-},{"./a_huge_library":"ReMerY"}]},{},[3])
+},{}]},{},[1]);

data/test/fixtures/mocha.js

@@ -1,4 +1,4 @@
-(function e(t,n,r){function s(o,u){if(!n[o]){if(!t[o]){var a=typeof require=="function"&&require;if(!u&&a)return a(o,!0);if(i)return i(o,!0);throw new Error("Cannot find module '"+o+"'")}var f=n[o]={exports:{}};t[o][0].call(f.exports,function(e){var n=t[o][1][e];return s(n?n:e)},f,f.exports,e,t,n,r)}return n[o].exports}var i=typeof require=="function"&&require;for(var o=0;o<r.length;o++)s(r[o]);return s})({1:[function(require,module,exports){
+(function e(t,n,r){function s(o,u){if(!n[o]){if(!t[o]){var a=typeof require=="function"&&require;if(!u&&a)return a(o,!0);if(i)return i(o,!0);var f=new Error("Cannot find module '"+o+"'");throw f.code="MODULE_NOT_FOUND",f}var l=n[o]={exports:{}};t[o][0].call(l.exports,function(e){var n=t[o][1][e];return s(n?n:e)},l,l.exports,e,t,n,r)}return n[o].exports}var i=typeof require=="function"&&require;for(var o=0;o<r.length;o++)s(r[o]);return s})({1:[function(require,module,exports){
 (function() {
   var f, hello;
 
@@ -17,4 +17,4 @@ module.exports = function (n) { return n * 11 }
 },{"./nested":3}],3:[function(require,module,exports){
 module.exports.NESTED = true;
 
-},{}]},{},[1])
+},{}]},{},[1]);

data/test/fixtures/node_path_based_require.out.js

@@ -1,4 +1,4 @@
-(function e(t,n,r){function s(o,u){if(!n[o]){if(!t[o]){var a=typeof require=="function"&&require;if(!u&&a)return a(o,!0);if(i)return i(o,!0);throw new Error("Cannot find module '"+o+"'")}var f=n[o]={exports:{}};t[o][0].call(f.exports,function(e){var n=t[o][1][e];return s(n?n:e)},f,f.exports,e,t,n,r)}return n[o].exports}var i=typeof require=="function"&&require;for(var o=0;o<r.length;o++)s(r[o]);return s})({1:[function(require,module,exports){
+(function e(t,n,r){function s(o,u){if(!n[o]){if(!t[o]){var a=typeof require=="function"&&require;if(!u&&a)return a(o,!0);if(i)return i(o,!0);var f=new Error("Cannot find module '"+o+"'");throw f.code="MODULE_NOT_FOUND",f}var l=n[o]={exports:{}};t[o][0].call(l.exports,function(e){var n=t[o][1][e];return s(n?n:e)},l,l.exports,e,t,n,r)}return n[o].exports}var i=typeof require=="function"&&require;for(var o=0;o<r.length;o++)s(r[o]);return s})({1:[function(require,module,exports){
 var answer = require('some_folder/answer');
 
 console.log('answer', answer);
@@ -6,4 +6,4 @@ console.log('answer', answer);
 },{"some_folder/answer":2}],2:[function(require,module,exports){
 module.exports = 42;
 
-},{}]},{},[1])
+},{}]},{},[1]);

data/test/fixtures/secondary.out.js

@@ -1,8 +1,24 @@
-(function e(t,n,r){function s(o,u){if(!n[o]){if(!t[o]){var a=typeof require=="function"&&require;if(!u&&a)return a(o,!0);if(i)return i(o,!0);throw new Error("Cannot find module '"+o+"'")}var f=n[o]={exports:{}};t[o][0].call(f.exports,function(e){var n=t[o][1][e];return s(n?n:e)},f,f.exports,e,t,n,r)}return n[o].exports}var i=typeof require=="function"&&require;for(var o=0;o<r.length;o++)s(r[o]);return s})({1:[function(require,module,exports){
+(function e(t,n,r){function s(o,u){if(!n[o]){if(!t[o]){var a=typeof require=="function"&&require;if(!u&&a)return a(o,!0);if(i)return i(o,!0);var f=new Error("Cannot find module '"+o+"'");throw f.code="MODULE_NOT_FOUND",f}var l=n[o]={exports:{}};t[o][0].call(l.exports,function(e){var n=t[o][1][e];return s(n?n:e)},l,l.exports,e,t,n,r)}return n[o].exports}var i=typeof require=="function"&&require;for(var o=0;o<r.length;o++)s(r[o]);return s})({1:[function(require,module,exports){
 var library = require('./a_huge_library');
 
 module.exports = function() {
   console.log('some problem', library);
 };
 
-},{"./a_huge_library":"ReMerY"}]},{},[1])
+},{"./a_huge_library":"/a_huge_library"}],2:[function(require,module,exports){
+// pretend this file is 1 MB
+//
+// app_main.js is going to require() it and browserify.yml is going to tell it to use --require on it
+//
+// app_secondary.js is going to require() it too but we know app_main.js is always going to be loaded
+// so browserify.yml will be configured to mark it as --external so it is not bundled in
+//
+// this results in app_main.js taking the cost of loading app_a_huge_library.js
+//
+// and app_secondary.js saving the cost of loading app_a_huge_library.js (because again,
+// we know a priori that something else has loaded it)
+
+
+module.exports = "THIS IS A HUGE LIBRARY";
+
+},{}]},{},[1]);

metadata

@@ -1,111 +1,111 @@
 --- !ruby/object:Gem::Specification
 name: browserify-rails
 version: !ruby/object:Gem::Version
-  version: 0.4.2
+  version: 0.5.0
 platform: ruby
 authors:
 - Henry Hsu, Cymen Vig
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-09-02 00:00:00.000000000 Z
+date: 2014-10-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: sprockets
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '2.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '2.0'
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '1.3'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '1.3'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: rails
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '3.2'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '3.2'
 - !ruby/object:Gem::Dependency
   name: coffee-rails
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: mocha
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: pry
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 description: Browserify + Rails = CommonJS Heaven
@@ -115,8 +115,8 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
-- .gitignore
-- .travis.yml
+- ".gitignore"
+- ".travis.yml"
 - Gemfile
 - LICENSE.txt
 - README.md
@@ -200,12 +200,12 @@ require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []