browser_review_gate 0.1.1 → 0.1.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: fc436627f031a3389801655161462b2da163e43679b3bc42b0856b28bd89b999
-  data.tar.gz: e22daa7ab54df4bff78e8926d18bfd627e5e615e5209547f9363a32591d6ce71
+  metadata.gz: 1d796f7cca8b1df8cb9baf1dde44f2ce6c7417a97df23904d83f57ff1d2b6585
+  data.tar.gz: 2dca99945ced333c56b66906d0e5603e6c1f6c71b65557a8acfbd5c364bafcbc
 SHA512:
-  metadata.gz: 36f2ef20d5d315c52fa483ce14e4279f6a2b16b798e71b9936a6c5946998e7e24def8c63e7d7b9408b6f156edbe382f02e38d509882a155d661ff618f38299eb
-  data.tar.gz: 165540cabff36b17c1dadcfcc225f23051ae0b558d912bf9d762127844daebb30913c0f00abb579b9987ff7bce5ba8c23de2cd9332cceaf77106d7957d4c9cd7
+  metadata.gz: 16f2cac1e96bfaa0f6b2a7e2033e1375b358f3323bc9095282eb59f28718f94ec5a225b1ace02f8e3379266887972c16b9ec333c93046ba40967929181c0e996
+  data.tar.gz: 3731b22121fd1cd20d16f0af4f44f375247966e56a5faab65301def109784823de3b8ff01d047174ef19967ef559d4fcdbbc4d5457bbf28af29d64d19c8de657

data/CHANGELOG.md

@@ -1,5 +1,12 @@
 # Changelog
 
+## 0.1.2
+
+- Nothing holds a command back any more. The before-command hooks of 0.1.1, which stopped
+  `gh pr create` and review requests while a run was owed, are removed: running the verification is
+  the author's choice, and only CI decides whether a review request stays. The installer deletes the
+  old hook entries; until then they do nothing.
+
 ## 0.1.1
 
 - Reviewers whose requests were taken back are asked again automatically once the run is published.

data/README.md

@@ -84,7 +84,7 @@ Local commands need the `gh` CLI, signed in.
 - **Reviewers come back on their own.** A request taken back is remembered; once the run is published, the same people are asked again.
 - **A waiver for what cannot be run.** Someone other than the author adds the `browser-verification-waived` label and review proceeds without a run.
 - **A status next to the checks.** `browser-verification` is pending while a run is owed and green otherwise. Make it a required check if you want it to block merging.
-- **A reminder before the PR.** In Claude Code, Cursor and Codex, `gh pr create` and review requests are held with a message when a run is still owed. The agent runs the verification first, or repeats the command with `BROWSER_REVIEW_GATE_SKIP=1` when the person says to go ahead.
+- **Nothing is forced.** Opening a PR never requires a run. The PR comment says when one is needed and how to do it; it only becomes necessary when the author wants a reviewer.
 - **The agent does not start your app.** It uses the one that is running and asks you to start it otherwise.
 
 ## What it does not do

data/lib/browser_review_gate/cli.rb

@@ -16,7 +16,6 @@ module BrowserReviewGate
         save --report PATH                        keep results until the PR for this commit is opened
         request-assessment NUMBER                 ask CI to assess a PR that has no decision yet
         hook AGENT                                after a command: publish the saved run after `gh pr create`
-        hook AGENT --before                       before a command: say when a browser run is still owed
 
       For CI
         ci NUMBER                                 assess the PR and take back premature reviewer requests
@@ -118,13 +117,14 @@ module BrowserReviewGate
       0
     end
 
+    # Version 0.1.1 installed a `--before` hook that held commands back. It is gone; a project that
+    # still has the entry gets a silent no-op until the installer removes it.
     def hook
-      before = !@argv.delete("--before").nil?
+      return 0 if @argv.delete("--before")
+
       agent = @argv.shift
-      hook = Hook.new(publisher_factory: -> { Publisher.new(github: github, config: config) },
-        status_factory: -> { Status.new(github: github, config: config) }, config: config)
-      message = before ? hook.before(@stdin.read) : hook.after(@stdin.read)
-      output = Hook.render(message, agent, before: before)
+      message = Hook.new(publisher_factory: -> { Publisher.new(github: github, config: config) }).after(@stdin.read)
+      output = Hook.render(message, agent)
       @stdout.puts output if output
       0
     end

data/lib/browser_review_gate/hook.rb

@@ -1,27 +1,23 @@
 require "json"
 
 module BrowserReviewGate
-  # Runs around an agent's shell commands.
-  #
-  # After a command that opened a PR, the browser run saved for this commit is published.
-  # Before a command that opens a PR or asks for review, the agent is told when a browser run is still
-  # owed, so the request is not made only to be taken back. It never fails the agent's session.
+  # Runs after an agent's shell command. When the command opened a PR, the browser run saved for this
+  # commit is published. It never holds a command back and never fails the agent: running the
+  # verification is the author's choice, and the gate on review requests lives in CI.
   class Hook
     OPEN_PR = "gh pr create"
-    REVIEW_REQUEST = /gh pr (create|edit)\b.*(--reviewer|--add-reviewer|-r )|requested_reviewers/
-    SKIP = "BROWSER_REVIEW_GATE_SKIP=1"
 
-    def initialize(publisher_factory:, status_factory: nil, config: Config.new, shell: Shell.new)
+    def initialize(publisher_factory:, shell: Shell.new)
       @publisher_factory = publisher_factory
-      @status_factory = status_factory
-      @config = config
       @shell = shell
     end
 
     # `payload` is the raw hook input. Returns a message for the agent, or nil when nothing was done.
     def after(payload)
       return unless payload.to_s.include?(OPEN_PR)
-      return unless saved_run?
+
+      sha = @shell.call("git", "rev-parse", "HEAD").strip
+      return unless SavedReport.new(sha: sha, shell: @shell).exist?
 
       verified = @publisher_factory.call.publish
       verified ? "Saved browser verification published; human review can be requested." :
@@ -30,58 +26,12 @@ module BrowserReviewGate
       "Saved browser verification was not published: #{error.message}"
     end
 
-    # Returns the reason the command should wait, or nil to let it run.
-    def before(payload)
-      text = payload.to_s
-      return if text.include?(SKIP)
-
-      reason = review_request_reason(text) if text.match?(REVIEW_REQUEST)
-      reason ||= open_pr_reason if text.include?(OPEN_PR)
-      reason && "#{reason} If the person asked to go ahead anyway, run the same command prefixed with #{SKIP}."
-    rescue Error
-      nil
-    end
-
-    # Claude Code and Codex read a JSON object; Cursor reads its own shape.
-    def self.render(message, agent, before: false)
+    # Claude Code and Codex read a JSON object; other agents show plain text.
+    def self.render(message, agent)
       return if message.nil?
-      return JSON.generate(permission: "deny", agentMessage: message, userMessage: message) if before && agent == "cursor"
       return message unless %w[claude codex].include?(agent)
-      return JSON.generate(hookSpecificOutput: { hookEventName: "PostToolUse", additionalContext: message }) unless before
-
-      JSON.generate(hookSpecificOutput: { hookEventName: "PreToolUse", permissionDecision: "deny", permissionDecisionReason: message })
-    end
-
-    private
-
-    def saved_run?
-      SavedReport.new(sha: @shell.call("git", "rev-parse", "HEAD").strip, shell: @shell).exist?
-    end
-
-    # No PR exists yet, so CI has not decided; only the changed paths can tell.
-    def open_pr_reason
-      return if saved_run? || changed_files.all? { |path| @config.ignored?(path) }
-
-      "No browser run is saved for this commit, and the change may alter browser behavior. " \
-        "Run #{@config.command} first: the run is published when the PR is opened and review requests stay."
-    end
-
-    def review_request_reason(text)
-      status = @status_factory.call.to_h(text[/gh pr edit\s+(\d+)/, 1]&.to_i)
-      case status["next"]
-      when "publish_saved" then "A browser run is saved but not published. Run `browser-review-gate publish` first, or the review request will be taken back."
-      when "run_and_publish", "ask_to_start_app" then "This PR needs a browser run (#{@config.command} #{status["pull_request"]}); a review request made now will be taken back."
-      end
-    end
 
-    # What the PR would contain. When no base branch can be found the change counts as unknown.
-    def changed_files
-      %w[origin/HEAD origin/main origin/master].each do |base|
-        return @shell.call("git", "diff", "--name-only", "#{base}...HEAD").lines.map(&:chomp)
-      rescue Error
-        next
-      end
-      [ "unknown" ]
+      JSON.generate(hookSpecificOutput: { hookEventName: "PostToolUse", additionalContext: message })
     end
   end
 end

data/lib/browser_review_gate/installer.rb

@@ -110,25 +110,23 @@ module BrowserReviewGate
 
     def install_claude
       managed(".claude/skills/browser-pr-verification/SKILL.md", render("claude_skill.md"))
-      add_hooks(".claude/settings.json", "claude") do |hooks, command, before|
-        (hooks[before ? "PreToolUse" : "PostToolUse"] ||= []) <<
-          { "matcher" => "Bash", "hooks" => [ { "type" => "command", "command" => command, "timeout" => 60 } ] }
+      add_hook(".claude/settings.json", "claude", %w[PreToolUse]) do |hooks, command|
+        (hooks["PostToolUse"] ||= []) << { "matcher" => "Bash", "hooks" => [ { "type" => "command", "command" => command, "timeout" => 60 } ] }
       end
     end
 
     def install_cursor
       managed(".cursor/commands/browser-pr-verification.md", render("cursor_command.md"))
-      add_hooks(".cursor/hooks.json", "cursor", "version" => 1) do |hooks, command, before|
-        (hooks[before ? "beforeShellExecution" : "afterShellExecution"] ||= []) << { "command" => command }
+      add_hook(".cursor/hooks.json", "cursor", %w[beforeShellExecution], "version" => 1) do |hooks, command|
+        (hooks["afterShellExecution"] ||= []) << { "command" => command }
       end
     end
 
     # Codex runs a project hook only after the person trusts it in /hooks, so the AGENTS.md section also
     # tells the agent to publish after it opens the PR.
     def install_codex
-      add_hooks(".codex/hooks.json", "codex") do |hooks, command, before|
-        (hooks[before ? "PreToolUse" : "PostToolUse"] ||= []) <<
-          { "matcher" => "^Bash$", "hooks" => [ { "type" => "command", "command" => command, "timeout" => 60 } ] }
+      add_hook(".codex/hooks.json", "codex", %w[PreToolUse]) do |hooks, command|
+        (hooks["PostToolUse"] ||= []) << { "matcher" => "^Bash$", "hooks" => [ { "type" => "command", "command" => command, "timeout" => 60 } ] }
       end
       path = "AGENTS.md"
       current = exist?(path) ? File.read(File.join(@root, path)) : nil
@@ -139,8 +137,8 @@ module BrowserReviewGate
 
     # A machine without the gem (a cloud agent, a fresh container) must not see a failing hook after
     # every command.
-    def hook_command(agent, before)
-      "command -v browser-review-gate >/dev/null 2>&1 && #{HOOK} #{agent}#{" --before" if before} || true"
+    def hook_command(agent)
+      "command -v browser-review-gate >/dev/null 2>&1 && #{HOOK} #{agent} || true"
     end
 
     def render(name)
@@ -161,14 +159,22 @@ module BrowserReviewGate
       write(path, content, current)
     end
 
-    # Adds the after-command and before-command hook entries the file does not have yet.
-    def add_hooks(path, agent, defaults = {})
+    # Adds the after-command hook entry when the file lacks it, and removes the before-command entries
+    # version 0.1.1 put under `stale_events`: nothing holds a command back any more.
+    def add_hook(path, agent, stale_events, defaults = {})
       current = exist?(path) ? File.read(File.join(@root, path)) : nil
-      missing = [ false, true ].reject { |before| current.to_s.match?(before ? /hook #{agent} --before/ : /hook #{agent}(?! --before)/) }
-      return @log.puts("  unchanged #{path}") if missing.empty?
+      present = current.to_s.match?(/hook #{agent}(?! --before)/)
+      return @log.puts("  unchanged #{path}") if present && !current.include?("hook #{agent} --before")
 
       settings = defaults.merge(current ? JSON.parse(current) : {})
-      missing.each { |before| yield(settings["hooks"] ||= {}, hook_command(agent, before), before) }
+      hooks = (settings["hooks"] ||= {})
+      stale_events.each do |event|
+        next unless hooks[event]
+
+        hooks[event].reject! { |entry| JSON.generate(entry).include?("hook #{agent} --before") }
+        hooks.delete(event) if hooks[event].empty?
+      end
+      yield(hooks, hook_command(agent)) unless present
       write(path, "#{JSON.pretty_generate(settings)}\n", current)
     end
 

data/lib/browser_review_gate/version.rb

@@ -1,3 +1,3 @@
 module BrowserReviewGate
-  VERSION = "0.1.1"
+  VERSION = "0.1.2"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: browser_review_gate
 version: !ruby/object:Gem::Version
-  version: 0.1.1
+  version: 0.1.2
 platform: ruby
 authors:
 - JetRockets
@@ -66,7 +66,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 4.0.10
+rubygems_version: 4.0.1
 specification_version: 4
 summary: Keeps human review of a pull request behind a browser run of its browser-visible
   changes.