browser 5.3.1 → 6.0.0

data/test/test_helper.rb

@@ -1,7 +1,9 @@
 # frozen_string_literal: true
 
 require "simplecov"
-SimpleCov.start
+SimpleCov.start do
+  add_filter %r{/test/}
+end
 
 ENV["BUNDLE_GEMFILE"] ||= File.expand_path("../Gemfile", __dir__)
 require "bundler/setup"
@@ -14,7 +16,7 @@ require "yaml"
 module Minitest
   class Test
     setup do
-      Browser::Bot.instance_variable_set("@detect_empty_ua", false)
+      Browser::Bot.instance_variable_set(:@detect_empty_ua, false)
     end
 
     def assert_deprecated(message, file, line, &block)

data/test/ua.yml

@@ -83,6 +83,11 @@ KINDLE: "Mozilla/5.0 (Linux; U; en-US) AppleWebKit/528.5+ (KHTML, like Gecko, Sa
 KINDLE_FIRE: "Mozilla/5.0 (Linux; U; Android 2.3.4; en-us; Kindle Fire Build/GINGERBREAD) AppleWebKit/533.1 (KHTML, like Gecko) Version/4.0 Mobile Safari/533.1"
 KINDLE_FIRE_HD: "Mozilla/5.0 (Linux; U; en-us; KFTT Build/IML74K) AppleWebKit/535.19 (KHTML, like Gecko) Silk/3.4 Safari/535.19 Silk-Accelerated=true"
 KINDLE_FIRE_HD_MOBILE: "Mozilla/5.0 (Linux; U; Android 4.0.3; en-us; KFTT Build/IML74K) AppleWebKit/535.19 (KHTML, like Gecko) Silk/3.4 Mobile Safari/535.19 Silk-Accelerated=true"
+KINDLE_SILK_TABLET: Mozilla/5.0 (Linux; Android 4.4.3; KFTHWI Build/KTU84M) AppleWebKit/537.36 (KHTML, like Gecko) Silk/44.1.54 like Chrome/44.0.2403.63 Safari/537.36
+KINDLE_SILK_DESKTOP: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Silk/44.1.54 like Chrome/44.0.2403.63 Safari/537.36
+KINDLE_SILK_MOBILE: Mozilla/5.0 (Linux; U; Android 4.4.3; KFTHWI Build/KTU84M) AppleWebKit/537.36 (KHTML, like Gecko) Silk/44.1.54 like Chrome/44.0.2403.63 Mobile Safari/537.36
+KINDLE_SILK_TABLET_1ST_GEN: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10_6_3; en-us; Silk/1.0.13.81_10003810) AppleWebKit/533.16 (KHTML, like Gecko) Version/5.0 Safari/533.16 Silk-Accelerated=true
+KINDLE_SILK_MOBILE_1ST_GEN: Mozilla/5.0 (Linux; U; Android 2.3.4; en-us; Silk/1.0.13.81_10003810) AppleWebKit/533.1 (KHTML, like Gecko) Version/4.0 Mobile Safari/533.1 Silk-Accelerated=true
 LUMIA800: "Mozilla/5.0 (compatible; MSIE 9.0; Windows NT 6.1; Trident/5.0; XBLWP7; ZuneWP7"
 MAC_OS: "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_3) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/13.0.5 Safari/605.1.15"
 MAC_OSX: "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_11_2) AppleWebKit/601.3.9 (KHTML, like Gecko) Version/9.0.2 Safari/601.3.9"

data/test/unit/accept_language_test.rb

@@ -161,6 +161,6 @@ class AcceptLanguageTest < Minitest::Test
   test "sets default quality value for invalid strings" do
     result = Browser::AcceptLanguage.parse(";q=0.0.0.0")
 
-    assert_equal 0.1, result[0].quality
+    assert_equal 0.1, result[0].quality # rubocop:disable Minitest/AssertInDelta
   end
 end

data/test/unit/android_app_test.rb

@@ -5,15 +5,15 @@ require "test_helper"
 class AndroidAppTest < Minitest::Test
   let(:browser) { Browser.new(Browser["ANDROID_WEBVIEW"]) }
 
-  test "detect as android" do
+  test "detects as android" do
     assert browser.platform.android?
   end
 
-  test "detect as webview" do
+  test "detects as webview" do
     assert browser.platform.android_webview?
   end
 
-  test "non-webviews do not detect as webview" do
+  test "does not detect non-webviews as webview" do
     %w[
       ANDROID_CUPCAKE
       ANDROID_DONUT

data/test/unit/android_test.rb

@@ -3,102 +3,102 @@
 require "test_helper"
 
 class AndroidTest < Minitest::Test
-  test "detect android cupcake (1.5)" do
+  test "detects android cupcake (1.5)" do
     browser = Browser.new(Browser["ANDROID_CUPCAKE"])
     assert browser.platform.android?
     assert browser.platform.android?(1.5)
   end
 
-  test "detect android donut (1.6)" do
+  test "detects android donut (1.6)" do
     browser = Browser.new(Browser["ANDROID_DONUT"])
     assert browser.platform.android?
     assert browser.platform.android?(1.6)
   end
 
-  test "detect android eclair (2.1)" do
+  test "detects android eclair (2.1)" do
     browser = Browser.new(Browser["ANDROID_ECLAIR_21"])
     assert browser.platform.android?
     assert browser.platform.android?(2.1)
   end
 
-  test "detect android froyo (2.2)" do
+  test "detects android froyo (2.2)" do
     browser = Browser.new(Browser["ANDROID_FROYO"])
     assert browser.platform.android?
     assert browser.platform.android?(2.2)
   end
 
-  test "detect android gingerbread (2.3)" do
+  test "detects android gingerbread (2.3)" do
     browser = Browser.new(Browser["ANDROID_GINGERBREAD"])
     assert browser.platform.android?
     assert browser.platform.android?("~> 2.3.0")
   end
 
-  test "detect android honeycomb (3.0)" do
+  test "detects android honeycomb (3.0)" do
     browser = Browser.new(Browser["ANDROID_HONEYCOMB_30"])
     assert browser.platform.android?
     assert browser.platform.android?("~> 3.0")
   end
 
-  test "detect android ice cream sandwich (4.0)" do
+  test "detects android ice cream sandwich (4.0)" do
     browser = Browser.new(Browser["ANDROID_ICECREAM"])
     assert browser.platform.android?
     assert browser.platform.android?("~> 4.0")
   end
 
-  test "detect android jellybean (4.1)" do
+  test "detects android jellybean (4.1)" do
     browser = Browser.new(Browser["ANDROID_JELLYBEAN_41"])
     assert browser.platform.android?
     assert browser.platform.android?("~> 4.1")
   end
 
-  test "detect android jellybean (4.2)" do
+  test "detects android jellybean (4.2)" do
     browser = Browser.new(Browser["ANDROID_JELLYBEAN_42"])
     assert browser.platform.android?
     assert browser.platform.android?(4.2)
   end
 
-  test "detect android jellybean (4.3)" do
+  test "detects android jellybean (4.3)" do
     browser = Browser.new(Browser["ANDROID_JELLYBEAN_43"])
     assert browser.platform.android?
     assert browser.platform.android?(4.3)
   end
 
-  test "detect android kitkat (4.4)" do
+  test "detects android kitkat (4.4)" do
     browser = Browser.new(Browser["ANDROID_KITKAT"])
     assert browser.platform.android?
     assert browser.platform.android?(4.4)
   end
 
-  test "detect android lollipop (5.0)" do
+  test "detects android lollipop (5.0)" do
     browser = Browser.new(Browser["ANDROID_LOLLIPOP_50"])
     assert browser.platform.android?
     assert browser.platform.android?(5.0)
   end
 
-  test "detect android lollipop (5.1)" do
+  test "detects android lollipop (5.1)" do
     browser = Browser.new(Browser["ANDROID_LOLLIPOP_51"])
     assert browser.platform.android?
     assert browser.platform.android?(5.1)
   end
 
-  test "detect android oreo (8.0)" do
+  test "detects android oreo (8.0)" do
     browser = Browser.new(Browser["ANDROID_OREO"])
     assert browser.platform.android?
     assert browser.platform.android?(8.0)
   end
 
-  test "detect android tv" do
+  test "detects android tv" do
     browser = Browser.new(Browser["ANDROID_TV"])
     assert browser.platform.android?
     assert browser.device.tv?
   end
 
-  test "detect nexus player" do
+  test "detects nexus player" do
     browser = Browser.new(Browser["ANDROID_NEXUS_PLAYER"])
     assert browser.platform.android?
   end
 
-  test "detect firefox for android without android version" do
+  test "detects firefox for android without android version" do
     browser = Browser.new(Browser["FIREFOX_ANDROID"])
 
     assert browser.platform.android?

data/test/unit/blackberry_test.rb

@@ -72,7 +72,7 @@ class BlackberryTest < Minitest::Test
     assert_equal "7", browser.version
   end
 
-  test "don't detect as two different versions" do
+  test "does not detect as two different versions" do
     browser = Browser.new(Browser["BLACKBERRY10"])
     assert browser.platform.blackberry?("~> 10.0")
     refute browser.platform.blackberry?("~> 7.0")

data/test/unit/bots_test.rb

@@ -4,13 +4,13 @@ require "test_helper"
 
 class BotsTest < Minitest::Test
   Browser.bot_user_agents.each do |key, ua|
-    test "detect #{key} as bot" do
+    test "detects #{key} as bot" do
       browser = Browser.new(ua)
       assert browser.bot?
     end
   end
 
-  test "don't detect as bot" do
+  test "does not detect as bot" do
     browser = Browser.new(Browser["CHROME"])
     refute browser.bot?
   end
@@ -55,7 +55,7 @@ class BotsTest < Minitest::Test
     refute browser.safari?
   end
 
-  test "custom android user agent (#144)" do
+  test "handles custom android user agent (#144)" do
     browser = Browser.new(Browser["CUSTOM_APP"])
 
     assert browser.platform.android?
@@ -86,7 +86,7 @@ class BotsTest < Minitest::Test
   end
 
   test "adds custom bot matcher" do
-    Browser::Bot.matchers << ->(ua, _) { ua.match?(/some-script/) }
+    Browser::Bot.matchers << ->(ua, _) { ua.include?("some-script") }
     browser = Browser.new("some-script")
 
     assert browser.bot?
@@ -108,4 +108,15 @@ class BotsTest < Minitest::Test
       assert_equal Browser::Bot::KeywordMatcher, browser.bot.why?
     end
   end
+
+  test "extends lists" do
+    Browser::Bot.bots["another-bot"] = "Another bot"
+    Browser::Bot.bot_exceptions.push("exclude-this-bot")
+    Browser::Bot.search_engines["new-search-engine"] = "New search engine"
+
+    assert_equal "Another bot", Browser::Bot.bots["another-bot"]
+    assert_includes Browser::Bot.bot_exceptions, "exclude-this-bot"
+    assert_equal "New search engine",
+                 Browser::Bot.search_engines["new-search-engine"]
+  end
 end

data/test/unit/chrome_test.rb

@@ -12,6 +12,7 @@ class ChromeTest < Minitest::Test
     assert browser.webkit?
     assert_equal "5.0.375.99", browser.full_version
     assert_equal "5", browser.version
+    assert browser.chromium_based?
   end
 
   test "detects mobile chrome" do

data/test/unit/device_test.rb

@@ -13,7 +13,7 @@ class DeviceTest < Minitest::Test
     end
   end
 
-  test "extend matchers" do
+  test "extends matchers" do
     Browser::Device.matchers.unshift(CustomDevice)
     device = Browser::Device.new("Custom")
     assert_equal :custom, device.id
@@ -23,28 +23,28 @@ class DeviceTest < Minitest::Test
     assert_equal :unknown_device, device.id
   end
 
-  test "detect generic device" do
+  test "detects generic device" do
     device = Browser::Device.new("")
 
     assert device.unknown?
     assert_equal :unknown_device, device.id
   end
 
-  test "detect ipad" do
+  test "detects ipad" do
     device = Browser::Device.new(Browser["IOS9"])
     assert device.ipad?
     assert_equal :ipad, device.id
     assert_equal "iPad", device.name
   end
 
-  test "detect old ipad" do
+  test "detects old ipad" do
     device = Browser::Device.new(Browser["IOS3"])
     assert device.ipad?
     assert_equal :ipad, device.id
     assert_equal "iPad", device.name
   end
 
-  test "detect ipod" do
+  test "detects ipod" do
     device = Browser::Device.new(Browser["IPOD"])
     assert device.ipod_touch?
     assert device.ipod?
@@ -52,14 +52,14 @@ class DeviceTest < Minitest::Test
     assert_equal "iPod Touch", device.name
   end
 
-  test "detect iphone" do
+  test "detects iphone" do
     device = Browser::Device.new(Browser["IOS8"])
     assert device.iphone?
     assert_equal :iphone, device.id
     assert_equal "iPhone", device.name
   end
 
-  test "detect ps3" do
+  test "detects ps3" do
     device = Browser::Device.new(Browser["PLAYSTATION3"])
     assert device.ps3?
     assert device.playstation3?
@@ -68,7 +68,7 @@ class DeviceTest < Minitest::Test
     assert_equal "PlayStation 3", device.name
   end
 
-  test "detect ps4" do
+  test "detects ps4" do
     device = Browser::Device.new(Browser["PLAYSTATION4"])
     assert device.ps4?
     assert device.playstation4?
@@ -99,14 +99,14 @@ class DeviceTest < Minitest::Test
     assert_equal "Xbox One", device.name
   end
 
-  test "detect psp" do
+  test "detects psp" do
     device = Browser::Device.new(Browser["PSP"])
     assert device.psp?
     assert_equal :psp, device.id
     assert_equal "PlayStation Portable", device.name
   end
 
-  test "detect psvita" do
+  test "detects psvita" do
     device = Browser::Device.new(Browser["PSP_VITA"])
     assert device.playstation_vita?
     assert device.vita?
@@ -114,7 +114,7 @@ class DeviceTest < Minitest::Test
     assert_equal "PlayStation Vita", device.name
   end
 
-  test "detect kindle" do
+  test "detects kindle" do
     device = Browser::Device.new(Browser["KINDLE"])
     assert device.kindle?
     assert_equal :kindle, device.id
@@ -127,7 +127,7 @@ class DeviceTest < Minitest::Test
     KINDLE_FIRE_HD
     KINDLE_FIRE_HD_MOBILE
   ].each do |key|
-    test "detect #{key} as kindle fire" do
+    test "detects #{key} as kindle fire" do
       device = Browser::Device.new(Browser[key])
 
       assert device.kindle?
@@ -137,7 +137,7 @@ class DeviceTest < Minitest::Test
     end
   end
 
-  test "detect wii" do
+  test "detects wii" do
     device = Browser::Device.new(Browser["NINTENDO_WII"])
     assert device.nintendo_wii?
     assert device.console?
@@ -147,7 +147,7 @@ class DeviceTest < Minitest::Test
     assert_equal "Nintendo Wii", device.name
   end
 
-  test "detect wiiu" do
+  test "detects wiiu" do
     device = Browser::Device.new(Browser["NINTENDO_WIIU"])
     assert device.nintendo_wiiu?
     assert device.wiiu?
@@ -157,7 +157,7 @@ class DeviceTest < Minitest::Test
     assert_equal "Nintendo WiiU", device.name
   end
 
-  test "detect switch" do
+  test "detects switch" do
     device = Browser::Device.new(Browser["NINTENDO_SWITCH"])
     assert device.nintendo_switch?
     assert device.switch?
@@ -167,7 +167,7 @@ class DeviceTest < Minitest::Test
     assert_equal "Nintendo Switch", device.name
   end
 
-  test "detect blackberry playbook" do
+  test "detects blackberry playbook" do
     device = Browser::Device.new(Browser["PLAYBOOK"])
     assert device.playbook?
     assert device.blackberry_playbook?
@@ -175,21 +175,21 @@ class DeviceTest < Minitest::Test
     assert_equal "BlackBerry Playbook", device.name
   end
 
-  test "detect surface" do
+  test "detects surface" do
     device = Browser::Device.new(Browser["SURFACE"])
     assert device.surface?
     assert_equal :surface, device.id
     assert_equal "Microsoft Surface", device.name
   end
 
-  test "detect tv" do
+  test "detects tv" do
     device = Browser::Device.new(Browser["SMART_TV"])
     assert device.tv?
     assert_equal :tv, device.id
     assert_equal "TV", device.name
   end
 
-  test "detect unknown device" do
+  test "detects unknown device" do
     device = Browser::Device.new("")
 
     assert device.unknown?
@@ -214,7 +214,7 @@ class DeviceTest < Minitest::Test
     OPERA_MOBI
     KINDLE_FIRE_HD_MOBILE
   ].each do |key|
-    test "detect #{key} as mobile" do
+    test "detects #{key} as mobile" do
       device = Browser::Device.new(Browser[key])
       assert device.mobile?
       refute device.tablet?
@@ -232,7 +232,7 @@ class DeviceTest < Minitest::Test
     FIREFOX_TABLET
     NEXUS7
   ].each do |key|
-    test "detect #{key} as tablet" do
+    test "detects #{key} as tablet" do
       device = Browser::Device.new(Browser[key])
       assert device.tablet?
       refute device.mobile?
@@ -253,13 +253,13 @@ class DeviceTest < Minitest::Test
     "CUSTOM_APP" => "HTC Ruby",
     "NOOK" => "NOOK BNTV250A"
   }.each do |key, name|
-    test "detect device name of #{key} as #{name}" do
+    test "detects device name of #{key} as #{name}" do
       device = Browser::Device.new(Browser[key])
       assert_equal name, device.name
     end
   end
 
-  test "detect samsung devices" do
+  test "detects samsung devices" do
     device = Browser::Device.new(Browser["SAMSUNG_SM-G975F"])
 
     assert device.samsung?
@@ -267,7 +267,7 @@ class DeviceTest < Minitest::Test
     assert_equal "Samsung Galaxy S10+", device.name
   end
 
-  test "detect generic samsung devices" do
+  test "detects generic samsung devices" do
     device = Browser::Device.new(Browser["SAMSUNG_SM-FAKE"])
 
     assert device.samsung?
@@ -280,7 +280,7 @@ class DeviceTest < Minitest::Test
     "SAMSUNG_SM-G960F" => "Samsung Galaxy S9",
     "SAMSUNG_SM-F700F" => "Samsung Galaxy Z Flip"
   }.each do |key, name|
-    test "detect device name of #{key} as #{name}" do
+    test "detects device name of #{key} as #{name}" do
       device = Browser::Device.new(Browser[key])
       assert_equal name, device.name
     end

data/test/unit/edge_test.rb

@@ -16,6 +16,7 @@ class EdgeTest < ActionController::TestCase
     refute browser.chrome?
     refute browser.safari?
     refute browser.device.mobile?
+    refute browser.chromium_based?
   end
 
   test "detects Microsoft Edge in compatibility view" do
@@ -33,6 +34,7 @@ class EdgeTest < ActionController::TestCase
     refute browser.chrome?
     refute browser.safari?
     refute browser.device.mobile?
+    refute browser.chromium_based?
   end
 
   test "detects Microsoft Edge Mobile" do
@@ -48,6 +50,7 @@ class EdgeTest < ActionController::TestCase
     refute browser.webkit?
     refute browser.chrome?
     refute browser.safari?
+    refute browser.chromium_based?
   end
 
   test "detects Microsoft Edge based on Chrome" do
@@ -58,6 +61,7 @@ class EdgeTest < ActionController::TestCase
     assert_equal "79.0.309.18", browser.full_version
     assert_equal "79", browser.version
     assert browser.platform.mac?
+    assert browser.chromium_based?
     refute browser.platform.windows?
     assert browser.edge?
     assert browser.webkit?
@@ -79,6 +83,7 @@ class EdgeTest < ActionController::TestCase
     refute browser.webkit?
     refute browser.chrome?
     refute browser.safari?
+    refute browser.chromium_based?
   end
 
   test "detects Microsoft Edge Mobile on Android" do
@@ -95,6 +100,7 @@ class EdgeTest < ActionController::TestCase
     refute browser.webkit?
     refute browser.chrome?
     refute browser.safari?
+    refute browser.chromium_based?
   end
 
   test "detects version by range" do

data/test/unit/electron_test.rb

@@ -3,7 +3,7 @@
 require "test_helper"
 
 class ElectronTest < Minitest::Test
-  test "detect electron" do
+  test "detects electron" do
     browser = Browser.new(Browser["ELECTRON"])
 
     assert_equal "Electron", browser.name

data/test/unit/facebook_test.rb

@@ -8,7 +8,7 @@ class FacebookTest < Minitest::Test
 
     assert_equal "Facebook", browser.name
     assert browser.facebook?
-    assert :facebook, browser.id
+    assert_equal :facebook, browser.id
     assert_equal "135.0.0.45.90", browser.full_version
     assert_equal "135", browser.version
   end
@@ -18,7 +18,7 @@ class FacebookTest < Minitest::Test
 
     assert_equal "Facebook", browser.name
     assert browser.facebook?
-    assert :facebook, browser.id
+    assert_equal :facebook, browser.id
     assert_equal "AppleWebKit/605.1.15", browser.full_version
     assert_equal "AppleWebKit/605", browser.version
   end
@@ -28,7 +28,7 @@ class FacebookTest < Minitest::Test
 
     assert_equal "Facebook", browser.name
     assert browser.facebook?
-    assert :facebook, browser.id
+    assert_equal :facebook, browser.id
     assert_equal "214.0.0.43.83", browser.full_version
     assert_equal "214", browser.version
   end

data/test/unit/generic_test.rb

@@ -3,20 +3,20 @@
 require "test_helper"
 
 class GenericTest < Minitest::Test
-  test "return default msie version" do
+  test "returns default msie version" do
     browser = Browser.new("")
 
     assert_equal "0.0", browser.msie_full_version
     assert_equal "0", browser.msie_version
   end
 
-  test "return default compatibility view" do
+  test "returns default compatibility view" do
     browser = Browser.new("")
 
     refute browser.compatibility_view?
   end
 
-  test "return default safari web app mode" do
+  test "returns default safari web app mode" do
     browser = Browser.new("")
 
     refute browser.safari_webapp_mode?

data/test/unit/instagram_test.rb

@@ -8,7 +8,7 @@ class InstagramTest < Minitest::Test
 
     assert_equal "Instagram", browser.name
     assert browser.instagram?
-    assert :instagram, browser.id
+    assert_equal :instagram, browser.id
     assert_equal "41.0.0.14.90", browser.full_version
     assert_equal "41", browser.version
   end
@@ -18,7 +18,7 @@ class InstagramTest < Minitest::Test
 
     assert_equal "Instagram", browser.name
     assert browser.instagram?
-    assert :instagram, browser.id
+    assert_equal :instagram, browser.id
     assert_equal "182257141", browser.full_version
     assert_equal "182257141", browser.version
   end

data/test/unit/internet_explorer_test.rb

@@ -261,43 +261,43 @@ class IeTest < Minitest::Test
     browser = Browser.new(Browser["IE6"])
     meta = browser.meta
 
-    assert meta.include?("ie")
-    assert meta.include?("ie6")
-    assert meta.include?("oldie")
-    assert meta.include?("lt-ie8")
-    assert meta.include?("lt-ie9")
-    assert meta.include?("windows")
+    assert_includes meta, "ie"
+    assert_includes meta, "ie6"
+    assert_includes meta, "oldie"
+    assert_includes meta, "lt-ie8"
+    assert_includes meta, "lt-ie9"
+    assert_includes meta, "windows"
   end
 
   test "returns string representation for ie7" do
     browser = Browser.new(Browser["IE7"])
     meta = browser.meta
 
-    assert meta.include?("ie")
-    assert meta.include?("ie7")
-    assert meta.include?("oldie")
-    assert meta.include?("lt-ie8")
-    assert meta.include?("lt-ie9")
-    assert meta.include?("windows")
+    assert_includes meta, "ie"
+    assert_includes meta, "ie7"
+    assert_includes meta, "oldie"
+    assert_includes meta, "lt-ie8"
+    assert_includes meta, "lt-ie9"
+    assert_includes meta, "windows"
   end
 
   test "returns string representation for ie8" do
     browser = Browser.new(Browser["IE8"])
     meta = browser.meta
 
-    assert meta.include?("ie")
-    assert meta.include?("ie8")
-    assert meta.include?("lt-ie9")
-    assert meta.include?("windows")
+    assert_includes meta, "ie"
+    assert_includes meta, "ie8"
+    assert_includes meta, "lt-ie9"
+    assert_includes meta, "windows"
   end
 
-  test "don't detect as two different versions" do
+  test "does not detect as two different versions" do
     browser = Browser.new(Browser["IE8"])
     assert browser.ie?(8)
     refute browser.ie?(7)
   end
 
-  test "more complex versioning check" do
+  test "handles more complex versioning check" do
     browser = Browser.new(Browser["IE8"])
     assert browser.ie?(["> 7", "< 9"])
   end

data/test/unit/ios_app_test.rb

@@ -5,15 +5,15 @@ require "test_helper"
 class IosAppTest < Minitest::Test
   let(:browser) { Browser.new(Browser["IOS_WEBVIEW"]) }
 
-  test "detect as ios" do
+  test "detects as ios" do
     assert browser.platform.ios?
   end
 
-  test "don't detect as safari" do
+  test "does not detect as safari" do
     refute browser.safari?
   end
 
-  test "detect as webview" do
+  test "detects as webview" do
     assert browser.platform.ios_webview?
   end
 end