browser 4.2.0 → 5.0.0

data/test/unit/alipay_test.rb

@@ -10,6 +10,9 @@ class AlipayTest < Minitest::Test
     assert browser.alipay?
     assert_equal "Alipay", browser.name
     assert_equal "2.3.4", browser.full_version
+
+    refute browser.chrome?
+    refute browser.safari?
   end
 
   test "detects alipay Android" do
@@ -19,6 +22,9 @@ class AlipayTest < Minitest::Test
     assert browser.alipay?
     assert_equal "Alipay", browser.name
     assert_equal "9.0.1.073001", browser.full_version
+
+    refute browser.chrome?
+    refute browser.safari?
   end
 
   test "detects version by range" do

data/test/unit/console_test.rb

@@ -5,11 +5,11 @@ require "test_helper"
 class ConsoleTest < Minitest::Test
   test "detects psp" do
     browser = Browser.new(Browser["PSP"])
-    assert_equal "Generic Browser", browser.name
+    assert_equal "Unknown Browser", browser.name
   end
 
   test "detects psp vita" do
     browser = Browser.new(Browser["PSP_VITA"])
-    assert_equal "Generic Browser", browser.name
+    assert_equal "Unknown Browser", browser.name
   end
 end

data/test/unit/device_test.rb

@@ -20,14 +20,14 @@ class DeviceTest < Minitest::Test
 
     Browser::Device.matchers.shift
     device = Browser::Device.new("Custom")
-    assert_equal :unknown, device.id
+    assert_equal :unknown_device, device.id
   end
 
   test "detect generic device" do
     device = Browser::Device.new("")
 
     assert device.unknown?
-    assert_equal :unknown, device.id
+    assert_equal :unknown_device, device.id
   end
 
   test "detect ipad" do

data/test/unit/duck_duck_go_test.rb

@@ -9,6 +9,7 @@ class DuckDuckGoTest < Minitest::Test
     refute browser.safari?
     refute browser.chrome?
     assert browser.webkit?
+    refute browser.bot?
     assert_equal "DuckDuckGo", browser.name
     assert_equal :duckduckgo, browser.id
   end
@@ -18,6 +19,7 @@ class DuckDuckGoTest < Minitest::Test
     assert browser.duck_duck_go?
     refute browser.safari?
     refute browser.chrome?
+    refute browser.bot?
     assert_equal "DuckDuckGo", browser.name
     assert_equal :duckduckgo, browser.id
   end

data/test/unit/google_search_app_test.rb

@@ -0,0 +1,54 @@
+# frozen_string_literal: true
+
+require "test_helper"
+
+class GoogleSearchAppTest < Minitest::Test
+  test "detects Google Search App (Android)" do
+    browser = Browser.new(Browser["GOOGLE_SEARCH_APP_ANDROID"])
+
+    assert browser.webkit?
+    assert browser.google_search_app?
+    assert browser.platform.android?
+    assert_equal :google_search_app, browser.id
+    assert_equal "11", browser.version
+    assert_equal "11.6.8.21", browser.full_version
+    assert_equal "Google Search App", browser.name
+    refute browser.chrome?
+    refute browser.safari?
+  end
+
+  test "detects Google Search App (iPad)" do
+    browser = Browser.new(Browser["GOOGLE_SEARCH_APP_IPAD"])
+
+    assert browser.webkit?
+    assert browser.google_search_app?
+    assert browser.device.ipad?
+    assert browser.platform.ios?
+    assert_equal :google_search_app, browser.id
+    assert_equal "102", browser.version
+    assert_equal "102.0.304944559", browser.full_version
+    assert_equal "Google Search App", browser.name
+    refute browser.chrome?
+    refute browser.safari?
+  end
+
+  test "detects Google Search App (iPhone)" do
+    browser = Browser.new(Browser["GOOGLE_SEARCH_APP_IPHONE"])
+
+    assert browser.webkit?
+    assert browser.google_search_app?
+    assert browser.device.iphone?
+    assert browser.platform.ios?
+    assert_equal :google_search_app, browser.id
+    assert_equal "105", browser.version
+    assert_equal "105.0.307913796", browser.full_version
+    assert_equal "Google Search App", browser.name
+    refute browser.chrome?
+    refute browser.safari?
+  end
+
+  test "detects version by range (iPad)" do
+    browser = Browser.new(Browser["GOOGLE_SEARCH_APP_IPAD"])
+    assert browser.google_search_app?(%w[>=102 <103])
+  end
+end

data/test/unit/huawei_browser_test.rb

@@ -0,0 +1,25 @@
+# frozen_string_literal: true
+
+require "test_helper"
+
+class HuaweiBrowserTest < Minitest::Test
+  test "detects Huawei Browser" do
+    browser = Browser.new(Browser["HUAWEI_BROWSER"])
+    assert browser.huawei_browser?
+    refute browser.safari?
+    refute browser.chrome?
+    assert_equal "Huawei Browser", browser.name
+    assert_equal :huawei_browser, browser.id
+  end
+
+  test "detects correct version" do
+    browser = Browser.new(Browser["HUAWEI_BROWSER"])
+    assert_equal "10.1.2.300", browser.full_version
+    assert_equal "10", browser.version
+  end
+
+  test "detects version by range" do
+    browser = Browser.new(Browser["HUAWEI_BROWSER"])
+    assert browser.huawei_browser?(%w[>=10 <11])
+  end
+end

data/test/unit/maxthon_test.rb

@@ -0,0 +1,25 @@
+# frozen_string_literal: true
+
+require "test_helper"
+
+class MaxthonTest < Minitest::Test
+  test "detects Maxthon" do
+    browser = Browser.new(Browser["MAXTHON"])
+    assert browser.maxthon?
+    refute browser.safari?
+    refute browser.chrome?
+    assert_equal "Maxthon", browser.name
+    assert_equal :maxthon, browser.id
+  end
+
+  test "detects correct version" do
+    browser = Browser.new(Browser["MAXTHON"])
+    assert_equal "5.3.8.2000", browser.full_version
+    assert_equal "5", browser.version
+  end
+
+  test "detects version by range" do
+    browser = Browser.new(Browser["MAXTHON"])
+    assert browser.maxthon?(%w[>=5 <6])
+  end
+end

data/test/unit/meta_test.rb

@@ -45,4 +45,13 @@ class MetaTest < Minitest::Test
     assert meta.include?("blackberry")
     assert meta.include?("mobile")
   end
+
+  test "returns string representation for unknown platform/device/browser" do
+    browser = Browser.new("Unknown")
+    meta = browser.to_s
+
+    assert meta.include?("unknown_platform")
+    assert meta.include?("unknown_device")
+    assert meta.include?("unknown_browser")
+  end
 end

data/test/unit/miui_browser_test.rb

@@ -0,0 +1,25 @@
+# frozen_string_literal: true
+
+require "test_helper"
+
+class MiuiBrowserTest < Minitest::Test
+  test "detects Miui Browser" do
+    browser = Browser.new(Browser["MIUI_BROWSER"])
+    assert browser.miui_browser?
+    refute browser.safari?
+    refute browser.chrome?
+    assert_equal "Miui Browser", browser.name
+    assert_equal :miui_browser, browser.id
+  end
+
+  test "detects correct version" do
+    browser = Browser.new(Browser["MIUI_BROWSER"])
+    assert_equal "12.3.3", browser.full_version
+    assert_equal "12", browser.version
+  end
+
+  test "detects version by range" do
+    browser = Browser.new(Browser["MIUI_BROWSER"])
+    assert browser.miui_browser?(%w[>=12 <13])
+  end
+end

data/test/unit/opera_test.rb

@@ -20,6 +20,7 @@ class OperaTest < Minitest::Test
     assert browser.opera?
     assert browser.webkit?
     refute browser.chrome?
+    refute browser.safari?
     assert_equal "15.0.1147.44", browser.full_version
     assert_equal "15", browser.version
   end

data/test/unit/platform_test.rb

@@ -20,7 +20,7 @@ class PlatformTest < Minitest::Test
 
     Browser::Platform.matchers.shift
     platform = Browser::Platform.new("Custom")
-    assert_equal :other, platform.id
+    assert_equal :unknown_platform, platform.id
   end
 
   test "implements to_s" do
@@ -35,13 +35,13 @@ class PlatformTest < Minitest::Test
     refute platform == :android
   end
 
-  test "detect other" do
-    platform = Browser::Platform.new("Other")
+  test "detect unknown platforms" do
+    platform = Browser::Platform.new("Unknown")
 
-    assert_equal "Other", platform.name
-    assert_equal :other, platform.id
+    assert_equal "Unknown", platform.name
+    assert_equal :unknown_platform, platform.id
     assert_equal "0", platform.version
-    assert platform.other?
+    assert platform.unknown?
   end
 
   test "detect ios (iPhone)" do

data/test/unit/qq_test.rb

@@ -9,6 +9,9 @@ class QQTest < Minitest::Test
     assert_equal "6.3.3.432", browser.full_version
     assert_equal "QQ Browser", browser.name
     assert_equal :qq, browser.id
+
+    refute browser.chrome?
+    refute browser.safari?
   end
 
   test "detects QQ browser for Android" do
@@ -17,6 +20,9 @@ class QQTest < Minitest::Test
     assert_equal "6.2", browser.full_version
     assert_equal "QQ Browser", browser.name
     assert_equal :qq, browser.id
+
+    refute browser.chrome?
+    refute browser.safari?
   end
 
   test "detects QQ browser for Mac" do
@@ -25,6 +31,9 @@ class QQTest < Minitest::Test
     assert_equal "4.2.4753.400", browser.full_version
     assert_equal "QQ Browser", browser.name
     assert_equal :qq, browser.id
+
+    refute browser.chrome?
+    refute browser.safari?
   end
 
   test "detects QQ browser lite for Mac" do
@@ -33,5 +42,8 @@ class QQTest < Minitest::Test
     assert_equal "1.0.4", browser.full_version
     assert_equal "QQ Browser", browser.name
     assert_equal :qq, browser.id
+
+    refute browser.chrome?
+    refute browser.safari?
   end
 end

data/test/unit/safari_test.rb

@@ -7,7 +7,7 @@ class SafariTest < Minitest::Test
     browser = Browser.new(Browser["SAFARI3"])
 
     assert browser.safari?
-    assert browser.safari?(3)
+    assert browser.safari?("~>3.0")
     assert_equal "3", browser.version
     assert_equal "3.0.3", browser.full_version
   end
@@ -16,7 +16,7 @@ class SafariTest < Minitest::Test
     browser = Browser.new(Browser["SAFARI4"])
 
     assert browser.safari?
-    assert browser.safari?(4)
+    assert browser.safari?("~>4.0")
     assert_equal "4", browser.version
     assert_equal "4.0.3", browser.full_version
   end
@@ -25,7 +25,7 @@ class SafariTest < Minitest::Test
     browser = Browser.new(Browser["SAFARI5"])
 
     assert browser.safari?
-    assert browser.safari?(5)
+    assert browser.safari?("~>5.0")
     assert_equal "5", browser.version
     assert_equal "5.0.3", browser.full_version
   end
@@ -34,7 +34,7 @@ class SafariTest < Minitest::Test
     browser = Browser.new(Browser["SAFARI6"])
 
     assert browser.safari?
-    assert browser.safari?(6)
+    assert browser.safari?("~>6.0")
     assert_equal "6", browser.version
     assert_equal "6.0", browser.full_version
   end
@@ -43,7 +43,7 @@ class SafariTest < Minitest::Test
     browser = Browser.new(Browser["SAFARI7"])
 
     assert browser.safari?
-    assert browser.safari?(7)
+    assert browser.safari?("~>7.0")
     assert_equal "7", browser.version
     assert_equal "7.0", browser.full_version
   end
@@ -52,7 +52,7 @@ class SafariTest < Minitest::Test
     browser = Browser.new(Browser["SAFARI8"])
 
     assert browser.safari?
-    assert browser.safari?(8)
+    assert browser.safari?("~>8.0")
     assert_equal "8", browser.version
     assert_equal "8.0", browser.full_version
   end
@@ -61,7 +61,7 @@ class SafariTest < Minitest::Test
     browser = Browser.new(Browser["SAFARI9"])
 
     assert browser.safari?
-    assert browser.safari?(9)
+    assert browser.safari?("~>9.0")
     assert_equal "9", browser.version
     assert_equal "9.0.2", browser.full_version
   end
@@ -88,4 +88,9 @@ class SafariTest < Minitest::Test
     browser = Browser.new(Browser["SAFARI9"])
     assert browser.webkit?(%w[>=601 <602])
   end
+
+  test "detects safari version by range" do
+    browser = Browser.new(Browser["SAFARI9"])
+    assert browser.safari?(%w[>=9.0 <10])
+  end
 end

data/test/unit/sougou_browser_test.rb

@@ -0,0 +1,41 @@
+# frozen_string_literal: true
+
+require "test_helper"
+
+class SougouBrowserTest < Minitest::Test
+  test "detects Sougou Browser on desktop device" do
+    browser = Browser.new(Browser["SOUGOU_BROWSER"])
+    assert browser.sougou_browser?
+    refute browser.safari?
+    refute browser.chrome?
+    assert_equal "Sougou Browser", browser.name
+    assert_equal :sougou_browser, browser.id
+  end
+
+  test "detects correct version on desktop device" do
+    browser = Browser.new(Browser["SOUGOU_BROWSER"])
+    assert_equal "0.0", browser.full_version
+    assert_equal "0", browser.version
+  end
+
+  test "detects Sougou Browser on mobile device" do
+    browser = Browser.new(Browser["SOUGOU_BROWSER_MOBILE"])
+    assert browser.sougou_browser?
+    assert browser.device.mobile?
+    refute browser.safari?
+    refute browser.chrome?
+    assert_equal "Sougou Browser", browser.name
+    assert_equal :sougou_browser, browser.id
+  end
+
+  test "detects correct version on mobile device" do
+    browser = Browser.new(Browser["SOUGOU_BROWSER_MOBILE"])
+    assert_equal "5.28.12", browser.full_version
+    assert_equal "5", browser.version
+  end
+
+  test "detects version by range on mobile device" do
+    browser = Browser.new(Browser["SOUGOU_BROWSER_MOBILE"])
+    assert browser.sougou_browser?(%w[>=5 <6])
+  end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: browser
 version: !ruby/object:Gem::Version
-  version: 4.2.0
+  version: 5.0.0
 platform: ruby
 authors:
 - Nando Vieira
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2020-05-31 00:00:00.000000000 Z
+date: 2020-09-23 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -177,6 +177,7 @@ files:
 - ".rubocop.yml"
 - ".travis.yml"
 - CHANGELOG.md
+- FUNDING.yml
 - Gemfile
 - README.md
 - Rakefile
@@ -227,9 +228,11 @@ files:
 - lib/browser/electron.rb
 - lib/browser/facebook.rb
 - lib/browser/firefox.rb
-- lib/browser/generic.rb
+- lib/browser/google_search_app.rb
+- lib/browser/huawei_browser.rb
 - lib/browser/instagram.rb
 - lib/browser/internet_explorer.rb
+- lib/browser/maxthon.rb
 - lib/browser/meta.rb
 - lib/browser/meta/base.rb
 - lib/browser/meta/device.rb
@@ -248,6 +251,7 @@ files:
 - lib/browser/middleware/context.rb
 - lib/browser/middleware/context/additions.rb
 - lib/browser/middleware/context/url_methods.rb
+- lib/browser/miui_browser.rb
 - lib/browser/nokia.rb
 - lib/browser/opera.rb
 - lib/browser/otter.rb
@@ -262,7 +266,7 @@ files:
 - lib/browser/platform/ios.rb
 - lib/browser/platform/linux.rb
 - lib/browser/platform/mac.rb
-- lib/browser/platform/other.rb
+- lib/browser/platform/unknown.rb
 - lib/browser/platform/windows.rb
 - lib/browser/platform/windows_mobile.rb
 - lib/browser/platform/windows_phone.rb
@@ -271,9 +275,11 @@ files:
 - lib/browser/safari.rb
 - lib/browser/samsung_browser.rb
 - lib/browser/snapchat.rb
+- lib/browser/sougou_browser.rb
 - lib/browser/sputnik.rb
 - lib/browser/testing.rb
 - lib/browser/uc_browser.rb
+- lib/browser/unknown.rb
 - lib/browser/version.rb
 - lib/browser/weibo.rb
 - lib/browser/yandex.rb
@@ -303,13 +309,17 @@ files:
 - test/unit/facebook_test.rb
 - test/unit/firefox_test.rb
 - test/unit/generic_test.rb
+- test/unit/google_search_app_test.rb
+- test/unit/huawei_browser_test.rb
 - test/unit/instagram_test.rb
 - test/unit/internet_explorer_test.rb
 - test/unit/ios_app_test.rb
 - test/unit/ios_test.rb
 - test/unit/kindle_test.rb
+- test/unit/maxthon_test.rb
 - test/unit/meta_test.rb
 - test/unit/micro_messenger_test.rb
+- test/unit/miui_browser_test.rb
 - test/unit/nokia_test.rb
 - test/unit/opera_test.rb
 - test/unit/otter_test.rb
@@ -319,6 +329,7 @@ files:
 - test/unit/safari_test.rb
 - test/unit/samsung_browser_test.rb
 - test/unit/snapchat_test.rb
+- test/unit/sougou_browser_test.rb
 - test/unit/sputnik_test.rb
 - test/unit/uc_browser_test.rb
 - test/unit/weibo_test.rb
@@ -330,7 +341,7 @@ licenses:
 - MIT
 metadata:
   changelog_uri: https://github.com/fnando/browser/blob/master/CHANGELOG.md
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -346,7 +357,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubygems_version: 3.1.2
-signing_key: 
+signing_key:
 specification_version: 4
 summary: Do some browser detection with Ruby.
 test_files:
@@ -375,13 +386,17 @@ test_files:
 - test/unit/facebook_test.rb
 - test/unit/firefox_test.rb
 - test/unit/generic_test.rb
+- test/unit/google_search_app_test.rb
+- test/unit/huawei_browser_test.rb
 - test/unit/instagram_test.rb
 - test/unit/internet_explorer_test.rb
 - test/unit/ios_app_test.rb
 - test/unit/ios_test.rb
 - test/unit/kindle_test.rb
+- test/unit/maxthon_test.rb
 - test/unit/meta_test.rb
 - test/unit/micro_messenger_test.rb
+- test/unit/miui_browser_test.rb
 - test/unit/nokia_test.rb
 - test/unit/opera_test.rb
 - test/unit/otter_test.rb
@@ -391,6 +406,7 @@ test_files:
 - test/unit/safari_test.rb
 - test/unit/samsung_browser_test.rb
 - test/unit/snapchat_test.rb
+- test/unit/sougou_browser_test.rb
 - test/unit/sputnik_test.rb
 - test/unit/uc_browser_test.rb
 - test/unit/weibo_test.rb