browsed 0.2.2 → 0.2.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 22709958a9bfb3df2bcd7c1705fab8b8142f684cd9520c87584ac152dec8685a
-  data.tar.gz: ceafaf076006cd6b2a19677416f61337bcd016c6093fcc956ad4fb94d6a374e6
+  metadata.gz: 61e83765b6257c39cd97be1c3764a20bb20e90b6ce602c94d693b0fb4444bf64
+  data.tar.gz: 8f747af9a52257cd1a05aecfddbd81fc714e76253472eba5ef7724a6dce1e10f
 SHA512:
-  metadata.gz: 4e138bccb76f8fa621d9b911a695b869204669de742f681c8617ca19a9b68fd50e9e7401ba537498aae19c966981b4a5eae85da8226e7e3ab474cedff8c70557
-  data.tar.gz: 365750f46aa4e252ba81962e82bc667277926fbcd81f864d8e1bdf594b00dcf55e116c10a6b7bef2695520f34410dbb4fe5e64a6f09f6d901cc8ad560366fbfd
+  metadata.gz: 666a4dd2ace58b39da9b7132493c0f64dc605fb50de3db3363b21f18caaa643be3cc33321c6ce5e94c372735e998e8ba611262a683591351f3512617f125ddee
+  data.tar.gz: 4b191391235827932b9b8e16942802757424bfb77f25b0a9076243ba8fa520f9da87a3faf293c29e321be0c8e64503d375fd5901344c480e5e744b8739837399

data/lib/browsed/chrome.rb

@@ -4,17 +4,17 @@ module Browsed
     private
       def register_chrome_driver(options: {}, timeout: 60, debug: false)
         headless                =   options.fetch(:headless, false)
-        width                   =   option.fetch(:width, 1920)
-        height                  =   options.fetch(:height, 1080)
+        resolution              =   options.fetch(:resolution, [1366,768])
         profile                 =   Selenium::WebDriver::Chrome::Profile.new
         
         profile["user-agent"]   =   self.user_agent unless self.user_agent.to_s.empty?
         
         proxy_options           =   chrome_proxy_options
         capabilities            =   !proxy_options.nil? ? Selenium::WebDriver::Remote::Capabilities.chrome(proxy: proxy_options) : {}
-        args                    =   %W(disable-popup-blocking window-size=#{height},#{width})
-        args                    =   args | %w(headless disable-gpu)
-        raise args.inspect
+        args                    =   %w(disable-popup-blocking)
+        args                    =   args | %W(window-size=#{resolution.first},#{resolution.last}) if resolution && resolution.any? && resolution.size.eql?(2)
+        args                    =   args | %w(headless disable-gpu) if headless
+        
         options                 =   Selenium::WebDriver::Chrome::Options.new(profile: profile, args: args)
         
         Capybara.register_driver self.driver do |app|

data/lib/browsed/client.rb

@@ -72,11 +72,16 @@ module Browsed
     def resize!(res = nil)
       res ||= self.resolution
       
-      if res && res.size.eql?(2) && !self.driver.eql?(:chrome) && !self.driver.eql?(:poltergeist) # Resolutions for Chrome & Poltergeist are set in the driver
+      if res && res.size.eql?(2) && resizable_browser?(self.driver) # Resolutions for Chrome & Poltergeist are set in the driver
         self.session.current_window.resize_to(res.first, res.last) # [width, height]
       end
     end
     
+    def resizable_browser?(driver)
+      non_resizable = [:poltergeist, :selenium_chrome, :selenium_chrome_headless]
+      !non_resizable.include?(driver.to_sym)
+    end
+    
     def reset_session!
       self.session.reset_session!
     end
@@ -104,18 +109,16 @@ module Browsed
       def register_driver!(options = {})
         if poltergeist?
           register_poltergeist_driver(options: options)
-        elsif selenium?
-          if firefox_browser?
-            register_firefox_driver(options: options)
-          elsif firefox_headless_browser?
-            register_firefox_driver(options: options.merge(headless: true))
-          elsif chrome_browser?
-            self.driver                 =   :selenium_chrome
-            register_chrome_driver(options: options)
-          elsif chrome_headless_browser?
-            self.driver                 =   :selenium_chrome_headless
-            register_chrome_driver(options: options.merge(headless: true))
-          end
+        elsif firefox_browser?
+          register_firefox_driver(options: options)
+        elsif firefox_headless_browser?
+          register_firefox_driver(options: options.merge(headless: true))
+        elsif chrome_browser?
+          self.driver                 =   :selenium_chrome
+          register_chrome_driver(options: options.merge(resolution: self.resolution))
+        elsif chrome_headless_browser?
+          self.driver                 =   :selenium_chrome_headless
+          register_chrome_driver(options: options.merge(resolution: self.resolution, headless: true))
         end
       end
     

data/lib/browsed/version.rb

@@ -1,3 +1,3 @@
 module Browsed
-  VERSION = "0.2.2"
+  VERSION = "0.2.3"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: browsed
 version: !ruby/object:Gem::Version
-  version: 0.2.2
+  version: 0.2.3
 platform: ruby
 authors:
 - Sebastian