browse-everything 1.3.0 → 1.5.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: b7cb857160ebc811eafac9247c7cec49eeac9b46edc453a2bb50eba106e58caf
-  data.tar.gz: 85551cebc8b3f2ae374b224e3fba8fd4f72126d58d12bab307977407119c5f75
+  metadata.gz: 75a514ad33ec151f78c54fd74220a6d385bde4107894e2b6beb69e30eab6c27e
+  data.tar.gz: e688ee1ba6a0a9b8f519ca33077acda6bbc062033fc122c33876da850ff36146
 SHA512:
-  metadata.gz: b75481a9a77c377a58a97b40eca87fe8f5fc1465db82bc1043ce0380674666a4ff80e0459554ba3f042c9bf210add815d176bbbce41255d9fafb9642f123ce34
-  data.tar.gz: a1118f1b26cf47d276fb47194dedc13f3006ffa632613f7df1022445b37e12f2451c307e38bd07c3c22d4151cd7f71e580448caf7461a4ff02f499486e605a0b
+  metadata.gz: 8b3b2068517c326ca832b8adf020dff2e297576bb19189f0707e5f812cc01b09ceef932cc8903fd1f60d6d0031d02d66685d5ba72829c89c22ee84474c2527d4
+  data.tar.gz: cf3298fd572ca0666e9a808ffb1d359cc48050ad6a512d8777d2c9fb0635b8546c0fa7c9312198ea2113440cfc24d4a6ef28302c98d343c2dde7b5edefcae260

data/.circleci/config.yml

@@ -13,7 +13,7 @@ jobs:
         type: string
       bundler_version:
         type: string
-        default: 2.4.3
+        default: 2.5.21
     executor:
       name: 'samvera/ruby'
       ruby_version: << parameters.ruby_version >>
@@ -45,46 +45,30 @@ jobs:
 workflows:
   ci:
     jobs:
+      - build:
+          name: "ruby3-3_rails8-0"
+          ruby_version: 3.3.6
+          rails_version: 8.0.0.1
+      - build:
+          name: "ruby3-3_rails7-2"
+          ruby_version: 3.3.6
+          rails_version: 7.2.1
       - build:
           name: "ruby3-2_rails7-1"
-          ruby_version: 3.2.1
-          rails_version: 7.1.1
+          ruby_version: 3.2.5
+          rails_version: 7.1.4
       - build:
           name: "ruby3-2_rails7-0"
-          ruby_version: 3.2.0
-          rails_version: 7.0.4
+          ruby_version: 3.2.5
+          rails_version: 7.0.8.4
       - build:
           name: "ruby3-1_rails7-0"
-          ruby_version: 3.1.2
-          rails_version: 7.0.4
-
+          ruby_version: 3.1.6
+          rails_version: 7.0.8.4
       - build:
           name: "ruby3-1_rails6-1"
-          ruby_version: 3.1.2
-          rails_version: 6.1.6
-      - build:
-          name: "ruby3-0_rails6-1"
-          ruby_version: 3.0.3
-          rails_version: 6.1.6
-
-      - build:
-          name: "ruby3-0_rails6-0"
-          ruby_version: 3.0.3
-          rails_version: 6.0.4.7
-      - build:
-          name: "ruby2-7_rails6-0"
-          ruby_version: 2.7.7
-          rails_version: 6.0.4.7
-
-      - build:
-          name: "ruby2-7_rails5-2"
-          ruby_version: 2.7.7
-          rails_version: 5.2.7
-
-      - build:
-          name: "ruby2-7_rails5-1"
-          ruby_version: 2.7.7
-          rails_version: 5.1.7
+          ruby_version: 3.1.6
+          rails_version: 6.1.7.8
 
   nightly:
     triggers:
@@ -96,39 +80,27 @@ workflows:
                 - main
     jobs:
       - build:
-          name: "ruby3-2_rails7-0"
-          ruby_version: 3.2.0
-          rails_version: 7.0.4
-      - build:
-          name: "ruby3-1_rails7-0"
-          ruby_version: 3.1.2
-          rails_version: 7.0.4
-
-      - build:
-          name: "ruby3-1_rails6-1"
-          ruby_version: 3.1.2
-          rails_version: 6.1.6
+          name: "ruby3-3_rails8-0"
+          ruby_version: 3.3.6
+          rails_version: 8.0.0.1
       - build:
-          name: "ruby3-0_rails6-1"
-          ruby_version: 3.0.3
-          rails_version: 6.1.6
-
+          name: "ruby3-3_rails7-2"
+          ruby_version: 3.3.5
+          rails_version: 7.2.1
       - build:
-          name: "ruby3-0_rails6-0"
-          ruby_version: 3.0.3
-          rails_version: 6.0.4.7
+          name: "ruby3-2_rails7-1"
+          ruby_version: 3.2.5
+          rails_version: 7.1.4
       - build:
-          name: "ruby2-7_rails6-0"
-          ruby_version: 2.7.7
-          rails_version: 6.0.4.7
-
+          name: "ruby3-2_rails7-0"
+          ruby_version: 3.2.5
+          rails_version: 7.0.8.4
       - build:
-          name: "ruby2-7_rails5-2"
-          ruby_version: 2.7.7
-          rails_version: 5.2.7
-
+          name: "ruby3-1_rails7-0"
+          ruby_version: 3.1.6
+          rails_version: 7.0.8.4
       - build:
-          name: "ruby2-7_rails5-1"
-          ruby_version: 2.7.7
-          rails_version: 5.1.7
+          name: "ruby3-1_rails6-1"
+          ruby_version: 3.1.6
+          rails_version: 6.1.7.8
 

data/.tool-versions

@@ -1,2 +1,2 @@
-ruby 2.7.5
-nodejs lts-fermium
+ruby   3.1.6
+nodejs lts-gallium

data/Gemfile

@@ -23,7 +23,7 @@ end
 
 # Set a default RAILS_VERSION so we make sure to get extra dependencies for it...
 
-ENV['RAILS_VERSION'] ||= "7.1.1"
+ENV['RAILS_VERSION'] ||= "8.0.0"
 
 if ENV['RAILS_VERSION']
   if ENV['RAILS_VERSION'] == 'edge'
@@ -33,20 +33,35 @@ if ENV['RAILS_VERSION']
   end
 
   case ENV['RAILS_VERSION']
+  when /^8./
+    # sprockets is not usually included in Rails 8, but we currently require it, and test with it.
+    gem "sprockets-rails"
   when /^7\.1\./
     # sprockets is optional for rails 7, but we currently require it, and test with it.
     gem "sprockets-rails"
   when /^7\.0\./
+    # rails previous to 7.1 can't use sqlite 2
+    gem "sqlite3", "~> 1.4"
+
     # sprockets is optional for rails 7, but we currently require it, and test with it.
     gem "sprockets-rails"
   when /^6\.1\./
+    # rails previous to 7.1 can't use sqlite 2
+    gem "sqlite3", "~> 1.4"
+
     # opt into mail 2.8.0.rc1 so we get extra dependencies required for rails 6.1
     # Once mail 2.8.0 final is released this will not be required.
     # https://github.com/mikel/mail/pull/1472
     gem "mail", ">= 2.8.0.rc1"
   when /^6\.0\./
+    # rails previous to 7.1 can't use sqlite 2
+    gem "sqlite3", "~> 1.4"
+
     gem 'sass-rails', '>= 6'
   when /^5\.[12]\./
+    # rails previous to 7.1 can't use sqlite 2
+    gem "sqlite3", "~> 1.4"
+
     gem 'sass-rails', '~> 5.0'
     gem 'sprockets', '~> 3.7'
     gem 'thor', '~> 0.20'

data/README.md

@@ -26,33 +26,48 @@ download the files.
 
 ## Technical Debt/Legacy warning
 
-This is code with a long history that has a number of known problems;
-we are trying to keep it alive for existing projects using it. But caution is
-advised in introducing it, in it's present form, to new projects.
+This project has been receiving very limited maintenance for at least 2-4 years
+now  -- just enough to keep it working for present users. Caution is indicated in
+considering adoption for new projects.
 
-A significant overhaul of this gem may be desirable (with backwards-breaking
-changes), to better accomplish gem goals. But there has not been the
-interest/resources in the community to accomplish that at present.
+### Known issues (Nov 2024)
 
-Some known current issues (Jun 2022):
+* The S3 local file system adapters are known working. It's not clear if any other
+adapters are working properly -- or if the browse_everything architecture as is
+is sufficient to support OAuth2 integration flows that may be required to get them
+working.
 
-* The S3 adapter is known working; but it's not clear if other adapters using
-OAuth2 (main use case for this gem) are in fact working reliably. And there
-is some concern that the current browse-everything integration API may not be
-compatible with proper OAuth/OAuth2 flows to support OAuth integrations --
-originally the main use case of this gem.
+* CSS and Javascript were both written for use with sprockets asset pipeline, and are
+currently only tested with sprockets -- even in Rails 8, where `rails new` cannot
+generate a sprockets using app.
+  * For use with Rails 8, you could consider adding sprockets to your app manually,
+    or copying browse_everything JS and CSS assets into your local app and including
+    them that way. The browse_everything installer is not capable of doing this
+    in an automated fashion.
 
-* The CSS and Javascript were both written for use with the sprockets Rails
-asset pipeline.  Recent versions of Rails may require custom configuration
-to use sprockets (especially for JS), which is not currently covered in
-instructions here. Using other means of including CSS and JS may require
-confusing customization also not fully covered here.
+* Good news: The `bootstrap4` CSS is tentatively demonstrated working with bootstrap 5
+too.
 
-* Javascript depends on JQuery, bootstrap (3 or 4; 5 untested), as well as a
-vendored copy of a jquery.treetable plugin.
+* JS depends on JQuery, which is unfortunate in 2024. As well as a vendored copy of
+  a jquery.treetable plugin.
 
-* CSS is provided for compatibilty with bootstrap 3 or bootstrap 4, but not
-bootstrap 5 (or no bootstrap at all)
+### Possible path to a revived gem
+
+If there are interest and resources, assuming a major version release.
+
+* Rewrite JS from the ground up to be vanilla JS without JQuery.
+  * And useable by either `importmap-rails` or an npm-based rails JS bundler.
+
+* Figure out what adapters actually work, drop those that don't work from the gem.
+  * Possibly find adapters in PR's or forks that work and can be added.
+
+* Testing overhaul
+  * Adapters have their network communication with cloud mocked for good reason,
+    but that makes them false negative and unreliable at detecting breakage.
+  * Testing is done with an in-repo Rails app instead of engine_cart, which
+    is probably reasonable, but that makes it harder to really test integration
+    with differnet rails versions or test the installer works, as Rails has had
+    churn in JS.  go back to engine_cart, or consider [combustion](https://github.com/pat/combustion)
 
 ## Product Owner & Maintenance
 

data/browse-everything.gemspec

@@ -23,7 +23,7 @@ Gem::Specification.new do |spec|
   spec.add_dependency 'dropbox_api', '>= 0.1.20'
   spec.add_dependency 'google-apis-drive_v3'
   spec.add_dependency 'googleauth', '>= 0.6.6', '< 2.0'
-  spec.add_dependency 'rails', '>= 4.2', '< 7.2'
+  spec.add_dependency 'rails', '>= 4.2', '< 8.1'
   spec.add_dependency 'ruby-box'
   spec.add_dependency 'signet', '~> 0.8'
   spec.add_dependency 'typhoeus'
@@ -48,6 +48,7 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency 'rubocop-rspec'
   spec.add_development_dependency 'sass-rails'
   spec.add_development_dependency 'selenium-webdriver'
+  # Rails <= 7.1 can't use sqlite3 gem 2.x yet
   spec.add_development_dependency 'sqlite3'
   spec.add_development_dependency 'turbolinks'
   spec.add_development_dependency 'webdrivers'

data/lib/browse_everything/auth/google/request_parameters.rb

@@ -1,10 +1,12 @@
 # frozen_string_literal: true
 
+require 'ostruct'
+
 # Manages request parameters for the request to the Google Drive API
 module BrowseEverything
   module Auth
     module Google
-      class RequestParameters < OpenStruct
+      class RequestParameters < ::OpenStruct
         # Overrides the constructor for an OpenStruct instance
         # Provides default parameters
         def initialize(params = {})

data/lib/browse_everything/driver/base.rb

@@ -69,7 +69,7 @@ module BrowseEverything
       # Generate the name for the driver
       # @return [String]
       def name
-        @name ||= (@config[:name] || self.class.name.split(/::/).last.titleize)
+        @name ||= @config[:name] || self.class.name.split(/::/).last.titleize
       end
 
       # Abstract method

data/lib/browse_everything/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module BrowseEverything
-  VERSION = '1.3.0'
+  VERSION = '1.5.0'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: browse-everything
 version: !ruby/object:Gem::Version
-  version: 1.3.0
+  version: 1.5.0
 platform: ruby
 authors:
 - Carolyn Cole
@@ -13,7 +13,7 @@ authors:
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2023-11-09 00:00:00.000000000 Z
+date: 2024-12-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: addressable
@@ -100,7 +100,7 @@ dependencies:
         version: '4.2'
     - - "<"
       - !ruby/object:Gem::Version
-        version: '7.2'
+        version: '8.1'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
@@ -110,7 +110,7 @@ dependencies:
         version: '4.2'
     - - "<"
       - !ruby/object:Gem::Version
-        version: '7.2'
+        version: '8.1'
 - !ruby/object:Gem::Dependency
   name: ruby-box
   requirement: !ruby/object:Gem::Requirement
@@ -631,7 +631,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.4.21
+rubygems_version: 3.5.9
 signing_key:
 specification_version: 4
 summary: AJAX/Rails engine file browser for cloud storage services