browse-everything 1.0.0.rc1 → 1.0.0.rc2

data/spec/javascripts/karma_spec.rb

@@ -0,0 +1,16 @@
+# frozen_string_literal: true
+
+require 'open3'
+
+# Run karma and parse the output for failures.
+# The spec will fail if any karma test fails.
+describe 'Karma' do
+  let(:runner)  { Open3.capture3('karma', 'start') }
+  let(:output)  { runner[0] + runner[1] }
+  let(:status)  { runner[2].exitstatus }
+
+  it 'expects all karma tests to pass' do
+    $stderr.puts output unless status == 0
+    expect(status).to eq(0)
+  end
+end

data/spec/lib/browse_everything_spec.rb

@@ -72,6 +72,13 @@ describe BrowseEverything do
 
       it_behaves_like 'a configured BrowseEverything module'
     end
+
+    context 'without a YAML file' do
+      let(:config) { '' }
+      it 'raises a configuration error' do
+        expect { described_class.configure(:config).to raise_error(BrowseEverything::ConfigurationError, 'Missing browse_everything_providers.yml configuration file') }
+      end
+    end
   end
 
   context 'with an unsupported or invalid configuration' do

data/spec/test_app_templates/Gemfile.extra

@@ -1,2 +1,9 @@
 gem 'jquery-rails'
 gem 'puma-rails'
+
+if ENV['TEST_BOOTSTRAP'] == "3"
+  gem "bootstrap-sass"
+else
+  # bootstrap 4
+  gem "bootstrap"
+end

data/spec/test_app_templates/lib/generators/test_app_generator.rb

@@ -17,7 +17,13 @@ class TestAppGenerator < Rails::Generators::Base
     copy_file File.expand_path('app/assets/stylesheets/application.css', ENV['RAILS_ROOT']), 'app/assets/stylesheets/application.css.scss'
     remove_file 'app/assets/stylesheets/application.css'
     insert_into_file 'app/assets/stylesheets/application.css.scss', after: '*/' do
-      %(\n\n@import "browse_everything")
+      if ENV['TEST_BOOTSTRAP'] == "3"
+        # bootstrap 3 from bootstrap-sass gem
+        %(\n\n@import "bootstrap-sprockets";\n@import "bootstrap";\n@import "browse_everything_bootstrap3";)
+      else
+        # bootstrap4 from bootstrap gem
+        %(\n\n@import "bootstrap";\n@import "browse_everything_bootstrap4";)
+      end
     end
   end
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: browse-everything
 version: !ruby/object:Gem::Version
-  version: 1.0.0.rc1
+  version: 1.0.0.rc2
 platform: ruby
 authors:
 - Carolyn Cole
@@ -13,7 +13,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-11-06 00:00:00.000000000 Z
+date: 2018-11-28 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: addressable
@@ -43,20 +43,6 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
-- !ruby/object:Gem::Dependency
-  name: bootstrap-sass
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '3.2'
-  type: :runtime
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '3.2'
 - !ruby/object:Gem::Dependency
   name: dropbox_api
   requirement: !ruby/object:Gem::Requirement
@@ -71,20 +57,6 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: 0.1.10
-- !ruby/object:Gem::Dependency
-  name: font-awesome-rails
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :runtime
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
 - !ruby/object:Gem::Dependency
   name: google-api-client
   requirement: !ruby/object:Gem::Requirement
@@ -155,20 +127,6 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
-- !ruby/object:Gem::Dependency
-  name: sass-rails
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :runtime
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
 - !ruby/object:Gem::Dependency
   name: signet
   requirement: !ruby/object:Gem::Requirement
@@ -504,13 +462,13 @@ files:
 - Rakefile
 - SUPPORT.md
 - app/assets/javascripts/browse_everything.js
-- app/assets/javascripts/browse_everything/behavior.js.coffee
-- app/assets/stylesheets/browse_everything.scss
+- app/assets/javascripts/browse_everything/behavior.js
+- app/assets/stylesheets/_browse_everything_bootstrap3.scss
+- app/assets/stylesheets/_browse_everything_bootstrap4.scss
 - app/assets/stylesheets/browse_everything/_browse_everything.scss
 - app/assets/stylesheets/jquery.treetable.theme.browse.css
 - app/controllers/browse_everything_controller.rb
 - app/helpers/browse_everything_helper.rb
-- app/helpers/font_awesome_version_helper.rb
 - app/services/browse_everything_session.rb
 - app/services/browse_everything_session/provider_session.rb
 - app/services/browser_factory.rb
@@ -524,6 +482,7 @@ files:
 - browse-everything.gemspec
 - config/locales/en_browse_everything.yml
 - config/routes.rb
+- karma.conf.js
 - lib/browse-everything.rb
 - lib/browse_everything.rb
 - lib/browse_everything/auth/google/credentials.rb
@@ -540,10 +499,8 @@ files:
 - lib/browse_everything/file_entry.rb
 - lib/browse_everything/retriever.rb
 - lib/browse_everything/version.rb
-- lib/generators/browse_everything/assets_generator.rb
 - lib/generators/browse_everything/config_generator.rb
 - lib/generators/browse_everything/install_generator.rb
-- lib/generators/browse_everything/templates/browse_everything.scss
 - lib/generators/browse_everything/templates/browse_everything_providers.yml.example
 - spec/controllers/browse_everything_controller_spec.rb
 - spec/features/select_files_spec.rb
@@ -557,9 +514,8 @@ files:
 - spec/helper/browse_everything_controller_helper_spec.rb
 - spec/javascripts/behavior_spec.js
 - spec/javascripts/helpers/jasmine-jquery.js
-- spec/javascripts/jasmine_spec.rb
-- spec/javascripts/support/jasmine.yml
-- spec/javascripts/support/jasmine_helper.rb
+- spec/javascripts/helpers/jquery.js
+- spec/javascripts/karma_spec.rb
 - spec/lib/browse_everything/auth/google/credentials_spec.rb
 - spec/lib/browse_everything/browse_everything_helper_spec.rb
 - spec/lib/browse_everything/browser_spec.rb
@@ -609,7 +565,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: 1.3.1
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.14.1
+rubygems_version: 2.7.3
 signing_key: 
 specification_version: 4
 summary: AJAX/Rails engine file browser for cloud storage services
@@ -626,9 +582,8 @@ test_files:
 - spec/helper/browse_everything_controller_helper_spec.rb
 - spec/javascripts/behavior_spec.js
 - spec/javascripts/helpers/jasmine-jquery.js
-- spec/javascripts/jasmine_spec.rb
-- spec/javascripts/support/jasmine.yml
-- spec/javascripts/support/jasmine_helper.rb
+- spec/javascripts/helpers/jquery.js
+- spec/javascripts/karma_spec.rb
 - spec/lib/browse_everything/auth/google/credentials_spec.rb
 - spec/lib/browse_everything/browse_everything_helper_spec.rb
 - spec/lib/browse_everything/browser_spec.rb

data/app/assets/javascripts/browse_everything/behavior.js.coffee

@@ -1,342 +0,0 @@
-$ ->
-  dialog = $('div#browse-everything')
-
-  initialize = (obj,options) ->
-    if $('div#browse-everything').length == 0
-      dialog = $('<div tabindex="-1" id="browse-everything" class="ev-browser modal fade" aria-live="polite" role="dialog" aria-labelledby="beModalLabel"></div>').hide().appendTo('body')
-
-    dialog.modal
-      backdrop: 'static'
-      show:     false
-    ctx =
-      opts: $.extend(true, {}, options)
-      callbacks:
-        show: $.Callbacks()
-        done: $.Callbacks()
-        cancel: $.Callbacks()
-        fail: $.Callbacks()
-    ctx.callback_proxy =
-      show:   (func) -> ctx.callbacks.show.add(func)   ; return this
-      done:   (func) -> ctx.callbacks.done.add(func)   ; return this
-      cancel: (func) -> ctx.callbacks.cancel.add(func) ; return this
-      fail:   (func) -> ctx.callbacks.fail.add(func)   ; return this
-    $(obj).data('ev-state',ctx)
-    ctx
-
-  toHiddenFields = (data) ->
-    fields = $.param(data)
-      .split('&')
-      .map (t) -> t.replace(/\+/g,' ').split('=',2)
-    elements = $(fields).map () ->
-      $("<input type='hidden'/>")
-        .attr('name',decodeURIComponent(this[0]))
-        .val(decodeURIComponent(this[1]))[0].outerHTML
-    $(elements.toArray().join("\n"))
-
-  indicateSelected = () ->
-    $('input.ev-url').each () ->
-      $("*[data-ev-location='#{$(this).val()}']").addClass('ev-selected')
-
-  fileIsSelected = (row) ->
-    result = false
-    $('input.ev-url').each () ->
-      if this.value == $(row).data('ev-location')
-        result = true
-    return result
-
-  toggleFileSelect = (row) ->
-    row.toggleClass('ev-selected')
-    if row.hasClass('ev-selected')
-      selectFile(row)
-    else
-      unselectFile(row)
-    updateFileCount()
-
-  selectFile = (row) ->
-    target_form = $('form.ev-submit-form')
-    file_location = row.data('ev-location')
-    hidden_input = $("<input type='hidden' class='ev-url' name='selected_files[]'/>").val(file_location)
-    target_form.append(hidden_input)
-    unless $(row).find('.ev-select-file').prop('checked')
-      $(row).find('.ev-select-file').prop('checked', true)
-
-  unselectFile = (row) ->
-    target_form = $('form.ev-submit-form')
-    file_location = row.data('ev-location')
-    $("form.ev-submit-form input[value='#{file_location}']").remove()
-    if $(row).find('.ev-select-file').prop('checked')
-        $(row).find('.ev-select-file').prop('checked', false)
-
-  updateFileCount = () ->
-    count = $('input.ev-url').length
-    files = if count == 1 then "file" else "files"
-    $('.ev-status').html("#{count} #{files} selected")
-
-  toggleBranchSelect = (row) ->
-    if row.hasClass('collapsed')
-      node_id = row.find('td.ev-file-name a.ev-link').attr('href')
-      $('table#file-list').treetable('expandNode',node_id)
-
-  selectAll = (rows) ->
-    rows.each () ->
-      if $(this).data('tt-branch')
-        box = $(this).find('#select_all')[0]
-        $(box).prop('checked', true)
-        $(box).prop('value', "1")
-        toggleBranchSelect($(this))
-      else
-        toggleFileSelect($(this)) unless fileIsSelected($(this))
-
-  selectChildRows = (row, action) ->
-    $('table#file-list tr').each () ->
-      if $(this).data('tt-parent-id')
-        re = RegExp($(row).data('tt-id'), 'i')
-        if $(this).data('tt-parent-id').match(re)
-          if $(this).data('tt-branch')
-            box = $(this).find('#select_all')[0]
-            $(box).prop('value', action)
-            if action == "1"
-              $(box).prop("checked", true)
-              node_id = $(this).find('td.ev-file-name a.ev-link').attr('href')
-              $('table#file-list').treetable('expandNode',node_id)
-            else
-              $(box).prop("checked", false)
-          else
-            if action == "1"
-              $(this).addClass('ev-selected')
-              selectFile($(this)) unless fileIsSelected($(this))
-            else
-              $(this).removeClass('ev-selected')
-              unselectFile($(this))
-            updateFileCount()
-
-  tableSetup = (table) ->
-    table.treetable
-      expandable: true
-      onNodeCollapse: ->
-        node = this;
-        table.treetable("unloadBranch", node)
-      onNodeExpand: ->
-        node = this
-        startWait()
-        size = $(node.row).find('td.ev-file-size').text().trim()
-        start = 1
-        increment = 1
-        if (size.indexOf("MB") >-1)
-          start = 10
-          increment = 5
-        if (size.indexOf("KB") >-1)
-          start = 50
-          increment = 10
-        setProgress(start)
-        progressIntervalID = setInterval (->
-          start = start + increment
-          if start > 99
-            start = 99
-          setProgress(start)
-        ), 2000
-        setTimeout (->
-          loadFiles(node, table, progressIntervalID)
-        ), 10
-    $("#file-list tr:first").focus()
-    sizeColumns(table)
-
-  sizeColumns = (table) ->
-    full_width = $('.ev-files').width()
-    table.width(full_width)
-    set_size = (selector, pct) ->
-      $(selector, table).width(full_width * pct).css('width',full_width * pct).css('max-width',full_width * pct)
-    set_size '.ev-file', 0.4
-    set_size '.ev-container', 0.4
-    set_size '.ev-size', 0.1
-    set_size '.ev-kind', 0.3
-    set_size '.ev-date', 0.2
-
-  loadFiles = (node, table, progressIntervalID)->
-    $.ajax
-      async: true # Must be false, otherwise loadBranch happens after showChildren?
-      url: $('a.ev-link',node.row).attr('href')
-      data:
-        parent: node.row.data('tt-id')
-        accept: dialog.data('ev-state').opts.accept
-        context: dialog.data('ev-state').opts.context
-    .done (html) ->
-      setProgress('100')
-      clearInterval progressIntervalID
-      rows = $('tbody tr',$(html))
-      table.treetable("loadBranch", node, rows)
-      $(node).show()
-      sizeColumns(table)
-      indicateSelected()
-      if $(node.row).find('#select_all')[0].checked
-        selectAll(rows)
-    .always ->
-        clearInterval progressIntervalID
-        stopWait()
-
-  setProgress = (done)->
-    $('.loading-text').text(done+'% complete')
-
-  refreshFiles = ->
-    $('.ev-providers select').change()
-
-  startWait = ->
-    $('.loading-progress').removeClass("hidden")
-    $('body').css('cursor','wait')
-    $("html").addClass("wait")
-    $(".ev-browser").addClass("loading")
-    $('.ev-submit').attr('disabled', true)
-
-  stopWait = ->
-    $('.loading-progress').addClass("hidden")
-    $('body').css('cursor','default')
-    $("html").removeClass("wait")
-    $(".ev-browser").removeClass("loading")
-    $('.ev-submit').attr('disabled', false)
-
-  $(window).on('resize', -> sizeColumns($('table#file-list')))
-
-  $.fn.browseEverything = (options) ->
-    ctx = $(this).data('ev-state')
-    options = $(this).data() unless (ctx? or options?)
-    if options?
-      ctx = initialize(this[0], options)
-      $(this).click () ->
-        dialog.data('ev-state',ctx)
-        dialog.load ctx.opts.route, () ->
-          setTimeout refreshFiles, 500
-          ctx.callbacks.show.fire()
-          dialog.modal('show')
-
-    if ctx
-      ctx.callback_proxy
-    else
-      {
-        show: -> this
-        done: -> this
-        cancel: -> this
-        fail: -> this
-      }
-
-  $.fn.browseEverything.toggleCheckbox = (box) ->
-    if box.value == "0"
-      $(box).prop('value', "1")
-    else
-      $(box).prop('value', "0")
-
-  $(document).on 'ev.refresh', (event) -> refreshFiles()
-
-  $(document).on 'click', 'button.ev-cancel', (event) ->
-    event.preventDefault()
-    dialog.data('ev-state').callbacks.cancel.fire()
-    $('.ev-browser').modal('hide')
-
-  $(document).on 'click', 'button.ev-submit', (event) ->
-    event.preventDefault()
-    $(this).button('loading')
-    startWait()
-    main_form = $(this).closest('form')
-    resolver_url = main_form.data('resolver')
-    ctx = dialog.data('ev-state')
-    $(main_form).find('input[name=context]').val(ctx.opts.context)
-    $.ajax resolver_url,
-      type: 'POST'
-      dataType: 'json'
-      data: main_form.serialize()
-    .done (data) ->
-      if ctx.opts.target?
-        fields = toHiddenFields({selected_files: data})
-        $(ctx.opts.target).append($(fields))
-      ctx.callbacks.done.fire(data)
-    .fail (xhr,status,error) ->
-      ctx.callbacks.fail.fire(status, error, xhr.responseText)
-    .always ->
-      $('body').css('cursor','default')
-      $('.ev-browser').modal('hide')
-      $('#browse-btn').focus()
-
-  $(document).on 'click', '.ev-files .ev-container a.ev-link', (event) ->
-    event.stopPropagation()
-    event.preventDefault()
-    row = $(this).closest('tr')
-    action = if row.hasClass('expanded') then 'collapseNode' else 'expandNode'
-    node_id = $(this).attr('href')
-    $('table#file-list').treetable(action,node_id)
-
-  $(document).on 'change', '.ev-providers select', (event) ->
-    event.preventDefault()
-    startWait()
-    $.ajax
-      url: $(this).val(),
-      data:
-        accept: dialog.data('ev-state').opts.accept
-        context: dialog.data('ev-state').opts.context
-    .done (data) ->
-      $('.ev-files').html(data)
-      indicateSelected();
-      $('#provider_auth').focus();
-      tableSetup($('table#file-list'))
-    .fail (xhr,status,error) ->
-      if (xhr.responseText.indexOf("Refresh token has expired")>-1)
-        $('.ev-files').html("Your sessison has expired please clear your cookies.")
-      else
-        $('.ev-files').html(xhr.responseText)
-    .always ->
-      stopWait()
-
-  $(document).on 'click', '.ev-providers a', (event) ->
-    $('.ev-providers li').removeClass('ev-selected')
-    $(this).closest('li').addClass('ev-selected')
-
-  $(document).on 'click', '.ev-file a', (event) ->
-    event.preventDefault()
-    target = $(this).closest('*[data-ev-location]')
-    toggleFileSelect(target)
-
-  $(document).on 'click', '.ev-auth', (event) ->
-    event.preventDefault()
-    auth_win = window.open($(this).attr('href'))
-    check_func = ->
-      if auth_win.closed
-        $('.ev-providers .ev-selected a').click()
-      else
-        window.setTimeout check_func, 1000
-    check_func()
-
-  $(document).on 'change', 'input.ev-select-all', (event) ->
-    event.stopPropagation()
-    event.preventDefault()
-    $.fn.browseEverything.toggleCheckbox(this)
-    action = this.value
-    row = $(this).closest('tr')
-    node_id = row.find('td.ev-file-name a.ev-link').attr('href')
-    if row.hasClass('collapsed')
-      $('table#file-list').treetable('expandNode',node_id)
-    else
-      selectChildRows(row, action)
-
-  $(document).on 'change', 'input.ev-select-file', (event) ->
-    event.stopPropagation()
-    event.preventDefault()
-    toggleFileSelect($(this).closest('tr'))
-
-
-auto_toggle = ->
-  triggers = $('*[data-toggle=browse-everything]')
-  if Rails?
-    $.ajaxSetup({
-        headers: { 'X-CSRF-TOKEN': (Rails || $.rails).csrfToken() || '' }
-    });
-
-  triggers.each () ->
-    ctx = $(this).data('ev-state')
-    $(this).browseEverything($(this).data()) unless ctx?
-
-if Turbolinks? && Turbolinks.supported
-  # Use turbolinks:load for Turbolinks 5, otherwise use the old way
-  if (Turbolinks.BrowserAdapter)
-    $(document).on 'turbolinks:load', auto_toggle
-  else
-    $(document).on 'page:change', auto_toggle
-else
-  $(document).ready auto_toggle