browse-everything 0.16.0 → 0.16.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: f010bc868532bf8d950f23deb2057dbf1ef250d3e3ea6a8350cdd4d5652406e5
-  data.tar.gz: 61b2d58f7cec21225de6e85392fb0603d768ac2859aa842763dfdd65d535a0a5
+  metadata.gz: 36223786bc3a801a4cde821810d4e8976f0a1034fcc228acaea6a7eba411770e
+  data.tar.gz: 1611bfb8566183526c1489bb3de4dd8beac2147c7cf0b637d18a445267984daf
 SHA512:
-  metadata.gz: c0580e42f8762c2f29e64860c5e7444f82f4c569e724edd9cac32e894506a62f9a192591e7dbf294f6747906170223f6cd4ff59c09e7a56c9c65ece3065cd275
-  data.tar.gz: 311ab92c994db67da4a8f4206edc00a6d50006dbd3a9492a06ea87002067b20121cce4e8afb3110a2f46aef84fbb43682b520d7a47f63709e0d82370ef755236
+  metadata.gz: 47f835658832bc8837d99c18f4e3dae6a5e8d1edebb183950022a3d44c9b309e04437853d727449b1c0705eaf959fa43ab62c7b5c50ccc78298d6b3d6d2d0e0c
+  data.tar.gz: a725066448c474d91fd38590dbc470ce5bdcf5cf7e60df0721a7ddfbc122fd004a23c99688565ca368610da3adf77f8b95d0bd383f940cf0285d4c189638756e

data/.gitignore

@@ -17,4 +17,3 @@ test/tmp
 test/version_tmp
 tmp
 .internal_test_app
-browse_everything_providers.yml

data/.rubocop.yml

@@ -1,10 +1,10 @@
 inherit_from: .rubocop_todo.yml
+inherit_gem:
+  bixby: bixby_default.yml
 
 AllCops:
-  TargetRubyVersion: 2.4
+  TargetRubyVersion: 2.3
   DisplayCopNames: true
-  Include:
-    - '**/Rakefile'
   Exclude:
     - 'vendor/**/*'
 
@@ -22,21 +22,8 @@ Metrics/LineLength:
   Max: 400
 Metrics/BlockLength:
   Exclude:
-    - 'spec/views/browse_everything/_files.html.erb_spec.rb'
-    - 'spec/unit/browse_everything_helper_spec.rb'
-    - 'spec/unit/browse_everything/retriever_spec.rb'
-    - 'spec/unit/browse_everything/file_entry_spec.rb'
-    - 'spec/unit/browse_everything/driver/s3_spec.rb'
-    - 'spec/unit/browse_everything/driver/google_drive_spec.rb'
-    - 'spec/unit/browse_everything/driver/file_system_spec.rb'
-    - 'spec/unit/browse_everything/driver/dropbox_spec.rb'
-    - 'spec/unit/browse_everything/driver/box_spec.rb'
-    - 'spec/unit/browse_everything/browser_spec.rb'
-    - 'spec/services/browser_factory_spec.rb'
-    - 'spec/services/browse_everything_session/provider_session_spec.rb'
-    - 'spec/helper/browse_everything_controller_helper_spec.rb'
-    - 'spec/controllers/browse_everything_controller_spec.rb'
-    - 'browse-everything.gemspec'
+    - '*.gemspec'
+    - 'spec/**/*'
 
 RSpec/NestedGroups:
   Enabled: false
@@ -45,27 +32,10 @@ RSpec/LeadingSubject:
   Enabled: false
 
 RSpec/ExampleLength:
-  Exclude:
-    - 'spec/unit/browse_everything/driver/base_spec.rb'
-    - 'spec/unit/browse_everything/driver/box_spec.rb'
-    - 'spec/unit/browse_everything/driver/dropbox_spec.rb'
-    - 'spec/unit/browse_everything/driver/file_system_spec.rb'
-    - 'spec/unit/browse_everything/driver/google_drive_spec.rb'
-    - 'spec/unit/browse_everything/driver/s3_spec.rb'
-    - 'spec/features/select_files_spec.rb'
-    - 'spec/javascripts/jasmine_spec.rb'
+  Enabled: false
 
 RSpec/MultipleExpectations:
-  Exclude:
-    - 'spec/unit/browse_everything/driver/base_spec.rb'
-    - 'spec/unit/browse_everything/driver/box_spec.rb'
-    - 'spec/unit/browse_everything/driver/dropbox_spec.rb'
-    - 'spec/unit/browse_everything/driver/file_system_spec.rb'
-    - 'spec/unit/browse_everything/driver/google_drive_spec.rb'
-    - 'spec/unit/browse_everything/driver/s3_spec.rb'
-    - 'spec/features/**/*'
-    - 'spec/controllers/browse_everything_controller_spec.rb'
-    - 'spec/unit/browse_everything/browser_spec.rb'
+  Enabled: false
 
 Style/NumericLiterals:
   MinDigits: 7
@@ -81,13 +51,13 @@ Naming/FileName:
 
 Style/MixinUsage:
   Exclude:
-    - 'spec/unit/browse_everything/driver/s3_spec.rb'
-    - 'spec/unit/browse_everything/driver/google_drive_spec.rb'
-    - 'spec/unit/browse_everything/driver/file_system_spec.rb'
-    - 'spec/unit/browse_everything/driver/dropbox_spec.rb'
-    - 'spec/unit/browse_everything/driver/box_spec.rb'
-    - 'spec/unit/browse_everything/driver/base_spec.rb'
-    - 'spec/unit/browse_everything/browser_spec.rb'
+    - 'spec/lib/browse_everything/driver/s3_spec.rb'
+    - 'spec/lib/browse_everything/driver/google_drive_spec.rb'
+    - 'spec/lib/browse_everything/driver/file_system_spec.rb'
+    - 'spec/lib/browse_everything/driver/dropbox_spec.rb'
+    - 'spec/lib/browse_everything/driver/box_spec.rb'
+    - 'spec/lib/browse_everything/driver/base_spec.rb'
+    - 'spec/lib/browse_everything/browser_spec.rb'
     - 'spec/services/browser_factory_spec.rb'
     - 'spec/helper/browse_everything_controller_helper_spec.rb'
 

data/app/helpers/font_awesome_version_helper.rb

@@ -1,7 +1,6 @@
 # frozen_string_literal: true
 
 module FontAwesomeVersionHelper
-
   # Determines if the App uses Font Awesome releases 3.x or 4.x
   # @return [TrueClass, FalseClass]
   def font_awesome_four?

data/app/services/browse_everything_session.rb

@@ -1,4 +1,3 @@
-
 # frozen_string_literal: true
 
 class BrowseEverythingSession

data/app/services/browser_factory.rb

@@ -1,4 +1,3 @@
-
 # frozen_string_literal: true
 
 class BrowserFactory

data/browse-everything.gemspec

@@ -26,13 +26,15 @@ Gem::Specification.new do |spec|
   spec.add_dependency 'font-awesome-rails'
   spec.add_dependency 'google-api-client', '~> 0.21'
   spec.add_dependency 'google_drive', '~> 2.1'
-  spec.add_dependency 'typhoeus'
+  spec.add_dependency 'googleauth', '0.6.2'
   spec.add_dependency 'rails', '>= 4.2'
   spec.add_dependency 'ruby-box'
   spec.add_dependency 'sass-rails'
   spec.add_dependency 'signet', '~> 0.8'
   spec.add_dependency 'thor', '~> 0.20'
+  spec.add_dependency 'typhoeus'
 
+  spec.add_development_dependency 'bixby', '>= 1.0'
   spec.add_development_dependency 'bundler', '~> 1.3'
   spec.add_development_dependency 'capybara'
   spec.add_development_dependency 'chromedriver-helper'
@@ -45,8 +47,7 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency 'rspec', '~> 3.0'
   spec.add_development_dependency 'rspec-its'
   spec.add_development_dependency 'rspec-rails'
-  spec.add_development_dependency 'rubocop', '~> 0.53'
-  spec.add_development_dependency 'rubocop-rspec', '~> 1.23'
+  spec.add_development_dependency 'rubocop-rspec'
   spec.add_development_dependency 'selenium-webdriver'
   spec.add_development_dependency 'simplecov'
   spec.add_development_dependency 'sqlite3'

data/lib/browse_everything.rb

@@ -53,14 +53,14 @@ module BrowseEverything
       elsif value.is_a?(String)
         config_file_content = File.read(value)
         config_file_template = ERB.new(config_file_content)
-        config_values = YAML.safe_load(config_file_template.result)
+        config_values = YAML.safe_load(config_file_template.result, [Symbol])
         @config = ActiveSupport::HashWithIndifferentAccess.new config_values
         @config.deep_symbolize_keys
       else
         raise InitializationError, "Unrecognized configuration: #{value.inspect}"
       end
 
-      if @config.include? 'drop_box'
+      if @config.include? 'drop_box' # rubocop:disable Style/GuardClause
         warn '[DEPRECATION] `drop_box` is deprecated.  Please use `dropbox` instead.'
         @config['dropbox'] = @config.delete('drop_box')
       end

data/lib/browse_everything/driver/dropbox.rb

@@ -13,7 +13,9 @@ module BrowseEverything
         end
 
         class << self
-          private def klass_for(metadata)
+          private
+
+          def klass_for(metadata)
             case metadata
             when DropboxApi::Metadata::File
               FileFactory

data/lib/browse_everything/file_entry.rb

@@ -15,7 +15,7 @@ module BrowseEverything
     end
 
     def relative_parent_path?
-      /^\.\.?$/.match(name) ? true : false
+      name =~ /^\.\.?$/ ? true : false
     end
 
     def container?

data/lib/browse_everything/retriever.rb

@@ -131,7 +131,7 @@ module BrowseEverything
         url = options.fetch(:url)
         retrieved = 0
 
-        request = Typhoeus::Request.new(url.to_s)
+        request = Typhoeus::Request.new(url.to_s, headers: headers)
         request.on_headers do |response|
           raise DownloadError.new("#{self.class}: Failed to download #{url}", response) unless response.code == 200
         end

data/lib/browse_everything/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module BrowseEverything
-  VERSION = '0.16.0'
+  VERSION = '0.16.1'
 end

data/lib/generators/browse_everything/config_generator.rb

@@ -7,7 +7,7 @@ class BrowseEverything::ConfigGenerator < Rails::Generators::Base
   This generator makes the following changes to your application:
    1. Creates config/browse_everything_providers.yml with a placeholder value
    2. Modifies your app's routes.rb to mount BrowseEverything at /browse
-    DESC
+  DESC
   source_root File.expand_path('templates', __dir__)
 
   def inject_routes
@@ -18,7 +18,7 @@ class BrowseEverything::ConfigGenerator < Rails::Generators::Base
   end
 
   def copy_example_config
-    FileUtils.rm 'config/browse_everything_providers.yml', force: true if File.exists? 'config/browse_everything_providers.yml'
+    FileUtils.rm 'config/browse_everything_providers.yml', force: true if File.exist? 'config/browse_everything_providers.yml'
     copy_file 'browse_everything_providers.yml.example', 'config/browse_everything_providers.yml', force: true
   end
 

data/spec/controllers/browse_everything_controller_spec.rb

@@ -22,6 +22,7 @@ RSpec.describe BrowseEverythingController, type: :controller do
       allow(provider).to receive(:connect)
       controller.auth
     end
+
     it 'retrieves the authorization code from the parameters' do
       expect(provider).to have_received(:connect).with({ 'code' => 'test-code' }, nil)
     end

data/spec/features/select_files_spec.rb

@@ -26,11 +26,13 @@ describe 'Choosing files', type: :feature, js: true do
 
   context 'when Turbolinks are enabled', fail: true do
     before { click_link('Enter Test App (Turbolinks)') }
+
     it_behaves_like 'browseable files'
   end
 
   context 'when Turbolinks are disabled' do
     before { click_link('Enter Test App (No Turbolinks)') }
+
     it_behaves_like 'browseable files'
   end
 end

data/spec/fixtures/config/browse_everything_providers.yml

@@ -0,0 +1,10 @@
+---
+:dropbox:
+  :app_key: test-key
+  :app_secret: test-secret
+:box:
+  :client_id: test-id
+  :client_secret: test-secret
+:google_drive:
+  :client_id: test-id
+  :client_secret: test-secret

data/spec/lib/browse_everything/auth/google/credentials_spec.rb

@@ -5,24 +5,25 @@ describe BrowseEverything::Auth::Google::Credentials do
 
   describe '#fetch_access_token' do
     let(:response) { double }
+
     before do
       WebMock.disable!
 
       allow(response).to receive(:status_code).and_return('200')
       allow(response).to receive(:body).and_return('{}')
-      allow(response).to receive(:header).and_return({ content_type: 'application/json' })
+      allow(response).to receive(:header).and_return(content_type: 'application/json')
 
       connection = instance_double(Faraday::Connection)
       allow(connection).to receive(:post).and_return(response)
       faraday = class_double('Faraday').as_stubbed_const(transfer_nested_constants: true)
       allow(faraday).to receive(:default_connection).and_return(connection)
-
     end
 
     context 'when an access has already been retrieved' do
       before do
         credentials.access_token = 'test-token'
       end
+
       it 'generates a Hash if an access token has already been set' do
         expect(credentials.fetch_access_token).to be_a Hash
         expect(credentials.fetch_access_token).to include('access_token' => 'test-token')

data/spec/lib/browse_everything/browse_everything_helper_spec.rb

@@ -11,7 +11,7 @@ describe BrowseEverythingHelper do
     end
   end
 
-  let(:test_file) { BrowseEverything::FileEntry.new 0, '/path/to/file.mp4', 'file.mp4', 12345, Time.now, false }
+  let(:test_file) { BrowseEverything::FileEntry.new 0, '/path/to/file.mp4', 'file.mp4', 12345, Time.current, false }
 
   it 'matches a full type' do
     expect(test_class.new(accept: 'video/mp4').is_acceptable?(test_file)).to eq(true)

data/spec/lib/browse_everything/browser_spec.rb

@@ -102,6 +102,7 @@ describe BrowseEverything::Browser do
 
   describe '#first_provider' do
     subject(:browser) { described_class.new(url_options) }
+
     it 'retrieves the first configured provider' do
       expect(browser.first_provider).to be_a BrowseEverything::Driver::FileSystem
     end

data/spec/lib/browse_everything/driver/base_spec.rb

@@ -14,16 +14,19 @@ describe BrowseEverything::Driver::Base do
     its(:auth_link) { is_expected.to be_empty          }
     specify         { is_expected.not_to be_authorized }
   end
+
   describe '#connect' do
     subject { driver.connect({}, {}) }
 
     it { is_expected.to be_blank }
   end
+
   describe '#contents' do
     subject { driver.contents('') }
 
     it { is_expected.to be_empty }
   end
+
   describe '#link_for' do
     subject { driver.link_for('/path/to/foo.txt') }
 

data/spec/lib/browse_everything/driver/box_spec.rb

@@ -66,16 +66,22 @@ describe BrowseEverything::Driver::Box, vcr: { cassette_name: 'box', record: :no
     context 'when the access token is not registered' do
       it { is_expected.to be(false) }
     end
+
     context 'when the access tokens are registered and not expired' do
       before { provider.token = token.merge('expires_at' => Time.now.to_i + 360) }
+
       it { is_expected.to be(true) }
     end
+
     context 'when the access tokens are registered but no expiration time' do
       before { provider.token = token }
+
       it { is_expected.to be(false) }
     end
+
     context 'when the access tokens are registered but expired' do
       before { provider.token = token.merge('expires_at' => Time.now.to_i - 360) }
+
       it { is_expected.to be(false) }
     end
   end
@@ -143,6 +149,7 @@ describe BrowseEverything::Driver::Box, vcr: { cassette_name: 'box', record: :no
         its(:id)       { is_expected.to be_kind_of(Pathname) }
         it             { is_expected.to be_container }
       end
+
       describe 'the second item' do
         subject { apps_dir }
 
@@ -150,6 +157,7 @@ describe BrowseEverything::Driver::Box, vcr: { cassette_name: 'box', record: :no
         its(:id)       { is_expected.to eq('2459974427') }
         it             { is_expected.to be_container }
       end
+
       describe 'a file' do
         subject { equipment }
 

data/spec/lib/browse_everything/driver/file_system_spec.rb

@@ -38,12 +38,14 @@ describe BrowseEverything::Driver::FileSystem do
         its(:name) { is_expected.to eq('dir_1') }
         specify    { is_expected.to be_container }
       end
+
       context 'when there are multiple directories' do
         subject { contents[1] }
 
         its(:name) { is_expected.to eq('dir_2') }
         specify    { is_expected.to be_container }
       end
+
       context 'when there is a PDF' do
         subject { contents[2] }
 
@@ -64,6 +66,7 @@ describe BrowseEverything::Driver::FileSystem do
         its(:name) { is_expected.to eq('dir_3') }
         specify    { is_expected.to be_container }
       end
+
       context 'when there is a text file' do
         subject { contents.last }
 

data/spec/lib/browse_everything/driver/s3_spec.rb

@@ -67,6 +67,7 @@ describe BrowseEverything::Driver::S3 do
         its(:name) { is_expected.to eq('bar') }
         specify    { is_expected.to be_container }
       end
+
       context 'with two assets' do
         subject { contents[1] }
 
@@ -100,6 +101,7 @@ describe BrowseEverything::Driver::S3 do
         its(:name) { is_expected.to eq('..') }
         specify    { is_expected.to be_container }
       end
+
       context 'with a JPEG asset' do
         subject { contents[1] }
 
@@ -109,6 +111,7 @@ describe BrowseEverything::Driver::S3 do
         its(:size)     { is_expected.to eq(52645)             }
         specify        { is_expected.not_to be_container }
       end
+
       context 'with a PNG asset' do
         subject { contents[2] }
 
@@ -133,17 +136,17 @@ describe BrowseEverything::Driver::S3 do
 
         it ':signed_url' do
           provider.config[:response_type] = :signed_url
-          expect(provider.link_for('foo/quux.png')).to eq ["https://s3.amazonaws.com/presigned_url", {:file_name=>"quux.png", :expires=>14400}]
+          expect(provider.link_for('foo/quux.png')).to eq ['https://s3.amazonaws.com/presigned_url', { file_name: 'quux.png', expires: 14400 }]
         end
 
         it ':public_url' do
           provider.config[:response_type] = :public_url
-          expect(provider.link_for('foo/quux.png')).to eq ["https://s3.amazonaws.com/public_url", {:file_name=>"quux.png"}]
+          expect(provider.link_for('foo/quux.png')).to eq ['https://s3.amazonaws.com/public_url', { file_name: 'quux.png' }]
         end
 
         it ':s3_uri' do
           provider.config[:response_type] = :s3_uri
-          expect(provider.link_for('foo/quux.png')).to eq ['s3://s3.bucket/foo/quux.png', {:file_name=>"quux.png"}]
+          expect(provider.link_for('foo/quux.png')).to eq ['s3://s3.bucket/foo/quux.png', { file_name: 'quux.png' }]
         end
       end
     end

data/spec/lib/browse_everything/driver_spec.rb

@@ -1,7 +1,6 @@
 # frozen_string_literal: true
 
 describe BrowseEverything::Driver do
-
   let(:my_driver) do
     MyDriver.new
   end
@@ -10,7 +9,7 @@ describe BrowseEverything::Driver do
     class MyDriver
       include BrowseEverything::Driver
 
-      def get_sorter
+      def get_sorter # rubocop:disable Naming/AccessorMethodName
         sorter
       end
     end
@@ -18,17 +17,17 @@ describe BrowseEverything::Driver do
 
   describe '#sorter' do
     it 'defaults to nil' do
-      expect(BrowseEverything::Driver.sorter).to be nil
+      expect(described_class.sorter).to be nil
     end
   end
 
   describe '#sorter=' do
     let(:new_sorter) do
-      lambda { |files| }
+      ->(files) {}
     end
 
     before do
-      BrowseEverything::Driver.sorter = new_sorter
+      described_class.sorter = new_sorter
     end
 
     it 'mutates the sorter from the initializer' do

data/spec/lib/browse_everything/retriever_spec.rb

@@ -9,7 +9,8 @@ describe BrowseEverything::Retriever, vcr: { cassette_name: 'retriever', record:
   let(:size) { File.size(datafile) }
 
   describe '#get_file_size' do
-    subject(:file_size) { retriever.file_size(options) }
+    subject(:computed_file_size) { retriever.file_size(options) }
+
     let(:url) { URI.parse("file://#{datafile}") }
     let(:headers) { [] }
     let(:file_size) { 0 }
@@ -22,26 +23,26 @@ describe BrowseEverything::Retriever, vcr: { cassette_name: 'retriever', record:
     end
 
     it 'calculates or retrieves the size of a file' do
-      retriever.retrieve(options) do |chunk, retrieved, total|
+      retriever.retrieve(options) do |_chunk, _retrieved, total|
         expect(total).to eq 2256
       end
     end
 
-    context "when retrieving a resource from a cloud storage provider" do
-      let(:url) { URI.parse("https://drive.google.com/uc?id=id&export=download") }
+    context 'when retrieving a resource from a cloud storage provider' do
+      let(:url) { URI.parse('https://drive.google.com/uc?id=id&export=download') }
 
       it 'calculates or retrieves the size of a file' do
-        retriever.retrieve(options) do |chunk, retrieved, total|
+        retriever.retrieve(options) do |_chunk, _retrieved, total|
           expect(total).to eq 1234
         end
       end
     end
 
-    context "when retrieving a resource with an unsupported protocol" do
-      let(:url) { URI.parse("ftp://invalid") }
+    context 'when retrieving a resource with an unsupported protocol' do
+      let(:url) { URI.parse('ftp://invalid') }
 
-      it "raises an error" do
-        expect { retriever.retrieve(options) {|c, r, t|} }.to raise_error(URI::BadURIError, "Unknown URI scheme: ftp")
+      it 'raises an error' do
+        expect { retriever.retrieve(options) { |c, r, t| } }.to raise_error(URI::BadURIError, 'Unknown URI scheme: ftp')
       end
     end
   end
@@ -167,7 +168,7 @@ describe BrowseEverything::Retriever, vcr: { cassette_name: 'retriever', record:
     end
   end
 
-  context '.can_retrieve?' do
+  describe '.can_retrieve?' do
     let(:expiry_time) { (Time.current + 3600).xmlschema }
     let(:spec) do
       {
@@ -181,19 +182,19 @@ describe BrowseEverything::Retriever, vcr: { cassette_name: 'retriever', record:
       }
     end
 
-    context 'can retrieve' do
+    context 'when can retrieve' do
       let(:url) { 'https://retrieve.cloud.example.com/some/dir/can_retrieve.pdf' }
 
       it 'says it can' do
-        expect(described_class.can_retrieve?(url)).to be_truthy
+        expect(described_class).to be_can_retrieve(url)
       end
     end
 
-    context 'cannot retrieve' do
+    context 'when cannot retrieve' do
       let(:url) { 'https://retrieve.cloud.example.com/some/dir/cannot_retrieve.pdf' }
 
       it 'says it cannot' do
-        expect(described_class.can_retrieve?(url)).to be_falsey
+        expect(described_class).not_to be_can_retrieve(url)
       end
     end
   end

data/spec/lib/browse_everything_spec.rb

@@ -1,59 +1,76 @@
 # frozen_string_literal: true
 
 describe BrowseEverything do
-  describe '.configure' do
-
-    let(:config) do
-      {
-        dropbox: {
-          app_key: 'test-key',
-          app_secret: 'test-secret'
-        },
-        box: {
-          client_id: 'test-id',
-          client_secret: 'test-secret'
-        },
-        google_drive: {
-          client_id: 'test-id',
-          client_secret: 'test-secret'
-        }
-      }
-    end
-    before do
-      BrowseEverything.configure(config)
-    end
-    it 'registers the configuration for the drivers' do
-      expect(BrowseEverything.config).to be_a ActiveSupport::HashWithIndifferentAccess
+  shared_examples "a configured BrowseEverything module" do
+    describe 'registered configuration' do
+      it 'registers the configuration for the drivers' do
+        expect(described_class.config).to be_a ActiveSupport::HashWithIndifferentAccess
 
-      expect(BrowseEverything.config).to include 'dropbox'
-      expect(BrowseEverything.config['dropbox']).to include({ 'app_key' => 'test-key' })
-      expect(BrowseEverything.config['dropbox']).to include({ 'app_secret' => 'test-secret' })
+        expect(described_class.config).to include 'dropbox'
+        expect(described_class.config['dropbox']).to include('app_key' => 'test-key')
+        expect(described_class.config['dropbox']).to include('app_secret' => 'test-secret')
 
-      expect(BrowseEverything.config).to include 'box'
-      expect(BrowseEverything.config['box']).to include({ 'client_id' => 'test-id' })
-      expect(BrowseEverything.config['box']).to include({ 'client_secret' => 'test-secret' })
+        expect(described_class.config).to include 'box'
+        expect(described_class.config['box']).to include('client_id' => 'test-id')
+        expect(described_class.config['box']).to include('client_secret' => 'test-secret')
 
-      expect(BrowseEverything.config).to include 'google_drive'
-      expect(BrowseEverything.config['google_drive']).to include({ 'client_id' => 'test-id' })
-      expect(BrowseEverything.config['google_drive']).to include({ 'client_secret' => 'test-secret' })
+        expect(described_class.config).to include 'google_drive'
+        expect(described_class.config['google_drive']).to include('client_id' => 'test-id')
+        expect(described_class.config['google_drive']).to include('client_secret' => 'test-secret')
+      end
     end
+  end
 
-    context 'with an entry for the drop_box provider' do
+  describe '.configure' do
+    context 'with a hash' do
       let(:config) do
         {
-          drop_box: {
+          dropbox: {
             app_key: 'test-key',
             app_secret: 'test-secret'
+          },
+          box: {
+            client_id: 'test-id',
+            client_secret: 'test-secret'
+          },
+          google_drive: {
+            client_id: 'test-id',
+            client_secret: 'test-secret'
           }
         }
       end
 
-      it 'logs a deprecation warning and sets it to the dropbox key' do
-        expect(BrowseEverything.config).not_to include 'drop_box'
-        expect(BrowseEverything.config).to include 'dropbox'
-        expect(BrowseEverything.config['dropbox']).to include({ 'app_key' => 'test-key' })
-        expect(BrowseEverything.config['dropbox']).to include({ 'app_secret' => 'test-secret' })
+      before do
+        described_class.configure(config)
       end
+
+      it_behaves_like 'a configured BrowseEverything module'
+
+      context 'with an entry for the drop_box provider' do
+        let(:config) do
+          {
+            drop_box: {
+              app_key: 'test-key',
+              app_secret: 'test-secret'
+            }
+          }
+        end
+
+        it 'logs a deprecation warning and sets it to the dropbox key' do
+          expect(described_class.config).not_to include 'drop_box'
+          expect(described_class.config).to include 'dropbox'
+          expect(described_class.config['dropbox']).to include('app_key' => 'test-key')
+          expect(described_class.config['dropbox']).to include('app_secret' => 'test-secret')
+        end
+      end
+    end
+
+    context 'with a YAML file' do
+      before do
+        described_class.configure(File.expand_path('../../fixtures/config/browse_everything_providers.yml', __FILE__))
+      end
+
+      it_behaves_like 'a configured BrowseEverything module'
     end
   end
 
@@ -61,7 +78,7 @@ describe BrowseEverything do
     let(:config) { 1234 }
 
     it 'raises an initialization error' do
-      expect { BrowseEverything.configure(config) }.to raise_error(BrowseEverything::InitializationError, 'Unrecognized configuration: 1234')
+      expect { described_class.configure(config) }.to raise_error(BrowseEverything::InitializationError, 'Unrecognized configuration: 1234')
     end
   end
 end

data/spec/services/browse_everything_session/provider_session_spec.rb

@@ -18,6 +18,7 @@ describe BrowseEverythingSession::ProviderSession do
       allow(session).to receive(:[]).and_return('test-token')
       provider_session.token = 'test-token'
     end
+
     it 'sets and accesses the access token' do
       expect(provider_session.token).to eq 'test-token'
       expect(session).to have_received(:[]).with('test_session_token')
@@ -30,6 +31,7 @@ describe BrowseEverythingSession::ProviderSession do
       allow(session).to receive(:[]).and_return('test-code')
       provider_session.code = 'test-code'
     end
+
     it 'sets and accesses the access code' do
       expect(provider_session.code).to eq 'test-code'
       expect(session).to have_received(:[]).with('test_session_code')
@@ -42,6 +44,7 @@ describe BrowseEverythingSession::ProviderSession do
       allow(session).to receive(:[]).and_return('test' => 'data')
       provider_session.data = { 'test' => 'data' }
     end
+
     it 'sets and accesses the access data' do
       expect(provider_session.data).to eq('test' => 'data')
       expect(session).to have_received(:[]).with('test_session_data')

data/spec/spec_helper.rb

@@ -1,6 +1,7 @@
 # frozen_string_literal: true
-ENV["RAILS_ENV"] ||= 'test'
-require "bundler/setup"
+
+ENV['RAILS_ENV'] ||= 'test'
+require 'bundler/setup'
 
 def coverage_needed?
   ENV['COVERAGE'] || ENV['TRAVIS']
@@ -9,7 +10,7 @@ end
 if coverage_needed?
   require 'simplecov'
   require 'coveralls'
-  SimpleCov.root(File.expand_path('../..', __FILE__))
+  SimpleCov.root(File.expand_path('..', __dir__))
   SimpleCov.formatter = SimpleCov::Formatter::MultiFormatter.new(
     [
       SimpleCov::Formatter::HTMLFormatter,

data/spec/test_app_templates/lib/generators/test_app_generator.rb

@@ -3,7 +3,7 @@
 require 'rails/generators'
 
 class TestAppGenerator < Rails::Generators::Base
-  source_root File.expand_path('../../../../spec/test_app_templates/', __FILE__)
+  source_root File.expand_path('../../../spec/test_app_templates', __dir__)
 
   def install_engine
     generate 'browse_everything:install -f'

data/spec/views/browse_everything/_files.html.erb_spec.rb

@@ -36,6 +36,7 @@ describe 'browse_everything/_files.html.erb', type: :view do
       allow(view).to receive(:file).and_return(file)
       render
     end
+
     context 'when a file is not too big' do
       let(:config) { { max_upload_file_size: (5 * 1024 * 1024 * 1024) } }
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: browse-everything
 version: !ruby/object:Gem::Version
-  version: 0.16.0
+  version: 0.16.1
 platform: ruby
 authors:
 - Carolyn Cole
@@ -13,7 +13,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-07-24 00:00:00.000000000 Z
+date: 2018-08-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: addressable
@@ -114,19 +114,19 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '2.1'
 - !ruby/object:Gem::Dependency
-  name: typhoeus
+  name: googleauth
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - '='
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 0.6.2
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - '='
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 0.6.2
 - !ruby/object:Gem::Dependency
   name: rails
   requirement: !ruby/object:Gem::Requirement
@@ -197,6 +197,34 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '0.20'
+- !ruby/object:Gem::Dependency
+  name: typhoeus
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: bixby
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '1.0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '1.0'
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
@@ -365,34 +393,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
-- !ruby/object:Gem::Dependency
-  name: rubocop
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '0.53'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '0.53'
 - !ruby/object:Gem::Dependency
   name: rubocop-rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '1.23'
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '1.23'
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: selenium-webdriver
   requirement: !ruby/object:Gem::Requirement
@@ -532,6 +546,7 @@ files:
 - spec/controllers/browse_everything_controller_spec.rb
 - spec/features/select_files_spec.rb
 - spec/features/test_compiling_stylesheets_spec.rb
+- spec/fixtures/config/browse_everything_providers.yml
 - spec/fixtures/file_system/dir_1/dir_3/file_3.m4v
 - spec/fixtures/file_system/dir_1/file_2.txt
 - spec/fixtures/file_system/dir_2/file_4.docx
@@ -604,6 +619,7 @@ test_files:
 - spec/controllers/browse_everything_controller_spec.rb
 - spec/features/select_files_spec.rb
 - spec/features/test_compiling_stylesheets_spec.rb
+- spec/fixtures/config/browse_everything_providers.yml
 - spec/fixtures/file_system/dir_1/dir_3/file_3.m4v
 - spec/fixtures/file_system/dir_1/file_2.txt
 - spec/fixtures/file_system/dir_2/file_4.docx