broken_record 0.0.3 → 0.0.5

checksums.yaml

@@ -1,15 +1,15 @@
 ---
 !binary "U0hBMQ==":
   metadata.gz: !binary |-
-    ZTEyNmRlZWM4NjUxZjdmNmE3ZWE0NjJlYzNmZDVjZDcyMTJkZGIwMw==
+    NmQyYTRiOTBhYjVhNTcyZTIzNTFhOWU3Y2JiNWY3NDFiYjk3ZTg5Ng==
   data.tar.gz: !binary |-
-    NmYxZDNlZGI5NzJhZDRkODU1YmFkOTFlZWUyNTU0MGEyZDNmZTg4ZA==
+    MjNjMWEzNTgyNzNjMjRmNTQ4YmMyZTAyZTM1OTgwNjRiYWIzNGMwMw==
 SHA512:
   metadata.gz: !binary |-
-    ZDAyNDkxNDc2MzEyY2I1MGY3NTQ2MzVkZGI5NmM1ZWViNzE1YTc0OGJkMDkz
-    MjQxMWM3NmNkYjc0ZGYxZmJlN2NjMTZkNWY5MGJkZWVmYzJjY2Y1ODAyODQ4
-    MzkxZjRmZTQ1YjA3YTIxMzlhOTM2NThmNTE3NDllNDlhMDczOGQ=
+    NzI0Mjg0ZmI4N2EyNWMwNmQ0ZGQ4YzM1ZTJlOTBkNGYwNDQyYWM3MTAxMWJl
+    N2EyNGE0ODBhZTJiMDg4YTY3ZjAzZGY2NzdlMzlkNzhmYzg1NTg4MWFjZjZm
+    NjgzZTBlZTMzN2ZjNWYxN2RkZmFmOTdhNjBlOWVjYWFiOGMwMmU=
   data.tar.gz: !binary |-
-    MWU0ZWQxZWViZjM5ZWY2YzI4NmRjYWIwZmRiOWM4ZDEzZTE2MmJkYjYyYTc0
-    NjA5NDg5MWJlNzQxN2NjNDc1OTVkMjUyNTM0YTBjZmZjN2MxZTc5ZDM5YjI2
-    OTEyY2NiYzg2MzkyMDRmNjgyYzQzOWUxNDY0YjljNWZmNWNmMWM=
+    YTczYzAzODkwOWM0ZTlmYjE4NmVhYzRmMjc3Mjk5YThkN2VkYTE1OWM3Y2I1
+    YTAxYTEyMmExY2ExZGFjOTUwMjM3YWQ4MWRkOWIzNjUxNWE1ZWQ1NzQ4OGIw
+    MDMxNTcyODIyMWZjOWIxYzRmMWVmOWY5YjJiODQ0MzY2NjQ1YzA=

data/CHANGELOG.md

@@ -9,4 +9,8 @@
 
 ## v0.0.3
 
-* Allow setting a per-model default scope
+* Allow setting a per-model default scope
+
+## v0.0.5
+
+* Show per-model test duration in log output

data/broken_record.gemspec

@@ -4,23 +4,23 @@ $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 require 'broken_record/version'
 
 Gem::Specification.new do |spec|
-  spec.name          = "broken_record"
+  spec.name          = 'broken_record'
   spec.version       = BrokenRecord::VERSION
-  spec.authors       = ["Nicholas Gervasi"]
-  spec.email         = ["nick@zenpayroll.com"]
+  spec.authors       = ['Nicholas Gervasi']
+  spec.email         = ['nick@zenpayroll.com']
   spec.description   = %q{Detects ActiveRecord models that are not valid.}
   spec.summary       = %q{Provides a rake task for scanning your ActiveRecord models and detecting validation errors.}
-  spec.homepage      = ""
-  spec.license       = "MIT"
+  spec.homepage      = 'https://github.com/nickgervasi/broken_record'
+  spec.license       = 'MIT'
 
   spec.files         = `git ls-files`.split($/)
   spec.executables   = spec.files.grep(%r{^bin/}) { |f| File.basename(f) }
   spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
-  spec.require_paths = ["lib"]
+  spec.require_paths = ['lib']
 
-  spec.add_development_dependency "bundler", "~> 1.3"
+  spec.add_development_dependency 'bundler', '~> 1.3'
 
-  spec.add_runtime_dependency "rake"
-  spec.add_runtime_dependency "parallel"
-  spec.add_runtime_dependency "colorize"
+  spec.add_runtime_dependency 'rake', '~> 10'
+  spec.add_runtime_dependency 'parallel', '~> 0'
+  spec.add_runtime_dependency 'colorize', '0.5.8'
 end

data/lib/broken_record/logger.rb

@@ -16,7 +16,7 @@ module BrokenRecord
 
     def self.report_results(test_results)
       total_errors = 0
-      test_results.each { |result| total_errors += result[:errors] }
+      test_results.each { |result| total_errors += result[:error_count] }
       if total_errors == 0
         puts "\nAll models validated successfully.".green
       else
@@ -31,29 +31,55 @@ module BrokenRecord
       end
     end
 
+    def self.log(model, &block)
+      logger = new
+      logger.start_log
+      logger.log_header "Validating model #{model}... ".ljust(70)
+
+      yield(logger)
+
+      logger.log_result
+      logger.result
+    end
+
     # Instance Methods
 
     def initialize
-      @errors = 0
-      @stdout = ""
+      @header = ''
+      @errors = []
+
+      @stdout = ''
     end
 
-    def log_error(message)
-      @stdout << "[FAIL]\n".red if @errors == 0
-      @stdout << "#{message.red}\n"
-      @errors += 1
+    def log_header(header_message)
+      @header = header_message
+    end
+
+    def start_log
+      @start_time = Time.now
     end
 
-    def log_message(message)
-      @stdout << "#{message}"
+    def log_error(message)
+      @errors << "#{message.red}\n"
     end
 
     def log_result
-      @stdout << "[PASS]\n".green if @errors == 0
+      @stdout << @header
+
+      if @errors.empty?
+        @stdout << '[PASS]'.green
+      else
+        @stdout << '[FAIL]'.red
+      end
+
+      duration = (Time.now - @start_time).round(3)
+      @stdout << "  (#{duration}s)\n"
+
+      @stdout << @errors.join
     end
 
     def result
-      { stdout: @stdout, errors: @errors}
+      { stdout: @stdout, error_count: @errors.count}
     end
   end
 end

data/lib/broken_record/scanner.rb

@@ -46,33 +46,29 @@ module BrokenRecord
     def validate_model(model)
       ActiveRecord::Base.connection.reconnect!
 
-      logger = BrokenRecord::Logger.new
-      logger.log_message "Validating model #{model}... ".ljust(70)
-
-      begin
-        if BrokenRecord::Config.default_scopes[model]
-          model_scope = model.instance_exec &BrokenRecord::Config.default_scopes[model]
-        else
-          model_scope = model.unscoped
-        end
+      BrokenRecord::Logger.log(model) do |logger|
+        begin
+          if BrokenRecord::Config.default_scopes[model]
+            model_scope = model.instance_exec &BrokenRecord::Config.default_scopes[model]
+          else
+            model_scope = model.unscoped
+          end
 
-        model_scope.find_each do |r|
-          begin
-            if !r.valid?
-              message = "    Invalid record in #{model} id=#{r.id}."
-              r.errors.each { |attr,msg| message <<  "\n        #{attr} - #{msg}" }
-              logger.log_error message
+          model_scope.find_each do |r|
+            begin
+              if !r.valid?
+                message = "    Invalid record in #{model} id=#{r.id}."
+                r.errors.each { |attr,msg| message <<  "\n        #{attr} - #{msg}" }
+                logger.log_error message
+              end
+            rescue Exception => msg
+              logger.log_error "    Exception for record in #{model} id=#{r.id} - #{msg}."
             end
-          rescue Exception => msg
-            logger.log_error "    Exception for record in #{model} id=#{r.id} - #{msg}."
           end
+        rescue Exception => msg
+          logger.log_error "    Error querying model #{model} - #{msg}."
         end
-      rescue Exception => msg
-        logger.log_error "    Error querying model #{model} - #{msg}."
       end
-
-      logger.log_result
-      logger.result
     end
   end
 end

data/lib/broken_record/version.rb

@@ -1,3 +1,3 @@
 module BrokenRecord
-  VERSION = "0.0.3"
+  VERSION = "0.0.5"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: broken_record
 version: !ruby/object:Gem::Version
-  version: 0.0.3
+  version: 0.0.5
 platform: ruby
 authors:
 - Nicholas Gervasi
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-02-26 00:00:00.000000000 Z
+date: 2014-03-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -28,44 +28,44 @@ dependencies:
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ~>
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '10'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ~>
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '10'
 - !ruby/object:Gem::Dependency
   name: parallel
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ~>
       - !ruby/object:Gem::Version
         version: '0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ~>
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: colorize
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - '='
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 0.5.8
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - '='
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 0.5.8
 description: Detects ActiveRecord models that are not valid.
 email:
 - nick@zenpayroll.com
@@ -87,7 +87,7 @@ files:
 - lib/broken_record/scanner.rb
 - lib/broken_record/tasks.rb
 - lib/broken_record/version.rb
-homepage: ''
+homepage: https://github.com/nickgervasi/broken_record
 licenses:
 - MIT
 metadata: {}