broadside 3.0.4 → 3.0.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 6d889d2cb5a3c7d2600fcb7cf3b678e2e5bd8856
-  data.tar.gz: 4bd0afa8288e64a363e033a3d8e82818481333e2
+  metadata.gz: a3e0d92c4b8e8a5079c5a3008c16c2986fe00862
+  data.tar.gz: 70c9df295003bc04c67ac64ed9acd1809aee14cd
 SHA512:
-  metadata.gz: df142f92284556a150dfa89f121a6b350f7450077e663f7112afa7727a97cd5a05ff5d5ff12d26d5b6c65d7ca8cf941fd695899e6dcf16ab59097ff32baf43d7
-  data.tar.gz: b726f0bc5e645e6fad7af0d1eee95dbbc257eb91ebb608cc181f6938011322b4d6ec35dc0639d2456d1e69bebd036649d93f7e27bd0d19e57e35c78f7587d265
+  metadata.gz: 46d9466884ee07ffd715ff753e04aefb1361bf807dbd0d31a1f6aa7ae96d8deb1cc65066c6f1394ee1384b4fa456cf4ca8f18965564505d5f75626292f9f0507
+  data.tar.gz: 5414a05c469f5c7014f834406658fe3ff7a53400cf9d0b01d2b3f14af43513c732769f95adce490cf37095069cf1d9ca7adc321e329774f440435986ec42ee5a

data/README.md

@@ -2,6 +2,8 @@
 
 A [GLI](https://github.com/davetron5000/gli) based command-line tool for deploying applications on [AWS EC2 Container Service (ECS)](https://aws.amazon.com/ecs/)
 
+### [The wiki](https://github.com/lumoslabs/broadside/wiki) has all kinds of useful information on it so don't just rely on this README.
+
 ## Overview
 Amazon ECS presents a low barrier to entry for production-level docker applications. Combined with ECS's built-in blue-green deployment, Elastic Load Balancers, Autoscale Groups, and CloudWatch, one can theoretically set up a robust cluster that can scale to serve any number of applications in a short amount of time. The ECS GUI, CLI, overall architecture are not the easiest to work with, however, so Broadside seeks to leverage the [ECS ruby API](http://docs.aws.amazon.com/sdkforruby/api/Aws/ECS.html) to dramatically simplify and improve the configuration and deployment process for developers, offering a simple command line interface and configuration format that should meet most needs.
 
@@ -102,4 +104,15 @@ For full application setup, see the [detailed instructions in the wiki](https://
 Use the `--debug` switch to enable stacktraces and debug output.
 
 ## Contributing
-Pull requests, bug reports, and feature suggestions are welcome! Before starting on a contribution, we recommend opening an issue or replying to an existing one to give others some initial context on the work needing to be done.
+Pull requests, bug reports, and feature suggestions are welcome!
+
+Before starting on a contribution, we recommend opening an issue or replying to an existing one to give others some initial context on the work needing to be done.
+
+**Specs must pass on pull requests for them to be considered.**
+
+### Running Specs
+Broadside has a lot of tests for most of its behaviors - just run
+```
+bundle exec rspec
+```
+in the broadside directory.  Don't open pull requests without passing specs.

data/lib/broadside/ecs/ecs_deploy.rb

@@ -152,7 +152,7 @@ module Broadside
         desired_count: scale,
         service: family,
         task_definition: task_definition_arn
-      }.deep_merge(@target.service_config || {}))
+      }.deep_merge(@target.service_config_for_update || {}))
 
       unless update_service_response.successful?
         raise EcsError, "Failed to update service:\n#{update_service_response.pretty_inspect}"

data/lib/broadside/target.rb

@@ -44,6 +44,14 @@ module Broadside
       record.errors.add(attr, 'is not an array of strings') unless val.is_a?(Array) && val.all? { |v| v.is_a?(String) }
     end
 
+    CREATE_ONLY_SERVICE_ATTRIBUTES = %i(
+      client_token
+      load_balancers
+      placement_constraints
+      placement_strategy
+      role
+    ).freeze
+
     def initialize(name, options = {})
       @name = name
 
@@ -93,5 +101,9 @@ module Broadside
         Cluster: @cluster
       }
     end
+
+    def service_config_for_update
+      service_config.try(:except, *CREATE_ONLY_SERVICE_ATTRIBUTES)
+    end
   end
 end

data/lib/broadside/version.rb

@@ -1,3 +1,3 @@
 module Broadside
-  VERSION = '3.0.4'.freeze
+  VERSION = '3.0.5'.freeze
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: broadside
 version: !ruby/object:Gem::Version
-  version: 3.0.4
+  version: 3.0.5
 platform: ruby
 authors:
 - Matthew Leung
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-02-26 00:00:00.000000000 Z
+date: 2017-03-01 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport