brightbox-cli 5.0.0.alpha → 5.0.0.rc2

data/spec/commands/sql/snapshots/show_spec.rb

@@ -8,21 +8,64 @@ describe "brightbox sql snapshots" do
 
     before do
       config = config_from_contents(USER_APP_CONFIG_CONTENTS)
-
-      # Setup in the VCR recordings
       cache_access_token(config, "f83da712e6299cda953513ec07f7a754f747d727")
     end
 
-    context "when resource exists", vcr: true do
+    context "without arguments" do
+      let(:argv) { %w[sql snapshots show] }
+
+      it "reports error" do
+        expect(stderr).to include("You must specify snapshot ids to show")
+        expect(stdout).to be_empty
+      end
+    end
+
+    context "with identifier argument" do
       let(:argv) { %w[sql snapshots show dbi-12345] }
+      let(:json_response) do
+        <<~EOS
+        {
+          "id": "dbi-12345",
+          "resource_type": "database_snapshot",
+          "url": "string",
+          "name": "string",
+          "description": "string",
+          "status": "creating",
+          "locked": true,
+          "database_engine": "string",
+          "database_version": "string",
+          "source": "string",
+          "source_trigger": "manual",
+          "size": 0,
+          "created_at": "2024-12-17T10:14:38.092Z",
+          "updated_at": "2024-12-17T10:14:38.092Z",
+          "deleted_at": "2024-12-17T10:14:38.092Z",
+          "account": {
+            "id": "acc-12345",
+            "resource_type": "account",
+            "url": "string",
+            "name": "string",
+            "description": "string",
+            "status": "pending"
+          },
+          "metadata": {
+            "labels": {}
+          }
+        }
+        EOS
+      end
 
-      it "does not output to stderr" do
-        expect(stderr).to eql("")
+      before do
+        stub_request(:get, "http://api.brightbox.localhost/1.0/database_snapshots/dbi-12345?account_id=acc-12345")
+          .to_return(status: 200, body: json_response)
       end
 
       it "outputs table details to stdout" do
-        expect(stdout).to_not be_empty
-        expect(stdout).to match(/dbi-12345/)
+        aggregate_failures do
+          expect(stderr).to be_empty unless ENV["DEBUG"]
+          expect(stdout).to_not be_empty
+          expect(stdout).to match(/dbi-12345/)
+        end
       end
     end
   end

data/spec/commands/users/show_spec.rb

@@ -6,11 +6,76 @@ describe "brightbox users" do
     let(:stdout) { output.stdout }
     let(:stderr) { output.stderr }
 
-    context "" do
+    before do
+      WebMock.reset!
+
+      config_from_contents(API_CLIENT_CONFIG_CONTENTS)
+      stub_client_token_request
+      Brightbox.config.reauthenticate
+    end
+
+    context "without arguments" do
       let(:argv) { %w[users show] }
 
       it "does not error" do
         expect { output }.to_not raise_error
+
+        aggregate_failures do
+          expect(stderr).to match("ERROR: You must specify user IDs to show")
+          expect(stdout).to be_empty
+        end
+      end
+    end
+
+    context "with identifier argument" do
+      let(:argv) { %w[users show usr-90781] }
+
+      before do
+        # FIXME: Two requests, one with the parameter and one without
+        #        One for ALL tests (with VCR breaking things)
+        #        One for this test standalone
+        stub_request(:get, "#{api_url}/1.0/users/usr-90781")
+          .to_return(
+            status: 200,
+            body: {
+              id: "usr-90781",
+              email_address: "user@domain.test",
+              accounts: [
+                {
+                  id: "acc-12345",
+                  name: "Test account"
+                }
+              ]
+            }.to_json
+          )
+
+        # Same again but supporting the account_id parameter
+        stub_request(:get, "#{api_url}/1.0/users/usr-90781")
+          .with(query: hash_including(account_id: "acc-12345"))
+          .to_return(
+            status: 200,
+            body: {
+              id: "usr-90781",
+              email_address: "user@domain.test",
+              accounts: [
+                {
+                  id: "acc-12345",
+                  name: "Test account"
+                }
+              ]
+            }.to_json
+          )
+      end
+
+      it "does not error" do
+        expect { output }.to_not raise_error
+
+        aggregate_failures do
+          expect(stderr).to match("")
+          expect(stderr).not_to match("ERROR")
+          expect(stdout).to match("usr-90781")
+          expect(stdout).to match("email_address: user@domain.test")
+        end
       end
     end
   end

data/spec/commands/volumes/attach_spec.rb

@@ -28,7 +28,7 @@ describe "brightbox volumes attach" do
     it "does not error" do
       expect { output }.to_not raise_error
 
-      expect(stderr).to eq("ERROR: You must specify the volume ID as the first argument\n")
+      expect(stderr).to include("ERROR: You must specify the volume ID as the first argument\n")
 
       expect(stdout).to match("")
     end
@@ -40,7 +40,7 @@ describe "brightbox volumes attach" do
     it "does not error" do
       expect { output }.to_not raise_error
 
-      expect(stderr).to eq("ERROR: You must specify the server ID to attach to as the second argument\n")
+      expect(stderr).to include("ERROR: You must specify the server ID to attach to as the second argument\n")
 
       expect(stdout).to match("")
     end
@@ -94,7 +94,7 @@ describe "brightbox volumes attach" do
     it "does not error" do
       expect { output }.to_not raise_error
 
-      expect(stderr).to eq("Attaching vol-809s1\n")
+      expect(stderr).to include("Attaching vol-809s1\n")
 
       aggregate_failures do
         expect(stdout).to match("vol-809s1")
@@ -153,7 +153,7 @@ describe "brightbox volumes attach" do
     it "does not error" do
       expect { output }.to_not raise_error
 
-      expect(stderr).to eq("Attaching vol-90328\n")
+      expect(stderr).to include("Attaching vol-90328\n")
 
       aggregate_failures do
         expect(stdout).to match("vol-90328")

data/spec/commands/volumes/copy_spec.rb

@@ -28,7 +28,7 @@ describe "brightbox volumes copy" do
     it "does not error" do
       expect { output }.to_not raise_error
 
-      expect(stderr).to eq("ERROR: You must specify the volume ID as the first argument\n")
+      expect(stderr).to include("ERROR: You must specify the volume ID as the first argument\n")
 
       expect(stdout).to match("")
     end
@@ -66,7 +66,7 @@ describe "brightbox volumes copy" do
     it "does not error" do
       expect { output }.to_not raise_error
 
-      expect(stderr).to eq("Copying vol-909ds\n")
+      expect(stderr).to include("Copying vol-909ds\n")
 
       expect(stdout).to match("vol-909ds")
     end

data/spec/commands/volumes/destroy_spec.rb

@@ -28,7 +28,7 @@ describe "brightbox volumes destroy" do
     it "does not error" do
       expect { output }.to_not raise_error
 
-      expect(stderr).to eq("ERROR: You must specify volume IDs as arguments\n")
+      expect(stderr).to include("ERROR: You must specify volume IDs as arguments\n")
 
       expect(stdout).to match("")
     end

data/spec/commands/volumes/detach_spec.rb

@@ -28,7 +28,7 @@ describe "brightbox volumes detach" do
     it "does not error" do
       expect { output }.to_not raise_error
 
-      expect(stderr).to eq("ERROR: You must specify volume IDs as arguments\n")
+      expect(stderr).to include("ERROR: You must specify volume IDs as arguments\n")
 
       expect(stdout).to match("")
     end

data/spec/commands/volumes/list_spec.rb

@@ -37,7 +37,7 @@ describe "brightbox volumes list" do
     it "does not error" do
       expect { output }.to_not raise_error
 
-      expect(stderr).to eq("")
+      expect(stderr).to be_empty unless ENV["DEBUG"]
 
       aggregate_failures do
         expect(stdout).to match("id.*type.*size.*status.*server.*boot")

data/spec/commands/volumes/resize_spec.rb

@@ -28,7 +28,7 @@ describe "brightbox volumes resize" do
     it "does not error" do
       expect { output }.to_not raise_error
 
-      expect(stderr).to eq("ERROR: You must specify the volume ID as the first argument\n")
+      expect(stderr).to include("ERROR: You must specify the volume ID as the first argument\n")
 
       expect(stdout).to match("")
     end
@@ -40,7 +40,7 @@ describe "brightbox volumes resize" do
     it "does not error" do
       expect { output }.to_not raise_error
 
-      expect(stderr).to eq("ERROR: A 'size' option is required\n")
+      expect(stderr).to include("ERROR: A 'size' option is required\n")
 
       expect(stdout).to match("")
     end
@@ -85,7 +85,7 @@ describe "brightbox volumes resize" do
     it "does not error" do
       expect { output }.to_not raise_error
 
-      expect(stderr).to eq("Resizing vol-op324\n")
+      expect(stderr).to include("Resizing vol-op324\n")
 
       aggregate_failures do
         expect(stdout).to match("vol-op324")

data/spec/commands/volumes/show_spec.rb

@@ -8,45 +8,27 @@ describe "brightbox volumes show" do
   let(:stderr) { output.stderr }
 
   before do
-    config_from_contents(API_CLIENT_CONFIG_CONTENTS)
-
-    stub_request(:post, "http://api.brightbox.localhost/token")
-      .to_return(
-        status: 200,
-        body: JSON.dump(
-          access_token: "ACCESS-TOKEN",
-          refresh_token: "REFRESH_TOKEN"
-        )
-      )
+    WebMock.reset!
 
+    config_from_contents(API_CLIENT_CONFIG_CONTENTS)
+    stub_client_token_request
     Brightbox.config.reauthenticate
   end
 
   context "without arguments" do
     let(:argv) { %w[volumes show] }
 
-    before do
-      stub_request(:get, "http://api.brightbox.localhost/1.0/volumes")
-        .with(query: hash_including(account_id: "acc-12345"))
-        .to_return(
-          status: 200,
-          body: volumes_response
-        )
-    end
-
-    it "does not error" do
+    it "reports missing IDs" do
       expect { output }.to_not raise_error
 
-      expect(stderr).to eq("")
-
       aggregate_failures do
-        expect(stdout).to match("id: vol-12345")
-        expect(stdout).to match("id: vol-abcde")
+        expect(stderr).to match("ERROR: You must specify volume IDs to show")
+        expect(stdout).to be_empty
       end
     end
   end
 
-  context "with identifier" do
+  context "with identifier argument" do
     let(:argv) { %w[volumes show vol-88878] }
 
     before do
@@ -92,4 +74,51 @@ describe "brightbox volumes show" do
       end
     end
   end
+
+  context "with multiple identifiers" do
+    let(:argv) { %w[volumes show vol-88878 vol-99999] }
+
+    before do
+      stub_request(:get, "http://api.brightbox.localhost/1.0/volumes/vol-88878")
+        .with(query: hash_including(account_id: "acc-12345"))
+        .to_return(
+          status: 200,
+          body: volume_response(
+            id: "vol-88878",
+            description: "A volume for testing",
+            filesystem_type: "ext4",
+            storage_type: "network",
+            size: 10_240,
+            status: "attached",
+            server: nil
+          )
+        )
+
+      stub_request(:get, "http://api.brightbox.localhost/1.0/volumes/vol-99999")
+        .with(query: hash_including(account_id: "acc-12345"))
+        .to_return(
+          status: 200,
+          body: volume_response(
+            id: "vol-99999",
+            description: "Another volume for testing",
+            filesystem_type: "ext4",
+            storage_type: "network",
+            size: 10_240,
+            status: "attached",
+            server: nil
+          )
+        )
+    end
+
+    it "does not error" do
+      expect { output }.to_not raise_error
+
+      expect(stderr).not_to match("ERROR")
+
+      aggregate_failures do
+        expect(stdout).to match("id: vol-88878")
+        expect(stdout).to match("id: vol-99999")
+      end
+    end
+  end
 end

data/spec/commands/volumes/update_spec.rb

@@ -28,7 +28,7 @@ describe "brightbox volumes update" do
     it "does not error" do
       expect { output }.to_not raise_error
 
-      expect(stderr).to eq("ERROR: You must specify the volume ID as the first argument\n")
+      expect(stderr).to include("ERROR: You must specify the volume ID as the first argument\n")
 
       expect(stdout).to match("")
     end
@@ -82,7 +82,7 @@ describe "brightbox volumes update" do
     it "does not error" do
       expect { output }.to_not raise_error
 
-      expect(stderr).to eq("Updating vol-908us\n")
+      expect(stderr).to include("Updating vol-908us\n")
 
       aggregate_failures do
         expect(stdout).to match("vol-908us")
@@ -129,7 +129,7 @@ describe "brightbox volumes update" do
     it "does not error" do
       expect { output }.to_not raise_error
 
-      expect(stderr).to eq("Updating vol-kl234\n")
+      expect(stderr).to include("Updating vol-kl234\n")
 
       aggregate_failures do
         expect(stdout).to match("vol-kl234")
@@ -176,7 +176,7 @@ describe "brightbox volumes update" do
     it "does not error" do
       expect { output }.to_not raise_error
 
-      expect(stderr).to eq("Updating vol-sdj2j\n")
+      expect(stderr).to include("Updating vol-sdj2j\n")
 
       aggregate_failures do
         expect(stdout).to match("vol-sdj2j")

data/spec/spec_helper.rb

@@ -1,9 +1,22 @@
+require "simplecov"
+
+SimpleCov.start do
+  add_filter "/spec/"
+  add_filter "/config/"
+  add_filter "/vendor/"
+
+  track_files "{lib}/**/*.rb"
+
+  # Currently just above 75% coverage - don't make it worse
+  minimum_coverage 75
+  refuse_coverage_drop
+end
+
 LIB_DIR = File.expand_path(File.join(File.dirname(__FILE__), "..", "lib"))
 
 $LOAD_PATH.unshift LIB_DIR unless
   $LOAD_PATH.include?(LIB_DIR) || $LOAD_PATH.include?(File.expand_path(LIB_DIR))
 
-require "simplecov"
 require "brightbox_cli"
 require "json"
 require "tmpdir"
@@ -31,15 +44,6 @@ Fog.timeout = 10
 
 require "fog/brightbox"
 
-SimpleCov.start do
-  add_filter "/spec/"
-  add_filter "/config/"
-  add_filter "/vendor/"
-end
-
-# Currently just above 80% coverage - don't make it worse
-SimpleCov.minimum_coverage 80
-
 RSpec.configure do |config|
   config.include CommonHelpers
   config.include ConfigHelpers

data/spec/support/shared/api_resource_examples.rb

@@ -9,7 +9,32 @@ shared_examples "a wrapped API resource" do
   it { is_expected.to respond_to(:to_row) }
 
   it { is_expected.to respond_to(:to_s) }
+
   it "#to_s equals the #id" do
     expect(subject.to_s).to eql(subject.id)
   end
+
+  # describe "#attributes" do
+  #   subject { described_class.new(fog_model) }
+
+  #   let(:fog_model) do
+  #     double("Fog::Model", id: "res-12345", attributes: { id: "res-12345"})
+  #   end
+
+  #   it "returns an IndifferentAccessHash" do
+  #     expect(subject.attributes).to be_a(IndifferentAccessHash)
+  #   end
+  # end
+
+  # describe "#to_row" do
+  #   subject { described_class.new(fog_model) }
+
+  #   let(:fog_model) do
+  #     double("Fog::Model", id: "res-12345", attributes: { id: "res-12345"})
+  #   end
+
+  #   it "returns a Hash to avoid hirb errors" do
+  #     expect(subject.to_row).to be_a(Hash)
+  #   end
+  # end
 end

data/spec/unit/brightbox/account/attributes_spec.rb

@@ -0,0 +1,13 @@
+require "spec_helper"
+
+RSpec.describe Brightbox::Account, "#attributes" do
+  subject { described_class.new(fog_model) }
+
+  let(:fog_model) do
+    double("Fog::Model", id: "res-12345", attributes: { id: "res-12345"})
+  end
+
+  it "returns an IndifferentAccessHash" do
+    expect(subject.attributes).to be_a(IndifferentAccessHash)
+  end
+end

data/spec/unit/brightbox/api/attributes_spec.rb

@@ -0,0 +1,65 @@
+require "spec_helper"
+
+RSpec.describe Brightbox::Api, "#attributes" do
+  subject(:model_attributes) { api_model.attributes }
+
+  let(:api_model) { Brightbox::Api.new(fog_model) }
+  let(:fog_model) do
+    double(
+      "Fog::Compute::Brightbox::Api",
+      id: "res-12345",
+      attributes: attributes
+    )
+  end
+
+  context "when attributes are not set" do
+    let(:attributes) { nil }
+
+    it "returns an indifferent access hash" do
+      expect(model_attributes).to be_instance_of(IndifferentAccessHash)
+    end
+  end
+
+  context "when attributes are set with a mix of string and symbols" do
+    let(:attributes) do
+      {
+        id: "res-12345",
+        name: "test",
+        acme: acme_details
+      }
+    end
+    let(:acme_details) do
+      {
+        "domains" => [
+          {
+            "identifier" => "example.test",
+            "status" => "pending"
+          }
+        ]
+      }
+    end
+
+    it "transforms the keys with deep symbolize" do
+      expect(model_attributes).to eq(
+        id: "res-12345",
+        name: "test",
+        acme: {
+          domains: [
+            {
+              identifier: "example.test",
+              status: "pending"
+            }
+          ]
+        }
+      )
+    end
+
+    it "can accessed by string keys" do
+      expect(model_attributes["acme"]["domains"].first["identifier"]).to eq("example.test")
+    end
+
+    it "can accessed by symbol keys" do
+      expect(model_attributes[:acme][:domains].first[:identifier]).to eq("example.test")
+    end
+  end
+end

data/spec/unit/brightbox/api/fog_attributes_spec.rb

@@ -0,0 +1,65 @@
+require "spec_helper"
+
+RSpec.describe Brightbox::Api, "#fog_attributes" do
+  subject(:model_attributes) { api_model.fog_attributes }
+
+  let(:api_model) { Brightbox::Api.new(fog_model) }
+  let(:fog_model) do
+    double(
+      "Fog::Compute::Brightbox::Api",
+      id: "res-12345",
+      attributes: attributes
+    )
+  end
+
+  context "when attributes are not set" do
+    let(:attributes) { nil }
+
+    it "returns an indifferent access hash" do
+      expect(model_attributes).to be_instance_of(IndifferentAccessHash)
+    end
+  end
+
+  context "when attributes are set with a mix of string and symbols" do
+    let(:attributes) do
+      {
+        id: "res-12345",
+        name: "test",
+        acme: acme_details
+      }
+    end
+    let(:acme_details) do
+      {
+        "domains" => [
+          {
+            "identifier" => "example.test",
+            "status" => "pending"
+          }
+        ]
+      }
+    end
+
+    it "transforms the keys with deep symbolize" do
+      expect(model_attributes).to eq(
+        id: "res-12345",
+        name: "test",
+        acme: {
+          domains: [
+            {
+              identifier: "example.test",
+              status: "pending"
+            }
+          ]
+        }
+      )
+    end
+
+    it "can not accessed by string keys" do
+      expect(model_attributes["acme"]["domains"].first["identifier"]).to eq("example.test")
+    end
+
+    it "can accessed by symbol keys" do
+      expect(model_attributes[:acme][:domains].first[:identifier]).to eq("example.test")
+    end
+  end
+end

data/spec/unit/brightbox/cloud_ip/attributes_spec.rb

@@ -0,0 +1,19 @@
+require "spec_helper"
+
+RSpec.describe Brightbox::CloudIP, "#attributes" do
+  subject { described_class.new(fog_model) }
+
+  let(:fog_model) do
+    double(
+      "Fog::Model",
+      id: "cip-12345",
+      destination_id: nil,
+      attributes: model_attributes
+    )
+  end
+  let(:model_attributes) { { id: "cip-12345" } }
+
+  it "returns an IndifferentAccessHash" do
+    expect(subject.attributes).to be_a(IndifferentAccessHash)
+  end
+end

data/spec/unit/brightbox/collaborating_account/attributes_spec.rb

@@ -0,0 +1,13 @@
+require "spec_helper"
+
+RSpec.describe Brightbox::CollaboratingAccount, "#attributes" do
+  subject { described_class.new(fog_model) }
+
+  let(:fog_model) do
+    double("Fog::Model", id: "res-12345", attributes: { id: "res-12345"})
+  end
+
+  it "returns an IndifferentAccessHash" do
+    expect(subject.attributes).to be_a(IndifferentAccessHash)
+  end
+end

data/spec/unit/brightbox/database_server/attributes_spec.rb

@@ -0,0 +1,13 @@
+require "spec_helper"
+
+RSpec.describe Brightbox::DatabaseServer, "#attributes" do
+  subject { described_class.new(fog_model) }
+
+  let(:fog_model) do
+    double("Fog::Model", id: "res-12345", attributes: { id: "res-12345"})
+  end
+
+  it "returns an IndifferentAccessHash" do
+    expect(subject.attributes).to be_a(IndifferentAccessHash)
+  end
+end

data/spec/unit/brightbox/database_snapshot/attributes_spec.rb

@@ -0,0 +1,13 @@
+require "spec_helper"
+
+RSpec.describe Brightbox::DatabaseSnapshot, "#attributes" do
+  subject { described_class.new(fog_model) }
+
+  let(:fog_model) do
+    double("Fog::Model", id: "res-12345", attributes: { id: "res-12345"})
+  end
+
+  it "returns an IndifferentAccessHash" do
+    expect(subject.attributes).to be_a(IndifferentAccessHash)
+  end
+end