brightbox-cli 4.3.1 → 4.4.0

data/spec/commands/cloudips/update_spec.rb

@@ -1,82 +1,162 @@
 require "spec_helper"
 
-describe "brightbox cloudips" do
-  describe "update" do
-    let(:output) { FauxIO.new { Brightbox.run(argv) } }
-    let(:stdout) { output.stdout }
-    let(:stderr) { output.stderr }
+describe "brightbox cloudips update" do
+  let(:output) { FauxIO.new { Brightbox.run(argv) } }
+  let(:stdout) { output.stdout }
+  let(:stderr) { output.stderr }
 
-    before do
-      config_from_contents(USER_APP_CONFIG_CONTENTS)
+  before do
+    config_from_contents(API_CLIENT_CONFIG_CONTENTS)
+
+    stub_request(:post, "http://api.brightbox.localhost/token")
+      .to_return(
+        status: 200,
+        body: JSON.dump(
+          access_token: "ACCESS-TOKEN",
+          refresh_token: "REFRESH_TOKEN"
+        )
+      )
+
+    Brightbox.config.reauthenticate
+  end
+
+  context "" do
+    let(:argv) { %w[cloudips update] }
 
-      stub_request(:post, "http://api.brightbox.localhost/token")
-        .to_return(status: 200, body: JSON.dump(access_token: "ACCESS-TOKEN", refresh_token: "REFRESH-TOKEN"))
+    it "does not error" do
+      expect { output }.to_not raise_error
     end
+  end
 
-    context "" do
-      let(:argv) { %w[cloudips update] }
+  context "when name is updated" do
+    let(:argv) { ["cloudips", "update", "--name=#{new_name}", "cip-12345"] }
 
-      it "does not error" do
-        expect { output }.to_not raise_error
-      end
+    let(:json_response) do
+      <<-EOS
+      {
+        "id":"cip-12345",
+        "name":"#{new_name}"
+      }
+      EOS
     end
 
-    context "when name is updated" do
-      let(:argv) { ["cloudips", "update", "--name=#{new_name}", "cip-12345"] }
+    context "--name 'New name'" do
+      let(:new_name) { "New name" }
+      let(:expected_args) { ["cip-12345", { :name => new_name }] }
+
+      before do
+        stub_request(:put, "http://api.brightbox.localhost/1.0/cloud_ips/cip-12345?account_id=acc-12345")
+          .with(:headers => { "Content-Type" => "application/json" },
+                :body => {
+                  name: "New name"
+                })
+          .and_return(:status => 200, :body => json_response)
 
-      let(:json_response) do
-        <<-EOS
-        {
-          "id":"cip-12345",
-          "name":"#{new_name}"
-        }
-        EOS
+        stub_request(:get, "http://api.brightbox.localhost/1.0/cloud_ips/cip-12345?account_id=acc-12345")
+          .with(:headers => { "Content-Type" => "application/json" })
+          .and_return(:status => 200, :body => json_response)
       end
 
-      context "--name 'New name'" do
-        let(:new_name) { "New name" }
-        let(:expected_args) { ["cip-12345", { :name => new_name }] }
-
-        before do
-          stub_request(:put, "http://api.brightbox.localhost/1.0/cloud_ips/cip-12345?account_id=acc-12345")
-            .with(:headers => { "Content-Type" => "application/json" },
-                  :body => hash_including("name" => "New name"))
-            .and_return(:status => 200, :body => json_response)
-
-          stub_request(:get, "http://api.brightbox.localhost/1.0/cloud_ips/cip-12345?account_id=acc-12345")
-            .with(:headers => { "Content-Type" => "application/json" })
-            .and_return(:status => 200, :body => json_response)
-        end
-
-        it "puts new name in update" do
-          expect(Brightbox::CloudIP.conn).to receive(:update_cloud_ip).with(*expected_args).and_call_original
-          expect(stderr).to eq("")
-          expect(stdout).to include("cip-12345")
-          expect(stdout).to include("New name")
-        end
+      it "puts new name in update" do
+        expect(Brightbox::CloudIP.conn).to receive(:update_cloud_ip).with(*expected_args).and_call_original
+        expect(stderr).to eq("")
+        expect(stdout).to include("cip-12345")
+        expect(stdout).to include("New name")
       end
+    end
+
+    context "--name ''" do
+      let(:new_name) { "" }
+      let(:expected_args) { ["cip-12345", { :name => "" }] }
 
-      context "--name ''" do
-        let(:new_name) { "" }
-        let(:expected_args) { ["cip-12345", { :name => "" }] }
-
-        before do
-          stub_request(:put, "http://api.brightbox.localhost/1.0/cloud_ips/cip-12345?account_id=acc-12345")
-            .with(:headers => { "Content-Type" => "application/json" },
-                  :body => hash_including("name" => ""))
-            .and_return(:status => 200, :body => json_response)
-
-          stub_request(:get, "http://api.brightbox.localhost/1.0/cloud_ips/cip-12345?account_id=acc-12345")
-            .with(:headers => { "Content-Type" => "application/json" })
-            .and_return(:status => 200, :body => json_response)
-        end
-
-        it "puts new name in update" do
-          expect(Brightbox::CloudIP.conn).to receive(:update_cloud_ip).with(*expected_args).and_call_original
-          expect(stderr).to eq("")
-          expect(stdout).to include("cip-12345")
-        end
+      before do
+        stub_request(:put, "http://api.brightbox.localhost/1.0/cloud_ips/cip-12345?account_id=acc-12345")
+          .with(:headers => { "Content-Type" => "application/json" },
+                :body => hash_including("name" => ""))
+          .and_return(:status => 200, :body => json_response)
+
+        stub_request(:get, "http://api.brightbox.localhost/1.0/cloud_ips/cip-12345?account_id=acc-12345")
+          .with(:headers => { "Content-Type" => "application/json" })
+          .and_return(:status => 200, :body => json_response)
+      end
+
+      it "puts new name in update" do
+        expect(Brightbox::CloudIP.conn).to receive(:update_cloud_ip).with(*expected_args).and_call_original
+        expect(stderr).to eq("")
+        expect(stdout).to include("cip-12345")
       end
     end
   end
+
+  context "--reverse-dns" do
+    let(:argv) { ["cloudips", "update", "--reverse-dns", "domain.example", "cip-dfsa3"] }
+
+    let(:json_response) do
+      <<-EOS
+      {
+        "id":"cip-dfsa3",
+        "reverse_dns":"domain.example"
+      }
+      EOS
+    end
+
+    before do
+      stub_request(:put, "http://api.brightbox.localhost/1.0/cloud_ips/cip-dfsa3?account_id=acc-12345")
+        .with(:headers => { "Content-Type" => "application/json" },
+              :body => {
+                reverse_dns: "domain.example"
+              })
+        .and_return(:status => 200, :body => json_response)
+
+      stub_request(:get, "http://api.brightbox.localhost/1.0/cloud_ips/cip-dfsa3?account_id=acc-12345")
+        .with(:headers => { "Content-Type" => "application/json" })
+        .and_return(:status => 200, :body => json_response)
+    end
+
+    it "puts new name in update" do
+      expect(stderr).to eq("")
+      expect(stdout).to include("cip-dfsa3")
+      expect(stdout).to include("domain.example")
+    end
+  end
+
+  context "--delete-reverse-dns" do
+    let(:argv) { ["cloudips", "update", "--delete-reverse-dns", "cip-dfsa3"] }
+
+    let(:json_response) do
+      <<-EOS
+      {
+        "id":"cip-dfsa3",
+        "reverse_dns":""
+      }
+      EOS
+    end
+
+    before do
+      stub_request(:put, "http://api.brightbox.localhost/1.0/cloud_ips/cip-dfsa3?account_id=acc-12345")
+        .with(:headers => { "Content-Type" => "application/json" },
+              :body => {
+                reverse_dns: ""
+              })
+        .and_return(:status => 200, :body => json_response)
+
+      stub_request(:get, "http://api.brightbox.localhost/1.0/cloud_ips/cip-dfsa3?account_id=acc-12345")
+        .with(:headers => { "Content-Type" => "application/json" })
+        .and_return(:status => 200, :body => json_response)
+    end
+
+    it "puts new name in update" do
+      expect(stderr).to eq("")
+      expect(stdout).to include("cip-dfsa3")
+    end
+  end
+
+  context "--reverse-dns and --delete-reverse-dns options" do
+    let(:argv) { ["cloudips", "update", "--reverse-dns", "domain.example", "--delete-reverse-dns", "cip-dfsa3"] }
+
+    it "puts new name in update" do
+      expect(stderr).to eq("ERROR: You must either specify a reverse DNS record or --delete-reverse-dns\n")
+      expect(stdout).to eq("")
+    end
+  end
 end

data/spec/commands/configmaps/create_spec.rb

@@ -0,0 +1,257 @@
+require "spec_helper"
+
+describe "brightbox configmaps create" do
+  let(:output) { FauxIO.new { Brightbox.run(argv) } }
+  let(:stdout) { output.stdout }
+  let(:stderr) { output.stderr }
+
+  let(:token) { SecureRandom.hex }
+
+  before do
+    config_from_contents(API_CLIENT_CONFIG_CONTENTS)
+
+    stub_request(:post, "http://api.brightbox.localhost/token")
+      .to_return(status: 200, body: JSON.dump(access_token: token))
+
+    Brightbox.config.reauthenticate
+  end
+
+  context "without options" do
+    let(:argv) { %w[configmaps create] }
+
+    it "does not error" do
+      expect { output }.to_not raise_error
+
+      expect(stderr).to match("Config map data is required as 'data' option")
+
+      expect(stdout).to eq("")
+    end
+  end
+
+  context "with 'name' and 'data'" do
+    let(:argv) { ["configmaps", "create", "--name", "tester", "--data", payload] }
+    let(:payload) { { key: "value" }.to_json }
+
+    before do
+      stub_request(:post, "http://api.brightbox.localhost/1.0/config_maps")
+        .with(headers: { "Content-Type" => "application/json" },
+              query: hash_including(account_id: "acc-12345"),
+              body: {
+                name: "tester",
+                data: {
+                  key: "value"
+                }
+              })
+        .to_return(
+          status: 200,
+          body: {
+            id: "cfg-lk342",
+            name: "tester",
+            data: {
+              key: "value"
+            }
+          }.to_json
+        )
+    end
+
+    it "does not error" do
+      expect { output }.to_not raise_error
+
+      expect(stderr).not_to match("ERROR")
+
+      aggregate_failures do
+        expect(stdout).to match("id.*name")
+
+        expect(stdout).to match("cfg-lk342")
+      end
+    end
+  end
+
+  context "with 'data'" do
+    let(:argv) { ["configmaps", "create", "--data", payload] }
+    let(:payload) { { key: "value" }.to_json }
+
+    before do
+      stub_request(:post, "http://api.brightbox.localhost/1.0/config_maps")
+        .with(headers: { "Content-Type" => "application/json" },
+              query: hash_including(account_id: "acc-12345"),
+              body: {
+                data: {
+                  key: "value"
+                }
+              }.to_json)
+        .to_return(
+          status: 200,
+          body: {
+            id: "cfg-lk342",
+            data: {
+              key: "value"
+            }
+          }.to_json
+        )
+    end
+
+    it "does not error" do
+      expect { output }.to_not raise_error
+
+      expect(stderr).not_to match("ERROR")
+
+      aggregate_failures do
+        expect(stdout).to match("id.*name")
+
+        expect(stdout).to match("cfg-lk342")
+      end
+    end
+
+    context "with invalid update" do
+      let(:payload) { "Not JSON!" }
+
+      it "does not error" do
+        expect { output }.to_not raise_error
+
+        expect(stderr).to eq("ERROR: Config map data was not valid JSON\n")
+
+        expect(stdout).to eq("")
+      end
+    end
+  end
+
+  context "with new map from 'data-file'" do
+    context "when filename is used" do
+      let(:argv) { ["configmaps", "create", "--data-file", data_file.path] }
+      let(:data_file) { Tempfile.open("config_map_test_data") }
+
+      around do |example|
+        data_file.write(payload)
+        data_file.close
+
+        example.run
+
+        data_file.unlink
+      end
+
+      context "with valid update" do
+        let(:payload) { { new_key: "new setting" }.to_json }
+
+        before do
+          stub_request(:post, "http://api.brightbox.localhost/1.0/config_maps")
+            .with(query: hash_including(account_id: "acc-12345"),
+                  body: {
+                    data: {
+                      new_key: "new setting"
+                    }
+                  })
+            .to_return(
+              status: 200,
+              body: {
+                id: "cfg-s432l",
+                name: "",
+                data: {
+                  new_key: "new setting"
+                }
+              }.to_json
+            )
+        end
+
+        it "does not error" do
+          expect { output }.to_not raise_error
+
+          expect(stderr).to eq("Creating config map\n")
+
+          aggregate_failures do
+            expect(stdout).to match("cfg-s432l")
+          end
+        end
+
+        context "with invalid update" do
+          let(:payload) { "Not JSON!" }
+
+          it "does not error" do
+            expect { output }.to_not raise_error
+
+            expect(stderr).to eq("ERROR: Config map data was not valid JSON\n")
+
+            expect(stdout).to eq("")
+          end
+        end
+      end
+    end
+  end
+
+  context "when '-' is used for STDIN" do
+    let(:argv) { ["configmaps", "create", "--data-file", "-", "cfg-stdin"] }
+
+    before do
+      stdin_data = StringIO.new
+      stdin_data.puts(payload)
+      stdin_data.rewind
+
+      $stdin = stdin_data
+    end
+
+    after do
+      $stdin = STDIN
+    end
+
+    context "with valid update" do
+      let(:payload) { { use_stdin: true }.to_json }
+
+      before do
+        stub_request(:post, "http://api.brightbox.localhost/1.0/config_maps")
+          .with(query: hash_including(account_id: "acc-12345"),
+                body: {
+                  data: {
+                    use_stdin: true
+                  }
+                })
+          .to_return(
+            status: 200,
+            body: {
+              id: "cfg-mj53s",
+              name: "",
+              data: {
+                use_stdin: true
+              }
+            }.to_json
+          )
+      end
+
+      it "does not error" do
+        expect { output }.to_not raise_error
+
+        expect(stderr).to eq("Creating config map\n")
+
+        aggregate_failures do
+          expect(stdout).to match("cfg-mj53s")
+        end
+      end
+
+      context "with invalid update" do
+        let(:payload) { "Not JSON!" }
+
+        it "does not error" do
+          expect { output }.to_not raise_error
+
+          expect(stderr).to eq("ERROR: Config map data was not valid JSON\n")
+
+          expect(stdout).to eq("")
+        end
+      end
+    end
+  end
+
+  context "with mutually exclusive data options" do
+    let(:argv) { ["configmaps", "create", "--data", payload, "--data-file", "-"] }
+    let(:payload) { { new_key: "new value" }.to_json }
+
+    context "with invalid update" do
+      it "does not error" do
+        expect { output }.to_not raise_error
+
+        expect(stderr).to eq("ERROR: Config map data can only be passed by either 'data' or 'data-file'\n")
+
+        expect(stdout).to eq("")
+      end
+    end
+  end
+end

data/spec/commands/configmaps/destroy_spec.rb

@@ -0,0 +1,156 @@
+require "spec_helper"
+
+describe "brightbox configmaps destroy" do
+  let(:output) { FauxIO.new { Brightbox.run(argv) } }
+  let(:stdout) { output.stdout }
+  let(:stderr) { output.stderr }
+
+  before do
+    config_from_contents(API_CLIENT_CONFIG_CONTENTS)
+
+    stub_request(:post, "http://api.brightbox.localhost/token")
+      .to_return(
+        status: 200,
+        body: JSON.dump(
+          access_token: "ACCESS-TOKEN",
+          refresh_token: "REFRESH_TOKEN"
+        )
+      )
+
+    Brightbox.config.reauthenticate
+  end
+
+  context "without arguments" do
+    let(:argv) { %w[configmaps destroy] }
+
+    it "does not error" do
+      expect { output }.to_not raise_error
+
+      expect(stderr).to eq("ERROR: You must specify config map IDs as arguments\n")
+
+      expect(stdout).to match("")
+    end
+  end
+
+  context "with one argument" do
+    let(:argv) { %w[configmaps destroy cfg-xdwe2] }
+
+    before do
+      stub_request(:get, "http://api.brightbox.localhost/1.0/config_maps/cfg-xdwe2")
+        .with(query: hash_including(account_id: "acc-12345"))
+        .to_return(
+          status: 200,
+          body: {
+            id: "cfg-xdwe2"
+          }.to_json
+        )
+        .to_return(
+          status: 200,
+          body: {
+            id: "cfg-xdwe2"
+          }.to_json
+        )
+
+      stub_request(:delete, "http://api.brightbox.localhost/1.0/config_maps/cfg-xdwe2")
+        .with(query: hash_including(account_id: "acc-12345"))
+        .to_return(
+          status: 202,
+          body: {
+            id: "cfg-xdwe2"
+          }.to_json
+        )
+    end
+
+    it "does not error" do
+      expect { output }.to_not raise_error
+
+      expect(stderr).to match("Destroying cfg-xdwe2\n")
+
+      expect(stdout).to eq("")
+    end
+  end
+
+  context "with multiple arguments" do
+    let(:argv) { %w[configmaps destroy cfg-12ds4 cfg-vf567] }
+
+    before do
+      stub_request(:get, "http://api.brightbox.localhost/1.0/config_maps/cfg-12ds4")
+        .with(query: hash_including(account_id: "acc-12345"))
+        .to_return(
+          status: 200,
+          body: {
+            id: "cfg-12ds4"
+          }.to_json
+        )
+        .to_return(
+          status: 200,
+          body: {
+            id: "cfg-12ds4"
+          }.to_json
+        )
+
+      stub_request(:delete, "http://api.brightbox.localhost/1.0/config_maps/cfg-12ds4")
+        .with(query: hash_including(account_id: "acc-12345"))
+        .to_return(
+          status: 200,
+          body: {
+            id: "cfg-12ds4"
+          }.to_json
+        )
+
+      stub_request(:get, "http://api.brightbox.localhost/1.0/config_maps/cfg-vf567")
+        .with(query: hash_including(account_id: "acc-12345"))
+        .to_return(
+          status: 200,
+          body: {
+            id: "cfg-vf567"
+          }.to_json
+        )
+        .to_return(
+          status: 200,
+          body: {
+            id: "cfg-vf567"
+          }.to_json
+        )
+
+      stub_request(:delete, "http://api.brightbox.localhost/1.0/config_maps/cfg-vf567")
+        .with(query: hash_including(account_id: "acc-12345"))
+        .to_return(
+          status: 200,
+          body: {
+            id: "cfg-vf567"
+          }.to_json
+        )
+    end
+
+    it "does not error" do
+      expect { output }.to_not raise_error
+
+      expect(stderr).to match("Destroying cfg-12ds4\n")
+      expect(stderr).to match("Destroying cfg-vf567\n")
+
+      expect(stdout).to eq("")
+    end
+  end
+
+  context "with unknown argument" do
+    let(:argv) { %w[configmaps destroy cfg-lk234] }
+
+    before do
+      stub_request(:get, "http://api.brightbox.localhost/1.0/config_maps/cfg-lk234")
+        .with(query: hash_including(account_id: "acc-12345"))
+        .to_return(
+          status: 404,
+          body: ""
+        )
+    end
+
+    it "does not error" do
+      expect { output }.to_not raise_error
+
+      expect(stderr).to match("Couldn't find cfg-lk234\n")
+
+      expect(stdout).to eq("")
+    end
+  end
+end