brightbox-cli 3.3.0 → 4.0.0.rc2

data/spec/commands/images/list_spec.rb

@@ -1,7 +1,6 @@
 require "spec_helper"
 
 describe "brightbox images" do
-
   describe "list" do
     let(:output) { FauxIO.new { Brightbox.run(argv) } }
     let(:stdout) { output.stdout }
@@ -10,68 +9,68 @@ describe "brightbox images" do
     before do
       config_from_contents(USER_APP_CONFIG_CONTENTS)
 
-      stub_request(:post, "http://api.brightbox.dev/token").
-        to_return(status: 200, body: JSON.dump(access_token: "ACCESS-TOKEN", refresh_token: "REFRESH-TOKEN"))
+      stub_request(:post, "http://api.brightbox.localhost/token")
+        .to_return(status: 200, body: JSON.dump(access_token: "ACCESS-TOKEN", refresh_token: "REFRESH-TOKEN"))
 
       image_listing_json = JSON.dump([
-        {
-          id: "img-test1",
-          name: "Official image",
-          status: "available",
-          official: true,
-          public: true,
-          source_type: "upload",
-          owner: "acc-99999"
-        },
-        {
-          id: "img-test2",
-          name: "Public image",
-          status: "available",
-          official: false,
-          public: true,
-          source_type: "upload",
-          owner: "acc-abcde"
-        },
-        {
-          id: "img-test3",
-          name: "Customer image",
-          status: "available",
-          official: false,
-          public: false,
-          source_type: "upload",
-          owner: "acc-12345"
-        },
-        {
-          id: "img-test4",
-          name: "Customer snapshot",
-          status: "available",
-          official: false,
-          public: false,
-          source_type: "snapshot",
-          owner: "acc-12345"
-        },
-        {
-          id: "img-test5",
-          name: "Customer deleting image",
-          status: "deleting",
-          official: false,
-          public: false,
-          source_type: "upload",
-          owner: "acc-12345"
-        }
-      ])
-
-      stub_request(:get, "http://api.brightbox.dev/1.0/images?account_id=acc-12345").
-        with(headers: { "Authorization" => "Bearer ACCESS-TOKEN" }).
-        to_return(status: 200, body: image_listing_json)
-
-      stub_request(:get, "http://api.brightbox.dev/1.0/account?account_id=acc-12345&nested=false").
-        with(headers: { "Authorization" => "Bearer ACCESS-TOKEN" }).
-        to_return(status: 200, body: JSON.dump({ id: "acc-12345" }))
+                                       {
+                                         id: "img-test1",
+                                         name: "Official image",
+                                         status: "available",
+                                         official: true,
+                                         public: true,
+                                         source_type: "upload",
+                                         owner: "acc-99999"
+                                       },
+                                       {
+                                         id: "img-test2",
+                                         name: "Public image",
+                                         status: "available",
+                                         official: false,
+                                         public: true,
+                                         source_type: "upload",
+                                         owner: "acc-abcde"
+                                       },
+                                       {
+                                         id: "img-test3",
+                                         name: "Customer image",
+                                         status: "available",
+                                         official: false,
+                                         public: false,
+                                         source_type: "upload",
+                                         owner: "acc-12345"
+                                       },
+                                       {
+                                         id: "img-test4",
+                                         name: "Customer snapshot",
+                                         status: "available",
+                                         official: false,
+                                         public: false,
+                                         source_type: "snapshot",
+                                         owner: "acc-12345"
+                                       },
+                                       {
+                                         id: "img-test5",
+                                         name: "Customer deleting image",
+                                         status: "deleting",
+                                         official: false,
+                                         public: false,
+                                         source_type: "upload",
+                                         owner: "acc-12345"
+                                       }
+                                     ])
+
+      stub_request(:get, "http://api.brightbox.localhost/1.0/images?account_id=acc-12345")
+        .with(headers: { "Authorization" => "Bearer ACCESS-TOKEN" })
+        .to_return(status: 200, body: image_listing_json)
+
+      stub_request(:get, "http://api.brightbox.localhost/1.0/account?account_id=acc-12345&nested=false")
+        .with(headers: { "Authorization" => "Bearer ACCESS-TOKEN" })
+        .to_return(status: 200, body: JSON.dump({ id: "acc-12345" }))
     end
 
     context "when default listing" do
-      let(:argv) { %w(images list) }
+      let(:argv) { %w[images list] }
 
       it "does not error" do
         expect(stderr).not_to include("ERROR")
@@ -85,7 +84,7 @@ describe "brightbox images" do
     end
 
     context "when listing all cases" do
-      let(:argv) { %w(images list --show-all) }
+      let(:argv) { %w[images list --show-all] }
 
       it "does not error" do
         expect(stderr).not_to include("ERROR")
@@ -99,7 +98,7 @@ describe "brightbox images" do
     end
 
     context "when filtering by status" do
-      let(:argv) { %w(images list --status deleting) }
+      let(:argv) { %w[images list --status deleting] }
 
       it "does not error" do
         expect(stderr).not_to include("ERROR")
@@ -113,7 +112,7 @@ describe "brightbox images" do
     end
 
     context "when filtering by type" do
-      let(:argv) { %w(images list --type snapshot) }
+      let(:argv) { %w[images list --type snapshot] }
 
       it "does not error" do
         expect(stderr).not_to include("ERROR")
@@ -127,7 +126,7 @@ describe "brightbox images" do
     end
 
     context "when filtering by own account ID" do
-      let(:argv) { %w(images list --account acc-12345) }
+      let(:argv) { %w[images list --account acc-12345] }
 
       it "does not error" do
         expect(stderr).not_to include("ERROR")
@@ -141,7 +140,7 @@ describe "brightbox images" do
     end
 
     context "when filter by own account ID and all" do
-      let(:argv) { %w(images list --account acc-12345 --show-all) }
+      let(:argv) { %w[images list --account acc-12345 --show-all] }
 
       it "does not error" do
         expect(stderr).not_to include("ERROR")

data/spec/commands/images/locking_spec.rb

@@ -19,7 +19,7 @@ describe "brightbox images" do
 
   describe "lock" do
     context "when resource is known" do
-      let(:argv) { %w(images lock img-12345) }
+      let(:argv) { %w[images lock img-12345] }
 
       before do
         expect(resource_class).to receive(:find_or_call).with(resource_ids).and_return(results)
@@ -32,7 +32,7 @@ describe "brightbox images" do
     end
 
     context "when resource is unknown" do
-      let(:argv) { %w(images lock img-12345) }
+      let(:argv) { %w[images lock img-12345] }
 
       before do
         expect(resource_class).to receive(:find).with(resource_id).and_raise(Brightbox::Api::NotFound)
@@ -46,7 +46,7 @@ describe "brightbox images" do
 
   describe "unlock" do
     context "when resource is known" do
-      let(:argv) { %w(images unlock img-12345) }
+      let(:argv) { %w[images unlock img-12345] }
 
       before do
         expect(resource_class).to receive(:find_or_call).with(resource_ids).and_return(results)
@@ -59,7 +59,7 @@ describe "brightbox images" do
     end
 
     context "when resource is unknown" do
-      let(:argv) { %w(images unlock img-12345) }
+      let(:argv) { %w[images unlock img-12345] }
 
       before do
         expect(resource_class).to receive(:find).with(resource_id).and_raise(Brightbox::Api::NotFound)

data/spec/commands/images/register_spec.rb

@@ -1,17 +1,103 @@
 require "spec_helper"
 
 describe "brightbox images" do
-
   describe "register" do
     let(:output) { FauxIO.new { Brightbox.run(argv) } }
     let(:stdout) { output.stdout }
     let(:stderr) { output.stderr }
 
-    context "" do
-      let(:argv) { %w(images register) }
+    before do
+      config_from_contents(API_CLIENT_CONFIG_CONTENTS)
+      stub_client_token_request
+      Brightbox.config.reauthenticate
+    end
+
+    context "without arguments" do
+      let(:argv) { %w[images register] }
+
+      it "does not error" do
+        expect { output }.to_not raise_error
+
+        expect(stderr).to match("ERROR: You must specify the architecture")
+        expect(stdout).to match("")
+      end
+    end
+
+    context "with minimal arguments" do
+      let(:argv) { %w[images register --arch x86_64 --source custom.img] }
+
+      before do
+        expect(Brightbox::Image).to receive(:register)
+          .with(hash_including(
+                  arch: "x86_64",
+                  source: "custom.img"
+                ))
+          .and_call_original
+
+        stub_request(:post, "#{api_url}/1.0/images?account_id=acc-12345")
+          .with(body: /"source":"custom.img"/)
+          .to_return(
+            status: 201,
+            body: {
+              id: "img-12345"
+            }.to_json
+          )
+
+        stub_request(:get, "#{api_url}/1.0/images/img-12345?account_id=acc-12345")
+          .to_return(
+            status: 200,
+            body: {
+              id: "img-12345"
+            }.to_json
+          )
+      end
 
       it "does not error" do
         expect { output }.to_not raise_error
+
+        expect(stderr).to match("")
+        expect(stderr).not_to match("ERROR")
+        expect(stdout).to match("img-12345")
+      end
+    end
+
+    context "with min-ram argument" do
+      let(:argv) { %w[images register --arch x86_64 --source custom.img --min-ram 2048] }
+
+      before do
+        expect(Brightbox::Image).to receive(:register)
+          .with(hash_including(
+                  arch: "x86_64",
+                  min_ram: 2048,
+                  source: "custom.img"
+                ))
+          .and_call_original
+
+        stub_request(:post, "#{api_url}/1.0/images?account_id=acc-12345")
+          .with(body: /"min_ram":2048/)
+          .to_return(
+            status: 201,
+            body: {
+              id: "img-12345"
+            }.to_json
+          )
+
+        stub_request(:get, "#{api_url}/1.0/images/img-12345?account_id=acc-12345")
+          .to_return(
+            status: 200,
+            body: {
+              id: "img-12345",
+              min_ram: 2048
+            }.to_json
+          )
+      end
+
+      it "does not error" do
+        expect { output }.to_not raise_error
+
+        expect(stderr).to match("")
+        expect(stderr).not_to match("ERROR")
+        expect(stdout).to match("img-12345")
       end
     end
   end

data/spec/commands/images/show_spec.rb

@@ -1,17 +1,69 @@
 require "spec_helper"
 
-describe "brightbox images" do
-
+RSpec.describe "brightbox images" do
   describe "show" do
     let(:output) { FauxIO.new { Brightbox.run(argv) } }
     let(:stdout) { output.stdout }
     let(:stderr) { output.stderr }
 
-    context "" do
-      let(:argv) { %w(images show) }
+    before do
+      WebMock.reset!
+
+      config_from_contents(API_CLIENT_CONFIG_CONTENTS)
+      stub_client_token_request
+      Brightbox.config.reauthenticate
+    end
+
+    context "without arguments" do
+      let(:argv) { %w[images show] }
+
+      before do
+        stub_request(:get, "#{api_url}/1.0/images?account_id=acc-12345")
+          .to_return(
+            status: 200,
+            body: [
+              {
+                id: "img-12345"
+              }
+            ].to_json
+          )
+      end
+
+      it "does not error" do
+        expect { output }.to_not raise_error
+
+        expect(stderr).to match("")
+        expect(stderr).not_to match("ERROR")
+        expect(stdout).to match("img-12345")
+      end
+    end
+
+    context "with identifier" do
+      let(:argv) { %w[images show img-11111] }
+
+      before do
+        expect(Brightbox::Image).to receive(:find)
+          .with("img-11111")
+          .and_call_original
+
+        stub_request(:get, "#{api_url}/1.0/images/img-11111?account_id=acc-12345")
+          .to_return(
+            status: 200,
+            body: {
+              id: "img-11111",
+              min_ram: 2_048
+            }.to_json
+          )
+      end
 
       it "does not error" do
         expect { output }.to_not raise_error
+
+        expect(stderr).to match("")
+        expect(stderr).not_to match("ERROR")
+        expect(stdout).to match("img-11111")
+
+        expect(stdout).to match("min_ram: 2048")
       end
     end
   end

data/spec/commands/images/update_spec.rb

@@ -1,17 +1,67 @@
 require "spec_helper"
 
 describe "brightbox images" do
-
   describe "update" do
     let(:output) { FauxIO.new { Brightbox.run(argv) } }
     let(:stdout) { output.stdout }
     let(:stderr) { output.stderr }
 
-    context "" do
-      let(:argv) { %w(images update) }
+    before do
+      config_from_contents(API_CLIENT_CONFIG_CONTENTS)
+      stub_client_token_request
+      Brightbox.config.reauthenticate
+    end
+
+    context "without arguments" do
+      let(:argv) { %w[images update] }
 
       it "does not error" do
         expect { output }.to_not raise_error
+
+        expect(stderr).to match("ERROR: You must specify the image to update as the first argument")
+        expect(stdout).to match("")
+      end
+    end
+
+    context "with --min-ram" do
+      let(:argv) { %w[images update --min-ram 2048 img-12345] }
+
+      before do
+        expect(Brightbox::Image).to receive(:find)
+          .with("img-12345")
+          .and_call_original
+
+        stub_request(:get, "#{api_url}/1.0/images/img-12345?account_id=acc-12345")
+          .and_return(
+            status: 200,
+            body: {
+              id: "img-12345",
+              min_ram: 1_024
+            }.to_json
+          )
+
+        stub_request(:put, "#{api_url}/1.0/images/img-12345?account_id=acc-12345")
+          .with(body: hash_including(
+            min_ram: 2_048
+          ))
+          .and_return(
+            status: 200,
+            body: {
+              id: "img-12345",
+              min_ram: 2_048
+            }.to_json
+          )
+      end
+
+      it "updates min_ram" do
+        expect { output }.to_not raise_error
+
+        expect(stderr).to match("")
+        expect(stderr).not_to match("ERROR")
+        expect(stdout).to match("img-12345")
+
+        # No shown in output
+        # expect(stdout).to match("min_ram: 2048")
       end
     end
   end

data/spec/commands/lbs/add_nodes_spec.rb

@@ -1,14 +1,13 @@
 require "spec_helper"
 
 describe "brightbox lbs" do
-
   describe "add_nodes" do
     let(:output) { FauxIO.new { Brightbox.run(argv) } }
     let(:stdout) { output.stdout }
     let(:stderr) { output.stderr }
 
     context "" do
-      let(:argv) { %w(lbs add_nodes) }
+      let(:argv) { %w[lbs add_nodes] }
 
       it "does not error" do
         expect { output }.to_not raise_error

data/spec/commands/lbs/create_spec.rb

@@ -1,7 +1,6 @@
 require "spec_helper"
 
 describe "brightbox lbs" do
-
   describe "create" do
     let(:output) { FauxIO.new { Brightbox.run(argv) } }
     let(:stdout) { output.stdout }
@@ -13,7 +12,7 @@ describe "brightbox lbs" do
     end
 
     context "" do
-      let(:argv) { %w(lbs create) }
+      let(:argv) { %w[lbs create] }
 
       it "does not error" do
         expect { output }.to_not raise_error
@@ -34,7 +33,7 @@ describe "brightbox lbs" do
       end
 
       before do
-        stub_request(:post, "http://api.brightbox.dev/1.0/load_balancers?account_id=acc-12345")
+        stub_request(:post, "http://api.brightbox.localhost/1.0/load_balancers?account_id=acc-12345")
           .with(:body => hash_including("ssl_minimum_version" => "TLSv1.0"))
           .to_return(:status => 202, :body => json_response)
       end

data/spec/commands/lbs/destroy_spec.rb

@@ -1,14 +1,13 @@
 require "spec_helper"
 
 describe "brightbox lbs" do
-
   describe "destroy" do
     let(:output) { FauxIO.new { Brightbox.run(argv) } }
     let(:stdout) { output.stdout }
     let(:stderr) { output.stderr }
 
     context "" do
-      let(:argv) { %w(lbs destroy) }
+      let(:argv) { %w[lbs destroy] }
 
       it "does not error" do
         expect { output }.to_not raise_error

data/spec/commands/lbs/list_spec.rb

@@ -1,14 +1,13 @@
 require "spec_helper"
 
 describe "brightbox lbs" do
-
   describe "list" do
     let(:output) { FauxIO.new { Brightbox.run(argv) } }
     let(:stdout) { output.stdout }
     let(:stderr) { output.stderr }
 
     context "" do
-      let(:argv) { %w(lbs list) }
+      let(:argv) { %w[lbs list] }
 
       it "does not error" do
         expect { output }.to_not raise_error

data/spec/commands/lbs/locking_spec.rb

@@ -19,7 +19,7 @@ describe "brightbox lbs" do
 
   describe "lock" do
     context "when resource is known" do
-      let(:argv) { %w(lbs lock lba-12345) }
+      let(:argv) { %w[lbs lock lba-12345] }
 
       before do
         expect(resource_class).to receive(:find_or_call).with(resource_ids).and_return(results)
@@ -32,7 +32,7 @@ describe "brightbox lbs" do
     end
 
     context "when resource is unknown" do
-      let(:argv) { %w(lbs lock lba-12345) }
+      let(:argv) { %w[lbs lock lba-12345] }
 
       before do
         expect(resource_class).to receive(:find).with(resource_id).and_raise(Brightbox::Api::NotFound)
@@ -46,7 +46,7 @@ describe "brightbox lbs" do
 
   describe "unlock" do
     context "when resource is known" do
-      let(:argv) { %w(lbs unlock lba-12345) }
+      let(:argv) { %w[lbs unlock lba-12345] }
 
       before do
         expect(resource_class).to receive(:find_or_call).with(resource_ids).and_return(results)
@@ -59,7 +59,7 @@ describe "brightbox lbs" do
     end
 
     context "when resource is unknown" do
-      let(:argv) { %w(lbs unlock lba-12345) }
+      let(:argv) { %w[lbs unlock lba-12345] }
 
       before do
         expect(resource_class).to receive(:find).with(resource_id).and_raise(Brightbox::Api::NotFound)

data/spec/commands/lbs/remove_nodes_spec.rb

@@ -1,14 +1,13 @@
 require "spec_helper"
 
 describe "brightbox lbs" do
-
   describe "remove_nodes" do
     let(:output) { FauxIO.new { Brightbox.run(argv) } }
     let(:stdout) { output.stdout }
     let(:stderr) { output.stderr }
 
     context "" do
-      let(:argv) { %w(lbs remove_nodes) }
+      let(:argv) { %w[lbs remove_nodes] }
 
       it "does not error" do
         expect { output }.to_not raise_error

data/spec/commands/lbs/show_spec.rb

@@ -1,14 +1,13 @@
 require "spec_helper"
 
 describe "brightbox lbs" do
-
   describe "show" do
     let(:output) { FauxIO.new { Brightbox.run(argv) } }
     let(:stdout) { output.stdout }
     let(:stderr) { output.stderr }
 
     context "" do
-      let(:argv) { %w(lbs show) }
+      let(:argv) { %w[lbs show] }
 
       it "does not error" do
         expect { output }.to_not raise_error

data/spec/commands/lbs/update_spec.rb

@@ -1,7 +1,6 @@
 require "spec_helper"
 
 describe "brightbox lbs" do
-
   describe "update" do
     let(:output) { FauxIO.new { Brightbox.run(argv) } }
     let(:stdout) { output.stdout }
@@ -13,7 +12,7 @@ describe "brightbox lbs" do
     end
 
     context "" do
-      let(:argv) { %w(lbs update) }
+      let(:argv) { %w[lbs update] }
 
       it "does not error" do
         expect { output }.to_not raise_error
@@ -33,10 +32,10 @@ describe "brightbox lbs" do
       end
 
       before do
-        stub_request(:get, "http://api.brightbox.dev/1.0/load_balancers/lba-12345?account_id=acc-12345")
+        stub_request(:get, "http://api.brightbox.localhost/1.0/load_balancers/lba-12345?account_id=acc-12345")
           .to_return(:status => 200, :body => '{"id":"lba-12345"}')
 
-        stub_request(:put, "http://api.brightbox.dev/1.0/load_balancers/lba-12345?account_id=acc-12345")
+        stub_request(:put, "http://api.brightbox.localhost/1.0/load_balancers/lba-12345?account_id=acc-12345")
           .with(:body => hash_including("ssl_minimum_version" => "TLSv1.0"))
           .to_return(:status => 202, :body => json_response)
       end