bridgetown-paginate 1.0.0.alpha1 → 1.0.0.alpha2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 1503605e813afc4d2b3fa331033a8a2f6a41066a88cf83432eb065e93c5fbdb0
-  data.tar.gz: e8078cbed32a2d3b6af6044dae34944d4019935865edda9d222fb03779296c79
+  metadata.gz: 7f4ddd4a70ec92776ef3aa0ef66b3962795bed297e7a9dc82823254b9ed0192a
+  data.tar.gz: c8f3a2c8df7fc1fcc53cc5dff9a55241bbdba95f9779fc350ab11caaece8fce6
 SHA512:
-  metadata.gz: 3e5fd22e0b2f291ea3be6921134fce48d384b39163b08dfc5f8b63ddc8ba0ca531e44db48b7919bce5c2db2c7799240f5dd19eea309e7962cb83d106be0d9282
-  data.tar.gz: 5fefc5e0d4384942edaabac5b26fa97abd260e47b42abc61c0ec6686f92624dceb802e0833058a4208e4470d3383a8ab5914d6c3e5a9018fa0c8f77c238762ca
+  metadata.gz: fe5262a059bb676c9c16f9d81c50cf3b006319da0c6fe28aeba1c6b1faaec84b0b8e158d6e15b4719b20c39e249222a2a54cef12d1c88c342079572d5778ac42
+  data.tar.gz: cfda5839ca555de2c8bb99a1639656bbb26a6c0074b99491db9469e4f451b3cdeb9cfb48a98d0fdad035802199bb800799bafe963cbe39e767ed16d59ac8650c

data/.rubocop.yml

@@ -2,9 +2,8 @@
 inherit_from: ../.rubocop.yml
 
 AllCops:
-  Include:
-    - lib/**/*.rb
-    - spec/**/*.rb
+  Exclude:
+    - "*.gemspec"
 
 Bridgetown/NoPutsAllowed:
   Exclude:

data/lib/bridgetown-paginate/pagination_generator.rb

@@ -36,7 +36,7 @@ module Bridgetown
         # If disabled then simply quit
         unless default_config["enabled"]
           Bridgetown.logger.info "Pagination:", "disabled. Enable in site config" \
-            " with pagination:\\n  enabled: true"
+                                                " with pagination:\\n  enabled: true"
           return
         end
 
@@ -102,11 +102,12 @@ module Bridgetown
         # Create a proc that will delegate logging
         # Decoupling Bridgetown specific logging
         logging_lambda = ->(message, type = "info") do
-          if type == "debug"
+          case type
+          when "debug"
             Bridgetown.logger.debug "Pagination:", message.to_s
-          elsif type == "error"
+          when "error"
             Bridgetown.logger.error "Pagination:", message.to_s
-          elsif type == "warn"
+          when "warn"
             Bridgetown.logger.warn "Pagination:", message.to_s
           else
             Bridgetown.logger.info "Pagination:", message.to_s

data/lib/bridgetown-paginate/pagination_indexer.rb

@@ -7,7 +7,7 @@ module Bridgetown
     # filtering said collections when requested by the defined filters.
     #
     class PaginationIndexer
-      @cached_index = {}
+      @cached_index = {}.compare_by_identity
 
       class << self
         attr_accessor :cached_index
@@ -53,10 +53,8 @@ module Bridgetown
           end
         end
 
-        unless cached_index[all_documents.object_id].is_a?(Hash)
-          cached_index[all_documents.object_id] = {}
-        end
-        cached_index[all_documents.object_id][index_key] = index
+        cached_index[all_documents] = {} unless cached_index[all_documents].is_a?(Hash)
+        cached_index[all_documents][index_key] = index
         index
       end
 

data/lib/bridgetown-paginate/pagination_model.rb

@@ -32,8 +32,11 @@ module Bridgetown
       # rubocop:disable Metrics/BlockLength
       def run(default_config, templates, site_title) # rubocop:todo Metrics/AbcSize
         if templates.size.to_i <= 0
-          @logging_lambda.call "is enabled in the config, but no paginated pages found." \
-            " Add 'pagination:\\n  collection: <label>' to the front-matter of a page.", "warn"
+          @logging_lambda.call(
+            "is enabled in the config, but no paginated pages found." \
+            " Add 'pagination:\\n  collection: <label>' to the front-matter of a page.",
+            "warn"
+          )
           return
         end
 
@@ -63,7 +66,7 @@ module Bridgetown
 
           next unless template_config["enabled"]
 
-          @logging_lambda.call "found page: " + template.path, "debug" unless @debug
+          @logging_lambda.call "found page: #{template.path}", "debug" unless @debug
 
           # Request all documents in all collections that the user has requested
           all_posts = get_docs_in_collections(template_config["collection"], template)
@@ -154,34 +157,34 @@ module Bridgetown
         r = 20
         f = "Pagination: ".rjust(20)
         # Debug print the config
-        if @debug
-          puts f + "----------------------------"
-          puts f + "Page: " + page_path.to_s
-          puts f + " Active configuration"
-          puts f + "  Enabled: ".ljust(r) + config["enabled"].to_s
-          puts f + "  Items per page: ".ljust(r) + config["per_page"].to_s
-          puts f + "  Permalink: ".ljust(r) + config["permalink"].to_s
-          puts f + "  Title: ".ljust(r) + config["title"].to_s
-          puts f + "  Limit: ".ljust(r) + config["limit"].to_s
-          puts f + "  Sort by: ".ljust(r) + config["sort_field"].to_s
-          puts f + "  Sort reverse: ".ljust(r) + config["sort_reverse"].to_s
-
-          puts f + " Active Filters"
-          puts f + "  Collection: ".ljust(r) + config["collection"].to_s
-          puts f + "  Offset: ".ljust(r) + config["offset"].to_s
-          puts f + "  Category: ".ljust(r) + (config["category"].nil? || config["category"] == "posts" ? "[Not set]" : config["category"].to_s)
-          puts f + "  Tag: ".ljust(r) + (config["tag"].nil? ? "[Not set]" : config["tag"].to_s)
-          puts f + "  Locale: ".ljust(r) + (config["locale"].nil? ? "[Not set]" : config["locale"].to_s)
-        end
+        return unless @debug
+
+        puts "#{f}----------------------------"
+        puts "#{f}Page: #{page_path}"
+        puts "#{f} Active configuration"
+        puts f + "  Enabled: ".ljust(r) + config["enabled"].to_s
+        puts f + "  Items per page: ".ljust(r) + config["per_page"].to_s
+        puts f + "  Permalink: ".ljust(r) + config["permalink"].to_s
+        puts f + "  Title: ".ljust(r) + config["title"].to_s
+        puts f + "  Limit: ".ljust(r) + config["limit"].to_s
+        puts f + "  Sort by: ".ljust(r) + config["sort_field"].to_s
+        puts f + "  Sort reverse: ".ljust(r) + config["sort_reverse"].to_s
+
+        puts "#{f} Active Filters"
+        puts f + "  Collection: ".ljust(r) + config["collection"].to_s
+        puts f + "  Offset: ".ljust(r) + config["offset"].to_s
+        puts f + "  Category: ".ljust(r) + (config["category"].nil? || config["category"] == "posts" ? "[Not set]" : config["category"].to_s)
+        puts f + "  Tag: ".ljust(r) + (config["tag"].nil? ? "[Not set]" : config["tag"].to_s)
+        puts f + "  Locale: ".ljust(r) + (config["locale"].nil? ? "[Not set]" : config["locale"].to_s)
       end
       # rubocop:enable Layout/LineLength
 
       # rubocop:disable Layout/LineLength
       def _debug_print_filtering_info(filter_name, before_count, after_count)
         # Debug print the config
-        if @debug
-          puts "Pagination: ".rjust(20) + " Filtering by: " + filter_name.to_s.ljust(9) + " " + before_count.to_s.rjust(3) + " => " + after_count.to_s
-        end
+        return unless @debug
+
+        puts "#{"Pagination: ".rjust(20)} Filtering by: #{filter_name.to_s.ljust(9)} #{before_count.to_s.rjust(3)} => #{after_count}"
       end
       # rubocop:enable Layout/LineLength
 
@@ -263,7 +266,7 @@ module Bridgetown
           # So to unblock this common issue for the date field I simply iterate
           # once over every document and initialize the .date field explicitly
           if @debug
-            puts "Pagination: ".rjust(20) + "Rolling through the date fields for all documents"
+            puts "#{"Pagination: ".rjust(20)}Rolling through the date fields for all documents"
           end
           using_posts.each do |u_post|
             next unless u_post.respond_to?("date")
@@ -378,11 +381,7 @@ module Bridgetown
           newpage.data["permalink"] = newpage.paginator.page_path if template.data["permalink"]
 
           # Transfer the title across to the new page
-          tmp_title = if !template.data["title"]
-                        site_title
-                      else
-                        template.data["title"]
-                      end
+          tmp_title = template.data["title"] || site_title
 
           # If the user specified a title suffix to be added then let's add that
           # to all the pages except the first
@@ -419,40 +418,40 @@ module Bridgetown
         # simplest is to include all of the links to the pages preceeding the
         # current one (e.g for page 1 you get the list 2, 3, 4.... and for
         # page 2 you get the list 3,4,5...)
-        if config["trail"] && !config["trail"].nil? && newpages.size.to_i.positive?
-          trail_before = [config["trail"]["before"].to_i, 0].max
-          trail_after = [config["trail"]["after"].to_i, 0].max
-          trail_length = trail_before + trail_after + 1
-
-          if trail_before.positive? || trail_after.positive?
-            newpages.select do |npage|
-              # Selecting the beginning of the trail
-              idx_start = [npage.paginator.page - trail_before - 1, 0].max
-              # Selecting the end of the trail
-              idx_end = [idx_start + trail_length, newpages.size.to_i].min
-
-              # Always attempt to maintain the max total of <trail_length> pages
-              # in the trail (it will look better if the trail doesn't shrink)
-              if idx_end - idx_start < trail_length
-                # Attempt to pad the beginning if we have enough pages
-                # Never go beyond the zero index
-                idx_start = [
-                  idx_start - (trail_length - (idx_end - idx_start)),
-                  0,
-                ].max
-              end
-
-              # Convert the newpages array into a two dimensional array that has
-              # [index, page_url] as items
-              npage.paginator.page_trail = newpages[idx_start...idx_end] \
-                .each_with_index.map do |ipage, idx|
-                PageTrail.new(
-                  idx_start + idx + 1,
-                  ipage.paginator.page_path,
-                  ipage.data["title"]
-                )
-              end
-            end
+        return unless config["trail"] && !config["trail"].nil? && newpages.size.to_i.positive?
+
+        trail_before = [config["trail"]["before"].to_i, 0].max
+        trail_after = [config["trail"]["after"].to_i, 0].max
+        trail_length = trail_before + trail_after + 1
+
+        return unless trail_before.positive? || trail_after.positive?
+
+        newpages.select do |npage|
+          # Selecting the beginning of the trail
+          idx_start = [npage.paginator.page - trail_before - 1, 0].max
+          # Selecting the end of the trail
+          idx_end = [idx_start + trail_length, newpages.size.to_i].min
+
+          # Always attempt to maintain the max total of <trail_length> pages
+          # in the trail (it will look better if the trail doesn't shrink)
+          if idx_end - idx_start < trail_length
+            # Attempt to pad the beginning if we have enough pages
+            # Never go beyond the zero index
+            idx_start = [
+              idx_start - (trail_length - (idx_end - idx_start)),
+              0,
+            ].max
+          end
+
+          # Convert the newpages array into a two dimensional array that has
+          # [index, page_url] as items
+          npage.paginator.page_trail = newpages[idx_start...idx_end] \
+            .each_with_index.map do |ipage, idx|
+            PageTrail.new(
+              idx_start + idx + 1,
+              ipage.paginator.page_path,
+              ipage.data["title"]
+            )
           end
         end
       end

data/lib/bridgetown-paginate/pagination_page.rb

@@ -11,7 +11,7 @@ module Bridgetown
     # not read from disk
     #
     class PaginationPage < Bridgetown::GeneratedPage
-      def initialize(page_to_copy, cur_page_nr, total_pages, index_pageandext, template_ext)
+      def initialize(page_to_copy, cur_page_nr, total_pages, index_pageandext, template_ext) # rubocop:disable Lint/MissingSuper
         @site = page_to_copy.site
         @base = ""
         @url = ""

data/lib/bridgetown-paginate/paginator.rb

@@ -29,7 +29,7 @@ module Bridgetown
 
         if @page > @total_pages
           raise "page number can't be greater than total pages:" \
-            " #{@page} > #{@total_pages}"
+                " #{@page} > #{@total_pages}"
         end
 
         init = (@page - 1) * @per_page
@@ -63,7 +63,7 @@ module Bridgetown
         @documents = documents[init..offset]
         @page_path = Utils.format_page_number(this_page_url, cur_page_nr, @total_pages)
 
-        @previous_page = @page != 1 ? @page - 1 : nil
+        @previous_page = @page == 1 ? nil : @page - 1
         @previous_page_path = unless @page == 1
                                 if @page == 2
                                   Utils.format_page_number(
@@ -77,7 +77,7 @@ module Bridgetown
                                   )
                                 end
                               end
-        @next_page = @page != @total_pages ? @page + 1 : nil
+        @next_page = @page == @total_pages ? nil : @page + 1
         @next_page_path = if @page != @total_pages
                             Utils.format_page_number(
                               paginated_page_url, @next_page, @total_pages

data/lib/bridgetown-paginate/utils.rb

@@ -74,14 +74,10 @@ module Bridgetown
       # Sorting routine used for ordering posts by custom fields.
       # Handles Strings separately as we want a case-insenstive sorting
       #
-      # rubocop:disable Naming/MethodParameterName, Metrics/CyclomaticComplexity, Metrics/PerceivedComplexity
+      # rubocop:disable Naming/MethodParameterName, Metrics/CyclomaticComplexity
       def self.sort_values(a, b)
-        if a.nil? && !b.nil?
-          return -1
-        elsif !a.nil? && b.nil?
-          return 1
-        end
-
+        return -1 if a.nil? && !b.nil?
+        return 1 if !a.nil? && b.nil?
         return a.downcase <=> b.downcase if a.is_a?(String)
 
         if a.respond_to?("to_datetime") && b.respond_to?("to_datetime")
@@ -91,7 +87,7 @@ module Bridgetown
         # By default use the built in sorting for the data type
         a <=> b
       end
-      # rubocop:enable Naming/MethodParameterName, Metrics/CyclomaticComplexity, Metrics/PerceivedComplexity
+      # rubocop:enable Naming/MethodParameterName, Metrics/CyclomaticComplexity
 
       # Retrieves the given sort field from the given post
       # the sort_field variable can be a hierarchical value on the form

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: bridgetown-paginate
 version: !ruby/object:Gem::Version
-  version: 1.0.0.alpha1
+  version: 1.0.0.alpha2
 platform: ruby
 authors:
 - Bridgetown Team
@@ -16,14 +16,14 @@ dependencies:
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 1.0.0.alpha1
+        version: 1.0.0.alpha2
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 1.0.0.alpha1
+        version: 1.0.0.alpha2
 description: 
 email: maintainers@bridgetownrb.com
 executables: []