brick 1.0.68 → 1.0.69

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 977737d8dec8900c82e2a973060dca56ae7897e281557e43e1c0696012521270
-  data.tar.gz: 8a005ecab292cbfdaf94b29476d4db56e9f5b71a46a5f71ca6fd049550ed4cff
+  metadata.gz: 7399b8731b349e5c2a053956c5e6aa9998eb5a2010b5a0e7c081e87f9cac843e
+  data.tar.gz: bc3f65bb32230c05c63f7ef585a825de315ce2979d03b8db6efc6df0d0a5c143
 SHA512:
-  metadata.gz: c3cfaf5cdcdf67038ba5969306f49b73c09977b9e1dec078ad3ca3d6f6e7d16b5b0d18eb16a982568966ac91cabdcb96e82362cce4906485581b36ce2e2410da
-  data.tar.gz: 50f38455e43528478fe694f08bfcc50a8968536c9e4e6d8ab0c1713ff621e2153454a541d8e5940f584f2bd9e06549c4d3db047ac11fbdedaf5bc536d0ac7cd1
+  metadata.gz: b8681ca78d035e6c727fcb6b60d17a5658841bb28e8a4f3dd7405563d5c7cb3e9739984cfe09ce741fd70d5334b949b786e929a1ce4232cf77568621c2813c9d
+  data.tar.gz: 39a9586ea23107b66ab3d461e93eed2defc459231b26d4b25961a7e2e4df9b04167ff620ac570ad07040681e19ad6b313969e822d6fdd8b492b5f4c1fded4c1c

data/lib/brick/extensions.rb

@@ -266,18 +266,27 @@ module ActiveRecord
       quoted_table_name = table_name.split('.').map { |x| "\"#{x}\"" }.join('.')
       order_by_txt = [] if is_do_txt
       ordering = [ordering] if ordering && !ordering.is_a?(Array)
-      order_by = ordering&.map do |ord_part| # %%% If a term is also used as an eqi-condition in the WHERE clause, it can be omitted from ORDER BY
+      order_by = ordering&.each_with_object([]) do |ord_part, s| # %%% If a term is also used as an eqi-condition in the WHERE clause, it can be omitted from ORDER BY
                    case ord_part
                    when String
                      ord_expr = ord_part.gsub('^^^', quoted_table_name)
                      order_by_txt&.<<("Arel.sql(#{ord_expr})")
-                     Arel.sql(ord_expr)
+                     s << Arel.sql(ord_expr)
                    else # Expecting only Symbol
-                     ord_part = "_br_#{ord_part}_ct" if _br_hm_counts.key?(ord_part)
-                     # Retain any reference to a bt_descrip as being a symbol
-                     # Was:  "#{quoted_table_name}.\"#{ord_part}\""
-                     order_by_txt&.<<(_br_bt_descrip.key?(ord_part) ? ord_part : ord_part.inspect)
-                     ord_part
+                     if _br_hm_counts.key?(ord_part)
+                       ord_part = "\"b_r_#{ord_part}_ct\""
+                     elsif !_br_bt_descrip.key?(ord_part) && !column_names.include?(ord_part.to_s)
+                       # Disallow ordering by a bogus column
+                       # %%% Note this bogus entry so that Javascript can remove any bogus _brick_order
+                       # parameter from the querystring, pushing it into the browser history.
+                       ord_part = nil
+                     end
+                     if ord_part
+                       # Retain any reference to a bt_descrip as being a symbol
+                       # Was:  "#{quoted_table_name}.\"#{ord_part}\""
+                       order_by_txt&.<<(_br_bt_descrip.key?(ord_part) ? ord_part : ord_part.inspect)
+                       s << ord_part
+                     end
                    end
                  end
       [order_by, order_by_txt]
@@ -373,6 +382,7 @@ module ActiveRecord
     end
 
     def brick_select(params, selects = nil, order_by = nil, translations = {}, join_array = ::Brick::JoinArray.new)
+      is_postgres = ActiveRecord::Base.connection.adapter_name == 'PostgreSQL'
       is_mysql = ActiveRecord::Base.connection.adapter_name == 'Mysql2'
       is_distinct = nil
       wheres = {}
@@ -401,10 +411,12 @@ module ActiveRecord
           col_alias = " AS _#{col.name}" if (col_name = col.name) == 'class'
           selects << if is_mysql
                        "`#{tbl_no_schema}`.`#{col_name}`#{col_alias}"
-                     else
+                     elsif is_postgres
                        # Postgres can not use DISTINCT with any columns that are XML, so for any of those just convert to text
                        cast_as_text = '::text' if is_distinct && Brick.relations[klass.table_name]&.[](:cols)&.[](col.name)&.first&.start_with?('xml')
                        "\"#{tbl_no_schema}\".\"#{col_name}\"#{cast_as_text}#{col_alias}"
+                     else # Sqlite or Oracle
+                       "#{tbl_no_schema}.#{col_name}#{col_alias}"
                      end
         end
       end
@@ -430,13 +442,15 @@ module ActiveRecord
               # Postgres can not use DISTINCT with any columns that are XML, so for any of those just convert to text
               is_xml = is_distinct && Brick.relations[sel_col.first.table_name]&.[](:cols)&.[](sel_col.last)&.first&.start_with?('xml')
               # If it's not unique then also include the belongs_to association name before the column name
-              if used_col_aliases.key?(col_alias = "_brfk_#{v.first}__#{sel_col.last}")
-                col_alias = "_brfk_#{v.first}__#{v1[idx][-2..-1].map(&:to_s).join('__')}"
+              if used_col_aliases.key?(col_alias = "br_fk_#{v.first}__#{sel_col.last}")
+                col_alias = "br_fk_#{v.first}__#{v1[idx][-2..-1].map(&:to_s).join('__')}"
               end
               selects << if is_mysql
                            "`#{field_tbl_name}`.`#{sel_col.last}` AS `#{col_alias}`"
-                         else
+                         elsif is_postgres
                            "\"#{field_tbl_name}\".\"#{sel_col.last}\"#{'::text' if is_xml} AS \"#{col_alias}\""
+                         else
+                           "#{field_tbl_name}.#{sel_col.last} AS \"#{col_alias}\""
                          end
               used_col_aliases[col_alias] = nil
               v1[idx] << col_alias
@@ -447,9 +461,11 @@ module ActiveRecord
               ((id_col = k1.primary_key).is_a?(Array) ? id_col : [id_col]).each do |id_part|
                 id_for_tables[v.first] << if id_part
                                             selects << if is_mysql
-                                                         "#{"`#{tbl_name}`.`#{id_part}`"} AS `#{(id_alias = "_brfk_#{v.first}__#{id_part}")}`"
+                                                         "#{"`#{tbl_name}`.`#{id_part}`"} AS `#{(id_alias = "br_fk_#{v.first}__#{id_part}")}`"
+                                                       elsif is_postgres
+                                                         "#{"\"#{tbl_name}\".\"#{id_part}\""} AS \"#{(id_alias = "br_fk_#{v.first}__#{id_part}")}\""
                                                        else
-                                                         "#{"\"#{tbl_name}\".\"#{id_part}\""} AS \"#{(id_alias = "_brfk_#{v.first}__#{id_part}")}\""
+                                                         "#{"#{tbl_name}.#{id_part}"} AS \"#{(id_alias = "br_fk_#{v.first}__#{id_part}")}\""
                                                        end
                                             id_alias
                                           end
@@ -479,9 +495,22 @@ module ActiveRecord
                        end
         next unless count_column # %%% Would be able to remove this when multiple foreign keys to same destination becomes bulletproof
 
-        tbl_alias = is_mysql ? "`_br_#{hm.name}`" : "\"_br_#{hm.name}\""
+        tbl_alias = if is_mysql
+                      "`b_r_#{hm.name}`"
+                    elsif is_postgres
+                      "\"b_r_#{hm.name}\""
+                    else
+                      "b_r_#{hm.name}"
+                    end
         pri_tbl = hm.active_record
         pri_tbl_name = is_mysql ? "`#{pri_tbl.table_name}`" : "\"#{pri_tbl.table_name.gsub('.', '"."')}\""
+        pri_tbl_name = if is_mysql
+                         "`#{pri_tbl.table_name}`"
+                       elsif is_postgres
+                         "\"#{pri_tbl.table_name.gsub('.', '"."')}\""
+                       else
+                         pri_tbl.table_name
+                       end
         on_clause = []
         if fk_col.is_a?(Array) # Composite key?
           fk_col.each_with_index { |fk_col_part, idx| on_clause << "#{tbl_alias}.#{fk_col_part} = #{pri_tbl_name}.#{pri_tbl.primary_key[idx]}" }
@@ -494,22 +523,29 @@ module ActiveRecord
           selects << poly_type
           on_clause << "#{tbl_alias}.#{poly_type} = '#{name}'"
         end
-        hm_table_name = is_mysql ? "`#{associative&.table_name || hm.klass.table_name}`" : "\"#{(associative&.table_name || hm.klass.table_name).gsub('.', '"."')}\""
+        hm_table_name = if is_mysql
+                          "`#{associative&.table_name || hm.klass.table_name}`"
+                        elsif is_postgres
+                          "\"#{(associative&.table_name || hm.klass.table_name).gsub('.', '"."')}\""
+                        else
+                          associative&.table_name || hm.klass.table_name
+                        end
+        group_bys = ::Brick.is_oracle ? selects : (1..selects.length).to_a
         join_clause = "LEFT OUTER
 JOIN (SELECT #{selects.join(', ')}, COUNT(#{'DISTINCT ' if hm.options[:through]}#{count_column
-          }) AS _ct_ FROM #{hm_table_name} GROUP BY #{(1..selects.length).to_a.join(', ')}) AS #{tbl_alias}"
+          }) AS c_t_ FROM #{hm_table_name} GROUP BY #{group_bys.join(', ')}) #{tbl_alias}"
         joins!("#{join_clause} ON #{on_clause.join(' AND ')}")
       end
       where!(wheres) unless wheres.empty?
       # Must parse the order_by and see if there are any symbols which refer to BT associations
-      # as they must be expanded to find the corresponding _br_model__column naming for each.
+      # as they must be expanded to find the corresponding b_r_model__column naming for each.
       if order_by.present?
         final_order_by = *order_by.each_with_object([]) do |v, s|
           if v.is_a?(Symbol)
             # Add the ordered series of columns derived from the BT based on its DSL
             if (bt_cols = klass._br_bt_descrip[v])
               bt_cols.values.each do |v1|
-                v1.each { |v2| s << v2.last if v2.length > 1 }
+                v1.each { |v2| s << "\"#{v2.last}\"" if v2.length > 1 }
               end
             else
               s << v
@@ -1020,6 +1056,7 @@ class Object
       table_name = ActiveSupport::Inflector.underscore(plural_class_name)
       singular_table_name = ActiveSupport::Inflector.singularize(table_name)
       pk = model&._brick_primary_key(relations.fetch(table_name, nil))
+      is_postgres = ActiveRecord::Base.connection.adapter_name == 'PostgreSQL'
       is_mysql = ActiveRecord::Base.connection.adapter_name == 'Mysql2'
 
       namespace_name = "#{namespace.name}::" if namespace
@@ -1125,7 +1162,13 @@ class Object
           # %%% Add custom HM count columns
           # %%% What happens when the PK is composite?
           counts = model._br_hm_counts.each_with_object([]) do |v, s|
-            s << (is_mysql ? "`_br_#{v.first}`._ct_ AS \"_br_#{v.first}_ct\"" : "\"_br_#{v.first}\"._ct_ AS \"_br_#{v.first}_ct\"")
+            s << if is_mysql
+                   "`b_r_#{v.first}`.c_t_ AS \"b_r_#{v.first}_ct\""
+                 elsif is_postgres
+                   "\"b_r_#{v.first}\".c_t_ AS \"b_r_#{v.first}_ct\""
+                 else
+                   "b_r_#{v.first}.c_t_ AS \"b_r_#{v.first}_ct\""
+                 end
           end
           instance_variable_set("@#{table_name}".to_sym, ar_relation.dup._select!(*selects, *counts))
           if namespace && (idx = lookup_context.prefixes.index(table_name))
@@ -1357,6 +1400,11 @@ module ActiveRecord::ConnectionHandling
         end
       when 'Mysql2'
         ::Brick.default_schema = schema = ActiveRecord::Base.connection.current_database
+      when 'OracleEnhanced'
+        # ActiveRecord::Base.connection.current_database will be something like "XEPDB1"
+        ::Brick.default_schema = schema = ActiveRecord::Base.connection.raw_connection.username
+        ::Brick.db_schemas = {}
+        execute_oracle("SELECT username FROM sys.all_users WHERE ORACLE_MAINTAINED != 'Y'").each { |s| ::Brick.db_schemas[s.first] = nil }
       when 'SQLite'
         sql = "SELECT m.name AS relation_name, UPPER(m.type) AS table_type,
           p.name AS column_name, p.type AS data_type,
@@ -1415,9 +1463,31 @@ module ActiveRecord::ConnectionHandling
           cols[col_name] = [r['data_type'], r['max_length'], measures&.include?(col_name), r['is_nullable'] == 'NO']
           # puts "KEY! #{r['relation_name']}.#{col_name} #{r['key']} #{r['const']}" if r['key']
         end
-      else # MySQL2 acts a little differently, bringing back an array for each row
-        ActiveRecord::Base.retrieve_schema_and_tables(sql).each do |r|
-          relation = relations[(relation_name = r[1])] # here relation represents a table or view from the database
+      else # MySQL2 and OracleEnhanced act a little differently, bringing back an array for each row
+        schema_and_tables = if ActiveRecord::Base.connection.adapter_name == 'OracleEnhanced'
+                              sql =
+"SELECT c.owner AS schema, c.table_name AS relation_name, 'BASE_TABLE' AS table_type,
+  LOWER(c.column_name) AS column_name, c.data_type,
+  COALESCE(c.data_length, c.data_precision) AS max_length,
+  CASE ac.constraint_type WHEN 'P' THEN 'PRIMARY KEY' END AS const,
+  ac.constraint_name AS \"key\",
+  CASE c.nullable WHEN 'Y' THEN 'YES' ELSE 'NO' END AS is_nullable
+FROM all_tab_cols c
+  LEFT OUTER JOIN all_cons_columns acc ON acc.owner = c.owner AND acc.table_name = c.table_name AND acc.column_name = c.column_name
+  LEFT OUTER JOIN all_constraints ac ON ac.owner = acc.owner AND ac.table_name = acc.table_name AND ac.constraint_name = acc.constraint_name AND constraint_type = 'P'
+WHERE c.owner IN (#{::Brick.db_schemas.keys.map { |s| "'#{s}'" }.join(', ')})
+ORDER BY 1, 2, c.internal_column_id, acc.position"
+                              execute_oracle(sql, *ar_tables)
+                            else
+                              ActiveRecord::Base.retrieve_schema_and_tables(sql)
+                            end
+        schema_and_tables.each do |r|
+          next if r[1].index('$') # Oracle can have goofy table names with $
+
+          if (relation_name = r[1]) =~ /^[A-Z_]+$/
+            relation_name.downcase!
+          end
+          relation = relations[relation_name] # here relation represents a table or view from the database
           relation[:isView] = true if r[2] == 'VIEW' # table_type
           col_name = r[3]
           key = case r[6] # constraint type
@@ -1474,32 +1544,53 @@ module ActiveRecord::ConnectionHandling
               AND kcu2.ORDINAL_POSITION = kcu1.ORDINAL_POSITION#{"
           WHERE kcu1.CONSTRAINT_SCHEMA = COALESCE(current_setting('SEARCH_PATH'), 'public')" if is_postgres && schema }"
           # AND kcu2.TABLE_NAME = ?;", Apartment::Tenant.current, table_name
+        fk_references = ActiveRecord::Base.execute_sql(sql)
       when 'SQLite'
         sql = "SELECT m.name, fkl.\"from\", fkl.\"table\", m.name || '_' || fkl.\"from\" AS constraint_name
         FROM sqlite_master m
           INNER JOIN pragma_foreign_key_list(m.name) fkl ON m.type = 'table'
         ORDER BY m.name, fkl.seq"
+        fk_references = ActiveRecord::Base.execute_sql(sql)
+      when 'OracleEnhanced'
+        schemas = ::Brick.db_schemas.keys.map { |s| "'#{s}'" }.join(', ')
+        sql =
+        "SELECT -- fk
+               ac.owner AS constraint_schema, acc_fk.table_name, LOWER(acc_fk.column_name),
+               -- referenced pk
+               ac.r_owner AS primary_schema, acc_pk.table_name AS primary_table, acc_fk.constraint_name AS constraint_schema_fk
+               -- , LOWER(acc_pk.column_name)
+        FROM all_cons_columns acc_fk
+          INNER JOIN all_constraints ac ON acc_fk.owner = ac.owner
+            AND acc_fk.constraint_name = ac.constraint_name
+          INNER JOIN all_cons_columns acc_pk ON ac.r_owner = acc_pk.owner
+            AND ac.r_constraint_name = acc_pk.constraint_name
+        WHERE ac.constraint_type = 'R'
+          AND ac.owner IN (#{schemas})
+          AND ac.r_owner IN (#{schemas})"
+        fk_references = ActiveRecord::Base.execute_oracle(sql)
       else
+        binding.pry
       end
-      if sql
-        # ::Brick.default_schema ||= schema ||= 'public' if ActiveRecord::Base.connection.adapter_name == 'PostgreSQL'
-        ActiveRecord::Base.execute_sql(sql).each do |fk|
-          fk = fk.values unless fk.is_a?(Array)
-          # Multitenancy makes things a little more general overall, except for non-tenanted tables
-          if apartment_excluded&.include?(fk[1].singularize.camelize)
-            fk[0] = Apartment.default_schema
-          elsif is_postgres && (fk[0] == 'public' || (is_multitenant && fk[0] == schema)) ||
-                !is_postgres && ['mysql', 'performance_schema', 'sys'].exclude?(fk[0])
-            fk[0] = nil
-          end
-          if apartment_excluded&.include?(fk[4].singularize.camelize)
-            fk[3] = Apartment.default_schema
-          elsif is_postgres && (fk[3] == 'public' || (is_multitenant && fk[3] == schema)) ||
-                !is_postgres && ['mysql', 'performance_schema', 'sys'].exclude?(fk[3])
-            fk[3] = nil
-          end
-          ::Brick._add_bt_and_hm(fk, relations)
+      ::Brick.is_oracle = true if ActiveRecord::Base.connection.adapter_name == 'OracleEnhanced'
+      # ::Brick.default_schema ||= schema ||= 'public' if ActiveRecord::Base.connection.adapter_name == 'PostgreSQL'
+      fk_references&.each do |fk|
+        fk = fk.values unless fk.is_a?(Array)
+        # Multitenancy makes things a little more general overall, except for non-tenanted tables
+        if apartment_excluded&.include?(fk[1].singularize.camelize)
+          fk[0] = Apartment.default_schema
+        elsif is_postgres && (fk[0] == 'public' || (is_multitenant && fk[0] == schema)) ||
+              !is_postgres && ['mysql', 'performance_schema', 'sys'].exclude?(fk[0])
+          fk[0] = nil
+        end
+        if apartment_excluded&.include?(fk[4].singularize.camelize)
+          fk[3] = Apartment.default_schema
+        elsif is_postgres && (fk[3] == 'public' || (is_multitenant && fk[3] == schema)) ||
+              !is_postgres && ['mysql', 'performance_schema', 'sys'].exclude?(fk[3])
+          fk[3] = nil
         end
+        fk[1].downcase! if ::Brick.is_oracle && fk[1] =~ /^[A-Z_]+$/
+        fk[4].downcase! if ::Brick.is_oracle && fk[4] =~ /^[A-Z_]+$/
+        ::Brick._add_bt_and_hm(fk, relations)
       end
     end
 
@@ -1560,13 +1651,27 @@ module ActiveRecord::ConnectionHandling
   --          AND t.table_type IN ('VIEW') -- 'BASE TABLE', 'FOREIGN TABLE'
       AND t.table_name NOT IN ('pg_stat_statements', ?, ?)
     ORDER BY 1, t.table_type DESC, 2, c.ordinal_position"
+    ActiveRecord::Base.execute_sql(sql, *ar_tables)
+  end
+
+  def ar_tables
     ar_smtn = if ActiveRecord::Base.respond_to?(:schema_migrations_table_name)
                 ActiveRecord::Base.schema_migrations_table_name
               else
                 'schema_migrations'
               end
     ar_imtn = ActiveRecord.version >= ::Gem::Version.new('5.0') ? ActiveRecord::Base.internal_metadata_table_name : ''
-    ActiveRecord::Base.execute_sql(sql, ar_smtn, ar_imtn)
+    [ar_smtn, ar_imtn]
+  end
+
+  def execute_oracle(*sql_args)
+    cursor = ActiveRecord::Base.execute_sql(*sql_args)
+    result = []
+    while row = cursor.fetch()
+      result << row
+    end
+    cursor.close
+    result
   end
 end
 

data/lib/brick/frameworks/rails/engine.rb

@@ -145,7 +145,7 @@ module Brick
                                                  'nil'
                                                else
                                                  # Postgres column names are limited to 63 characters
-                                                 "#{obj_name}.#{"_br_#{assoc_name}_ct"[0..62]} || 0"
+                                                 "#{obj_name}.#{"b_r_#{assoc_name}_ct"[0..62]} || 0"
                                                end
                                      ", #{set_ct}, #{path_keys(hm_assoc, hm_fk_name, obj_name, pk)}"
                                    end
@@ -1096,7 +1096,9 @@ flatpickr(\".timepicker\", {enableTime: true, noCalendar: true});
             gErd.setAttribute(\"class\", \"relatedModel\");
             gErd.addEventListener(\"click\",
               function (evt) {
-                location.href = changeout(changeout(location.href, -1, cbs[this.id]), \"_brick_erd\", \"1\");
+                location.href = changeout(changeout(
+                  changeout(location.href, '_brick_order', null), // Remove any ordering
+                -1, cbs[this.id]), \"_brick_erd\", \"1\");
               }
             );
           }

data/lib/brick/version_number.rb

@@ -5,7 +5,7 @@ module Brick
   module VERSION
     MAJOR = 1
     MINOR = 0
-    TINY = 68
+    TINY = 69
 
     # PRE is nil unless it's a pre-release (beta, RC, etc.)
     PRE = nil

data/lib/brick.rb

@@ -123,7 +123,7 @@ module Brick
   end
 
   class << self
-    attr_accessor :default_schema, :db_schemas, :routes_done
+    attr_accessor :default_schema, :db_schemas, :routes_done, :is_oracle
 
     def set_db_schema(params)
       schema = params['_brick_schema'] || 'public'

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: brick
 version: !ruby/object:Gem::Version
-  version: 1.0.68
+  version: 1.0.69
 platform: ruby
 authors:
 - Lorin Thwaits
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2022-09-04 00:00:00.000000000 Z
+date: 2022-09-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord