brick 1.0.142 → 1.0.143

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 4e907aa4b41603045845a12d80de47e9ad714768929225b8bec209ddd9b92212
-  data.tar.gz: 227137ba8ec83040eec6dbf76c3541f6438b7427c586690f7430572cdd59eb8a
+  metadata.gz: 5f3f2c35ad5ad81b538cb12c4d5166ed24bbf5e60bbc02583ed3d6f60cb38783
+  data.tar.gz: 2e598860e1be1b371160146ad05b8c43dfaa108c6125a1c567774fc928945a5f
 SHA512:
-  metadata.gz: b68b20ad2ef66293dd7bdfd329c1ea341fb535e6240128beb1d5cd0dec99503ecc95b44b1adfde24f1493e4d7edb20ea61c7a4c9a1e5f6502b95c3c512261208
-  data.tar.gz: 45722aa4054d96a858bab394a0e207e37d92ab415eb2a5832807e95d855e1c662139074bde9cf545d662a062fbe834ccd228d9595061c1dfde73990e6a3b3feb
+  metadata.gz: d4a99c758d21966a05f82b10d6b33865c17d85dcacb1a0c2af5d6cada712f062f30ebeab0124e7a8d31d132fe83cc265474246b2d45efa98a0b0a0c86f377cb9
+  data.tar.gz: 004b04e031315c1b7b96b516a55c13a7587fe109179b6ae1bd7dbe11ca305c37adfdb61b2f6c2acf26fb35cb9fbbba898c18552bc2ad050bec48fa5dec072c3d

data/lib/brick/compatibility.rb

@@ -10,6 +10,77 @@ unless ActiveRecord.respond_to?(:version)
   end
 end
 
+# Allow ActiveRecord < 3.2 to work with Ruby 2.7 and later
+if ::Gem::Version.new(RUBY_VERSION) >= ::Gem::Version.new('2.7')
+  if ActiveRecord.version < ::Gem::Version.new('3.2')
+    # Remove circular reference for "now"
+    ::Brick::Util._patch_require(
+      'active_support/values/time_zone.rb', '/activesupport',
+      ['  def parse(str, now=now)',
+      '  def parse(str, now=now())']
+    )
+    # Remove circular reference for "reflection" for ActiveRecord 3.1
+    if ActiveRecord.version >= ::Gem::Version.new('3.1')
+      ::Brick::Util._patch_require(
+        'active_record/associations/has_many_association.rb', '/activerecord',
+        ['reflection = reflection)',
+        'reflection = reflection())'],
+        :HasManyAssociation # Make sure the path for this guy is available to be autoloaded
+      )
+    end
+  end
+
+  unless ActiveRecord.const_defined?(:NoDatabaseError) # Generic version of NoDatabaseError for Rails <= 4.0
+    require 'active_model'
+    require 'active_record/errors'
+    class ::ActiveRecord::NoDatabaseError < ::ActiveRecord::StatementInvalid
+    end
+  end
+
+  # Create unfrozen route path in Rails 3.x
+  if ActiveRecord.version < ::Gem::Version.new('4')
+    # ::Brick::Util._patch_require(
+    #   'action_dispatch/routing/route_set.rb', '/actiondispatch',
+    #   ["path = (script_name.blank? ? _generate_prefix(options) : script_name.chomp('/')).to_s",
+    #    "path = (script_name.blank? ? _generate_prefix(options) : script_name.chomp('/')).to_s.dup"]
+    #    #,
+    #   #:RouteSet # Make sure the path for this guy is available to be autoloaded
+    # )
+    require 'action_dispatch/routing/route_set'
+    # This is by no means elegant -- wish the above would work instead.  Here we completely replace #url_for
+    # only in order to add a ".dup"
+    ::ActionDispatch::Routing::RouteSet.class_exec do
+      def url_for(options)
+        finalize!
+        options = (options || {}).reverse_merge!(default_url_options)
+
+        handle_positional_args(options)
+
+        user, password = extract_authentication(options)
+        path_segments  = options.delete(:_path_segments)
+        script_name    = options.delete(:script_name)
+
+        # Just adding .dup on the end in order to not have a frozen string
+        path = (script_name.blank? ? _generate_prefix(options) : script_name.chomp('/')).to_s.dup
+
+        path_options = options.except(*::ActionDispatch::Routing::RouteSet::RESERVED_OPTIONS)
+        path_options = yield(path_options) if block_given?
+
+        path_addition, params = generate(path_options, path_segments || {})
+
+        path << path_addition
+
+        ActionDispatch::Http::URL.url_for(options.merge({
+          :path => path,
+          :params => params,
+          :user => user,
+          :password => password
+        }))
+      end
+    end
+  end
+end
+
 # ActiveSupport, ActionPack, and ActionView before 4.0 didn't have #version
 require 'active_support' # Needed for Rails 4.x
 unless ActiveSupport.respond_to?(:version)

data/lib/brick/extensions.rb

@@ -458,17 +458,19 @@ module ActiveRecord
 
   module AttributeMethods
     module ClassMethods
-      alias _brick_dangerous_attribute_method? dangerous_attribute_method?
-      # Bypass the error "ActiveRecord::DangerousAttributeError" if this object comes from a view.
-      # (Allows for column names such as 'attribute', 'delete', and 'update' to still work.)
-      def dangerous_attribute_method?(name)
-        if (is_dangerous = _brick_dangerous_attribute_method?(name)) && is_view?
-          if column_names.include?(name.to_s)
-            puts "WARNING:  Column \"#{name}\" in view #{table_name} conflicts with a reserved ActiveRecord method name."
+      if respond_to?(:dangerous_attribute_method?)
+        alias _brick_dangerous_attribute_method? dangerous_attribute_method?
+        # Bypass the error "ActiveRecord::DangerousAttributeError" if this object comes from a view.
+        # (Allows for column names such as 'attribute', 'delete', and 'update' to still work.)
+        def dangerous_attribute_method?(name)
+          if (is_dangerous = _brick_dangerous_attribute_method?(name)) && is_view?
+            if column_names.include?(name.to_s)
+              puts "WARNING:  Column \"#{name}\" in view #{table_name} conflicts with a reserved ActiveRecord method name."
+            end
+            return false
           end
-          return false
+          is_dangerous
         end
-        is_dangerous
       end
     end
   end
@@ -587,7 +589,7 @@ module ActiveRecord
 
       if join_array.present?
         if ActiveRecord.version < Gem::Version.new('4.2')
-          joins!(join_array)
+          self.joins_values += join_array # Same as:  joins!(join_array)
         else
           left_outer_joins!(join_array)
         end
@@ -1019,52 +1021,54 @@ Might want to add this in your brick.rb:
     module ClassMethods
     private
 
-      alias _brick_find_sti_class find_sti_class
-      def find_sti_class(type_name)
-        return if type_name.is_a?(Numeric)
+      if respond_to?(:find_sti_class)
+        alias _brick_find_sti_class find_sti_class
+        def find_sti_class(type_name)
+          return if type_name.is_a?(Numeric)
 
-        if ::Brick.sti_models.key?(type_name ||= name)
-          ::Brick.sti_models[type_name].fetch(:base, nil) || _brick_find_sti_class(type_name)
-        else
-          # This auto-STI is more of a brute-force approach, building modules where needed
-          # The more graceful alternative is the overload of ActiveSupport::Dependencies#autoload_module! found below
-          ::Brick.sti_models[type_name] = { base: self } unless type_name.blank?
-          module_prefixes = type_name.split('::')
-          module_prefixes.unshift('') unless module_prefixes.first.blank?
-          module_name = module_prefixes[0..-2].join('::')
-          if (base_name = ::Brick.config.sti_namespace_prefixes&.fetch("#{module_name}::", nil)) ||
-             File.exist?(candidate_file = ::Rails.root.join('app/models' + module_prefixes.map(&:underscore).join('/') + '.rb'))
-            if base_name
-              base_name == "::#{name}" ? self : base_name.constantize
-            else
-              _brick_find_sti_class(type_name) # Find this STI class normally
-            end
+          if ::Brick.sti_models.key?(type_name ||= name)
+            ::Brick.sti_models[type_name].fetch(:base, nil) || _brick_find_sti_class(type_name)
           else
-            # Build missing prefix modules if they don't yet exist
-            this_module = Object
-            module_prefixes[1..-2].each do |module_name|
-              this_module = if this_module.const_defined?(module_name)
-                              this_module.const_get(module_name)
-                            else
-                              this_module.const_set(module_name.to_sym, Module.new)
-                            end
-            end
-            begin
-              if this_module.const_defined?(class_name = module_prefixes.last.to_sym)
-                this_module.const_get(class_name)
+            # This auto-STI is more of a brute-force approach, building modules where needed
+            # The more graceful alternative is the overload of ActiveSupport::Dependencies#autoload_module! found below
+            ::Brick.sti_models[type_name] = { base: self } unless type_name.blank?
+            module_prefixes = type_name.split('::')
+            module_prefixes.unshift('') unless module_prefixes.first.blank?
+            module_name = module_prefixes[0..-2].join('::')
+            if (base_name = ::Brick.config.sti_namespace_prefixes&.fetch("#{module_name}::", nil)) ||
+              File.exist?(candidate_file = ::Rails.root.join('app/models' + module_prefixes.map(&:underscore).join('/') + '.rb'))
+              if base_name
+                base_name == "::#{name}" ? self : base_name.constantize
               else
-                # Build STI subclass and place it into the namespace module
-                this_module.const_set(class_name, klass = Class.new(self))
-                klass
+                _brick_find_sti_class(type_name) # Find this STI class normally
               end
-            rescue NameError => err
-              if column_names.include?(inheritance_column)
-                puts "Table #{table_name} has column #{inheritance_column} which ActiveRecord expects to use as its special inheritance column."
-                puts "Unfortunately the value \"#{type_name}\" does not seem to refer to a valid type name, greatly confusing matters.  If that column is intended to be used for data and not STI, consider putting this line into your Brick initializer so that only for this table that column will not clash with ActiveRecord:"
-                puts "  Brick.sti_type_column = { 'rails_#{inheritance_column}' => ['#{table_name}'] }"
-                self
-              else
-                raise
+            else
+              # Build missing prefix modules if they don't yet exist
+              this_module = Object
+              module_prefixes[1..-2].each do |module_name|
+                this_module = if this_module.const_defined?(module_name)
+                                this_module.const_get(module_name)
+                              else
+                                this_module.const_set(module_name.to_sym, Module.new)
+                              end
+              end
+              begin
+                if this_module.const_defined?(class_name = module_prefixes.last.to_sym)
+                  this_module.const_get(class_name)
+                else
+                  # Build STI subclass and place it into the namespace module
+                  this_module.const_set(class_name, klass = Class.new(self))
+                  klass
+                end
+              rescue NameError => err
+                if column_names.include?(inheritance_column)
+                  puts "Table #{table_name} has column #{inheritance_column} which ActiveRecord expects to use as its special inheritance column."
+                  puts "Unfortunately the value \"#{type_name}\" does not seem to refer to a valid type name, greatly confusing matters.  If that column is intended to be used for data and not STI, consider putting this line into your Brick initializer so that only for this table that column will not clash with ActiveRecord:"
+                  puts "  Brick.sti_type_column = { 'rails_#{inheritance_column}' => ['#{table_name}'] }"
+                  self
+                else
+                  raise
+                end
               end
             end
           end
@@ -2655,7 +2659,7 @@ ORDER BY 1, 2, c.internal_column_id, acc.position"
       pg_catalog.col_description(
         ('\"' || t.table_schema || '\".\"' || t.table_name || '\"')::regclass::oid, c.ordinal_position
       ) AS column_description," if is_postgres}
-      c.column_name, c.data_type,
+      c.column_name, #{is_postgres ? "CASE c.data_type WHEN 'USER-DEFINED' THEN pg_t.typname ELSE c.data_type END AS data_type" : 'c.data_type'},
       COALESCE(c.character_maximum_length, c.numeric_precision) AS max_length,
       kcu.constraint_type AS const, kcu.constraint_name AS \"key\",
       c.is_nullable
@@ -2676,7 +2680,11 @@ ORDER BY 1, 2, c.internal_column_id, acc.position"
         kcu.CONSTRAINT_SCHEMA = c.table_schema
         AND kcu.TABLE_NAME = c.table_name
         AND kcu.column_name = c.column_name#{"
-    --    AND kcu.position_in_unique_constraint IS NULL" unless is_mssql}
+    --    AND kcu.position_in_unique_constraint IS NULL" unless is_mssql}#{"
+      INNER JOIN pg_catalog.pg_namespace pg_n ON pg_n.nspname = t.table_schema
+      INNER JOIN pg_catalog.pg_class pg_c ON pg_n.oid = pg_c.relnamespace AND pg_c.relname = c.table_name
+      INNER JOIN pg_catalog.pg_attribute pg_a ON pg_c.oid = pg_a.attrelid AND pg_a.attname = c.column_name
+      INNER JOIN pg_catalog.pg_type pg_t ON pg_t.oid = pg_a.atttypid" if is_postgres}
     WHERE t.table_schema #{is_postgres || is_mssql ?
         "NOT IN ('information_schema', 'pg_catalog', 'pg_toast', 'heroku_ext',
                  'INFORMATION_SCHEMA', 'sys')"

data/lib/brick/frameworks/rails/engine.rb

@@ -64,7 +64,7 @@ module Brick
             if lat_lng && !(lat_lng.first.zero? && lat_lng.last.zero?)
               # Create a link to this style of Google maps URL:  https://www.google.com/maps/place/38.7071296+-121.2810649/@38.7071296,-121.2810649,12z
               "<a href=\"https://www.google.com/maps/place/#{lat_lng.first}+#{lat_lng.last}/@#{lat_lng.first},#{lat_lng.last},12z\" target=\"blank\">#{val}</a>"
-            elsif val.is_a?(Numeric)
+            elsif val.is_a?(Numeric) && ::ActiveSupport.const_defined?(:NumberHelper)
               ::ActiveSupport::NumberHelper.number_to_delimited(val, delimiter: ',')
             else
               ::Brick::Rails::FormBuilder.hide_bcrypt(val, col_type == :xml)
@@ -685,8 +685,8 @@ window.addEventListener(\"popstate\", linkSchemas);
                 rescue StandardError => e
                   # Search through the routes to confirm that something might match (Devise stuff for instance, which has its own view templates),
                   # and bubble the same exception (probably an ActionView::MissingTemplate) if a legitimate option is found.
-                  raise if ::Rails.application.routes.set.find { |x| args[1].include?(x.defaults[:controller]) && args[0] == x.defaults[:action] } &&
-                           ActionView.version >= ::Gem::Version.new('5.0')
+                  raise if ActionView.version >= ::Gem::Version.new('5.0') &&
+                           ::Rails.application.routes.set.find { |x| args[1].include?(x.defaults[:controller]) && args[0] == x.defaults[:action] }
 
                   find_template_err = e
                 end
@@ -1723,7 +1723,10 @@ end
         case collection
         when ActiveRecord::Relation # has_many (which comes in as a CollectionProxy) or a has_one#{
           poly_fix}
-          collection2, descrip_cols = collection.brick_list
+          collection2, descrip_cols = begin
+                                        collection.brick_list
+                                      rescue
+                                      end
         when ActiveRecord::Base # Object from a has_one :through
           collection2 = [collection]
         else # We get an array back when AR < 4.2

data/lib/brick/frameworks/rails/form_builder.rb

@@ -41,7 +41,7 @@ module Brick::Rails::FormBuilder
                    col&.type
                  end
       case (col_type ||= col&.sql_type)
-      when :string, :text
+      when :string, :text, :citext
         if ::Brick::Rails::FormBuilder.is_bcrypt?(val) # || .readonly?
           is_revert = false
           out << ::Brick::Rails::FormBuilder.hide_bcrypt(val, nil, 1000)

data/lib/brick/util.rb

@@ -32,9 +32,6 @@ module Brick
            !alp.include?(custom_require_dir)
           alp.unshift(custom_require_dir)
         end
-        # require 'pry-byebug'
-        # binding.pry
-        # z = 10
       elsif is_bundler
         puts "Bundler hack"
         require 'pry-byebug'
@@ -52,12 +49,11 @@ module Brick
           # then required in place of the original.
 
           Kernel.module_exec do
-            # class << self
             alias_method :orig_require, :require
-            # end
             # To be most faithful to Ruby's normal behaviour, this should look like a public singleton
             define_method(:require) do |name|
-              puts name if name.to_s.include?('cucu')
+              # %%% Can get a message such as "ActionDispatch::Routing is not missing constant RouteSet! (NameError)"
+              # binding.pry if name.start_with?('action_dispatch/routing/route_') # || name == 'active_support/values/time_zone'
               if (require_override = ::Brick::Util.instance_variable_get(:@_require_overrides)[name])
                 extension, folder_matcher, replacements, autoload_symbol = require_override
                 patched_filename = "/patched_#{name.tr('/', '_')}#{extension}"

data/lib/brick/version_number.rb

@@ -5,7 +5,7 @@ module Brick
   module VERSION
     MAJOR = 1
     MINOR = 0
-    TINY = 142
+    TINY = 143
 
     # PRE is nil unless it's a pre-release (beta, RC, etc.)
     PRE = nil

data/lib/brick.rb

@@ -1,6 +1,7 @@
 # frozen_string_literal: true
 
 require 'brick/compatibility'
+ruby_version = ::Gem::Version.new(RUBY_VERSION)
 
 # Allow ActiveRecord 4.2.7 and older to work with newer Ruby (>= 2.4) by avoiding a "stack level too deep"
 # error when ActiveSupport tries to smarten up Numeric by messing with Fixnum and Bignum at the end of:
@@ -25,37 +26,6 @@ end
 
 require 'brick/util'
 
-# Allow ActiveRecord < 3.2 to work with Ruby 2.7 and later
-if (is_ruby_2_7 = (ruby_version = ::Gem::Version.new(RUBY_VERSION)) >= ::Gem::Version.new('2.7'))
-  if ActiveRecord.version < ::Gem::Version.new('3.2')
-    # Remove circular reference for "now"
-    ::Brick::Util._patch_require(
-      'active_support/values/time_zone.rb', '/activesupport',
-      ['  def parse(str, now=now)',
-      '  def parse(str, now=now())']
-    )
-    # Remove circular reference for "reflection" for ActiveRecord 3.1
-    if ActiveRecord.version >= ::Gem::Version.new('3.1')
-      ::Brick::Util._patch_require(
-        'active_record/associations/has_many_association.rb', '/activerecord',
-        ['reflection = reflection)',
-        'reflection = reflection())'],
-        :HasManyAssociation # Make sure the path for this guy is available to be autoloaded
-      )
-    end
-  end
-
-  # # Create unfrozen route path in Rails 3.2
-  # if ActiveRecord.version < ::Gem::Version.new('4')
-  #   ::Brick::Util._patch_require(
-  #     'action_dispatch/routing/route_set.rb', '/actiondispatch',
-  #     ["script_name.chomp('/')).to_s",
-  #      "script_name.chomp('/')).to_s.dup"],
-  #     :RouteSet # Make sure the path for this guy is available to be autoloaded
-  #   )
-  # end
-end
-
 # Add left_outer_joins! to Associations::JoinDependency and Relation::QueryMethods
 if ActiveRecord.version >= ::Gem::Version.new('4') && ActiveRecord.version < ::Gem::Version.new('5')
   ::Brick::Util._patch_require(
@@ -163,7 +133,8 @@ module Brick
 
     # All tables and views (what Postgres calls "relations" including column and foreign key info)
     def relations
-      return {} if ::ActiveRecord::Base.connection_handler.connection_pool_list.blank?
+      return {} if (ch = ::ActiveRecord::Base.connection_handler).respond_to?(:connection_pool_list) &&
+                   ch.connection_pool_list.blank?
 
       # Key our list of relations for this connection off of the connection pool's object_id
       (@relations ||= {})[ActiveRecord::Base.connection_pool.object_id] ||= Hash.new { |h, k| h[k] = Hash.new { |h, k| h[k] = {} } }
@@ -946,20 +917,22 @@ In config/initializers/brick.rb appropriate entries would look something like:
           end
         end
 
-        if ::Brick.config.add_status && (status_as = "#{controller_prefix.tr('/', '_')}brick_status".to_sym)
-           (
-             !(status_route = instance_variable_get(:@set).named_routes.find { |route| route.first == status_as }&.last) ||
-             !status_route.ast.to_s.include?("/#{controller_prefix}brick_status/")
-           )
-          get("/#{controller_prefix}brick_status", to: 'brick_gem#status', as: status_as.to_s)
-        end
+        if (named_routes = instance_variable_get(:@set).named_routes).respond_to?(:find)
+          if ::Brick.config.add_status && (status_as = "#{controller_prefix.tr('/', '_')}brick_status".to_sym)
+            (
+              !(status_route = instance_variable_get(:@set).named_routes.find { |route| route.first == status_as }&.last) ||
+              !status_route.ast.to_s.include?("/#{controller_prefix}brick_status/")
+            )
+            get("/#{controller_prefix}brick_status", to: 'brick_gem#status', as: status_as.to_s)
+          end
 
-        if ::Brick.config.add_orphans && (orphans_as = "#{controller_prefix.tr('/', '_')}brick_orphans".to_sym)
-           (
-             !(orphans_route = instance_variable_get(:@set).named_routes.find { |route| route.first == orphans_as }&.last) ||
-             !orphans_route.ast.to_s.include?("/#{controller_prefix}brick_orphans/")
-           )
-          get("/#{controller_prefix}brick_orphans", to: 'brick_gem#orphans', as: 'brick_orphans')
+          if ::Brick.config.add_orphans && (orphans_as = "#{controller_prefix.tr('/', '_')}brick_orphans".to_sym)
+            (
+              !(orphans_route = instance_variable_get(:@set).named_routes.find { |route| route.first == orphans_as }&.last) ||
+              !orphans_route.ast.to_s.include?("/#{controller_prefix}brick_orphans/")
+            )
+            get("/#{controller_prefix}brick_orphans", to: 'brick_gem#orphans', as: 'brick_orphans')
+          end
         end
 
         if instance_variable_get(:@set).named_routes.names.exclude?(:brick_crosstab)
@@ -1030,7 +1003,11 @@ require 'brick/version_number'
 if (is_postgres = (Object.const_defined?('PG::VERSION') || Gem::Specification.find_all_by_name('pg').present?)) &&
    ActiveRecord.version < ::Gem::Version.new('4.2.6')
   ::Brick::Util._patch_require(
-    'active_record/connection_adapters/postgresql_adapter.rb', '/activerecord', ["'panic'", "'error'"]
+    'active_record/connection_adapters/postgresql_adapter.rb', '/activerecord', [
+      ["'panic'", "'error'"],
+      # ActiveRecord < 3.2.13 uses the pg_attrdef.adsrc column, but it's missing in Postgres 12 and later, so we need to use pg_get_expr(d.adbin, d.adrelid).
+      [', d.adsrc,', ', pg_get_expr(d.adbin, d.adrelid),']
+    ]
   )
 end
 
@@ -1317,8 +1294,8 @@ ActiveSupport.on_load(:active_record) do
   end
   # rubocop:enable Lint/ConstantDefinitionInBlock
 
-  arsc = ::ActiveRecord::StatementCache
-  if is_ruby_2_7 && arsc.respond_to?(:create) &&
+  if ruby_version >= ::Gem::Version.new('2.7') && ::ActiveRecord.const_defined?(:StatementCache) &&
+     (arsc = ::ActiveRecord::StatementCache).respond_to?(:create) &&
      (params = arsc.method(:create).parameters).length == 2 && params.last == [:opt, :block]
     arsc.class_exec do
       def self.create(connection, callable = nil, &block)
@@ -1423,14 +1400,18 @@ ActiveSupport.on_load(:active_record) do
         elsif araat.respond_to?(:create) # Rails 4.1 and 4.2
           @alias_tracker = araat.create(base.connection, joins)
           @alias_tracker.aliased_table_for(base, base.table_name) # Updates the count for base.table_name to 1
-        else # Rails 4.0
+        else # Rails <= 4.0
           is_rails_4 = true
           @base_klass    = base
           @table_joins   = joins
           @join_parts    = [JoinBase.new(base)]
           @associations  = {}
           @reflections   = []
-          @alias_tracker = araat.new(base.connection, joins)
+          @alias_tracker = if araat.instance_method(:initialize).parameters.length == 2 # Rails > 3.2.8
+                             araat.new(base.connection, joins)
+                           else
+                             araat.new(joins)
+                           end
           @alias_tracker.aliased_name_for(base.table_name) # Updates the count for base.table_name to 1
           tree = build(associations)
         end
@@ -1441,7 +1422,7 @@ ActiveSupport.on_load(:active_record) do
         if (relation = associations.instance_variable_get(:@relation))
           tree.instance_variable_set(:@relation, relation)
         end
-        return if is_rails_4 # Rails 4.0 doesn't know about the rest
+        return if is_rails_4 # Rails <= 4.0 doesn't know about the rest
 
         @join_root = JoinBase.new base, build(tree, base)
         @join_root.children.each { |child| construct_tables! @join_root, child }
@@ -1618,7 +1599,7 @@ module ActiveRecord
         _brick_build_join_query(manager, buckets, *args) # , **kwargs)
       end
 
-    else # elsif private_instance_methods.include?(:select_association_list)
+    elsif private_instance_methods.include?(:select_association_list)
       alias _brick_select_association_list select_association_list
       def select_association_list(associations, stashed_joins = nil)
         result = _brick_select_association_list(associations, stashed_joins)

data/lib/generators/brick/migrations_generator.rb

@@ -137,7 +137,8 @@ module Brick
         fringe.each do |tbl|
           next unless (relation = ::Brick.relations.fetch(tbl, nil))&.fetch(:cols, nil)&.present?
 
-          pkey_cols = (rpk = relation[:pkey].values.flatten) & (arpk = [ApplicationRecord.primary_key].flatten.sort)
+          ar_base = Object.const_defined?(:ApplicationRecord) ? ApplicationRecord : Class.new(ActiveRecord::Base)
+          pkey_cols = (rpk = relation[:pkey].values.flatten) & (arpk = [ar_base.primary_key].flatten.sort)
           # In case things aren't as standard
           if pkey_cols.empty?
             pkey_cols = if rpk.empty? && relation[:cols][arpk.first]&.first == key_type

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: brick
 version: !ruby/object:Gem::Version
-  version: 1.0.142
+  version: 1.0.143
 platform: ruby
 authors:
 - Lorin Thwaits
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2023-05-17 00:00:00.000000000 Z
+date: 2023-05-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
@@ -16,14 +16,14 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '3.0'
+        version: 3.1.1
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '3.0'
+        version: 3.1.1
 - !ruby/object:Gem::Dependency
   name: fancy_gets
   requirement: !ruby/object:Gem::Requirement