brendan-entrails 1.0.4 → 1.0.5

data/entrails.gemspec

@@ -1,12 +1,12 @@
       Gem::Specification.new do |s|
         s.name = %q{entrails}
-        s.version = "1.0.4"
+        s.version = "1.0.5"
 
         s.specification_version = 2 if s.respond_to? :specification_version=
 
         s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
         s.authors = ["Brendan Baldwin"]
-        s.date = "2008-08-26"
+        s.date = "2009-01-29"
         s.default_executable = %q{entrails}
         s.description = "This is a collection of extensions to Rails internals that I've found to be absolutely indispensible since I implimented them.  The real action is happening in the following two files at the moment: http://github.com/brendan/entrails/tree/master/lib/entrails/active_record/better_conditions.rb http://github.com/brendan/entrails/tree/master/lib/entrails/active_record/find_by_association.rb"
         s.email = ["brendan@usergenic.com"]

data/lib/entrails/action_controller/named_route_parameter.rb

@@ -1,3 +1,14 @@
+# NamedRouteParameter is currently in the "hack" phase because its implementation
+# essentially creates a duplicate route in memory for every named_route defined.
+# The purpose of this hack is really to be able to determine which named_route is
+# being recognized by simply tacking on a new parameter called :named_route.
+#
+# This can be helpful in shared partials where you may only want to display
+# something for certain views and it would be nice to determine it from the
+# named route.  It is also very helpful if you need a concise standard name
+# when analyzing the path from a local referer (indeed, this was the initial
+# use case for its construction.)
+#
 module Entrails::ActionController::NamedRouteParameter
   
   def add_named_route_with_named_route_parameter(name, path, options = {})

data/lib/entrails/action_controller/template_for_referer.rb

@@ -1,14 +1,46 @@
+# TemplateForReferer, when included in ActionController::Base patches the built-in
+# default_template_name method, which is used to determine what template to use in
+# the app/views folder.  It does this so that we can create special templates to
+# respond to requests coming from specific named routes.
+#
+# Why?  This can be useful when managing responses for requests coming to the same
+# controller action from multiple contexts.  This was created primarily to deal with
+# context in an AJAX setting, where the javascript returned by an RJS file will
+# depend on the current page in the browser, since you may be changing DOM structures
+# specific to that page.
+#
+# Consider a social network site where you want to support giving users the ability
+# to friend each other.  You'll probably have a friendships resource which will respond
+# to a post method, and you may want to support doing so via AJAX.  Well in one case 
+# there may be an "add as friend" button on the user profile, which reacts by flipping
+# the button to "remove friend".  In another case you may have many buttons in a list
+# which respond by redrawing the list and adding the new friend in another list.
+#
+# The solution provided by this module is to allow you to define templates based on
+# the named_route from which the request is being issued/refered.  So in the case of
+# the button on the user profile, which would probably by the 'user' named route,
+# you would define a create_for_user.js.rjs template to handle it in app/views/friendships.
+# In the case of the list, say the users named route (i.e. the index of users),
+# app/views/friendships/create_for_users.js.rjs
+#
+# If there is no specific template for the referer's named route or if the referer
+# is not the local application, (determined by request.host) then we just revert to
+# the default_template_name originally provided by Rails.
+#
+# Note that this behavior is not enabled just for rjs templates-- You can use it for
+# any formats.  
+#
+# Rails uses the controller and action names to determine the
+# name of the template to load.
 module Entrails::ActionController::TemplateForReferer
   
   private
   
   def default_template_name_with_template_for_referer
     template_name = default_template_name_without_template_for_referer
-    begin
-      @template.pick_template("#{template_name}_for_#{referer_named_route}")
-    rescue
-      template_name
-    end
+    template_name_for_referer = "#{template_name}_for_#{referer_named_route}"
+    return template_name_for_referer if template_exists?(template_name_for_referer)
+    template_name
   end
   
   def referer_host
@@ -39,4 +71,4 @@ module Entrails::ActionController::TemplateForReferer
     host.alias_method_chain :default_template_name, :template_for_referer
   end
   
-end
+end

data/lib/entrails/active_record/find_by_association.rb

@@ -163,7 +163,7 @@ module Entrails::ActiveRecord::FindByAssociation
     match = /^find_or_(initialize|create)_by_([_a-zA-Z]\w*)$/.match(method_id.to_s) unless match
     if match
       action_type = ($1 =~ /by/) ? :finder : :instantiator
-      attribute_names = extract_attribute_names_from_match(match)
+      attribute_names = $2.split(/_and_/)
       options_argument = (arguments.size > attribute_names.size) ? arguments.last : {}
       associations = {}
       index = 0
@@ -241,7 +241,7 @@ module Entrails::ActiveRecord::FindByAssociation
   # database engines.  This hack has been shown to significantly benefit query times
   # for mysql and sqlite3. (has not yet been tested with other engines.)
   def use_derived_table_hack_for_subquery_optimization?
-    true
+    false
   end
   
   def self.extended(host)

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification 
 name: brendan-entrails
 version: !ruby/object:Gem::Version 
-  version: 1.0.4
+  version: 1.0.5
 platform: ruby
 authors: 
 - Brendan Baldwin
@@ -9,7 +9,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2008-08-26 00:00:00 -07:00
+date: 2009-01-29 00:00:00 -08:00
 default_executable: entrails
 dependencies: []