breakers 0.2.2 → 0.5.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: 9e6817087ef7b241395a0788e84a0ee14cfb476f
-  data.tar.gz: 95130c9e75c4915a1b6d6fd88bcc8ee8ae7e1564
+SHA256:
+  metadata.gz: eb4f99f9230a8a77ef80b47b9c06582f7e885f0f52f52998b1c92fa61070bb0b
+  data.tar.gz: 78ec47202acff0af6961a7be2f8735103360bc976df6e32df3ab94eb0de79533
 SHA512:
-  metadata.gz: df1d03686061dea6bc19d266463d7d884e5d2610740b6381cdd25c90e48beace78d59f9f7590c275b696d7068d2156e04dd7b5ee6b5bb326d51150b966a27c96
-  data.tar.gz: 44c580e0f38c489e474fbe8c88ab79a1b2ad0d259973964765c296f0a9e73b08519248a6c134d77e3462e8c1e5fa03060cb6c04288a6ce9abbb6ab802fc8cec2
+  metadata.gz: 158c40c57705a319eb1683f27f5fc58fe6da8786e59faf4d7ea05c5868333e55e1885eb8eaa005bb0564ad57931a18eddc12c0278a86ee2ef382820927392b87
+  data.tar.gz: d5551fdb570642bb96b0cce674efed1e470454542793d5696a15eace950ed7dd73acde565ff515d790b0157936cb9b3b70f758cf6de8dfc6403aa30e4c4c17c1

data/.rubocop.yml

@@ -2,6 +2,8 @@ AllCops:
   TargetRubyVersion: 2.3
   Include:
     - 'Rakefile'
+  Exclude:
+    - Gemfile
 
 Metrics/LineLength:
   Max: 140
@@ -22,6 +24,9 @@ Metrics/ClassLength:
 Metrics/MethodLength:
   Max: 50
 
+Metrics/BlockLength:
+  Max: 500
+
 Metrics/AbcSize:
   Max: 75
 
@@ -98,7 +103,7 @@ Style/GuardClause:
 Style/Next:
   Enabled: false
 
-Style/IndentArray:
+Layout/IndentArray:
   EnforcedStyle: consistent
 
 # This forces you to change simple if/unless blocks to the conditional form like: `return 2 if badness`.
@@ -149,7 +154,7 @@ Style/WordArray:
 
 # Some people really like to put lines at the beginning and end of class bodies, while other people
 # really don't. It doesn't really seem to matter.
-Style/EmptyLinesAroundClassBody:
+Layout/EmptyLinesAroundClassBody:
   Enabled: false
 
 # This forces you to put a comment like this at the top of every single file:
@@ -164,10 +169,10 @@ Style/Lambda:
   Enabled: false
 
 # Force indentation for milti-line expressions and method calls
-Style/MultilineOperationIndentation:
+Layout/MultilineOperationIndentation:
   EnforcedStyle: indented
 
-Style/MultilineMethodCallIndentation:
+Layout/MultilineMethodCallIndentation:
   EnforcedStyle: indented
 
 # This disallows the use of $1, $2 from regular expressions, which seems to make no sense whatsoever
@@ -198,7 +203,7 @@ Style/ZeroLengthPredicate:
 #   ...
 # end
 Lint/EndAlignment:
-  AlignWith: variable
+  EnforcedStyleAlignWith: variable
 
 # This cop will require you to replace or prefix method arguments that go unused with underscores. The problem
 # is that while seeming to solve no problem this could easily cause issues where someone editing the code to

data/breakers.gemspec

@@ -1,4 +1,5 @@
 # coding: utf-8
+
 lib = File.expand_path('../lib', __FILE__)
 $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 require 'breakers/version'
@@ -21,7 +22,7 @@ Gem::Specification.new do |spec|
   spec.executables   = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
   spec.require_paths = ['lib']
 
-  spec.add_dependency 'faraday', ['>= 0.7.4', '< 0.10']
+  spec.add_dependency 'faraday', ['>= 0.7.4', '< 2.0']
   spec.add_dependency 'multi_json', '~> 1.0'
 
   spec.add_development_dependency 'bundler', '~> 1.0'

data/lib/breakers/service.rb

@@ -17,6 +17,7 @@ module Breakers
     # @option opts [Integer] :seconds_before_retry The number of seconds to wait after an outage begins before testing with a new request
     # @option opts [Integer] :error_threshold The percentage of errors over the last two minutes that indicates an outage
     # @option opts [Integer] :data_retention_seconds The number of seconds to retain success and error data in Redis
+    # @option opts [Proc] :exception_handler A proc taking an exception and returns true if it represents an error on the service
     def initialize(opts)
       @configuration = DEFAULT_OPTS.merge(opts)
     end
@@ -43,6 +44,13 @@ module Breakers
       @configuration[:seconds_before_retry]
     end
 
+    # Returns true if a given exception represents an error with the service
+    #
+    # @return [Boolean] is it an error?
+    def exception_represents_server_error?(exception)
+      @configuration[:exception_handler]&.call(exception)
+    end
+
     # Indicate that an error has occurred and potentially create an outage
     def add_error
       increment_key(key: errors_key)

data/lib/breakers/uptime_middleware.rb

@@ -35,6 +35,9 @@ module Breakers
     protected
 
     def outage_response(outage:, service:)
+      Breakers.client.plugins.each do |plugin|
+        plugin.on_skipped_request(service) if plugin.respond_to?(:on_skipped_request)
+      end
       if Breakers.outage_response[:type] == :status_code
         Faraday::Response.new.tap do |response|
           response.finish(
@@ -51,7 +54,7 @@ module Breakers
     def handle_request(service:, request_env:, current_outage: nil)
       start_time = Time.now
       return @app.call(request_env).on_complete do |response_env|
-        response_env[:duration] = Time.now - start_time
+        response_env[:duration] = (Time.now - start_time) * 1000
         if response_env.status >= 500
           handle_error(
             service: service,
@@ -69,8 +72,17 @@ module Breakers
           end
         end
       end
+    rescue Faraday::TimeoutError, Faraday::ConnectionFailed => e
+      handle_error(
+        service: service,
+        request_env: request_env,
+        response_env: nil,
+        error: "#{e.class.name} - #{e.message}",
+        current_outage: current_outage
+      )
+      raise
     rescue => e
-      unless e.is_a?(Breakers::OutageException)
+      if service.exception_represents_server_error?(e)
         handle_error(
           service: service,
           request_env: request_env,

data/lib/breakers/version.rb

@@ -1,3 +1,3 @@
 module Breakers
-  VERSION = '0.2.2'.freeze
+  VERSION = '0.5.0'.freeze
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: breakers
 version: !ruby/object:Gem::Version
-  version: 0.2.2
+  version: 0.5.0
 platform: ruby
 authors:
 - Aubrey Holland
-autorequire: 
+autorequire:
 bindir: exe
 cert_chain: []
-date: 2016-10-28 00:00:00.000000000 Z
+date: 2021-05-17 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: faraday
@@ -19,7 +19,7 @@ dependencies:
         version: 0.7.4
     - - "<"
       - !ruby/object:Gem::Version
-        version: '0.10'
+        version: '2.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
@@ -29,7 +29,7 @@ dependencies:
         version: 0.7.4
     - - "<"
       - !ruby/object:Gem::Version
-        version: '0.10'
+        version: '2.0'
 - !ruby/object:Gem::Dependency
   name: multi_json
   requirement: !ruby/object:Gem::Requirement
@@ -200,7 +200,7 @@ homepage: https://github.com/department-of-veterans-affairs/breakers
 licenses:
 - CC0-1.0
 metadata: {}
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -215,10 +215,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.5.1
-signing_key: 
+rubygems_version: 3.0.8
+signing_key:
 specification_version: 4
 summary: Handle outages to backend systems with a Faraday middleware
 test_files: []
-has_rdoc: