breakers 0.2.1 → 0.4.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: 35c7aacf61c91cf32f46b61946acb6f80d0b00fc
-  data.tar.gz: 4d62beb0e55e286b22ae035f2ac3a8f390a271fd
+SHA256:
+  metadata.gz: f3f0fe57f169c943767204654e3a06cc0bfa1b5d94d5526b2b9a17277b7dddca
+  data.tar.gz: 2c2d30d44317fa7ebeb595b6dee476327b93a9d34466de1c25136c48b3201505
 SHA512:
-  metadata.gz: 2cc042397050ea304a6632a7f758e9fe2f3efdabc48843759366f6f953a50762ecd432be06846d211b2e537b7e283730772f021febc866d85447166e32444323
-  data.tar.gz: 9358d0bbf12c1b5b378ecaa2b94584e775887e746958ef0405d176daf5a207ba780a108428ab7f49c6fa92eebe6174e90ad6668004b085de0b473fc4a6f90c77
+  metadata.gz: 97f7d582d247487f891990c0283b191fb3a34f3340bcb61d36dd3bb999a8cb0831d920dee3f172b250a2e2405ac323a7cadf9df6f041f2ec85a309c185b1554f
+  data.tar.gz: c0a1271baf89a686198968c6153c2e6f3eee5eb044faef715623d389bc6d640290ca633ef55d096562ac20dad79cf827e0520bb167fdaf3b9110c8413afc29e4

data/.rubocop.yml

@@ -2,6 +2,8 @@ AllCops:
   TargetRubyVersion: 2.3
   Include:
     - 'Rakefile'
+  Exclude:
+    - Gemfile
 
 Metrics/LineLength:
   Max: 140
@@ -22,6 +24,9 @@ Metrics/ClassLength:
 Metrics/MethodLength:
   Max: 50
 
+Metrics/BlockLength:
+  Max: 500
+
 Metrics/AbcSize:
   Max: 75
 
@@ -98,7 +103,7 @@ Style/GuardClause:
 Style/Next:
   Enabled: false
 
-Style/IndentArray:
+Layout/IndentArray:
   EnforcedStyle: consistent
 
 # This forces you to change simple if/unless blocks to the conditional form like: `return 2 if badness`.
@@ -149,7 +154,7 @@ Style/WordArray:
 
 # Some people really like to put lines at the beginning and end of class bodies, while other people
 # really don't. It doesn't really seem to matter.
-Style/EmptyLinesAroundClassBody:
+Layout/EmptyLinesAroundClassBody:
   Enabled: false
 
 # This forces you to put a comment like this at the top of every single file:
@@ -164,10 +169,10 @@ Style/Lambda:
   Enabled: false
 
 # Force indentation for milti-line expressions and method calls
-Style/MultilineOperationIndentation:
+Layout/MultilineOperationIndentation:
   EnforcedStyle: indented
 
-Style/MultilineMethodCallIndentation:
+Layout/MultilineMethodCallIndentation:
   EnforcedStyle: indented
 
 # This disallows the use of $1, $2 from regular expressions, which seems to make no sense whatsoever
@@ -198,7 +203,7 @@ Style/ZeroLengthPredicate:
 #   ...
 # end
 Lint/EndAlignment:
-  AlignWith: variable
+  EnforcedStyleAlignWith: variable
 
 # This cop will require you to replace or prefix method arguments that go unused with underscores. The problem
 # is that while seeming to solve no problem this could easily cause issues where someone editing the code to

data/breakers.gemspec

@@ -1,4 +1,5 @@
 # coding: utf-8
+
 lib = File.expand_path('../lib', __FILE__)
 $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 require 'breakers/version'
@@ -21,7 +22,7 @@ Gem::Specification.new do |spec|
   spec.executables   = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
   spec.require_paths = ['lib']
 
-  spec.add_dependency 'faraday', ['>= 0.7.4', '< 0.10']
+  spec.add_dependency 'faraday', ['>= 0.7.4', '< 0.18']
   spec.add_dependency 'multi_json', '~> 1.0'
 
   spec.add_development_dependency 'bundler', '~> 1.0'

data/lib/breakers/service.rb

@@ -17,6 +17,7 @@ module Breakers
     # @option opts [Integer] :seconds_before_retry The number of seconds to wait after an outage begins before testing with a new request
     # @option opts [Integer] :error_threshold The percentage of errors over the last two minutes that indicates an outage
     # @option opts [Integer] :data_retention_seconds The number of seconds to retain success and error data in Redis
+    # @option opts [Proc] :exception_handler A proc taking an exception and returns true if it represents an error on the service
     def initialize(opts)
       @configuration = DEFAULT_OPTS.merge(opts)
     end
@@ -43,6 +44,13 @@ module Breakers
       @configuration[:seconds_before_retry]
     end
 
+    # Returns true if a given exception represents an error with the service
+    #
+    # @return [Boolean] is it an error?
+    def exception_represents_server_error?(exception)
+      @configuration[:exception_handler]&.call(exception)
+    end
+
     # Indicate that an error has occurred and potentially create an outage
     def add_error
       increment_key(key: errors_key)

data/lib/breakers/uptime_middleware.rb

@@ -35,6 +35,9 @@ module Breakers
     protected
 
     def outage_response(outage:, service:)
+      Breakers.client.plugins.each do |plugin|
+        plugin.on_skipped_request(service) if plugin.respond_to?(:on_skipped_request)
+      end
       if Breakers.outage_response[:type] == :status_code
         Faraday::Response.new.tap do |response|
           response.finish(
@@ -49,7 +52,9 @@ module Breakers
     end
 
     def handle_request(service:, request_env:, current_outage: nil)
+      start_time = Time.now
       return @app.call(request_env).on_complete do |response_env|
+        response_env[:duration] = (Time.now - start_time) * 1000
         if response_env.status >= 500
           handle_error(
             service: service,
@@ -67,8 +72,17 @@ module Breakers
           end
         end
       end
+    rescue Faraday::TimeoutError, Faraday::ConnectionFailed => e
+      handle_error(
+        service: service,
+        request_env: request_env,
+        response_env: nil,
+        error: "#{e.class.name} - #{e.message}",
+        current_outage: current_outage
+      )
+      raise
     rescue => e
-      unless e.is_a?(Breakers::OutageException)
+      if service.exception_represents_server_error?(e)
         handle_error(
           service: service,
           request_env: request_env,

data/lib/breakers/version.rb

@@ -1,3 +1,3 @@
 module Breakers
-  VERSION = '0.2.1'.freeze
+  VERSION = '0.4.0'.freeze
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: breakers
 version: !ruby/object:Gem::Version
-  version: 0.2.1
+  version: 0.4.0
 platform: ruby
 authors:
 - Aubrey Holland
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2016-10-26 00:00:00.000000000 Z
+date: 2020-10-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: faraday
@@ -19,7 +19,7 @@ dependencies:
         version: 0.7.4
     - - "<"
       - !ruby/object:Gem::Version
-        version: '0.10'
+        version: '0.18'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
@@ -29,7 +29,7 @@ dependencies:
         version: 0.7.4
     - - "<"
       - !ruby/object:Gem::Version
-        version: '0.10'
+        version: '0.18'
 - !ruby/object:Gem::Dependency
   name: multi_json
   requirement: !ruby/object:Gem::Requirement
@@ -215,10 +215,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.5.1
+rubygems_version: 3.1.4
 signing_key: 
 specification_version: 4
 summary: Handle outages to backend systems with a Faraday middleware
 test_files: []
-has_rdoc: