breadcrumbs 0.1.0 → 0.1.1

data/lib/breadcrumbs/render/inline.rb

@@ -29,6 +29,8 @@ class Breadcrumbs
         options[:class] << " #{css.join(" ")}"
         options[:class].gsub!(/^ *(.*?)$/, '\\1')
 
+        text = CGI.escapeHTML(text)
+
         if url
           text = tag(:a, text, options.merge(:href => url))
         else

data/lib/breadcrumbs/render/list.rb

@@ -24,7 +24,7 @@ class Breadcrumbs
         css << "item-#{i}"
 
         text, url, options = *item
-
+        text = CGI.escapeHTML(text)
         text = tag(:a, text, options.merge(:href => url)) if url
 
         tag(:li, text, :class => css.join(" "))

data/lib/breadcrumbs/version.rb

@@ -2,7 +2,7 @@ class Breadcrumbs
   module Version # :nodoc: all
     MAJOR = 0
     MINOR = 1
-    PATCH = 0
+    PATCH = 1
     STRING = "#{MAJOR}.#{MINOR}.#{PATCH}"
   end
 end

data/lib/breadcrumbs.rb

@@ -44,7 +44,7 @@ class Breadcrumbs
 
   def translate(scope) # :nodoc:
     text = I18n.t(scope, :scope => :breadcrumbs, :raise => true) rescue nil
-    text ||= I18n.t(scope, :default => scope)
+    text ||= I18n.t(scope, :default => scope.to_s)
     text
   end
 end

data/test/breadcrumbs_test.rb

@@ -145,8 +145,34 @@ class BreadcrumbsTest < Test::Unit::TestCase
     assert_equal "Nosso time", items[1].inner_text
   end
 
+  def test_render_scope_as_text_for_missing_scope
+    @breadcrumbs.add :contact
+    @breadcrumbs.add "Help"
+
+    html = Nokogiri::HTML(@breadcrumbs.render)
+
+    items = html.search("li")
+
+    assert_equal "contact", items[0].inner_text
+    assert_equal "Help", items[1].inner_text
+  end
+
   def test_pimp_action_controller
     methods = ActionController::Base.instance_methods
     assert (methods.include?(:breadcrumbs) || methods.include?("breadcrumbs"))
   end
+
+  def test_escape_text_when_rendering_inline
+    @breadcrumbs.add "<script>alert(1)</script>"
+    html = @breadcrumbs.render(:format => :inline)
+
+    assert_equal %[<span class="first last item-0">&lt;script&gt;alert(1)&lt;/script&gt;</span>], html
+  end
+
+  def test_escape_text_when_rendering_list
+    @breadcrumbs.add "<script>alert(1)</script>"
+    html = @breadcrumbs.render
+
+    assert_match /&lt;script&gt;alert\(1\)&lt;\/script&gt;/, html
+  end
 end

metadata

@@ -5,8 +5,8 @@ version: !ruby/object:Gem::Version
   segments: 
   - 0
   - 1
-  - 0
-  version: 0.1.0
+  - 1
+  version: 0.1.1
 platform: ruby
 authors: 
 - Nando Vieira
@@ -14,7 +14,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2010-03-24 00:00:00 -03:00
+date: 2010-03-25 00:00:00 -03:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency 
@@ -50,7 +50,7 @@ files:
 - test/resources/pt.yml
 - test/test_helper.rb
 has_rdoc: true
-homepage: http://github.com/fnando/games_radar
+homepage: http://github.com/fnando/breadcrumbs
 licenses: []
 
 post_install_message: