brakeman 6.0.1 → 6.1.0
Sign up to get free protection for your applications and to get access to all the features.
- checksums.yaml +4 -4
- data/CHANGES.md +9 -0
- data/bundle/load.rb +1 -1
- data/bundle/ruby/3.1.0/gems/{rexml-3.2.5 → rexml-3.2.6}/NEWS.md +100 -2
- data/bundle/ruby/3.1.0/gems/{rexml-3.2.5 → rexml-3.2.6}/README.md +10 -1
- data/bundle/ruby/3.1.0/gems/{rexml-3.2.5 → rexml-3.2.6}/lib/rexml/attribute.rb +14 -9
- data/bundle/ruby/3.1.0/gems/{rexml-3.2.5 → rexml-3.2.6}/lib/rexml/document.rb +1 -1
- data/bundle/ruby/3.1.0/gems/{rexml-3.2.5 → rexml-3.2.6}/lib/rexml/element.rb +3 -3
- data/bundle/ruby/3.1.0/gems/{rexml-3.2.5 → rexml-3.2.6}/lib/rexml/entity.rb +25 -15
- data/bundle/ruby/3.1.0/gems/{rexml-3.2.5 → rexml-3.2.6}/lib/rexml/formatters/pretty.rb +2 -2
- data/bundle/ruby/3.1.0/gems/{rexml-3.2.5 → rexml-3.2.6}/lib/rexml/namespace.rb +8 -4
- data/bundle/ruby/3.1.0/gems/{rexml-3.2.5 → rexml-3.2.6}/lib/rexml/parsers/xpathparser.rb +136 -86
- data/bundle/ruby/3.1.0/gems/{rexml-3.2.5 → rexml-3.2.6}/lib/rexml/rexml.rb +3 -1
- data/bundle/ruby/3.1.0/gems/{rexml-3.2.5 → rexml-3.2.6}/lib/rexml/text.rb +6 -4
- data/lib/brakeman/checks/check_ransack.rb +53 -0
- data/lib/brakeman/checks/check_sql.rb +1 -1
- data/lib/brakeman/options.rb +4 -0
- data/lib/brakeman/processors/alias_processor.rb +1 -2
- data/lib/brakeman/processors/lib/module_helper.rb +31 -1
- data/lib/brakeman/processors/library_processor.rb +6 -0
- data/lib/brakeman/scanner.rb +104 -42
- data/lib/brakeman/tracker/controller.rb +14 -10
- data/lib/brakeman/tracker.rb +1 -1
- data/lib/brakeman/version.rb +1 -1
- data/lib/brakeman/warning_codes.rb +1 -0
- metadata +56 -55
- /data/bundle/ruby/3.1.0/gems/{rexml-3.2.5 → rexml-3.2.6}/LICENSE.txt +0 -0
- /data/bundle/ruby/3.1.0/gems/{rexml-3.2.5 → rexml-3.2.6}/lib/rexml/attlistdecl.rb +0 -0
- /data/bundle/ruby/3.1.0/gems/{rexml-3.2.5 → rexml-3.2.6}/lib/rexml/cdata.rb +0 -0
- /data/bundle/ruby/3.1.0/gems/{rexml-3.2.5 → rexml-3.2.6}/lib/rexml/child.rb +0 -0
- /data/bundle/ruby/3.1.0/gems/{rexml-3.2.5 → rexml-3.2.6}/lib/rexml/comment.rb +0 -0
- /data/bundle/ruby/3.1.0/gems/{rexml-3.2.5 → rexml-3.2.6}/lib/rexml/doctype.rb +0 -0
- /data/bundle/ruby/3.1.0/gems/{rexml-3.2.5 → rexml-3.2.6}/lib/rexml/dtd/attlistdecl.rb +0 -0
- /data/bundle/ruby/3.1.0/gems/{rexml-3.2.5 → rexml-3.2.6}/lib/rexml/dtd/dtd.rb +0 -0
- /data/bundle/ruby/3.1.0/gems/{rexml-3.2.5 → rexml-3.2.6}/lib/rexml/dtd/elementdecl.rb +0 -0
- /data/bundle/ruby/3.1.0/gems/{rexml-3.2.5 → rexml-3.2.6}/lib/rexml/dtd/entitydecl.rb +0 -0
- /data/bundle/ruby/3.1.0/gems/{rexml-3.2.5 → rexml-3.2.6}/lib/rexml/dtd/notationdecl.rb +0 -0
- /data/bundle/ruby/3.1.0/gems/{rexml-3.2.5 → rexml-3.2.6}/lib/rexml/encoding.rb +0 -0
- /data/bundle/ruby/3.1.0/gems/{rexml-3.2.5 → rexml-3.2.6}/lib/rexml/formatters/default.rb +0 -0
- /data/bundle/ruby/3.1.0/gems/{rexml-3.2.5 → rexml-3.2.6}/lib/rexml/formatters/transitive.rb +0 -0
- /data/bundle/ruby/3.1.0/gems/{rexml-3.2.5 → rexml-3.2.6}/lib/rexml/functions.rb +0 -0
- /data/bundle/ruby/3.1.0/gems/{rexml-3.2.5 → rexml-3.2.6}/lib/rexml/instruction.rb +0 -0
- /data/bundle/ruby/3.1.0/gems/{rexml-3.2.5 → rexml-3.2.6}/lib/rexml/light/node.rb +0 -0
- /data/bundle/ruby/3.1.0/gems/{rexml-3.2.5 → rexml-3.2.6}/lib/rexml/node.rb +0 -0
- /data/bundle/ruby/3.1.0/gems/{rexml-3.2.5 → rexml-3.2.6}/lib/rexml/output.rb +0 -0
- /data/bundle/ruby/3.1.0/gems/{rexml-3.2.5 → rexml-3.2.6}/lib/rexml/parent.rb +0 -0
- /data/bundle/ruby/3.1.0/gems/{rexml-3.2.5 → rexml-3.2.6}/lib/rexml/parseexception.rb +0 -0
- /data/bundle/ruby/3.1.0/gems/{rexml-3.2.5 → rexml-3.2.6}/lib/rexml/parsers/baseparser.rb +0 -0
- /data/bundle/ruby/3.1.0/gems/{rexml-3.2.5 → rexml-3.2.6}/lib/rexml/parsers/lightparser.rb +0 -0
- /data/bundle/ruby/3.1.0/gems/{rexml-3.2.5 → rexml-3.2.6}/lib/rexml/parsers/pullparser.rb +0 -0
- /data/bundle/ruby/3.1.0/gems/{rexml-3.2.5 → rexml-3.2.6}/lib/rexml/parsers/sax2parser.rb +0 -0
- /data/bundle/ruby/3.1.0/gems/{rexml-3.2.5 → rexml-3.2.6}/lib/rexml/parsers/streamparser.rb +0 -0
- /data/bundle/ruby/3.1.0/gems/{rexml-3.2.5 → rexml-3.2.6}/lib/rexml/parsers/treeparser.rb +0 -0
- /data/bundle/ruby/3.1.0/gems/{rexml-3.2.5 → rexml-3.2.6}/lib/rexml/parsers/ultralightparser.rb +0 -0
- /data/bundle/ruby/3.1.0/gems/{rexml-3.2.5 → rexml-3.2.6}/lib/rexml/quickpath.rb +0 -0
- /data/bundle/ruby/3.1.0/gems/{rexml-3.2.5 → rexml-3.2.6}/lib/rexml/sax2listener.rb +0 -0
- /data/bundle/ruby/3.1.0/gems/{rexml-3.2.5 → rexml-3.2.6}/lib/rexml/security.rb +0 -0
- /data/bundle/ruby/3.1.0/gems/{rexml-3.2.5 → rexml-3.2.6}/lib/rexml/source.rb +0 -0
- /data/bundle/ruby/3.1.0/gems/{rexml-3.2.5 → rexml-3.2.6}/lib/rexml/streamlistener.rb +0 -0
- /data/bundle/ruby/3.1.0/gems/{rexml-3.2.5 → rexml-3.2.6}/lib/rexml/undefinednamespaceexception.rb +0 -0
- /data/bundle/ruby/3.1.0/gems/{rexml-3.2.5 → rexml-3.2.6}/lib/rexml/validation/relaxng.rb +0 -0
- /data/bundle/ruby/3.1.0/gems/{rexml-3.2.5 → rexml-3.2.6}/lib/rexml/validation/validation.rb +0 -0
- /data/bundle/ruby/3.1.0/gems/{rexml-3.2.5 → rexml-3.2.6}/lib/rexml/validation/validationexception.rb +0 -0
- /data/bundle/ruby/3.1.0/gems/{rexml-3.2.5 → rexml-3.2.6}/lib/rexml/xmldecl.rb +0 -0
- /data/bundle/ruby/3.1.0/gems/{rexml-3.2.5 → rexml-3.2.6}/lib/rexml/xmltokens.rb +0 -0
- /data/bundle/ruby/3.1.0/gems/{rexml-3.2.5 → rexml-3.2.6}/lib/rexml/xpath.rb +0 -0
- /data/bundle/ruby/3.1.0/gems/{rexml-3.2.5 → rexml-3.2.6}/lib/rexml/xpath_parser.rb +0 -0
- /data/bundle/ruby/3.1.0/gems/{rexml-3.2.5 → rexml-3.2.6}/lib/rexml.rb +0 -0
@@ -26,10 +26,12 @@
|
|
26
26
|
# - REXML::Document.
|
27
27
|
# - REXML::Element.
|
28
28
|
#
|
29
|
+
# There's also an {REXML tutorial}[doc/rexml/tutorial_rdoc.html].
|
30
|
+
#
|
29
31
|
module REXML
|
30
32
|
COPYRIGHT = "Copyright © 2001-2008 Sean Russell <ser@germane-software.com>"
|
31
33
|
DATE = "2008/019"
|
32
|
-
VERSION = "3.2.
|
34
|
+
VERSION = "3.2.6"
|
33
35
|
REVISION = ""
|
34
36
|
|
35
37
|
Copyright = COPYRIGHT
|
@@ -1,4 +1,4 @@
|
|
1
|
-
# frozen_string_literal:
|
1
|
+
# frozen_string_literal: true
|
2
2
|
require_relative 'security'
|
3
3
|
require_relative 'entity'
|
4
4
|
require_relative 'doctype'
|
@@ -131,7 +131,7 @@ module REXML
|
|
131
131
|
def Text.check string, pattern, doctype
|
132
132
|
|
133
133
|
# illegal anywhere
|
134
|
-
if string
|
134
|
+
if !string.match?(VALID_XML_CHARS)
|
135
135
|
if String.method_defined? :encode
|
136
136
|
string.chars.each do |c|
|
137
137
|
case c.ord
|
@@ -371,7 +371,7 @@ module REXML
|
|
371
371
|
copy = input.to_s
|
372
372
|
# Doing it like this rather than in a loop improves the speed
|
373
373
|
#copy = copy.gsub( EREFERENCE, '&' )
|
374
|
-
copy = copy.gsub( "&", "&" )
|
374
|
+
copy = copy.gsub( "&", "&" ) if copy.include?("&")
|
375
375
|
if doctype
|
376
376
|
# Replace all ampersands that aren't part of an entity
|
377
377
|
doctype.entities.each_value do |entity|
|
@@ -382,7 +382,9 @@ module REXML
|
|
382
382
|
else
|
383
383
|
# Replace all ampersands that aren't part of an entity
|
384
384
|
DocType::DEFAULT_ENTITIES.each_value do |entity|
|
385
|
-
|
385
|
+
if copy.include?(entity.value)
|
386
|
+
copy = copy.gsub(entity.value, "&#{entity.name};" )
|
387
|
+
end
|
386
388
|
end
|
387
389
|
end
|
388
390
|
copy
|
@@ -0,0 +1,53 @@
|
|
1
|
+
require 'brakeman/checks/base_check'
|
2
|
+
|
3
|
+
class Brakeman::CheckRansack < Brakeman::BaseCheck
|
4
|
+
Brakeman::Checks.add self
|
5
|
+
|
6
|
+
@description = "Checks for dangerous use of the Ransack library"
|
7
|
+
|
8
|
+
def run_check
|
9
|
+
return unless version_between? "0.0.0", "3.99", tracker.config.gem_version(:ransack)
|
10
|
+
check_ransack_calls
|
11
|
+
end
|
12
|
+
|
13
|
+
def check_ransack_calls
|
14
|
+
tracker.find_call(method: :ransack, nested: true).each do |result|
|
15
|
+
next unless original? result
|
16
|
+
|
17
|
+
call = result[:call]
|
18
|
+
arg = call.first_arg
|
19
|
+
|
20
|
+
# If an allow list is defined anywhere in the
|
21
|
+
# class or super classes, consider it safe
|
22
|
+
class_name = result[:chain].first
|
23
|
+
|
24
|
+
next if ransackable_allow_list?(class_name)
|
25
|
+
|
26
|
+
if input = has_immediate_user_input?(arg)
|
27
|
+
confidence = if tracker.find_class(class_name).nil?
|
28
|
+
confidence = :low
|
29
|
+
elsif result[:location][:file].relative.include? 'admin'
|
30
|
+
confidence = :medium
|
31
|
+
else
|
32
|
+
confidence = :high
|
33
|
+
end
|
34
|
+
|
35
|
+
message = msg('Unrestricted search using ', msg_code('ransack'), ' library called with ', msg_input(input), '. Limit search by defining ', msg_code('ransackable_attributes'), ' and ', msg_code('ransackable_associations'), ' methods in class or upgrade Ransack to version 4.0.0 or newer')
|
36
|
+
|
37
|
+
warn result: result,
|
38
|
+
warning_type: 'Missing Authorization',
|
39
|
+
warning_code: :ransack_search,
|
40
|
+
message: message,
|
41
|
+
user_input: input,
|
42
|
+
confidence: confidence,
|
43
|
+
cwe_id: [862],
|
44
|
+
link: 'https://positive.security/blog/ransack-data-exfiltration'
|
45
|
+
end
|
46
|
+
end
|
47
|
+
end
|
48
|
+
|
49
|
+
def ransackable_allow_list? class_name
|
50
|
+
tracker.find_method(:ransackable_attributes, class_name, :class) and
|
51
|
+
tracker.find_method(:ransackable_associations, class_name, :class)
|
52
|
+
end
|
53
|
+
end
|
@@ -591,7 +591,7 @@ class Brakeman::CheckSQL < Brakeman::BaseCheck
|
|
591
591
|
:sanitize_sql_for_assignment, :sanitize_sql_for_conditions, :sanitize_sql_hash,
|
592
592
|
:sanitize_sql_hash_for_assignment, :sanitize_sql_hash_for_conditions,
|
593
593
|
:to_sql, :sanitize, :primary_key, :table_name_prefix, :table_name_suffix,
|
594
|
-
:where_values_hash, :foreign_key, :uuid
|
594
|
+
:where_values_hash, :foreign_key, :uuid, :escape, :escape_string
|
595
595
|
]
|
596
596
|
|
597
597
|
def ignore_methods_in_sql
|
data/lib/brakeman/options.rb
CHANGED
@@ -244,6 +244,10 @@ module Brakeman::Options
|
|
244
244
|
options[:debug] = true
|
245
245
|
end
|
246
246
|
|
247
|
+
opts.on "--timing", "Measure time for scan steps" do
|
248
|
+
options[:show_timing] = true
|
249
|
+
end
|
250
|
+
|
247
251
|
opts.on "-f",
|
248
252
|
"--format TYPE",
|
249
253
|
[:pdf, :text, :html, :csv, :tabs, :json, :markdown, :codeclimate, :cc, :plain, :table, :junit, :sarif, :sonar, :github],
|
@@ -84,6 +84,9 @@ module Brakeman::ModuleHelper
|
|
84
84
|
res.line(exp.line)
|
85
85
|
@current_method = nil
|
86
86
|
|
87
|
+
# TODO: if target is not self/nil, then
|
88
|
+
# the method should be added to `target`, not current class
|
89
|
+
|
87
90
|
if @current_class
|
88
91
|
@current_class.add_method @visibility, name, res, @current_file
|
89
92
|
elsif @current_module
|
@@ -96,7 +99,13 @@ module Brakeman::ModuleHelper
|
|
96
99
|
name = exp.method_name
|
97
100
|
|
98
101
|
@current_method = name
|
99
|
-
|
102
|
+
|
103
|
+
if @inside_sclass
|
104
|
+
res = Sexp.new :defs, s(:self), name, exp.formal_args, *process_all!(exp.body)
|
105
|
+
else
|
106
|
+
res = Sexp.new :defn, name, exp.formal_args, *process_all!(exp.body)
|
107
|
+
end
|
108
|
+
|
100
109
|
res.line(exp.line)
|
101
110
|
@current_method = nil
|
102
111
|
|
@@ -108,4 +117,25 @@ module Brakeman::ModuleHelper
|
|
108
117
|
|
109
118
|
res
|
110
119
|
end
|
120
|
+
|
121
|
+
# class << self
|
122
|
+
def process_sclass exp
|
123
|
+
@inside_sclass = true
|
124
|
+
|
125
|
+
process_all! exp
|
126
|
+
|
127
|
+
exp
|
128
|
+
ensure
|
129
|
+
@inside_sclass = false
|
130
|
+
end
|
131
|
+
|
132
|
+
def make_defs exp
|
133
|
+
# 'What if' there was some crazy code that had a
|
134
|
+
# defs inside a def inside an sclass? :|
|
135
|
+
return exp if node_type? exp, :defs
|
136
|
+
|
137
|
+
raise "Unexpected node type: #{exp.node_type}" unless node_type? exp, :defn
|
138
|
+
|
139
|
+
Sexp.new(:defs, s(:self), exp.method_name, exp.formal_args, *exp.body).line(exp.line)
|
140
|
+
end
|
111
141
|
end
|
@@ -30,6 +30,12 @@ class Brakeman::LibraryProcessor < Brakeman::BaseProcessor
|
|
30
30
|
end
|
31
31
|
|
32
32
|
def process_defn exp
|
33
|
+
# TODO: Why is this different from ModuleHelper?
|
34
|
+
|
35
|
+
if @inside_sclass
|
36
|
+
exp = make_defs(exp)
|
37
|
+
end
|
38
|
+
|
33
39
|
if exp.method_name == :initialize
|
34
40
|
@alias_processor.process_safely exp.body_list
|
35
41
|
@initializer_env = @alias_processor.only_ivars
|
data/lib/brakeman/scanner.rb
CHANGED
@@ -30,6 +30,7 @@ class Brakeman::Scanner
|
|
30
30
|
end
|
31
31
|
|
32
32
|
@processor = processor || Brakeman::Processor.new(@app_tree, options)
|
33
|
+
@show_timing = tracker.options[:debug] || tracker.options[:show_timing]
|
33
34
|
end
|
34
35
|
|
35
36
|
#Returns the Tracker generated from the scan
|
@@ -37,35 +38,89 @@ class Brakeman::Scanner
|
|
37
38
|
@processor.tracked_events
|
38
39
|
end
|
39
40
|
|
41
|
+
def process_step description
|
42
|
+
Brakeman.notify "#{description}...".ljust(40)
|
43
|
+
|
44
|
+
if @show_timing
|
45
|
+
start_t = Time.now
|
46
|
+
yield
|
47
|
+
duration = Time.now - start_t
|
48
|
+
|
49
|
+
Brakeman.notify "(#{description}) Duration: #{duration} seconds"
|
50
|
+
else
|
51
|
+
yield
|
52
|
+
end
|
53
|
+
end
|
54
|
+
|
55
|
+
def process_step_file description
|
56
|
+
if @show_timing
|
57
|
+
Brakeman.notify "Processing #{description}"
|
58
|
+
|
59
|
+
start_t = Time.now
|
60
|
+
yield
|
61
|
+
duration = Time.now - start_t
|
62
|
+
|
63
|
+
Brakeman.notify "(#{description}) Duration: #{duration} seconds"
|
64
|
+
else
|
65
|
+
yield
|
66
|
+
end
|
67
|
+
end
|
68
|
+
|
40
69
|
#Process everything in the Rails application
|
41
70
|
def process
|
42
|
-
|
43
|
-
|
44
|
-
|
45
|
-
|
46
|
-
|
47
|
-
|
48
|
-
|
49
|
-
|
50
|
-
|
51
|
-
|
52
|
-
|
53
|
-
|
54
|
-
|
55
|
-
|
56
|
-
|
57
|
-
|
58
|
-
|
59
|
-
|
60
|
-
|
61
|
-
|
62
|
-
|
63
|
-
|
64
|
-
|
65
|
-
|
66
|
-
|
67
|
-
|
68
|
-
|
71
|
+
process_step 'Processing gems' do
|
72
|
+
process_gems
|
73
|
+
end
|
74
|
+
|
75
|
+
process_step 'Processing configuration' do
|
76
|
+
guess_rails_version
|
77
|
+
process_config
|
78
|
+
end
|
79
|
+
|
80
|
+
process_step 'Parsing files' do
|
81
|
+
parse_files
|
82
|
+
end
|
83
|
+
|
84
|
+
process_step 'Detecting file types' do
|
85
|
+
detect_file_types
|
86
|
+
end
|
87
|
+
|
88
|
+
process_step 'Processing initializers' do
|
89
|
+
process_initializers
|
90
|
+
end
|
91
|
+
|
92
|
+
process_step 'Processing libs' do
|
93
|
+
process_libs
|
94
|
+
end
|
95
|
+
|
96
|
+
process_step 'Processing routes' do
|
97
|
+
process_routes
|
98
|
+
end
|
99
|
+
|
100
|
+
process_step 'Processing templates' do
|
101
|
+
process_templates
|
102
|
+
end
|
103
|
+
|
104
|
+
process_step 'Processing data flow in templates' do
|
105
|
+
process_template_data_flows
|
106
|
+
end
|
107
|
+
|
108
|
+
process_step 'Processing models' do
|
109
|
+
process_models
|
110
|
+
end
|
111
|
+
|
112
|
+
process_step 'Processing controllers' do
|
113
|
+
process_controllers
|
114
|
+
end
|
115
|
+
|
116
|
+
process_step 'Processing data flow in controllers' do
|
117
|
+
process_controller_data_flows
|
118
|
+
end
|
119
|
+
|
120
|
+
process_step 'Indexing call sites' do
|
121
|
+
index_call_sites
|
122
|
+
end
|
123
|
+
|
69
124
|
tracker
|
70
125
|
end
|
71
126
|
|
@@ -214,8 +269,9 @@ class Brakeman::Scanner
|
|
214
269
|
#Adds parsed information to tracker.initializers
|
215
270
|
def process_initializers
|
216
271
|
track_progress @file_list[:initializers] do |init|
|
217
|
-
|
218
|
-
|
272
|
+
process_step_file init[:path] do
|
273
|
+
process_initializer init
|
274
|
+
end
|
219
275
|
end
|
220
276
|
end
|
221
277
|
|
@@ -234,8 +290,9 @@ class Brakeman::Scanner
|
|
234
290
|
end
|
235
291
|
|
236
292
|
track_progress @file_list[:libs] do |lib|
|
237
|
-
|
238
|
-
|
293
|
+
process_step_file lib.path do
|
294
|
+
process_lib lib
|
295
|
+
end
|
239
296
|
end
|
240
297
|
end
|
241
298
|
|
@@ -266,8 +323,9 @@ class Brakeman::Scanner
|
|
266
323
|
#Adds processed controllers to tracker.controllers
|
267
324
|
def process_controllers
|
268
325
|
track_progress @file_list[:controllers] do |controller|
|
269
|
-
|
270
|
-
|
326
|
+
process_step_file controller.path do
|
327
|
+
process_controller controller
|
328
|
+
end
|
271
329
|
end
|
272
330
|
end
|
273
331
|
|
@@ -275,9 +333,10 @@ class Brakeman::Scanner
|
|
275
333
|
controllers = tracker.controllers.sort_by { |name, _| name.to_s }
|
276
334
|
|
277
335
|
track_progress controllers, "controllers" do |name, controller|
|
278
|
-
|
279
|
-
|
280
|
-
|
336
|
+
process_step_file name do
|
337
|
+
controller.src.each do |file, src|
|
338
|
+
@processor.process_controller_alias name, src, nil, file
|
339
|
+
end
|
281
340
|
end
|
282
341
|
end
|
283
342
|
|
@@ -300,8 +359,9 @@ class Brakeman::Scanner
|
|
300
359
|
templates = @file_list[:templates].sort_by { |t| t[:path] }
|
301
360
|
|
302
361
|
track_progress templates, "templates" do |template|
|
303
|
-
|
304
|
-
|
362
|
+
process_step_file template[:path] do
|
363
|
+
process_template template
|
364
|
+
end
|
305
365
|
end
|
306
366
|
end
|
307
367
|
|
@@ -313,8 +373,9 @@ class Brakeman::Scanner
|
|
313
373
|
templates = tracker.templates.sort_by { |name, _| name.to_s }
|
314
374
|
|
315
375
|
track_progress templates, "templates" do |name, template|
|
316
|
-
|
317
|
-
|
376
|
+
process_step_file name do
|
377
|
+
@processor.process_template_alias template
|
378
|
+
end
|
318
379
|
end
|
319
380
|
end
|
320
381
|
|
@@ -323,8 +384,9 @@ class Brakeman::Scanner
|
|
323
384
|
#Adds the processed models to tracker.models
|
324
385
|
def process_models
|
325
386
|
track_progress @file_list[:models] do |model|
|
326
|
-
|
327
|
-
|
387
|
+
process_step_file model[:path] do
|
388
|
+
process_model model[:path], model[:ast]
|
389
|
+
end
|
328
390
|
end
|
329
391
|
end
|
330
392
|
|
@@ -120,16 +120,20 @@ module Brakeman
|
|
120
120
|
filter[:methods] << a[1] if a.node_type == :lit
|
121
121
|
end
|
122
122
|
|
123
|
-
|
124
|
-
|
125
|
-
|
126
|
-
|
127
|
-
|
128
|
-
|
129
|
-
|
130
|
-
|
131
|
-
|
132
|
-
|
123
|
+
options = args.last
|
124
|
+
|
125
|
+
if hash? options
|
126
|
+
# Probably only one option,
|
127
|
+
# but this also avoids issues with kwsplats
|
128
|
+
hash_iterate(options) do |option, value|
|
129
|
+
case value.node_type
|
130
|
+
when :array
|
131
|
+
filter[option.value] = value.sexp_body.map {|v| v[1] }
|
132
|
+
when :lit, :str
|
133
|
+
filter[option.value] = value[1]
|
134
|
+
else
|
135
|
+
Brakeman.debug "[Notice] Unknown before_filter value: #{option} => #{value}"
|
136
|
+
end
|
133
137
|
end
|
134
138
|
else
|
135
139
|
filter[:all] = true
|
data/lib/brakeman/tracker.rb
CHANGED
@@ -245,7 +245,7 @@ class Brakeman::Tracker
|
|
245
245
|
end
|
246
246
|
|
247
247
|
# Not in any included modules, check the parent
|
248
|
-
@method_cache[cache_key] = find_method(method_name, klass.parent)
|
248
|
+
@method_cache[cache_key] = find_method(method_name, klass.parent, method_type)
|
249
249
|
end
|
250
250
|
end
|
251
251
|
|
data/lib/brakeman/version.rb
CHANGED
metadata
CHANGED
@@ -1,14 +1,14 @@
|
|
1
1
|
--- !ruby/object:Gem::Specification
|
2
2
|
name: brakeman
|
3
3
|
version: !ruby/object:Gem::Version
|
4
|
-
version: 6.0
|
4
|
+
version: 6.1.0
|
5
5
|
platform: ruby
|
6
6
|
authors:
|
7
7
|
- Justin Collins
|
8
8
|
autorequire:
|
9
9
|
bindir: bin
|
10
10
|
cert_chain: []
|
11
|
-
date: 2023-
|
11
|
+
date: 2023-12-05 00:00:00.000000000 Z
|
12
12
|
dependencies: []
|
13
13
|
description: Brakeman detects security vulnerabilities in Ruby on Rails applications
|
14
14
|
via static analysis.
|
@@ -134,59 +134,59 @@ files:
|
|
134
134
|
- bundle/ruby/3.1.0/gems/parallel-1.23.0/MIT-LICENSE.txt
|
135
135
|
- bundle/ruby/3.1.0/gems/parallel-1.23.0/lib/parallel.rb
|
136
136
|
- bundle/ruby/3.1.0/gems/parallel-1.23.0/lib/parallel/version.rb
|
137
|
-
- bundle/ruby/3.1.0/gems/rexml-3.2.
|
138
|
-
- bundle/ruby/3.1.0/gems/rexml-3.2.
|
139
|
-
- bundle/ruby/3.1.0/gems/rexml-3.2.
|
140
|
-
- bundle/ruby/3.1.0/gems/rexml-3.2.
|
141
|
-
- bundle/ruby/3.1.0/gems/rexml-3.2.
|
142
|
-
- bundle/ruby/3.1.0/gems/rexml-3.2.
|
143
|
-
- bundle/ruby/3.1.0/gems/rexml-3.2.
|
144
|
-
- bundle/ruby/3.1.0/gems/rexml-3.2.
|
145
|
-
- bundle/ruby/3.1.0/gems/rexml-3.2.
|
146
|
-
- bundle/ruby/3.1.0/gems/rexml-3.2.
|
147
|
-
- bundle/ruby/3.1.0/gems/rexml-3.2.
|
148
|
-
- bundle/ruby/3.1.0/gems/rexml-3.2.
|
149
|
-
- bundle/ruby/3.1.0/gems/rexml-3.2.
|
150
|
-
- bundle/ruby/3.1.0/gems/rexml-3.2.
|
151
|
-
- bundle/ruby/3.1.0/gems/rexml-3.2.
|
152
|
-
- bundle/ruby/3.1.0/gems/rexml-3.2.
|
153
|
-
- bundle/ruby/3.1.0/gems/rexml-3.2.
|
154
|
-
- bundle/ruby/3.1.0/gems/rexml-3.2.
|
155
|
-
- bundle/ruby/3.1.0/gems/rexml-3.2.
|
156
|
-
- bundle/ruby/3.1.0/gems/rexml-3.2.
|
157
|
-
- bundle/ruby/3.1.0/gems/rexml-3.2.
|
158
|
-
- bundle/ruby/3.1.0/gems/rexml-3.2.
|
159
|
-
- bundle/ruby/3.1.0/gems/rexml-3.2.
|
160
|
-
- bundle/ruby/3.1.0/gems/rexml-3.2.
|
161
|
-
- bundle/ruby/3.1.0/gems/rexml-3.2.
|
162
|
-
- bundle/ruby/3.1.0/gems/rexml-3.2.
|
163
|
-
- bundle/ruby/3.1.0/gems/rexml-3.2.
|
164
|
-
- bundle/ruby/3.1.0/gems/rexml-3.2.
|
165
|
-
- bundle/ruby/3.1.0/gems/rexml-3.2.
|
166
|
-
- bundle/ruby/3.1.0/gems/rexml-3.2.
|
167
|
-
- bundle/ruby/3.1.0/gems/rexml-3.2.
|
168
|
-
- bundle/ruby/3.1.0/gems/rexml-3.2.
|
169
|
-
- bundle/ruby/3.1.0/gems/rexml-3.2.
|
170
|
-
- bundle/ruby/3.1.0/gems/rexml-3.2.
|
171
|
-
- bundle/ruby/3.1.0/gems/rexml-3.2.
|
172
|
-
- bundle/ruby/3.1.0/gems/rexml-3.2.
|
173
|
-
- bundle/ruby/3.1.0/gems/rexml-3.2.
|
174
|
-
- bundle/ruby/3.1.0/gems/rexml-3.2.
|
175
|
-
- bundle/ruby/3.1.0/gems/rexml-3.2.
|
176
|
-
- bundle/ruby/3.1.0/gems/rexml-3.2.
|
177
|
-
- bundle/ruby/3.1.0/gems/rexml-3.2.
|
178
|
-
- bundle/ruby/3.1.0/gems/rexml-3.2.
|
179
|
-
- bundle/ruby/3.1.0/gems/rexml-3.2.
|
180
|
-
- bundle/ruby/3.1.0/gems/rexml-3.2.
|
181
|
-
- bundle/ruby/3.1.0/gems/rexml-3.2.
|
182
|
-
- bundle/ruby/3.1.0/gems/rexml-3.2.
|
183
|
-
- bundle/ruby/3.1.0/gems/rexml-3.2.
|
184
|
-
- bundle/ruby/3.1.0/gems/rexml-3.2.
|
185
|
-
- bundle/ruby/3.1.0/gems/rexml-3.2.
|
186
|
-
- bundle/ruby/3.1.0/gems/rexml-3.2.
|
187
|
-
- bundle/ruby/3.1.0/gems/rexml-3.2.
|
188
|
-
- bundle/ruby/3.1.0/gems/rexml-3.2.
|
189
|
-
- bundle/ruby/3.1.0/gems/rexml-3.2.
|
137
|
+
- bundle/ruby/3.1.0/gems/rexml-3.2.6/LICENSE.txt
|
138
|
+
- bundle/ruby/3.1.0/gems/rexml-3.2.6/NEWS.md
|
139
|
+
- bundle/ruby/3.1.0/gems/rexml-3.2.6/README.md
|
140
|
+
- bundle/ruby/3.1.0/gems/rexml-3.2.6/lib/rexml.rb
|
141
|
+
- bundle/ruby/3.1.0/gems/rexml-3.2.6/lib/rexml/attlistdecl.rb
|
142
|
+
- bundle/ruby/3.1.0/gems/rexml-3.2.6/lib/rexml/attribute.rb
|
143
|
+
- bundle/ruby/3.1.0/gems/rexml-3.2.6/lib/rexml/cdata.rb
|
144
|
+
- bundle/ruby/3.1.0/gems/rexml-3.2.6/lib/rexml/child.rb
|
145
|
+
- bundle/ruby/3.1.0/gems/rexml-3.2.6/lib/rexml/comment.rb
|
146
|
+
- bundle/ruby/3.1.0/gems/rexml-3.2.6/lib/rexml/doctype.rb
|
147
|
+
- bundle/ruby/3.1.0/gems/rexml-3.2.6/lib/rexml/document.rb
|
148
|
+
- bundle/ruby/3.1.0/gems/rexml-3.2.6/lib/rexml/dtd/attlistdecl.rb
|
149
|
+
- bundle/ruby/3.1.0/gems/rexml-3.2.6/lib/rexml/dtd/dtd.rb
|
150
|
+
- bundle/ruby/3.1.0/gems/rexml-3.2.6/lib/rexml/dtd/elementdecl.rb
|
151
|
+
- bundle/ruby/3.1.0/gems/rexml-3.2.6/lib/rexml/dtd/entitydecl.rb
|
152
|
+
- bundle/ruby/3.1.0/gems/rexml-3.2.6/lib/rexml/dtd/notationdecl.rb
|
153
|
+
- bundle/ruby/3.1.0/gems/rexml-3.2.6/lib/rexml/element.rb
|
154
|
+
- bundle/ruby/3.1.0/gems/rexml-3.2.6/lib/rexml/encoding.rb
|
155
|
+
- bundle/ruby/3.1.0/gems/rexml-3.2.6/lib/rexml/entity.rb
|
156
|
+
- bundle/ruby/3.1.0/gems/rexml-3.2.6/lib/rexml/formatters/default.rb
|
157
|
+
- bundle/ruby/3.1.0/gems/rexml-3.2.6/lib/rexml/formatters/pretty.rb
|
158
|
+
- bundle/ruby/3.1.0/gems/rexml-3.2.6/lib/rexml/formatters/transitive.rb
|
159
|
+
- bundle/ruby/3.1.0/gems/rexml-3.2.6/lib/rexml/functions.rb
|
160
|
+
- bundle/ruby/3.1.0/gems/rexml-3.2.6/lib/rexml/instruction.rb
|
161
|
+
- bundle/ruby/3.1.0/gems/rexml-3.2.6/lib/rexml/light/node.rb
|
162
|
+
- bundle/ruby/3.1.0/gems/rexml-3.2.6/lib/rexml/namespace.rb
|
163
|
+
- bundle/ruby/3.1.0/gems/rexml-3.2.6/lib/rexml/node.rb
|
164
|
+
- bundle/ruby/3.1.0/gems/rexml-3.2.6/lib/rexml/output.rb
|
165
|
+
- bundle/ruby/3.1.0/gems/rexml-3.2.6/lib/rexml/parent.rb
|
166
|
+
- bundle/ruby/3.1.0/gems/rexml-3.2.6/lib/rexml/parseexception.rb
|
167
|
+
- bundle/ruby/3.1.0/gems/rexml-3.2.6/lib/rexml/parsers/baseparser.rb
|
168
|
+
- bundle/ruby/3.1.0/gems/rexml-3.2.6/lib/rexml/parsers/lightparser.rb
|
169
|
+
- bundle/ruby/3.1.0/gems/rexml-3.2.6/lib/rexml/parsers/pullparser.rb
|
170
|
+
- bundle/ruby/3.1.0/gems/rexml-3.2.6/lib/rexml/parsers/sax2parser.rb
|
171
|
+
- bundle/ruby/3.1.0/gems/rexml-3.2.6/lib/rexml/parsers/streamparser.rb
|
172
|
+
- bundle/ruby/3.1.0/gems/rexml-3.2.6/lib/rexml/parsers/treeparser.rb
|
173
|
+
- bundle/ruby/3.1.0/gems/rexml-3.2.6/lib/rexml/parsers/ultralightparser.rb
|
174
|
+
- bundle/ruby/3.1.0/gems/rexml-3.2.6/lib/rexml/parsers/xpathparser.rb
|
175
|
+
- bundle/ruby/3.1.0/gems/rexml-3.2.6/lib/rexml/quickpath.rb
|
176
|
+
- bundle/ruby/3.1.0/gems/rexml-3.2.6/lib/rexml/rexml.rb
|
177
|
+
- bundle/ruby/3.1.0/gems/rexml-3.2.6/lib/rexml/sax2listener.rb
|
178
|
+
- bundle/ruby/3.1.0/gems/rexml-3.2.6/lib/rexml/security.rb
|
179
|
+
- bundle/ruby/3.1.0/gems/rexml-3.2.6/lib/rexml/source.rb
|
180
|
+
- bundle/ruby/3.1.0/gems/rexml-3.2.6/lib/rexml/streamlistener.rb
|
181
|
+
- bundle/ruby/3.1.0/gems/rexml-3.2.6/lib/rexml/text.rb
|
182
|
+
- bundle/ruby/3.1.0/gems/rexml-3.2.6/lib/rexml/undefinednamespaceexception.rb
|
183
|
+
- bundle/ruby/3.1.0/gems/rexml-3.2.6/lib/rexml/validation/relaxng.rb
|
184
|
+
- bundle/ruby/3.1.0/gems/rexml-3.2.6/lib/rexml/validation/validation.rb
|
185
|
+
- bundle/ruby/3.1.0/gems/rexml-3.2.6/lib/rexml/validation/validationexception.rb
|
186
|
+
- bundle/ruby/3.1.0/gems/rexml-3.2.6/lib/rexml/xmldecl.rb
|
187
|
+
- bundle/ruby/3.1.0/gems/rexml-3.2.6/lib/rexml/xmltokens.rb
|
188
|
+
- bundle/ruby/3.1.0/gems/rexml-3.2.6/lib/rexml/xpath.rb
|
189
|
+
- bundle/ruby/3.1.0/gems/rexml-3.2.6/lib/rexml/xpath_parser.rb
|
190
190
|
- bundle/ruby/3.1.0/gems/ruby2ruby-2.4.4/History.rdoc
|
191
191
|
- bundle/ruby/3.1.0/gems/ruby2ruby-2.4.4/Manifest.txt
|
192
192
|
- bundle/ruby/3.1.0/gems/ruby2ruby-2.4.4/README.rdoc
|
@@ -472,6 +472,7 @@ files:
|
|
472
472
|
- lib/brakeman/checks/check_pathname.rb
|
473
473
|
- lib/brakeman/checks/check_permit_attributes.rb
|
474
474
|
- lib/brakeman/checks/check_quote_table_name.rb
|
475
|
+
- lib/brakeman/checks/check_ransack.rb
|
475
476
|
- lib/brakeman/checks/check_redirect.rb
|
476
477
|
- lib/brakeman/checks/check_regex_dos.rb
|
477
478
|
- lib/brakeman/checks/check_render.rb
|
File without changes
|
File without changes
|
File without changes
|
File without changes
|
File without changes
|
File without changes
|
File without changes
|
File without changes
|
File without changes
|
File without changes
|
File without changes
|
File without changes
|
File without changes
|
File without changes
|
File without changes
|
File without changes
|
File without changes
|