brakecheck 0.1.8 → 0.1.9

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 1f86fc95232d0cd5d6053045857fddb8e219701d
-  data.tar.gz: 7adf75f80ca779ed4fa29118fcb4c1b4e4efd9ea
+  metadata.gz: e682c69de61ad736e0f3f3ffbc44dd429054cfd1
+  data.tar.gz: 281099bff9ad2c4b89b5acfe16a9239d98270ca2
 SHA512:
-  metadata.gz: f66c71aff2839bed21fc02360495bf19c6cb0eee9d439c5a91fa15f53ca3216aac0ea6488677bfeb7580c59ad8ca1dd37c2294733b8401a96f70aaba7cbcce11
-  data.tar.gz: f091d34aa833949d3f44491bf40dfff2c68cfa37aab9bb3e2e92e7652ed06c071f6367fb22daf4af8f96958a6a035bf02fd7240315da846396004a691d57593b
+  metadata.gz: d6b159898c555ba7324d825203a4a511d9e0ba9edd6e2d2a8a4849bf0a93883b99b4ea37fe55f37e77114dae59f8b1bdb335efd3090f6e36f2e583f7e489153a
+  data.tar.gz: 4cb5adf1d1e3893a60c81708a288340f6dc31add67c8743833609320edd7bdc27f27f69301ada907edf3ae2917f55de49e081e0f969c8932a13dcae3a1da26bc

data/README.md

@@ -1,37 +1,39 @@
 # Brakecheck
 
-Test breakage when important gems are stale.
-
-## Why?!? What's wrong with Bundler?
-
-We use brakeman regularly and it's important to keep that up to date. This breaks the build if brakeman is not current. Bundler still requires that somebody run bundle update.
+Test breakage when important gems are stale, to always have the latest versions of rubocop/brakeman/bundler-audit etc.
 
 ## Installation
 
-Add this line to your application's Gemfile:
 
 ```ruby
-gem 'brakecheck'
+# Gemfile
+gem 'brakecheck', group: :test, require: false
 ```
 
 And then execute:
 
-    $ bundle
+```
+bundle
+```
 
 Or install it yourself as:
 
-    $ gem install brakecheck
+```
+gem install brakecheck
+```
 
 ## Usage
 
-1. Create a basic test
-2. `include Brakecheck`
-3. expect(gem_name).to be_the_latest_version
+### CLI
+
+```
+brakecheck rubocop
+```
 
-Full example:
+### RSpec
 
 ```ruby
-require 'brakecheck'
+require 'brakecheck/rspec'
 
 describe "Brakeman" do
   before do

data/bin/brakecheck

@@ -1,5 +1,11 @@
 #!/usr/bin/env ruby
+require 'brakecheck'
+abort "Need gem name as only argument" unless ARGV.size == 1
+gem_name = ARGV[0]
 
-require "bundler/setup"
-require 'rspec'
-RSpec::Core::Runner.run([File.join(__FILE__, "..", "..", "lib", "bin_test.rb")])
+success, message = Brakecheck::Core.compare(gem_name)
+if success
+  puts message
+else
+  abort message
+end

data/brakecheck.gemspec

@@ -1,7 +1,4 @@
-# coding: utf-8
-lib = File.expand_path('../lib', __FILE__)
-$LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
-require 'brakecheck/version'
+require './lib/brakecheck/version'
 
 Gem::Specification.new do |spec|
   spec.name          = "brakecheck"
@@ -14,19 +11,12 @@ Gem::Specification.new do |spec|
   spec.homepage      = "https://github.com/apanzerj/brakecheck"
   spec.license       = "MIT"
 
-  # Prevent pushing this gem to RubyGems.org. To allow pushes either set the 'allowed_push_host'
-  # to allow pushing to a single host or delete this section to allow pushing to any host.
   spec.files         = `git ls-files -z`.split("\x0").reject { |f| f.match(%r{^(test|spec|features)/}) }
-  spec.bindir        = "bin"
   spec.executables   = ['brakecheck']
-  spec.require_paths = ["lib"]
 
   spec.add_development_dependency "bundler", "~> 1.12"
   spec.add_development_dependency "rake", "~> 10.0"
-  spec.add_runtime_dependency "rspec", "~> 3.0"
+  spec.add_development_dependency "rspec"
   spec.add_development_dependency "webmock"
   spec.add_development_dependency "pry"
-  spec.add_runtime_dependency "minitest"
-  spec.add_runtime_dependency "faraday"
-  spec.add_runtime_dependency "faraday_middleware"
 end

data/lib/brakecheck.rb

@@ -1,51 +1,32 @@
 require "brakecheck/version"
-require "faraday"
-require "faraday_middleware"
+require "open-uri"
+require "bundler"
 
 module Brakecheck
   class Core
-    attr_reader :client
+    RUBYGEMS_HOST = "https://rubygems.org"
+    LOCK = Bundler.default_lockfile
 
     def self.latest(gem_name)
-      new.client.get("#{gem_name}/latest.json").body['version']
+      open("#{RUBYGEMS_HOST}/api/v1/versions/#{gem_name}/latest.json").read[/"version":"(.+?)"/, 1]
+    rescue StandardError
+      nil
     end
 
-    def client
-      @client = Faraday.new(:url => "https://rubygems.org/api/v1/versions") do |faraday|
-        faraday.request       :url_encoded
-        faraday.adapter       Faraday.default_adapter
-        faraday.use           FaradayMiddleware::ParseJson
-      end
+    def self.local(gem_name)
+      lock = Bundler::LockfileParser.new(Bundler.read_file(LOCK))
+      return unless spec = lock.specs.detect { |s| s.name == gem_name }
+      spec.version.to_s
     end
-  end
-
-  module Rspec
-    require 'rspec/expectations'
-
-    RSpec::Matchers.define :be_the_latest_version do
-      match do |gem_name|
-        spec_from_file = loaded_specs(gem_name)
-        Brakecheck::Core.latest(gem_name) == spec_from_file
-      end
 
-      failure_message do |gem_name|
-        if loaded_specs(gem_name) == :not_in_bundle
-          "that gem is not in the bundle"
-        else
-          "expected #{gem_name} to be #{Brakecheck::Core.latest(gem_name)} but was actually #{loaded_specs(gem_name)}."
-        end
-      end
-
-      def loaded_specs(gem_name)
-        gem_here = specs.detect do |specs|
-          specs.name == gem_name
-        end
-
-        gem_here.nil? ? :not_in_bundle : gem_here.version.to_s
-      end
+    def self.compare(gem_name)
+      return [false, "#{gem_name} not found in #{LOCK.basename}"] unless local = local(gem_name)
+      return [false, "#{gem_name} not found on #{RUBYGEMS_HOST}"] unless latest = latest(gem_name)
 
-      def specs
-        @specs ||= Bundler::LockfileParser.new(Bundler.read_file(Bundler.default_lockfile)).specs
+      if latest == local
+        [true, "Latest #{gem_name} #{latest} installed"]
+      else
+        [false, "Local version #{local} of #{gem_name} is not the latest version #{latest}"]
       end
     end
   end

data/lib/brakecheck/rspec.rb

@@ -0,0 +1,17 @@
+require 'brakecheck'
+require 'rspec/expectations'
+
+module Brakecheck
+  module RSpec
+    ::RSpec::Matchers.define :be_the_latest_version do
+      match do |gem_name|
+        success, @message = Brakecheck::Core.compare(gem_name)
+        success
+      end
+
+      failure_message do |_gem_name|
+        @message
+      end
+    end
+  end
+end

data/lib/brakecheck/version.rb

@@ -1,3 +1,3 @@
 module Brakecheck
-  VERSION = "0.1.8"
+  VERSION = "0.1.9"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: brakecheck
 version: !ruby/object:Gem::Version
-  version: 0.1.8
+  version: 0.1.9
 platform: ruby
 authors:
 - Adam Panzer
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-11-11 00:00:00.000000000 Z
+date: 2016-12-06 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -40,20 +40,6 @@ dependencies:
         version: '10.0'
 - !ruby/object:Gem::Dependency
   name: rspec
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '3.0'
-  type: :runtime
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '3.0'
-- !ruby/object:Gem::Dependency
-  name: webmock
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -67,7 +53,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: pry
+  name: webmock
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -81,41 +67,13 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: minitest
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :runtime
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-- !ruby/object:Gem::Dependency
-  name: faraday
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :runtime
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-- !ruby/object:Gem::Dependency
-  name: faraday_middleware
+  name: pry
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
-  type: :runtime
+  type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
@@ -142,8 +100,8 @@ files:
 - bin/console
 - bin/setup
 - brakecheck.gemspec
-- lib/bin_test.rb
 - lib/brakecheck.rb
+- lib/brakecheck/rspec.rb
 - lib/brakecheck/version.rb
 homepage: https://github.com/apanzerj/brakecheck
 licenses:

data/lib/bin_test.rb

@@ -1,10 +0,0 @@
-require "brakecheck"
-RSpec.describe ENV['BRAKECHECK_GEM'] do
-  before do
-    WebMock.disable_net_connect!(allow: 'rubygems.org') if defined? WebMock
-  end
-
-  it 'is the lastest version' do
-    expect(ENV['BRAKECHECK_GEM']).to be_the_latest_version
-  end
-end