brainzlab 0.1.29 → 0.1.32

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 66b1827b6976d4cc3f0b16536eda54ac36ebc3fdba1f49369d93089198a99d73
-  data.tar.gz: 6a5d234eb169b6401ff226fe0944006fc3fea60df64a574aeb86f98466fd7c7d
+  metadata.gz: 2c27f671d247f5b7274905767ed060ec3bfc90c7e2389b8fe117fb300c09a59b
+  data.tar.gz: 3af6ac68bd7042f00aa16defa1c68d170653a9b053fe98cb375760b6f72bc14a
 SHA512:
-  metadata.gz: 2e958e58fdf83b5b472e3353a3f14b5b8d8a39315942eb74668735a2faefef9413d561b06b511bfff63fe2f633e8261320d3a8a7a25cf269ff0454283bfe6e36
-  data.tar.gz: 7601dbd331048b5fc8dd184c218ce9605ef010efd47d5b51fbeee52506f692bd4bad768219a4b8ad95562e9e28a006696886643c492fae303008ae8ca8c2795f
+  metadata.gz: 571ec070d0ff6d1f3503245a6c0e201d4d81903fda8a0d6ddf316ae7148c4bee6deb93299b76e5fc22839747d9f827cbf68da46dc04cb7d01abf2685580fb647
+  data.tar.gz: 9af9570ce725917a5093a9efbc46f81b13c454bb044549057eb49e43fa717e2750d28d580db055171bcb7e9d4c2cc2173e283bb47e7154510a16f1c82ac2ee3e

data/CHANGELOG.md

@@ -2,6 +2,18 @@
 
 All notable changes to this project will be documented in this file.
 
+## [0.1.31] - 2026-06-18
+
+### Fixed
+
+- **Health-check Engine no longer auto-draws routes at all.** Any `routes.draw` (class-body in ≤0.1.29, or an initializer in 0.1.30) triggers Devise's `RouteSet#finalize!` patch → `Devise.configure_warden!`. When that runs before Warden's middleware is configured, apps with `devise_scope` routes crash with `NoMethodError: undefined method 'failure_app=' for nil`. The engine's routes were unused (consumers use their own `/up` probe), so the auto-draw is removed entirely. The health logic remains available via `HealthCheck.run`; apps can expose HTTP endpoints from their own routes (see the comment in `health_check.rb`).
+
+## [0.1.30] - 2026-06-18
+
+### Fixed
+
+- **Health-check Engine route draw deferred to an initializer** (superseded by 0.1.31 — deferring wasn't enough, since the initializer still ran before Warden middleware).
+
 ## [0.1.25] - 2026-06-07
 
 ### Added

data/lib/brainzlab/rails/railtie.rb

@@ -30,8 +30,12 @@ module BrainzLab
           end
         end
 
-        # Add request context middleware (runs early)
-        app.middleware.insert_after ActionDispatch::RequestId, BrainzLab::Rails::Middleware
+        # Add request context middleware. Gated on `enabled` so the kill switch
+        # (BRAINZLAB_SDK_ENABLED=false) fully removes it — it previously loaded
+        # unconditionally, so disabling didn't stop its session interference.
+        if BrainzLab.configuration.enabled
+          app.middleware.insert_after ActionDispatch::RequestId, BrainzLab::Rails::Middleware
+        end
 
         # Add DevTools middlewares if enabled
         if BrainzLab.configuration.devtools_enabled
@@ -220,16 +224,10 @@ module BrainzLab
         # Store request_id in thread local for log subscriber
         Thread.current[:brainzlab_request_id] = request_id
 
-        # Capture session_id - access session to ensure it's loaded
-        if request.session.respond_to?(:id)
-          # Force session load by accessing it
-          session_id = begin
-            request.session.id
-          rescue StandardError
-            nil
-          end
-          context.session_id = session_id.to_s if session_id.present?
-        end
+        # NOTE: session_id is captured AFTER @app.call (see below), never here.
+        # Forcing a session load on the way in — before the app's session
+        # middleware and any reset_session (login) — drops the session on
+        # cookie/active_record_store apps, causing login loops.
 
         # Capture full request info for Reflex
         context.request_method = request.request_method
@@ -276,6 +274,19 @@ module BrainzLab
 
         status, headers, response = @app.call(env)
 
+        # Capture session_id now that the app (and its session middleware) has
+        # run. Read it only if the session was already loaded — never force a
+        # load — so we never disturb the session lifecycle / Set-Cookie.
+        begin
+          rack_session = env['rack.session']
+          if rack_session && (!rack_session.respond_to?(:loaded?) || rack_session.loaded?)
+            sid = rack_session.respond_to?(:id) ? rack_session.id : nil
+            context.session_id = sid.to_s if sid && !sid.to_s.empty?
+          end
+        rescue StandardError
+          nil
+        end
+
         # Add breadcrumb for response
         BrainzLab::Reflex.add_breadcrumb(
           "Response #{status}",

data/lib/brainzlab/utilities/health_check.rb

@@ -254,16 +254,26 @@ module BrainzLab
         end
       end
 
-      # Rails Engine for mounting health endpoints
+      # Rails Engine for the health endpoints.
+      #
+      # Routes are intentionally NOT auto-drawn at boot. Any `routes.draw`
+      # triggers Devise's RouteSet#finalize! patch, which calls
+      # Devise.configure_warden!; if that runs before Warden's middleware is
+      # configured (e.g. while another engine draws routes during early boot),
+      # apps with `devise_scope` routes crash with
+      # `NoMethodError: undefined method 'failure_app=' for nil`.
+      #
+      # The health logic is available directly via `HealthCheck.run`. To expose
+      # HTTP endpoints, draw them in your app's own routes (loaded at the correct
+      # boot phase), e.g.:
+      #   namespace :health, module: "brain_z_lab/utilities/health_check" do
+      #     get "/",      to: "health#show"
+      #     get "/live",  to: "health#live"
+      #     get "/ready", to: "health#ready"
+      #   end
       if defined?(::Rails::Engine)
         class Engine < ::Rails::Engine
           isolate_namespace BrainzLab::Utilities::HealthCheck
-
-          routes.draw do
-            get '/', to: 'health#show'
-            get '/live', to: 'health#live'
-            get '/ready', to: 'health#ready'
-          end
         end
       end
 

data/lib/brainzlab/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module BrainzLab
-  VERSION = '0.1.29'
+  VERSION = '0.1.32'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: brainzlab
 version: !ruby/object:Gem::Version
-  version: 0.1.29
+  version: 0.1.32
 platform: ruby
 authors:
 - BrainzLab