brainzlab 0.1.28 → 0.1.31

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: d9fdb52091b2fd8dc2da465cda4b4dc3f37f9b0bef3319f6b1bc6795a1a49c5d
-  data.tar.gz: 866b90f99c3f099618cb0cb981da3e75068824b89998adecad0edd5f89f9db68
+  metadata.gz: 5c7573fc851c73fe6b684611c10fb6799369c4817cc48b2fa7b18c6e84ac2188
+  data.tar.gz: 792060817bb43eafa993a0a34206d7fd53b30d94ebb861205b02775243f9292d
 SHA512:
-  metadata.gz: 3268bd499dfa2ae01e25bc18d57110ba45516d2a6971bca24158be6fd43d8c928ffb51f816946b7c3c084a8928d61c54b8507760deb78dec5a6f2288b5299db1
-  data.tar.gz: c7fd19b498c1d193f885ff0c0bddd86047006101195fe3a7f1a545ba3fa4e251691ce30ddf9589fbdd5b63dd5d98ab100527612b4c34e83c38d1fde8189b5211
+  metadata.gz: a16f37708f020bdfa8f3aaf3131ef7cbb572b086cea2ec1567eb56e2d810042ed90b2ff8f17c1d84401b50bbe1a66f1fb221b1ad8948c2df8d28b44aecf1f605
+  data.tar.gz: 3dd6909b4dc67fa7cb47767f6ca001e7df4547ebe5c1a99f08efe12f8d0285da58f62ef99f9ad9a9884b7526a12cd7a6018be45993b0dee131dda696fa37fb47

data/CHANGELOG.md

@@ -2,6 +2,18 @@
 
 All notable changes to this project will be documented in this file.
 
+## [0.1.31] - 2026-06-18
+
+### Fixed
+
+- **Health-check Engine no longer auto-draws routes at all.** Any `routes.draw` (class-body in ≤0.1.29, or an initializer in 0.1.30) triggers Devise's `RouteSet#finalize!` patch → `Devise.configure_warden!`. When that runs before Warden's middleware is configured, apps with `devise_scope` routes crash with `NoMethodError: undefined method 'failure_app=' for nil`. The engine's routes were unused (consumers use their own `/up` probe), so the auto-draw is removed entirely. The health logic remains available via `HealthCheck.run`; apps can expose HTTP endpoints from their own routes (see the comment in `health_check.rb`).
+
+## [0.1.30] - 2026-06-18
+
+### Fixed
+
+- **Health-check Engine route draw deferred to an initializer** (superseded by 0.1.31 — deferring wasn't enough, since the initializer still ran before Warden middleware).
+
 ## [0.1.25] - 2026-06-07
 
 ### Added

data/lib/brainzlab/pulse/client.rb

@@ -20,6 +20,13 @@ module BrainzLab
       def send_trace(payload)
         return unless @config.pulse_enabled && @config.pulse_valid?
 
+        # Per-trace sampling — the single chokepoint every trace path funnels
+        # through (request middleware, jobs, sidekiq, delayed_job, grape, manual
+        # traces). Decided once per complete trace (spans travel inline in the
+        # payload, so they never orphan) and BEFORE buffering, so dropped traces
+        # never reach the buffer/batch. Error traces are always kept.
+        return unless keep_trace?(payload)
+
         if @config.pulse_buffer_size > 1
           buffer_trace(payload)
         else
@@ -61,6 +68,15 @@ module BrainzLab
 
       private
 
+      # Keep error traces always; otherwise keep with probability = the
+      # effective per-tier sample rate (internal=0.1, standard=0.5, client=1.0).
+      def keep_trace?(payload)
+        return true if payload[:error] == true || payload['error'] == true
+
+        rate = @config.effective_pulse_sample_rate
+        rate >= 1.0 || rand < rate
+      end
+
       def buffer_trace(payload)
         should_flush = false
 

data/lib/brainzlab/pulse/tracer.rb

@@ -17,7 +17,6 @@ module BrainzLab
       end
 
       def start_trace(name, kind: 'custom', **attributes)
-        sample_rate = @config.effective_pulse_sample_rate
         trace = {
           trace_id: SecureRandom.uuid,
           name: name,
@@ -26,10 +25,6 @@ module BrainzLab
           environment: @config.environment,
           commit: @config.commit,
           host: @config.host,
-          sample_rate: sample_rate,
-          # Per-trace sampling decision (atomic, so spans never orphan). Errors
-          # override this at finish_trace and are always kept.
-          sampled: sample_rate >= 1.0 || rand < sample_rate,
           **attributes
         }
 
@@ -43,14 +38,8 @@ module BrainzLab
         trace = current_trace
         return unless trace
 
-        # Drop unsampled successful traces entirely (skip payload build + send);
-        # error traces are always kept regardless of the sampling decision.
-        unless error || trace.fetch(:sampled, true)
-          Thread.current[:brainzlab_pulse_trace] = nil
-          Thread.current[:brainzlab_pulse_spans] = nil
-          return
-        end
-
+        # Sampling is applied at the single send chokepoint (Pulse::Client#send_trace),
+        # which every trace path funnels through — so finish_trace just builds + sends.
         ended_at = Time.now.utc
         duration_ms = ((ended_at - trace[:started_at]) * 1000).round(2)
 

data/lib/brainzlab/utilities/health_check.rb

@@ -254,16 +254,26 @@ module BrainzLab
         end
       end
 
-      # Rails Engine for mounting health endpoints
+      # Rails Engine for the health endpoints.
+      #
+      # Routes are intentionally NOT auto-drawn at boot. Any `routes.draw`
+      # triggers Devise's RouteSet#finalize! patch, which calls
+      # Devise.configure_warden!; if that runs before Warden's middleware is
+      # configured (e.g. while another engine draws routes during early boot),
+      # apps with `devise_scope` routes crash with
+      # `NoMethodError: undefined method 'failure_app=' for nil`.
+      #
+      # The health logic is available directly via `HealthCheck.run`. To expose
+      # HTTP endpoints, draw them in your app's own routes (loaded at the correct
+      # boot phase), e.g.:
+      #   namespace :health, module: "brain_z_lab/utilities/health_check" do
+      #     get "/",      to: "health#show"
+      #     get "/live",  to: "health#live"
+      #     get "/ready", to: "health#ready"
+      #   end
       if defined?(::Rails::Engine)
         class Engine < ::Rails::Engine
           isolate_namespace BrainzLab::Utilities::HealthCheck
-
-          routes.draw do
-            get '/', to: 'health#show'
-            get '/live', to: 'health#live'
-            get '/ready', to: 'health#ready'
-          end
         end
       end
 

data/lib/brainzlab/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module BrainzLab
-  VERSION = '0.1.28'
+  VERSION = '0.1.31'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: brainzlab
 version: !ruby/object:Gem::Version
-  version: 0.1.28
+  version: 0.1.31
 platform: ruby
 authors:
 - BrainzLab