brainzlab 0.1.28 → 0.1.29

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: d9fdb52091b2fd8dc2da465cda4b4dc3f37f9b0bef3319f6b1bc6795a1a49c5d
-  data.tar.gz: 866b90f99c3f099618cb0cb981da3e75068824b89998adecad0edd5f89f9db68
+  metadata.gz: 66b1827b6976d4cc3f0b16536eda54ac36ebc3fdba1f49369d93089198a99d73
+  data.tar.gz: 6a5d234eb169b6401ff226fe0944006fc3fea60df64a574aeb86f98466fd7c7d
 SHA512:
-  metadata.gz: 3268bd499dfa2ae01e25bc18d57110ba45516d2a6971bca24158be6fd43d8c928ffb51f816946b7c3c084a8928d61c54b8507760deb78dec5a6f2288b5299db1
-  data.tar.gz: c7fd19b498c1d193f885ff0c0bddd86047006101195fe3a7f1a545ba3fa4e251691ce30ddf9589fbdd5b63dd5d98ab100527612b4c34e83c38d1fde8189b5211
+  metadata.gz: 2e958e58fdf83b5b472e3353a3f14b5b8d8a39315942eb74668735a2faefef9413d561b06b511bfff63fe2f633e8261320d3a8a7a25cf269ff0454283bfe6e36
+  data.tar.gz: 7601dbd331048b5fc8dd184c218ce9605ef010efd47d5b51fbeee52506f692bd4bad768219a4b8ad95562e9e28a006696886643c492fae303008ae8ca8c2795f

data/lib/brainzlab/pulse/client.rb

@@ -20,6 +20,13 @@ module BrainzLab
       def send_trace(payload)
         return unless @config.pulse_enabled && @config.pulse_valid?
 
+        # Per-trace sampling — the single chokepoint every trace path funnels
+        # through (request middleware, jobs, sidekiq, delayed_job, grape, manual
+        # traces). Decided once per complete trace (spans travel inline in the
+        # payload, so they never orphan) and BEFORE buffering, so dropped traces
+        # never reach the buffer/batch. Error traces are always kept.
+        return unless keep_trace?(payload)
+
         if @config.pulse_buffer_size > 1
           buffer_trace(payload)
         else
@@ -61,6 +68,15 @@ module BrainzLab
 
       private
 
+      # Keep error traces always; otherwise keep with probability = the
+      # effective per-tier sample rate (internal=0.1, standard=0.5, client=1.0).
+      def keep_trace?(payload)
+        return true if payload[:error] == true || payload['error'] == true
+
+        rate = @config.effective_pulse_sample_rate
+        rate >= 1.0 || rand < rate
+      end
+
       def buffer_trace(payload)
         should_flush = false
 

data/lib/brainzlab/pulse/tracer.rb

@@ -17,7 +17,6 @@ module BrainzLab
       end
 
       def start_trace(name, kind: 'custom', **attributes)
-        sample_rate = @config.effective_pulse_sample_rate
         trace = {
           trace_id: SecureRandom.uuid,
           name: name,
@@ -26,10 +25,6 @@ module BrainzLab
           environment: @config.environment,
           commit: @config.commit,
           host: @config.host,
-          sample_rate: sample_rate,
-          # Per-trace sampling decision (atomic, so spans never orphan). Errors
-          # override this at finish_trace and are always kept.
-          sampled: sample_rate >= 1.0 || rand < sample_rate,
           **attributes
         }
 
@@ -43,14 +38,8 @@ module BrainzLab
         trace = current_trace
         return unless trace
 
-        # Drop unsampled successful traces entirely (skip payload build + send);
-        # error traces are always kept regardless of the sampling decision.
-        unless error || trace.fetch(:sampled, true)
-          Thread.current[:brainzlab_pulse_trace] = nil
-          Thread.current[:brainzlab_pulse_spans] = nil
-          return
-        end
-
+        # Sampling is applied at the single send chokepoint (Pulse::Client#send_trace),
+        # which every trace path funnels through — so finish_trace just builds + sends.
         ended_at = Time.now.utc
         duration_ms = ((ended_at - trace[:started_at]) * 1000).round(2)
 

data/lib/brainzlab/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module BrainzLab
-  VERSION = '0.1.28'
+  VERSION = '0.1.29'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: brainzlab
 version: !ruby/object:Gem::Version
-  version: 0.1.28
+  version: 0.1.29
 platform: ruby
 authors:
 - BrainzLab