brainzlab 0.1.21 → 0.1.23

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 270efe6b3c0c0dbb73b656bf71512df7c076c099bfbbc338998339617041c3a8
-  data.tar.gz: f38258fa3dbdd3987514ec4cef4585ad3824c30f63ffc276789c156199d8553d
+  metadata.gz: bba9f09002a8dcd486cb1b110567274f2d558c471eed12657996fbb0589cbba0
+  data.tar.gz: 60a5d0b80300d8ccf3aa6aa48bd615514fd222246be796f3ba7e2c9260578050
 SHA512:
-  metadata.gz: 4ae23a5d31515df4c0a21b9b456321286dc0d6d085fa32a2b0da618f64289f6c9bd398849cc9e9461b84cb98f9daad5358f94804e2dffabbe250c7f722269227
-  data.tar.gz: 9b83420964240f4e97f54c39ff53d9b7a2418b1c507179c64c7212e4f7dba6155547efc9be71288460e6d83bd1710aaeb40eccbb6bc711bbb27b8718aaca7a98
+  metadata.gz: 2d4d0694747b4b08413636cb030465ad5babdd79388d8751f6fe6482229eea1dee0ca891711eb82a56641f745018b09c04cdfdcd87843ac1271c40f0b54bd2e8
+  data.tar.gz: cfd9ba154ac07f66eca51f22a4666a5c5a97db6c28265b725b7fcb1bbbd90a9064203957b0a26a39164201b963d55da8dbe7f23f45a9357cd89eccbe1cbce202

data/lib/brainzlab/configuration.rb

@@ -158,7 +158,13 @@ module BrainzLab
                   :devtools_expand_by_default,
                   :rails_instrumentation_handled_externally,
                   :development_db_path,
-                  :development_log_output
+                  :development_log_output,
+                  :slow_query_threshold,
+                  :very_slow_query_threshold,
+                  :slow_query_log_level,
+                  :very_slow_query_log_level,
+                  :n_plus_one_threshold,
+                  :n_plus_one_log_level
 
     # Services that should not track themselves to avoid circular dependencies
     SELF_TRACKING_SERVICES = {
@@ -362,6 +368,16 @@ module BrainzLab
       @http_ignore_hosts = %w[localhost 127.0.0.1]
       @redis_ignore_commands = %w[ping info] # Commands to skip tracking
 
+      # ActiveRecord slow-query / N+1 detection — all tunable so a single chatty
+      # default can't flood Recall. Slow-query duration is APM data (Pulse already
+      # records it), so it defaults to a quiet level (:debug) and a higher threshold.
+      @slow_query_threshold       = (ENV['BRAINZLAB_SLOW_QUERY_THRESHOLD'] || 500).to_i      # ms (was hardcoded 100)
+      @very_slow_query_threshold  = (ENV['BRAINZLAB_VERY_SLOW_QUERY_THRESHOLD'] || 2000).to_i # ms (was hardcoded 1000)
+      @slow_query_log_level       = (ENV['BRAINZLAB_SLOW_QUERY_LOG_LEVEL'] || 'debug').to_sym  # was :warn → floods
+      @very_slow_query_log_level  = (ENV['BRAINZLAB_VERY_SLOW_QUERY_LOG_LEVEL'] || 'warn').to_sym
+      @n_plus_one_threshold       = (ENV['BRAINZLAB_N_PLUS_ONE_THRESHOLD'] || 10).to_i        # was hardcoded 5
+      @n_plus_one_log_level       = (ENV['BRAINZLAB_N_PLUS_ONE_LOG_LEVEL'] || 'debug').to_sym  # was :warning
+
       # Log formatter settings
       @log_formatter_enabled = true
       @log_formatter_colors = nil # auto-detect TTY

data/lib/brainzlab/instrumentation/active_record.rb

@@ -6,11 +6,13 @@ module BrainzLab
       SCHEMA_QUERIES = %w[SCHEMA EXPLAIN].freeze
       INTERNAL_TABLES = %w[pg_ information_schema sqlite_ mysql.].freeze
 
-      # Thresholds for slow query detection (in milliseconds)
+      # Slow-query / N+1 thresholds + log levels are now configurable — see
+      # BrainzLab::Configuration (slow_query_threshold, very_slow_query_threshold,
+      # slow_query_log_level, very_slow_query_log_level, n_plus_one_threshold,
+      # n_plus_one_log_level) + their BRAINZLAB_* env vars. These constants are
+      # kept only as legacy fallbacks and are no longer read by the instrumentation.
       SLOW_QUERY_THRESHOLD = 100
       VERY_SLOW_QUERY_THRESHOLD = 1000
-
-      # N+1 detection settings
       N_PLUS_ONE_THRESHOLD = 5 # queries to same table in single request
       N_PLUS_ONE_WINDOW = 50   # max queries to track per request
 
@@ -58,7 +60,7 @@ module BrainzLab
           record_sql_span(event, duration)
 
           # Log slow queries to Recall
-          log_slow_query(event, duration) if duration >= SLOW_QUERY_THRESHOLD
+          log_slow_query(event, duration) if duration >= BrainzLab.configuration.slow_query_threshold
 
           # Track for N+1 detection
           track_query_for_n_plus_one(event)
@@ -79,9 +81,10 @@ module BrainzLab
                     end
 
           # Determine level based on duration
+          cfg = BrainzLab.configuration
           level = case duration
-                  when 0...SLOW_QUERY_THRESHOLD then :info
-                  when SLOW_QUERY_THRESHOLD...VERY_SLOW_QUERY_THRESHOLD then :warning
+                  when 0...cfg.slow_query_threshold then :info
+                  when cfg.slow_query_threshold...cfg.very_slow_query_threshold then :warning
                   else :error
                   end
 
@@ -146,7 +149,8 @@ module BrainzLab
           operation = extract_operation(sql)
           name = payload[:name] || 'SQL'
 
-          level = duration >= VERY_SLOW_QUERY_THRESHOLD ? :error : :warn
+          cfg = BrainzLab.configuration
+          level = duration >= cfg.very_slow_query_threshold ? cfg.very_slow_query_log_level : cfg.slow_query_log_level
 
           BrainzLab::Recall.send(
             level,
@@ -158,7 +162,7 @@ module BrainzLab
             row_count: payload[:row_count],
             affected_rows: payload[:affected_rows],
             connection_name: extract_connection_name(payload[:connection]),
-            threshold_exceeded: duration >= VERY_SLOW_QUERY_THRESHOLD ? 'critical' : 'warning'
+            threshold_exceeded: duration >= cfg.very_slow_query_threshold ? 'critical' : 'warning'
           )
         end
 
@@ -188,7 +192,7 @@ module BrainzLab
           end
 
           # Detect N+1 pattern
-          if tracker[:count] == N_PLUS_ONE_THRESHOLD
+          if tracker[:count] == BrainzLab.configuration.n_plus_one_threshold
             report_n_plus_one(table, tracker)
           end
         end
@@ -197,7 +201,7 @@ module BrainzLab
           BrainzLab::Reflex.add_breadcrumb(
             "Potential N+1 detected: #{tracker[:count]}+ queries to '#{table}'",
             category: 'db.n_plus_one',
-            level: :warning,
+            level: BrainzLab.configuration.n_plus_one_log_level,
             data: {
               table: table,
               query_count: tracker[:count],

data/lib/brainzlab/rails/log_formatter.rb

@@ -644,6 +644,17 @@ module BrainzLab
         obj.is_a?(Hash) || (!obj.is_a?(Array) && obj.respond_to?(:to_h) && obj.respond_to?(:each))
       end
 
+      # Convert hash-like values for display without raising. ActionController::Parameters
+      # raises UnfilteredParameters on #to_h when not permitted — use #to_unsafe_h (this
+      # is a log formatter, not a security boundary; param filtering happens elsewhere).
+      def safe_to_h(obj)
+        return obj.to_unsafe_h if obj.respond_to?(:to_unsafe_h)
+
+        obj.to_h
+      rescue StandardError
+        obj
+      end
+
       def format_params_toml(params, prefix = '', depth = 0)
         lines = []
         line_prefix = colorize("#{BOX[:vertical]}  ", :cyan)
@@ -654,11 +665,7 @@ module BrainzLab
 
           case value
           when Hash, ActionController::Parameters
-            value_hash = begin
-              value.to_h
-            rescue StandardError
-              value
-            end
+            value_hash = safe_to_h(value)
             if value_hash.keys.length <= 3 && value_hash.values.all? { |v| !hash_like?(v) && !v.is_a?(Array) }
               # Compact inline hash for simple cases
               inline = value_hash.map { |k, v| "#{k} = #{format_value(v)}" }.join(', ')
@@ -669,16 +676,12 @@ module BrainzLab
               value_hash.each do |k, v|
                 if hash_like?(v)
                   # Recursively format nested hashes
-                  lines << format_hash_nested(v.to_h, "#{full_key}.#{k}", depth + 1)
+                  lines << format_hash_nested(safe_to_h(v), "#{full_key}.#{k}", depth + 1)
                 elsif v.is_a?(Array) && hash_like?(v.first)
                   lines << "#{line_prefix}#{indent}  #{colorize("[[#{full_key}.#{k}]]",
                                                                 :gray)} #{colorize("# #{v.length} items", :gray)}"
                   if v.first
-                    first_hash = begin
-                      v.first.to_h
-                    rescue StandardError
-                      v.first
-                    end
+                    first_hash = safe_to_h(v.first)
                     first_hash.each do |nested_k, nested_v|
                       lines << "#{line_prefix}#{indent}  #{colorize(nested_k.to_s, :white)} = #{format_value(nested_v)}"
                     end
@@ -699,19 +702,11 @@ module BrainzLab
                                                           :gray)} #{colorize("# #{value.length} items", :gray)}"
               # Show first item fully expanded
               if value.first
-                first_item = begin
-                  value.first.to_h
-                rescue StandardError
-                  value.first
-                end
+                first_item = safe_to_h(value.first)
                 first_item.each do |k, v|
                   if hash_like?(v)
                     # Expand nested hash fully
-                    nested_hash = begin
-                      v.to_h
-                    rescue StandardError
-                      v
-                    end
+                    nested_hash = safe_to_h(v)
                     lines << "#{line_prefix}#{indent}  #{colorize("[#{k}]", :gray)}"
                     nested_hash.each do |nested_k, nested_v|
                       lines << "#{line_prefix}#{indent}    #{colorize(nested_k.to_s,

data/lib/brainzlab/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module BrainzLab
-  VERSION = '0.1.21'
+  VERSION = '0.1.23'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: brainzlab
 version: !ruby/object:Gem::Version
-  version: 0.1.21
+  version: 0.1.23
 platform: ruby
 authors:
 - BrainzLab