braintreehttp 0.1.3 → 0.1.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 599e49054f1dc90ce4af2229aba6e6bb6140143e
-  data.tar.gz: d9582efa699f71babf7f411744ca33efb34f2f46
+  metadata.gz: c27ebe667c362f44516138044f39c78650e219d0
+  data.tar.gz: 1c28e5cfaccc55dbd25aebd705c5c85ed5a732c8
 SHA512:
-  metadata.gz: 2e0fca1e69a0bf2bac1e6445bfc67d433c8323d8cdeeabe3b08437ec5c3fe1a0ce1225b0f68e98d0e72495c0e63905509f57af407c04a6ca2788994abb686e16
-  data.tar.gz: e1c67247bcf30af276952d34601a868d905b99e25cdcb1725ed6d7f66c95a1d5c08075a0b888cbd55212f153ee73dc510a67826302a8769f06613f1cb8ef5357
+  metadata.gz: f54685a7c757914557ba87bfff0676d10dbd4fbf5e90d2e9b1f8570c1317dd39bf6c62438eb935ceefbd146b898f7f4dec5a76cfe65ec21b347f0a19cc09845b
+  data.tar.gz: 7dd8391649bcf0f8a6797d4ed0cfadff17f0741886664018980e56af4b2a150cae3473d26b32577bd605a9b52e8ad18a4a997b8c9a87dd45648a76bbd1366436

data/braintreehttp.gemspec

@@ -4,7 +4,7 @@ Gem::Specification.new do |s|
   s.name = "braintreehttp"
   s.summary = "BraintreeHttp Client Library"
   s.description = "Used for generated API clients"
-  s.version = "0.1.3"
+  s.version = "0.1.4"
   s.license = "MIT"
   s.author = "Braintree"
   s.email = "code@getbraintree.com"

data/lib/braintreehttp/encoder.rb

@@ -3,31 +3,72 @@ require 'json'
 module BraintreeHttp
 
   class Encoder
+    def initialize
+      @encoders = [Json.new, Text.new]
+    end
 
     def serialize_request(req)
       raise UnsupportedEncodingError.new('HttpRequest did not have Content-Type header set') unless req.headers && (req.headers['content-type'] || req.headers['Content-Type'])
 
       content_type = req.headers['content-type'] || req.headers['Content-Type']
-      raise UnsupportedEncodingError.new("Unable to serialize request with Content-Type #{content_type}. Supported encodings are #{supported_encodings}") unless content_type == 'application/json'
+      content_type = content_type.first if content_type.kind_of?(Array)
+
+      enc = _encoder(content_type)
+      raise UnsupportedEncodingError.new("Unable to serialize request with Content-Type #{content_type}. Supported encodings are #{supported_encodings}") unless enc
 
-      JSON.generate(req.body)
+      enc.encode(req.body)
     end
 
     def deserialize_response(resp, headers)
       raise UnsupportedEncodingError.new('HttpResponse did not have Content-Type header set') unless headers && (headers['content-type'] || headers['Content-Type'])
 
       content_type = headers['content-type'] || headers['Content-Type']
-      raise UnsupportedEncodingError.new("Unable to deserialize response with Content-Type #{content_type}. Supported decodings are #{supported_decodings}") unless content_type.include? 'application/json'
+      content_type = content_type.first if content_type.kind_of?(Array)
+
+      enc = _encoder(content_type)
+      raise UnsupportedEncodingError.new("Unable to deserialize response with Content-Type #{content_type}. Supported decodings are #{supported_encodings}") unless enc
 
-      JSON.parse(resp)
+      enc.decode(resp)
     end
 
     def supported_encodings
-      ['application/json']
+      @encoders.map { |enc| enc.content_type.inspect }
+    end
+
+    def _encoder(content_type)
+      idx = @encoders.index { |enc| enc.content_type.match(content_type) }
+
+      @encoders[idx] if idx
+    end
+  end
+
+  class Json
+
+    def encode(body)
+      JSON.generate(body)
+    end
+
+    def decode(body)
+      JSON.parse(body)
+    end
+
+    def content_type
+      /^application\/json$/
+    end
+  end
+
+  class Text
+
+    def encode(body)
+      body.to_s
+    end
+
+    def decode(body)
+      body.to_s
     end
 
-    def supported_decodings
-      ['application/json']
+    def content_type
+      /^text\/.*/
     end
   end
 end

data/spec/braintreehttp/encoder_spec.rb

@@ -3,7 +3,7 @@ require 'ostruct'
 describe Encoder do
 
   describe 'serialize_request' do
-    it 'serializes the request' do
+    it 'serializes the request when content-type == application/json' do
       req = OpenStruct.new({
         :headers  => {
           "content-type" => "application/json"
@@ -25,6 +25,17 @@ describe Encoder do
       expect(Encoder.new.serialize_request(req)).to eq(expected)
     end
 
+    it 'serializes the request when content-type == text/*' do
+      req = OpenStruct.new({
+        :headers  => {
+          "content-type" => "text/plain"
+        },
+        :body => "some text"
+      })
+
+      expect(Encoder.new.serialize_request(req)).to eq("some text")
+    end
+
     it 'throws when content-type is not application/json' do
       req = OpenStruct.new({
         :headers  => {
@@ -33,7 +44,7 @@ describe Encoder do
         :body => { :string => "value" }
       })
 
-      expect{Encoder.new.serialize_request(req)}.to raise_error(UnsupportedEncodingError, /Unable to serialize request with Content-Type .*\. Supported encodings are \["application\/json"\]/)
+      expect{Encoder.new.serialize_request(req)}.to raise_error(UnsupportedEncodingError, /Unable to serialize request with Content-Type .*\. Supported encodings are .*/)
     end
 
     it 'throws when headers undefined' do
@@ -52,7 +63,7 @@ describe Encoder do
         "content-type" => ["application/xml"]
       }
 
-      expect{Encoder.new.deserialize_response(body, headers)}.to raise_error(UnsupportedEncodingError, /Unable to deserialize response with Content-Type .*\. Supported decodings are \["application\/json"\]/)
+      expect{Encoder.new.deserialize_response(body, headers)}.to raise_error(UnsupportedEncodingError, /Unable to deserialize response with Content-Type .*\. Supported decodings are .*/)
     end
 
     it 'throws when headers undefined' do
@@ -61,7 +72,7 @@ describe Encoder do
       expect{Encoder.new.deserialize_response(body, nil)}.to raise_error(UnsupportedEncodingError, 'HttpResponse did not have Content-Type header set')
     end
 
-    it 'deserializes the response' do
+    it 'deserializes the response when content-type == application/json' do
       expected = {
         "string" => "value",
         "number" => 1.23,
@@ -78,5 +89,12 @@ describe Encoder do
 
       expect(Encoder.new.deserialize_response(body, headers)).to eq(expected)
     end
+
+    it 'deserializes the response when content-type == text/*' do
+      headers = {"content-type" => ["text/plain"]}
+      body = 'some text'
+
+      expect(Encoder.new.deserialize_response(body, headers)).to eq('some text')
+    end
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: braintreehttp
 version: !ruby/object:Gem::Version
-  version: 0.1.3
+  version: 0.1.4
 platform: ruby
 authors:
 - Braintree
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-08-15 00:00:00.000000000 Z
+date: 2017-08-29 00:00:00.000000000 Z
 dependencies: []
 description: Used for generated API clients
 email: code@getbraintree.com
@@ -45,7 +45,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: braintreehttp
-rubygems_version: 2.2.2
+rubygems_version: 2.6.12
 signing_key: 
 specification_version: 4
 summary: BraintreeHttp Client Library