braintree 2.84.0 → 2.85.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 363bcd4d73f995c9a4d466742eeec1496685280b
-  data.tar.gz: a1cd82c6bb218c247760888361869e070290a74f
+  metadata.gz: b0d64ca677afdd3bc219c98009af627b4cbfaaaa
+  data.tar.gz: a5c8eafe9e54ce75579959bface19399b59ecf8e
 SHA512:
-  metadata.gz: 07ef9f0eafcf69cd852a6a296d3a3662915cd13460574b11af1dc111cf6c50febb6036563f27d625397a268e317f08156714064ce230797b4008a839bb8a2249
-  data.tar.gz: c85e68010fb8f18916c7ed9d71dec1e5ed9b97e494db6fc3e47b63561bd5fa1a42d4e4ececf6d8849ad4f0d1e37192ad5c0df006e67f10ae5a114d331821f568
+  metadata.gz: fc4bed06b88725a62739b7f2c2b014b19b42aaeb55a4ab7eb2d559aeb2c136b6d14ff60c684fbe44f2943a3c3119ec1be4eaba9adfda8a17601d05f63f79d993
+  data.tar.gz: 93eac87bd236a4923440f96413c19aad8ddf09bbbd7c2ab633bfe6ccd6645d70c737ce643de9204833bf585b2a811308a1f84f3d89c7526f8c9e691410523dd7

data/lib/braintree.rb

@@ -105,6 +105,9 @@ require "braintree/paginated_result"
 require "braintree/europe_bank_account"
 require "braintree/europe_bank_account_gateway"
 require "braintree/us_bank_account"
+require "braintree/us_bank_account_verification"
+require "braintree/us_bank_account_verification_gateway"
+require "braintree/us_bank_account_verification_search"
 require "braintree/us_bank_account_gateway"
 require "braintree/transaction/us_bank_account_details"
 require "braintree/sha256_digest"

data/lib/braintree/advanced_search.rb

@@ -62,6 +62,10 @@ module Braintree
       end
     end
 
+    class EndsWithNode < SearchNode # :nodoc:
+      operators :ends_with
+    end
+
     class MultipleValueOrTextNode < MultipleValueNode
       extend Forwardable
       def_delegators :@text_node, :contains, :ends_with, :is, :is_not, :starts_with
@@ -129,6 +133,10 @@ module Braintree
       _create_field_accessors(fields, DateRangeNode)
     end
 
+    def self.ends_with_fields(*fields)
+      _create_field_accessors(fields, EndsWithNode)
+    end
+
     def self._create_field_accessors(fields, node_class)
       fields.each do |field|
         define_method(field) do |*args|

data/lib/braintree/credit_card_verification_gateway.rb

@@ -7,7 +7,7 @@ module Braintree
     end
 
     def find(id)
-      raise ArgumentError if id.nil? || id.strip.to_s == ""
+      raise ArgumentError if id.nil? || id.to_s.strip == ""
       response = @config.http.get("#{@config.base_merchant_path}/verifications/#{id}")
       CreditCardVerification._new(response[:verification])
     rescue NotFoundError

data/lib/braintree/error_codes.rb

@@ -343,6 +343,8 @@ module Braintree
       PaymentMethodNonceCardTypeIsNotAccepted = "91567"
       PaymentMethodNonceConsumed = "91564"
       PaymentMethodNonceHasNoValidPaymentInstrumentType = "91569"
+      UsBankAccountNonceMustBePlaidVerified = "915171"
+      UsBankAccountNotVerified = "915172"
       PaymentMethodNonceLocked = "91566"
       PaymentMethodNonceUnknown = "91565"
       PaymentMethodTokenCardTypeIsNotAccepted = "91517"
@@ -612,6 +614,10 @@ module Braintree
       PaymentMethodNonceLocked = "93109"
       CannotForwardPaymentMethodType = "93107"
       PaymentMethodNoLongerSupported = "93117"
+
+      module Options
+        UsBankAccountVerificationMethodIsInvalid = "93121"
+      end
     end
 
     module AuthorizationFingerprint

data/lib/braintree/gateway.rb

@@ -112,6 +112,10 @@ module Braintree
       TestingGateway.new(self)
     end
 
+    def us_bank_account_verification
+      UsBankAccountVerificationGateway.new(self)
+    end
+
     def verification
       CreditCardVerificationGateway.new(self)
     end

data/lib/braintree/payment_method_gateway.rb

@@ -139,6 +139,8 @@ module Braintree
         SuccessfulResult.new(:payment_method => CoinbaseAccount._new(@gateway, response[:coinbase_account]))
       elsif response[:api_error_response]
         ErrorResult.new(@gateway, response[:api_error_response])
+      elsif response[:us_bank_account]
+        SuccessfulResult.new(:payment_method => UsBankAccount._new(@gateway, response[:us_bank_account]))
       elsif response
         SuccessfulResult.new(:payment_method => UnknownPaymentMethod._new(@gateway, response))
       else
@@ -163,7 +165,7 @@ module Braintree
       paypal_options_shipping_signature = AddressGateway._shared_signature
       options = [
         :make_default, :verification_merchant_account_id, :verify_card, :venmo_sdk_session,
-        :verification_amount,
+        :verification_amount, :us_bank_account_verification_method,
         :paypal => [
           :payee_email,
           :order_id,

data/lib/braintree/us_bank_account.rb

@@ -11,11 +11,19 @@ module Braintree
     attr_reader :last_4
     attr_reader :routing_number
     attr_reader :token
+    attr_reader :verifications
+    attr_reader :verified
 
     def initialize(gateway, attributes) # :nodoc:
       @gateway = gateway
       set_instance_variables_from_hash(attributes)
       @ach_mandate = AchMandate.new(attributes[:ach_mandate]) if attributes[:ach_mandate]
+
+      if attributes[:verifications]
+        @verifications = attributes[:verifications].map do |v|
+          UsBankAccountVerification._new(v)
+        end
+      end
     end
 
     def default?

data/lib/braintree/us_bank_account_verification.rb

@@ -0,0 +1,75 @@
+module Braintree
+  class UsBankAccountVerification
+    include BaseModule
+    include Braintree::Util::IdEquality
+
+    module Status
+      Failed = "failed"
+      GatewayRejected = "gateway_rejected"
+      ProcessorDeclined = "processor_declined"
+      Verified = "verified"
+
+      All = [Failed, GatewayRejected, ProcessorDeclined, Verified]
+    end
+
+    module VerificationMethod
+      IndependentCheck = "independent_check"
+      NetworkCheck = "network_check"
+      TokenizedCheck = "tokenized_check"
+
+      All = [IndependentCheck, NetworkCheck, TokenizedCheck]
+    end
+
+    attr_reader :id
+    attr_reader :status
+    attr_reader :verification_determined_at
+    attr_reader :verification_method
+    attr_reader :processor_response_code
+    attr_reader :processor_response_text
+    attr_reader :merchant_account_id
+    attr_reader :gateway_rejection_reason
+    attr_reader :us_bank_account
+    attr_reader :created_at
+
+    def initialize(attributes) # :nodoc:
+      set_instance_variables_from_hash(attributes)
+    end
+
+    def inspect # :nodoc:
+      attr_order = [
+        :status,
+        :processor_response_code,
+        :processor_response_text,
+        :merchant_account_id,
+        :gateway_rejection_reason,
+        :id,
+        :us_bank_account,
+        :verification_method,
+        :verification_determined_at,
+        :created_at
+      ]
+
+      formatted_attrs = attr_order.map do |attr|
+        "#{attr}: #{send(attr).inspect}"
+      end
+
+      "#<#{self.class} #{formatted_attrs.join(", ")}>"
+    end
+
+    class << self
+      protected :new
+    end
+
+    def self._new(*args) # :nodoc:
+      self.new *args
+    end
+
+    def self.find(*args)
+      Configuration.gateway.us_bank_account_verification.find(*args)
+    end
+
+    def self.search(&block)
+      Configuration.gateway.us_bank_account_verification.search(&block)
+    end
+  end
+end

data/lib/braintree/us_bank_account_verification_gateway.rb

@@ -0,0 +1,32 @@
+module Braintree
+  class UsBankAccountVerificationGateway
+    def initialize(gateway)
+      @gateway = gateway
+      @config = gateway.config
+      @config.assert_has_access_token_or_keys
+    end
+
+    def find(id)
+      raise ArgumentError if id.nil? || id.to_s.strip == ""
+      response = @config.http.get("#{@config.base_merchant_path}/us_bank_account_verifications/#{id}")
+      UsBankAccountVerification._new(response[:us_bank_account_verification])
+    rescue NotFoundError
+      raise NotFoundError, "verification with id #{id.inspect} not found"
+    end
+
+    def search(&block)
+      search = UsBankAccountVerificationSearch.new
+      block.call(search) if block
+
+      response = @config.http.post("#{@config.base_merchant_path}/us_bank_account_verifications/advanced_search_ids", {:search => search.to_hash})
+      ResourceCollection.new(response) { |ids| _fetch_verifications(search, ids) }
+    end
+
+    def _fetch_verifications(search, ids)
+      search.ids.in ids
+      response = @config.http.post("#{@config.base_merchant_path}/us_bank_account_verifications/advanced_search", {:search => search.to_hash})
+      attributes = response[:us_bank_account_verifications]
+      Util.extract_attribute_as_array(attributes, :us_bank_account_verification).map { |attrs| UsBankAccountVerification._new(attrs) }
+    end
+  end
+end

data/lib/braintree/us_bank_account_verification_search.rb

@@ -0,0 +1,19 @@
+module Braintree
+  class UsBankAccountVerificationSearch < AdvancedSearch # :nodoc:
+     text_fields(
+       :id,
+       :account_holder_name,
+       :routing_number,
+       :payment_method_token,
+       :customer_id,
+       :customer_email,
+     )
+
+    multiple_value_field :verification_method, :allows => UsBankAccountVerification::VerificationMethod::All
+    multiple_value_field :status, :allows => UsBankAccountVerification::Status::All
+    multiple_value_field :ids
+    ends_with_fields :account_number
+    range_fields :created_at
+    equality_fields :account_type
+  end
+end

data/lib/braintree/version.rb

@@ -1,7 +1,7 @@
 module Braintree
   module Version
     Major = 2
-    Minor = 84
+    Minor = 85
     Tiny = 0
 
     String = "#{Major}.#{Minor}.#{Tiny}"

data/lib/braintree/webhook_notification.rb

@@ -30,6 +30,7 @@ module Braintree
       PartnerMerchantConnected = "partner_merchant_connected"
       PartnerMerchantDisconnected = "partner_merchant_disconnected"
       PartnerMerchantDeclined = "partner_merchant_declined"
+      OAuthAccessRevoked = "oauth_access_revoked"
 
       AccountUpdaterDailyReport = "account_updater_daily_report"
 
@@ -51,6 +52,7 @@ module Braintree
     attr_reader :ideal_payment
     attr_reader :kind
     attr_reader :partner_merchant
+    attr_reader :oauth_access_revocation
     attr_reader :source_merchant_id
     attr_reader :subscription
     attr_reader :timestamp
@@ -70,6 +72,7 @@ module Braintree
       @error_result = ErrorResult.new(gateway, @subject[:api_error_response]) if @subject.has_key?(:api_error_response)
       @merchant_account = MerchantAccount._new(gateway, @subject[:merchant_account]) if @subject.has_key?(:merchant_account)
       @partner_merchant = OpenStruct.new(@subject[:partner_merchant]) if @subject.has_key?(:partner_merchant)
+      @oauth_access_revocation = OpenStruct.new(@subject[:oauth_application_revocation]) if @subject.has_key?(:oauth_application_revocation)
       @subscription = Subscription._new(gateway, @subject[:subscription]) if @subject.has_key?(:subscription)
       @transaction = Transaction._new(gateway, @subject[:transaction]) if @subject.has_key?(:transaction)
       @disbursement = Disbursement._new(gateway, @subject[:disbursement]) if @subject.has_key?(:disbursement)

data/lib/braintree/webhook_testing_gateway.rb

@@ -46,6 +46,8 @@ module Braintree
         _partner_merchant_disconnected_sample_xml(id)
       when Braintree::WebhookNotification::Kind::PartnerMerchantDeclined
         _partner_merchant_declined_sample_xml(id)
+      when Braintree::WebhookNotification::Kind::OAuthAccessRevoked
+        _oauth_access_revoked_sample_xml(id)
       when Braintree::WebhookNotification::Kind::SubMerchantAccountApproved
         _merchant_account_approved_sample_xml(id)
       when Braintree::WebhookNotification::Kind::SubMerchantAccountDeclined
@@ -151,6 +153,14 @@ module Braintree
       XML
     end
 
+    def _oauth_access_revoked_sample_xml(id)
+      <<-XML
+        <oauth-application-revocation>
+          <merchant-id>abc123</merchant-id>
+        </oauth-application-revocation>
+      XML
+    end
+
     def _merchant_account_approved_sample_xml(id)
 
       <<-XML

data/spec/httpsd.pid

@@ -1 +1 @@
-1590
+2671

data/spec/integration/braintree/client_api/spec_helper.rb

@@ -1,6 +1,5 @@
 require 'json'
 
-
 def decode_client_token(raw_client_token)
   decoded_client_token_string = Base64.decode64(raw_client_token)
   JSON.parse(decoded_client_token_string)
@@ -56,7 +55,7 @@ def nonce_for_paypal_account(paypal_account_details)
   body["paypalAccounts"][0]["nonce"]
 end
 
-def generate_valid_us_bank_account_nonce()
+def generate_non_plaid_us_bank_account_nonce
   raw_client_token = Braintree::ClientToken.generate
   client_token = decode_client_token(raw_client_token)
 
@@ -72,8 +71,37 @@ def generate_valid_us_bank_account_nonce()
     },
     :account_type => "checking",
     :routing_number => "021000021",
-    :account_number => "567891234",
-    :account_holder_name => "Dan Schulman",
+    :account_number => "1000000000",
+    :first_name => "John",
+    :last_name => "Doe",
+    :ownership_type => "personal",
+    :ach_mandate => {
+      :text => "cl mandate text"
+    }
+  }
+
+  json = _cosmos_post(token, url, payload)
+  json["data"]["id"]
+end
+
+def generate_valid_plaid_us_bank_account_nonce
+  raw_client_token = Braintree::ClientToken.generate
+  client_token = decode_client_token(raw_client_token)
+
+  url = client_token["braintree_api"]["url"] + "/tokens"
+  token = client_token["braintree_api"]["access_token"]
+  payload = {
+    :type => "plaid_public_token",
+    :public_token => "good",
+    :account_id => "plaid_account_id",
+    :ownership_type => "business",
+    :business_name => "PayPal, Inc.",
+    :billing_address => {
+      :street_address => "123 Ave",
+      :region => "CA",
+      :locality => "San Francisco",
+      :postal_code => "94112"
+    },
     :ach_mandate => {
       :text => "cl mandate text"
     }
@@ -126,7 +154,7 @@ def _cosmos_post(token, url, payload)
   resp = connection.start do |http|
     request = Net::HTTP::Post.new(uri.path)
     request["Content-Type"] = "application/json"
-    request["Braintree-Version"] = "2015-11-01"
+    request["Braintree-Version"] = "2016-10-07"
     request["Authorization"] = "Bearer #{token}"
     request.body = payload.to_json
     http.request(request)

data/spec/integration/braintree/credit_card_spec.rb

@@ -459,7 +459,7 @@ describe Braintree::CreditCard do
             :venmo_sdk_payment_method_code => Braintree::Test::VenmoSDK::VisaPaymentMethodCode
           )
           result.success?.should == true
-          result.credit_card.venmo_sdk?.should == true
+          result.credit_card.venmo_sdk?.should == false
           result.credit_card.bin.should == "400934"
           result.credit_card.last_4.should == "1881"
         end
@@ -490,7 +490,7 @@ describe Braintree::CreditCard do
             }
           )
           result.success?.should == true
-          result.credit_card.venmo_sdk?.should == true
+          result.credit_card.venmo_sdk?.should == false
         end
 
         it "venmo_sdk? returns false when given an invalid session" do

data/spec/integration/braintree/customer_spec.rb

@@ -456,7 +456,7 @@ describe Braintree::Customer do
           }
         )
         result.success?.should == true
-        result.customer.credit_cards.first.venmo_sdk?.should == true
+        result.customer.credit_cards.first.venmo_sdk?.should == false
       end
     end
 
@@ -973,7 +973,12 @@ describe Braintree::Customer do
 
     it "returns associated us bank accounts" do
       result = Braintree::Customer.create(
-        :payment_method_nonce => generate_valid_us_bank_account_nonce
+        :payment_method_nonce => generate_non_plaid_us_bank_account_nonce,
+        :credit_card => {
+          :options => {
+            :verification_merchant_account_id => SpecHelper::UsBankMerchantAccountId,
+          }
+        }
       )
       result.should be_success
 
@@ -984,9 +989,9 @@ describe Braintree::Customer do
       us_bank_account = found_customer.us_bank_accounts.first
       us_bank_account.should be_a(Braintree::UsBankAccount)
       us_bank_account.routing_number.should == "021000021"
-      us_bank_account.last_4.should == "1234"
+      us_bank_account.last_4.should == "0000"
       us_bank_account.account_type.should == "checking"
-      us_bank_account.account_holder_name.should == "Dan Schulman"
+      us_bank_account.account_holder_name.should == "John Doe"
       us_bank_account.bank_name.should =~ /CHASE/
     end
 

data/spec/integration/braintree/dispute_search_spec.rb

@@ -10,7 +10,7 @@ describe Braintree::Dispute, "search" do
       :email => "jen@example.com",
       :phone => "312.555.1234",
       :fax => "614.555.5678",
-      :website => "www.example.com"
+      :website => "www.example.com",
     )
 
     result.customer
@@ -21,12 +21,12 @@ describe Braintree::Dispute, "search" do
       :amount => '10.00',
       :credit_card => {
         :expiration_date => '01/2020',
-        :number => Braintree::Test::CreditCardNumbers::Disputes::Chargeback
+        :number => Braintree::Test::CreditCardNumbers::Disputes::Chargeback,
       },
       :customer_id => customer.id,
       :merchant_account_id => "14LaddersLLC_instant",
       :options => {
-        :submit_for_settlement => true
+        :submit_for_settlement => true,
       }
     )
 
@@ -114,5 +114,16 @@ describe Braintree::Dispute, "search" do
 
       expect(dispute.received_date).to eq(Date.new(2014, 3, 4))
     end
+
+    it "correctly returns disputes by reply_by_date range" do
+      reply_by_date = transaction.disputes.first.reply_by_date
+
+      collection = Braintree::Dispute.search do |search|
+        search.reply_by_date.between(reply_by_date, reply_by_date + 1)
+      end
+
+      dispute_ids = collection.disputes.map { |d| d.id }
+      expect(dispute_ids).to include(transaction.disputes.first.id)
+    end
   end
 end