braintree 2.84.0 → 2.85.0

data/spec/integration/braintree/us_bank_account_spec.rb

@@ -5,20 +5,23 @@ describe Braintree::UsBankAccount do
   describe "self.find" do
     it "returns a UsBankAccount" do
       customer = Braintree::Customer.create!
-      nonce = generate_valid_us_bank_account_nonce
+      nonce = generate_non_plaid_us_bank_account_nonce
 
       result = Braintree::PaymentMethod.create(
         :payment_method_nonce => nonce,
-        :customer_id => customer.id
+        :customer_id => customer.id,
+        :options => {
+          :verification_merchant_account_id => SpecHelper::UsBankMerchantAccountId,
+        }
       )
       result.should be_success
 
       us_bank_account = Braintree::UsBankAccount.find(result.payment_method.token)
       us_bank_account.should be_a(Braintree::UsBankAccount)
       us_bank_account.routing_number.should == "021000021"
-      us_bank_account.last_4.should == "1234"
+      us_bank_account.last_4.should == "0000"
       us_bank_account.account_type.should == "checking"
-      us_bank_account.account_holder_name.should == "Dan Schulman"
+      us_bank_account.account_holder_name.should == "John Doe"
       us_bank_account.bank_name.should =~ /CHASE/
       us_bank_account.ach_mandate.text.should == "cl mandate text"
       us_bank_account.ach_mandate.accepted_at.should be_a Time
@@ -34,24 +37,31 @@ describe Braintree::UsBankAccount do
   context "self.sale" do
     it "creates a transaction using a us bank account and returns a result object" do
       customer = Braintree::Customer.create!
-      nonce = generate_valid_us_bank_account_nonce
+      nonce = generate_non_plaid_us_bank_account_nonce
 
       result = Braintree::PaymentMethod.create(
         :payment_method_nonce => nonce,
-        :customer_id => customer.id
+        :customer_id => customer.id,
+        :options => {
+          :verification_merchant_account_id => SpecHelper::UsBankMerchantAccountId,
+        }
       )
       result.should be_success
 
-      result = Braintree::UsBankAccount.sale(result.payment_method.token, :merchant_account_id => "us_bank_merchant_account", :amount => "100.00")
+      result = Braintree::UsBankAccount.sale(
+        result.payment_method.token,
+        :merchant_account_id => SpecHelper::UsBankMerchantAccountId,
+        :amount => "100.00"
+      )
 
       result.success?.should == true
       result.transaction.amount.should == BigDecimal.new("100.00")
       result.transaction.type.should == "sale"
       us_bank_account = result.transaction.us_bank_account_details
       us_bank_account.routing_number.should == "021000021"
-      us_bank_account.last_4.should == "1234"
+      us_bank_account.last_4.should == "0000"
       us_bank_account.account_type.should == "checking"
-      us_bank_account.account_holder_name.should == "Dan Schulman"
+      us_bank_account.account_holder_name.should == "John Doe"
       us_bank_account.bank_name.should =~ /CHASE/
       us_bank_account.ach_mandate.text.should == "cl mandate text"
       us_bank_account.ach_mandate.accepted_at.should be_a Time
@@ -61,23 +71,30 @@ describe Braintree::UsBankAccount do
   context "self.sale!" do
     it "creates a transaction using a us bank account and returns a result object" do
       customer = Braintree::Customer.create!
-      nonce = generate_valid_us_bank_account_nonce
+      nonce = generate_non_plaid_us_bank_account_nonce
 
       result = Braintree::PaymentMethod.create(
         :payment_method_nonce => nonce,
-        :customer_id => customer.id
+        :customer_id => customer.id,
+        :options => {
+          :verification_merchant_account_id => SpecHelper::UsBankMerchantAccountId,
+        }
       )
       result.should be_success
 
-      transaction = Braintree::UsBankAccount.sale!(result.payment_method.token, :merchant_account_id => "us_bank_merchant_account", :amount => "100.00")
+      transaction = Braintree::UsBankAccount.sale!(
+        result.payment_method.token,
+        :merchant_account_id => SpecHelper::UsBankMerchantAccountId,
+        :amount => "100.00"
+      )
 
       transaction.amount.should == BigDecimal.new("100.00")
       transaction.type.should == "sale"
       us_bank_account = transaction.us_bank_account_details
       us_bank_account.routing_number.should == "021000021"
-      us_bank_account.last_4.should == "1234"
+      us_bank_account.last_4.should == "0000"
       us_bank_account.account_type.should == "checking"
-      us_bank_account.account_holder_name.should == "Dan Schulman"
+      us_bank_account.account_holder_name.should == "John Doe"
       us_bank_account.bank_name.should =~ /CHASE/
       us_bank_account.ach_mandate.text.should == "cl mandate text"
       us_bank_account.ach_mandate.accepted_at.should be_a Time
@@ -85,7 +102,11 @@ describe Braintree::UsBankAccount do
 
     it "does not creates a transaction using a us bank account and returns raises an exception" do
       expect do
-        Braintree::UsBankAccount.sale!(generate_invalid_us_bank_account_nonce, :merchant_account_id => "us_bank_merchant_account", :amount => "100.00")
+        Braintree::UsBankAccount.sale!(
+          generate_invalid_us_bank_account_nonce,
+          :merchant_account_id => SpecHelper::UsBankMerchantAccountId,
+          :amount => "100.00"
+        )
       end.to raise_error(Braintree::ValidationsFailed)
     end
   end

data/spec/integration/braintree/us_bank_account_verification_search_spec.rb

@@ -0,0 +1,178 @@
+require File.expand_path(File.dirname(__FILE__) + "/../spec_helper")
+require File.expand_path(File.dirname(__FILE__) + "/client_api/spec_helper")
+
+describe Braintree::UsBankAccountVerification, "search" do
+  it "correctly returns a result with no matches" do
+    collection = Braintree::UsBankAccountVerification.search do |search|
+      search.account_holder_name.is "thisnameisnotreal"
+    end
+
+    collection.maximum_size.should == 0
+  end
+
+  let(:nonce) { generate_non_plaid_us_bank_account_nonce }
+
+  it "can search on text fields" do
+    customer = Braintree::Customer.create(
+      :email => "john.doe@example.com",
+    ).customer
+    payment_method = Braintree::PaymentMethod.create(
+      :payment_method_nonce => nonce,
+      :customer_id => customer.id,
+      :options => {
+        :verification_merchant_account_id => SpecHelper::UsBankMerchantAccountId,
+      }
+    ).payment_method
+    verification = payment_method.verifications.first
+
+    search_criteria = {
+      :id => verification.id,
+      :account_holder_name => "John Doe",
+      :routing_number => "021000021",
+      :payment_method_token => payment_method.token,
+      :account_type => "checking",
+      :customer_id => customer.id,
+      :customer_email => "john.doe@example.com",
+    }
+
+    search_criteria.each do |criterion, value|
+      collection = Braintree::UsBankAccountVerification.search do |search|
+        search.id.is verification.id
+        search.send(criterion).is value
+      end
+      collection.maximum_size.should == 1
+      collection.first.id.should == verification.id
+
+      collection = Braintree::UsBankAccountVerification.search do |search|
+        search.id.is verification.id
+        search.send(criterion).is "invalid_attribute"
+      end
+      collection.should be_empty
+    end
+
+    collection = Braintree::UsBankAccountVerification.search do |search|
+      search.id.is verification.id
+      search_criteria.each do |criterion, value|
+        search.send(criterion).is value
+      end
+    end
+
+    collection.maximum_size.should == 1
+    collection.first.id.should == verification.id
+  end
+
+  describe "multiple value fields" do
+    it "searches on ids" do
+      customer = Braintree::Customer.create.customer
+
+      payment_method1 = Braintree::PaymentMethod.create(
+        :payment_method_nonce => generate_non_plaid_us_bank_account_nonce,
+        :customer_id => customer.id,
+        :options => {
+          :verification_merchant_account_id => SpecHelper::UsBankMerchantAccountId,
+        }
+      ).payment_method
+      verification1 = payment_method1.verifications.first
+
+      payment_method2 = Braintree::PaymentMethod.create(
+        :payment_method_nonce => generate_non_plaid_us_bank_account_nonce,
+        :customer_id => customer.id,
+        :options => {
+          :verification_merchant_account_id => SpecHelper::UsBankMerchantAccountId,
+        }
+      ).payment_method
+      verification2 = payment_method2.verifications.first
+
+      collection = Braintree::UsBankAccountVerification.search do |search|
+        search.ids.in verification1.id, verification2.id
+      end
+
+      collection.maximum_size.should == 2
+    end
+  end
+
+  context "range fields" do
+    it "searches on created_at" do
+      customer = Braintree::Customer.create.customer
+
+      payment_method = Braintree::PaymentMethod.create(
+        :payment_method_nonce => generate_non_plaid_us_bank_account_nonce,
+        :customer_id => customer.id,
+        :options => {
+          :verification_merchant_account_id => SpecHelper::UsBankMerchantAccountId,
+        }
+      ).payment_method
+      verification = payment_method.verifications.first
+
+      created_at = verification.created_at
+
+      collection = Braintree::UsBankAccountVerification.search do |search|
+        search.id.is verification.id
+        search.created_at.between(
+          created_at - 60,
+          created_at + 60
+        )
+      end
+
+      collection.maximum_size.should == 1
+      collection.first.id.should == verification.id
+
+      collection = Braintree::UsBankAccountVerification.search do |search|
+        search.id.is verification.id
+        search.created_at >= created_at - 1
+      end
+
+      collection.maximum_size.should == 1
+      collection.first.id.should == verification.id
+
+      collection = Braintree::UsBankAccountVerification.search do |search|
+        search.id.is verification.id
+        search.created_at <= created_at + 1
+      end
+
+      collection.maximum_size.should == 1
+      collection.first.id.should == verification.id
+
+      collection = Braintree::UsBankAccountVerification.search do |search|
+        search.id.is verification.id
+        search.created_at.between(
+          created_at - 300,
+          created_at - 100
+        )
+      end
+
+      collection.maximum_size.should == 0
+
+      collection = Braintree::UsBankAccountVerification.search do |search|
+        search.id.is verification.id
+        search.created_at.is created_at
+      end
+
+      collection.maximum_size.should == 1
+      collection.first.id.should == verification.id
+    end
+  end
+
+  context "ends with fields" do
+    it "does ends_with search on account_number" do
+      customer = Braintree::Customer.create.customer
+
+      payment_method = Braintree::PaymentMethod.create(
+        :payment_method_nonce => nonce,
+        :customer_id => customer.id,
+        :options => {
+          :verification_merchant_account_id => SpecHelper::UsBankMerchantAccountId,
+        }
+      ).payment_method
+      verification = payment_method.verifications.first
+
+      collection = Braintree::UsBankAccountVerification.search do |search|
+        search.id.is verification.id
+        search.account_number.ends_with "0000"
+      end
+
+      collection.maximum_size.should == 1
+      collection.first.id.should == verification.id
+    end
+  end
+end

data/spec/integration/braintree/us_bank_account_verification_spec.rb

@@ -0,0 +1,79 @@
+require File.expand_path(File.dirname(__FILE__) + "/../spec_helper")
+require File.expand_path(File.dirname(__FILE__) + "/client_api/spec_helper")
+
+describe Braintree::UsBankAccountVerification, "search" do
+  let(:nonce) { generate_non_plaid_us_bank_account_nonce }
+  let(:customer) do
+    params = {
+      :first_name => "Tom",
+      :last_name => "Smith",
+      :email => "tom.smith@example.com",
+    }
+
+    Braintree::Customer.create(params).customer
+  end
+
+  describe "self.find" do
+    it "finds the verification with the given id" do
+      result = Braintree::PaymentMethod.create(
+        :payment_method_nonce => nonce,
+        :customer_id => customer.id,
+        :options => {
+          :verification_merchant_account_id => SpecHelper::UsBankMerchantAccountId,
+          :us_bank_account_verification_method => Braintree::UsBankAccountVerification::VerificationMethod::NetworkCheck,
+        }
+      )
+
+      result.should be_success
+
+      created_verification = result.payment_method.verifications.first
+      found_verification = Braintree::UsBankAccountVerification.find(created_verification.id)
+
+      found_verification.should == created_verification
+    end
+
+    it "raises a NotFoundError exception if verification cannot be found" do
+      expect do
+        Braintree::UsBankAccountVerification.find("invalid-id")
+      end.to raise_error(Braintree::NotFoundError, 'verification with id "invalid-id" not found')
+    end
+  end
+
+  describe "self.search" do
+    let(:payment_method) do
+      Braintree::PaymentMethod.create(
+        :payment_method_nonce => nonce,
+        :customer_id => customer.id,
+        :options => {
+          :verification_merchant_account_id => SpecHelper::UsBankMerchantAccountId,
+          :us_bank_account_verification_method => Braintree::UsBankAccountVerification::VerificationMethod::NetworkCheck,
+        }
+      ).payment_method
+    end
+
+    let(:created_verification) do
+      payment_method.verifications.first
+    end
+
+    it "searches and finds verification using verification fields" do
+      found_verifications = Braintree::UsBankAccountVerification.search do |search|
+        search.created_at >= (Time.now() - 120)
+        search.ids.in created_verification.id
+        search.status.in created_verification.status
+        search.verification_method.in created_verification.verification_method
+      end
+
+      found_verifications.should include(created_verification)
+    end
+
+    it "searches and finds verifications using customer fields" do
+      found_verifications = Braintree::UsBankAccountVerification.search do |search|
+        search.customer_email.is customer.email
+        search.customer_id.is customer.id
+        search.payment_method_token.is payment_method.token
+      end
+
+      found_verifications.count.should eq(1)
+    end
+  end
+end

data/spec/spec_helper.rb

@@ -39,7 +39,8 @@ unless defined?(SPEC_HELPER_LOADED)
     ThreeDSecureMerchantAccountId = "three_d_secure_merchant_account"
     FakeAmexDirectMerchantAccountId = "fake_amex_direct_usd"
     FakeVenmoAccountMerchantAccountId = "fake_first_data_venmo_account"
-    UsBankMerhantAccountId = "us_bank_merchant_account"
+    UsBankMerchantAccountId = "us_bank_merchant_account"
+    AnotherUsBankMerchantAccountId = "another_us_bank_merchant_account"
     IdealMerchantAccountId = "ideal_merchant_account"
 
     TrialPlan = {

data/spec/unit/braintree/us_bank_account_verification_search_spec.rb

@@ -0,0 +1,60 @@
+require File.expand_path(File.dirname(__FILE__) + "/../spec_helper")
+
+module Braintree
+  describe UsBankAccountVerificationSearch do
+    context "verification method" do
+      it "allows All verification methods" do
+        search = UsBankAccountVerificationSearch.new
+
+        lambda do
+          search.verification_method.in(
+            *Braintree::UsBankAccountVerification::VerificationMethod::All,
+          )
+        end.should_not raise_error
+      end
+    end
+
+    context "id" do
+      it "is" do
+        search = UsBankAccountVerificationSearch.new
+        search.id.is "v_id"
+
+        search.to_hash.should == {:id => {:is => "v_id"}}
+      end
+    end
+
+    context "ids" do
+      it "correctly builds a hash with ids" do
+        search = UsBankAccountVerificationSearch.new
+        search.ids.in("id1", "id2")
+
+        search.to_hash.should == {:ids => ["id1", "id2"]}
+      end
+    end
+
+    context "account_holder_name" do
+      it "is" do
+        search = UsBankAccountVerificationSearch.new
+        search.account_holder_name.is "v_account_holder_name"
+
+        search.to_hash.should == {:account_holder_name => {:is => "v_account_holder_name"}}
+      end
+    end
+
+    context "created_at" do
+      it "is a range node" do
+        search = UsBankAccountVerificationSearch.new
+        search.created_at.should be_kind_of(Braintree::AdvancedSearch::RangeNode)
+      end
+    end
+
+    context "account number" do
+      it "uses ends_with" do
+        search = UsBankAccountVerificationSearch.new
+        search.account_number.ends_with "1234"
+
+        search.to_hash.should == {:account_number => {:ends_with => "1234"}}
+      end
+    end
+  end
+end

data/spec/unit/braintree/us_bank_account_verification_spec.rb

@@ -0,0 +1,67 @@
+require File.expand_path(File.dirname(__FILE__) + "/../spec_helper")
+
+describe Braintree::UsBankAccountVerification do
+  describe "inspect" do
+    let(:verification) do
+      Braintree::UsBankAccountVerification._new(
+        :id => "some_verification_id",
+        :status => Braintree::UsBankAccountVerification::Status::Verified,
+        :verification_method => Braintree::UsBankAccountVerification::VerificationMethod::IndependentCheck,
+        :verification_determined_at => "2018-02-28T12:01:01Z",
+      )
+    end
+
+    it "has a status" do
+      verification.status.should == Braintree::UsBankAccountVerification::Status::Verified
+    end
+  end
+
+  describe "self.find" do
+    it "raises error if passed empty string" do
+      expect do
+        Braintree::UsBankAccountVerification.find("")
+      end.to raise_error(ArgumentError)
+    end
+
+    it "raises error if passed empty string wth space" do
+      expect do
+        Braintree::UsBankAccountVerification.find(" ")
+      end.to raise_error(ArgumentError)
+    end
+
+    it "raises error if passed nil" do
+      expect do
+        Braintree::UsBankAccountVerification.find(nil)
+      end.to raise_error(ArgumentError)
+    end
+  end
+
+  describe "==" do
+    it "returns true for verifications with the same id" do
+      first = Braintree::UsBankAccountVerification._new(:id => "123")
+      second = Braintree::UsBankAccountVerification._new(:id => "123")
+
+      first.should == second
+      second.should == first
+    end
+
+    it "returns false for verifications with different ids" do
+      first = Braintree::UsBankAccountVerification._new(:id => "123")
+      second = Braintree::UsBankAccountVerification._new(:id => "124")
+
+      first.should_not == second
+      second.should_not == first
+    end
+
+    it "returns false when comparing to nil" do
+      Braintree::UsBankAccountVerification._new({}).should_not == nil
+    end
+
+    it "returns false when comparing to non-verifications" do
+      same_id_different_object = Object.new
+      def same_id_different_object.id; "123"; end
+      verification = Braintree::UsBankAccountVerification._new(:id => "123")
+      verification.should_not == same_id_different_object
+    end
+  end
+end