braintree 4.38.0 → 4.40.0

data/spec/integration/braintree/customer_spec.rb

@@ -4,8 +4,7 @@ require File.expand_path(File.dirname(__FILE__) + "/client_api/spec_helper")
 
 describe Braintree::Customer do
   describe "self.all" do
-    #Disabling test until we have a more stable CI
-    xit "gets more than a page of customers" do
+    it "gets more than a page of customers" do
       customers = Braintree::Customer.all
       expect(customers.maximum_size).to be > 100
 
@@ -1242,7 +1241,7 @@ describe Braintree::Customer do
       expect(apple_pay_card.expiration_year).not_to be_nil
       expect(apple_pay_card.healthcare).not_to be_nil
       expect(apple_pay_card.issuing_bank).not_to be_nil
-      expect(apple_pay_card.payment_instrument_name).to eq("AmEx 41002")
+      expect(apple_pay_card.payment_instrument_name).to match(/\AAmEx \d{4,5}\z/)
       expect(apple_pay_card.payroll).not_to be_nil
       expect(apple_pay_card.prepaid).not_to be_nil
       expect(apple_pay_card.prepaid_reloadable).not_to be_nil
@@ -1326,7 +1325,7 @@ describe Braintree::Customer do
       expect(venmo_account.username).not_to be_nil
     end
 
-    xit "returns associated us bank accounts" do
+    it "returns associated us bank accounts" do
       result = Braintree::Customer.create(
         :payment_method_nonce => generate_non_plaid_us_bank_account_nonce,
         :credit_card => {
@@ -1693,7 +1692,8 @@ describe Braintree::Customer do
 
       apple_pay_card = result.customer.payment_methods.find { |pm| pm.is_a?(Braintree::ApplePayCard) }
       expect(apple_pay_card).not_to be_nil
-      expect(apple_pay_card.last_4).to eq(Braintree::Test::CreditCardNumbers::Visa[-4..-1])
+      expect(apple_pay_card.card_type).to eq(Braintree::ApplePayCard::CardType::Visa)
+      expect(apple_pay_card.last_4).to match(/\A\d{4}\z/)
       expect(apple_pay_card.cardholder_name).to eq("Updated Joe Cardholder")
 
       verification = apple_pay_card.verification
@@ -2084,6 +2084,154 @@ describe Braintree::Customer do
       expect(result).to be_success
     end
 
+    it "accepts a three_d_secure_pass_thru network specified on customer create" do
+      result = Braintree::Customer.create(
+        :payment_method_nonce => Braintree::Test::Nonce::TransactableVisa,
+        :credit_card => {
+          :three_d_secure_pass_thru => {
+            :eci_flag => "05",
+            :cavv => "some_cavv",
+            :xid => "some_xid",
+            :three_d_secure_version => "2.2.0",
+            :authentication_response => "Y",
+            :directory_response => "Y",
+            :cavv_algorithm => "2",
+            :ds_transaction_id => "some_ds_transaction_id",
+            :network => Braintree::ThreeDSecurePassThru::Network::Visa,
+          },
+          :options => {:verify_card => true},
+        },
+      )
+      expect(result).to be_success
+    end
+
+    it "rejects invalid network value in 3ds pass thru params on customer create" do
+      result = Braintree::Customer.create(
+        :payment_method_nonce => Braintree::Test::Nonce::Transactable,
+        :credit_card => {
+          :three_d_secure_pass_thru => {
+            :eci_flag => "05",
+            :cavv => "some_cavv",
+            :xid => "some_xid",
+            :three_d_secure_version => "2.2.0",
+            :authentication_response => "Y",
+            :directory_response => "Y",
+            :cavv_algorithm => "2",
+            :ds_transaction_id => "some_ds_transaction_id",
+            :network => "DISCOVER",
+          },
+          :options => {:verify_card => true},
+        },
+      )
+      expect(result).not_to be_success
+      error = result.errors.for(:verification).first
+      expect(error.code).to eq(Braintree::ErrorCodes::Verification::ThreeDSecurePassThru::NetworkIsInvalid)
+      expect(error.message).to eq("Network is invalid. Supported networks are eftpos, Visa, and Mastercard.")
+    end
+
+    it "rejects request where 3ds pass thru network does not match the payment instrument on customer create (VISA nonce, Mastercard network)" do
+      result = Braintree::Customer.create(
+        :payment_method_nonce => Braintree::Test::Nonce::TransactableVisa,
+        :credit_card => {
+          :three_d_secure_pass_thru => {
+            :eci_flag => "05",
+            :cavv => "some_cavv",
+            :xid => "some_xid",
+            :three_d_secure_version => "2.2.0",
+            :authentication_response => "Y",
+            :directory_response => "Y",
+            :cavv_algorithm => "2",
+            :ds_transaction_id => "some_ds_transaction_id",
+            :network => Braintree::ThreeDSecurePassThru::Network::MasterCard,
+          },
+          :options => {:verify_card => true},
+        },
+      )
+      expect(result).not_to be_success
+      error = result.errors.for(:verification).first
+      expect(error.code).to eq(Braintree::ErrorCodes::Verification::ThreeDSecurePassThru::NetworkDoesNotMatchPaymentInstrument)
+      expect(error.message).to eq("Network does not match the payment instrument.")
+    end
+
+    it "accepts a three_d_secure_pass_thru network specified on customer update" do
+      customer = Braintree::Customer.create!
+      result = Braintree::Customer.update(
+        customer.id,
+        :credit_card => {
+          :number => Braintree::Test::CreditCardNumbers::Visa,
+          :expiration_date => "05/2009",
+          :three_d_secure_pass_thru => {
+            :eci_flag => "05",
+            :cavv => "some_cavv",
+            :xid => "some_xid",
+            :three_d_secure_version => "2.2.0",
+            :authentication_response => "Y",
+            :directory_response => "Y",
+            :cavv_algorithm => "2",
+            :ds_transaction_id => "some_ds_transaction_id",
+            :network => Braintree::ThreeDSecurePassThru::Network::Visa,
+          },
+          :options => {:verify_card => true}
+        },
+      )
+
+      expect(result).to be_success
+    end
+
+    it "rejects invalid network value in 3ds pass thru params on customer update" do
+      customer = Braintree::Customer.create!
+      result = Braintree::Customer.update(
+        customer.id,
+        :credit_card => {
+          :number => Braintree::Test::CreditCardNumbers::Visa,
+          :expiration_date => "05/2009",
+          :three_d_secure_pass_thru => {
+            :eci_flag => "05",
+            :cavv => "some_cavv",
+            :xid => "some_xid",
+            :three_d_secure_version => "2.2.0",
+            :authentication_response => "Y",
+            :directory_response => "Y",
+            :cavv_algorithm => "2",
+            :ds_transaction_id => "some_ds_transaction_id",
+            :network => "DISCOVER",
+          },
+          :options => {:verify_card => true}
+        },
+      )
+      expect(result).not_to be_success
+      error = result.errors.for(:verification).first
+      expect(error.code).to eq(Braintree::ErrorCodes::Verification::ThreeDSecurePassThru::NetworkIsInvalid)
+      expect(error.message).to eq("Network is invalid. Supported networks are eftpos, Visa, and Mastercard.")
+    end
+
+    it "rejects request where 3ds pass thru network does not match the payment instrument on customer update (VISA card, Mastercard network)" do
+      customer = Braintree::Customer.create!
+      result = Braintree::Customer.update(
+        customer.id,
+        :credit_card => {
+          :number => Braintree::Test::CreditCardNumbers::Visa,
+          :expiration_date => "05/2009",
+          :three_d_secure_pass_thru => {
+            :eci_flag => "05",
+            :cavv => "some_cavv",
+            :xid => "some_xid",
+            :three_d_secure_version => "2.2.0",
+            :authentication_response => "Y",
+            :directory_response => "Y",
+            :cavv_algorithm => "2",
+            :ds_transaction_id => "some_ds_transaction_id",
+            :network => Braintree::ThreeDSecurePassThru::Network::MasterCard,
+          },
+          :options => {:verify_card => true}
+        },
+      )
+      expect(result).not_to be_success
+      error = result.errors.for(:verification).first
+      expect(error.code).to eq(Braintree::ErrorCodes::Verification::ThreeDSecurePassThru::NetworkDoesNotMatchPaymentInstrument)
+      expect(error.message).to eq("Network does not match the payment instrument.")
+    end
+
     it "returns 3DS info on cc verification" do
       result = Braintree::Customer.create(
         :payment_method_nonce => Braintree::Test::Nonce::ThreeDSecureVisaFullAuthentication,

data/spec/integration/braintree/http_spec.rb

@@ -97,7 +97,7 @@ describe Braintree::Http do
     end
 
     describe "ssl_version" do
-      xit "causes failed requests to sandbox with incompatible SSL version" do
+      it "causes failed requests to sandbox with incompatible SSL version" do
         begin
           original_env = Braintree::Configuration.environment
           Braintree::Configuration.environment = :sandbox

data/spec/integration/braintree/payment_method_spec.rb

@@ -92,8 +92,8 @@ describe Braintree::PaymentMethod do
       expect(apple_pay_card.bin).not_to be_nil
       expect(apple_pay_card.token).to eq(token)
       expect(apple_pay_card.card_type).to eq(Braintree::ApplePayCard::CardType::AmEx)
-      expect(apple_pay_card.payment_instrument_name).to eq("AmEx 41002")
-      expect(apple_pay_card.source_description).to eq("AmEx 41002")
+      expect(apple_pay_card.payment_instrument_name).to match(/\AAmEx \d{4,5}\z/)
+      expect(apple_pay_card.source_description).to match(/\AAmEx \d{4,5}\z/)
       expect(apple_pay_card.default).to eq(true)
       expect(apple_pay_card.image_url).to match(/apple_pay/)
       expect(apple_pay_card.expiration_month.to_i).to be > 0
@@ -127,8 +127,8 @@ describe Braintree::PaymentMethod do
       expect(apple_pay_card.bin).not_to be_nil
       expect(apple_pay_card.token).to eq(token)
       expect(apple_pay_card.card_type).to eq(Braintree::ApplePayCard::CardType::Visa)
-      expect(apple_pay_card.payment_instrument_name).to eq("Visa 2006")
-      expect(apple_pay_card.source_description).to eq("Visa 2006")
+      expect(apple_pay_card.payment_instrument_name).to match(/\AVisa \d{4}\z/)
+      expect(apple_pay_card.source_description).to match(/\AVisa \d{4}\z/)
       expect(apple_pay_card.default).to eq(true)
       expect(apple_pay_card.image_url).to match(/apple_pay/)
       expect(apple_pay_card.expiration_month.to_i).to be > 0
@@ -382,6 +382,76 @@ describe Braintree::PaymentMethod do
       expect(result).to be_success
     end
 
+    it "accepts a three_d_secure_pass_thru network specified in the request" do
+      customer = Braintree::Customer.create!
+      result = Braintree::PaymentMethod.create(
+        :customer_id => customer.id,
+        :payment_method_nonce => Braintree::Test::Nonce::TransactableVisa,
+        :three_d_secure_pass_thru => {
+          :eci_flag => "05",
+          :cavv => "some_cavv",
+          :xid => "some_xid",
+          :three_d_secure_version => "2.2.0",
+          :authentication_response => "Y",
+          :directory_response => "Y",
+          :cavv_algorithm => "2",
+          :ds_transaction_id => "some_ds_transaction_id",
+          :network => Braintree::ThreeDSecurePassThru::Network::Visa,
+        },
+        :options => {:verify_card => true},
+      )
+
+      expect(result).to be_success
+    end
+
+    it "rejects invalid network value in 3ds pass thru params" do
+      customer = Braintree::Customer.create!
+      result = Braintree::PaymentMethod.create(
+        :customer_id => customer.id,
+        :payment_method_nonce => Braintree::Test::Nonce::Transactable,
+        :three_d_secure_pass_thru => {
+          :eci_flag => "05",
+          :cavv => "some_cavv",
+          :xid => "some_xid",
+          :three_d_secure_version => "2.2.0",
+          :authentication_response => "Y",
+          :directory_response => "Y",
+          :cavv_algorithm => "2",
+          :ds_transaction_id => "some_ds_transaction_id",
+          :network => "DISCOVER",
+        },
+        :options => {:verify_card => true},
+      )
+      expect(result).not_to be_success
+      error = result.errors.for(:verification).first
+      expect(error.code).to eq(Braintree::ErrorCodes::Verification::ThreeDSecurePassThru::NetworkIsInvalid)
+      expect(error.message).to eq("Network is invalid. Supported networks are eftpos, Visa, and Mastercard.")
+    end
+
+    it "rejects request where 3ds pass thru network does not match the payment instrument (VISA nonce, Mastercard network)" do
+      customer = Braintree::Customer.create!
+      result = Braintree::PaymentMethod.create(
+        :customer_id => customer.id,
+        :payment_method_nonce => Braintree::Test::Nonce::TransactableVisa,
+        :three_d_secure_pass_thru => {
+          :eci_flag => "05",
+          :cavv => "some_cavv",
+          :xid => "some_xid",
+          :three_d_secure_version => "2.2.0",
+          :authentication_response => "Y",
+          :directory_response => "Y",
+          :cavv_algorithm => "2",
+          :ds_transaction_id => "some_ds_transaction_id",
+          :network => Braintree::ThreeDSecurePassThru::Network::MasterCard,
+        },
+        :options => {:verify_card => true},
+      )
+      expect(result).not_to be_success
+      error = result.errors.for(:verification).first
+      expect(error.code).to eq(Braintree::ErrorCodes::Verification::ThreeDSecurePassThru::NetworkDoesNotMatchPaymentInstrument)
+      expect(error.message).to eq("Network does not match the payment instrument.")
+    end
+
     it "returns 3DS info on cc verification" do
       customer = Braintree::Customer.create.customer
       result = Braintree::PaymentMethod.create(
@@ -813,7 +883,7 @@ describe Braintree::PaymentMethod do
         expect(update_result.payment_method.verification.credit_card[:account_type]).to eq("credit")
       end
 
-      xit "updates the credit card with account_type debit" do
+      it "updates the credit card with account_type debit" do
         customer = Braintree::Customer.create!
         credit_card = Braintree::CreditCard.create!(
           :cardholder_name => "Original Holder",
@@ -1404,7 +1474,7 @@ describe Braintree::PaymentMethod do
         expect(apple_pay_card.image_url).to match(/apple_pay/)
         expect(apple_pay_card.expiration_month.to_i).to be > 0
         expect(apple_pay_card.expiration_year.to_i).to be > 0
-        expect(apple_pay_card.source_description).to eq("AmEx 41002")
+        expect(apple_pay_card.source_description).to match(/\AAmEx \d{4,5}\z/)
         expect(apple_pay_card.customer_id).to eq(customer.id)
       end
 
@@ -1427,7 +1497,7 @@ describe Braintree::PaymentMethod do
         expect(apple_pay_card.image_url).to match(/apple_pay/)
         expect(apple_pay_card.expiration_month.to_i).to be > 0
         expect(apple_pay_card.expiration_year.to_i).to be > 0
-        expect(apple_pay_card.source_description).to eq("Visa 2006")
+        expect(apple_pay_card.source_description).to match(/\AVisa \d{4}\z/)
         expect(apple_pay_card.customer_id).to eq(customer.id)
         expect(apple_pay_card.is_device_token).to eq(false)
         apple_pay_card.merchant_token_identifier == "DNITHE302308980427388297"

data/spec/integration/braintree/samsung_pay_card_spec.rb

@@ -3,7 +3,7 @@ require File.expand_path(File.dirname(__FILE__) + "/client_api/spec_helper")
 
 # NEXT_MAJOR_VERSION remove these tests
 # SamsungPayCard has been deprecated
-xdescribe Braintree::SamsungPayCard do
+describe Braintree::SamsungPayCard do
   it "can create from payment method nonce" do
     customer = Braintree::Customer.create!
 

data/spec/integration/braintree/transaction_search_spec.rb

@@ -11,8 +11,7 @@ describe Braintree::Transaction, "search" do
       expect(collection.maximum_size).to eq(0)
     end
 
-    #Disabling test until we have more stable CI
-    xit "can search on text fields" do
+    it "can search on text fields" do
       first_name = "Tim_#{rand(10**10)}"
       token = "creditcard_#{rand(10**10)}"
       customer_id = "customer_#{rand(10**10)}"
@@ -132,8 +131,7 @@ describe Braintree::Transaction, "search" do
       expect(collection.first.id).to eq(transaction.id)
     end
 
-    #Disabling test until we have more stable CI
-    xit "searches on users" do
+    it "searches on users" do
       transaction = Braintree::Transaction.sale!(
         :amount => Braintree::Test::TransactionAmounts::Authorize,
         :payment_method_nonce => Braintree::Test::Nonce::PayPalBillingAgreement,
@@ -177,14 +175,15 @@ describe Braintree::Transaction, "search" do
       expect(collection.first.id).to eq(transaction_id)
     end
 
-    it "searches on reason_codes for 3 items" do
+    it "searches on reason_codes for 2 items" do
       reason_code = ["R01", "R02"]
 
       collection = Braintree::Transaction.search do |search|
+        search.ids.in ["ach_txn_ret1", "ach_txn_ret2"]
         search.reason_code.in reason_code
       end
 
-      expect(collection.maximum_size).to eq(3)
+      expect(collection.maximum_size).to eq(2)
     end
 
     it "searches on reason_code" do
@@ -192,6 +191,7 @@ describe Braintree::Transaction, "search" do
       reason_code = "R01"
 
       collection = Braintree::Transaction.search do |search|
+        search.ids.in [transaction_id]
         search.reason_code.in reason_code
       end
       item = collection.find { |t| t.id == transaction_id }
@@ -204,6 +204,7 @@ describe Braintree::Transaction, "search" do
       reason_code = "RJCT"
 
       collection = Braintree::Transaction.search do |search|
+        search.ids.in [transaction_id]
         search.reason_code.in reason_code
       end
       item = collection.find { |t| t.id == transaction_id }
@@ -217,10 +218,11 @@ describe Braintree::Transaction, "search" do
       reason_code = "any_reason_code"
 
       collection = Braintree::Transaction.search do |search|
+        search.ids.in ["ach_txn_ret1", "ach_txn_ret2", "ach_txn_ret3", "ach_txn_ret4"]
         search.reason_code.is reason_code
       end
 
-      expect(collection.maximum_size).to eq(6)
+      expect(collection.maximum_size).to eq(4)
     end
 
     context "multiple value fields" do
@@ -512,6 +514,7 @@ describe Braintree::Transaction, "search" do
       end
 
       it "finds expired authorizations by status" do
+        skip "pending search fix"
         collection = Braintree::Transaction.search do |search|
           search.status.in Braintree::Transaction::Status::AuthorizationExpired
         end
@@ -614,7 +617,7 @@ describe Braintree::Transaction, "search" do
         expect(collection.first.id).to eq(transaction_id)
       end
 
-      xit "searches on debit_network" do
+      it "searches on debit_network" do
         transaction = Braintree::Transaction.sale!(
           :amount => Braintree::Test::TransactionAmounts::Authorize,
           :merchant_account_id => SpecHelper::PinlessDebitMerchantAccountId,
@@ -854,6 +857,7 @@ describe Braintree::Transaction, "search" do
       context "ach return response created at" do
         it "it finds records within date range of the custom field" do
           date_search = Braintree::Transaction.search do |search|
+            search.ids.in ["ach_txn_ret1", "ach_txn_ret2", "ach_txn_ret3", "ach_txn_ret4"]
             search.ach_return_responses_created_at.between(DateTime.now - 1.0, DateTime.now + 1.0)
           end
 
@@ -862,6 +866,7 @@ describe Braintree::Transaction, "search" do
 
         it "it does not find records not within date range of the custom field" do
           neg_date_search = Braintree::Transaction.search do |search|
+           search.ids.in ["ach_txn_ret1", "ach_txn_ret2", "ach_txn_ret3", "ach_txn_ret4"]
            search.ach_return_responses_created_at.between(DateTime.now + 1.0, DateTime.now - 1.0)
           end
 
@@ -1006,7 +1011,7 @@ describe Braintree::Transaction, "search" do
           }
         end
 
-        xit "searches on dispute_date in UTC" do
+        it "searches on dispute_date in UTC" do
           collection = Braintree::Transaction.search do |search|
             search.id.is @disputed_transaction.id
             search.dispute_date.between(
@@ -1043,7 +1048,7 @@ describe Braintree::Transaction, "search" do
           expect(collection.first.id).to eq(@disputed_transaction.id)
         end
 
-        xit "searches on dispute_date in local time" do
+        it "searches on dispute_date in local time" do
           now = @disputed_time.localtime("-06:00")
 
           collection = Braintree::Transaction.search do |search|
@@ -1073,7 +1078,7 @@ describe Braintree::Transaction, "search" do
           expect(collection.maximum_size).to eq(1)
         end
 
-        xit "searches on dispute_date with date ranges" do
+        it "searches on dispute_date with date ranges" do
           collection = Braintree::Transaction.search do |search|
             search.id.is @disputed_transaction.id
             search.dispute_date.between(
@@ -1151,6 +1156,7 @@ describe Braintree::Transaction, "search" do
         end
 
         it "finds expired authorizations in a given range" do
+          skip "pending search fix"
           collection = Braintree::Transaction.search do |search|
             search.authorization_expired_at.between(
               Date.today - 2,
@@ -1379,8 +1385,7 @@ describe Braintree::Transaction, "search" do
       end
     end
 
-    #Disabling until we have a more stable CI
-    xit "returns multiple results" do
+    it "returns multiple results" do
       collection = Braintree::Transaction.search
       expect(collection.maximum_size).to be > 100