braintree 4.23.0 → 4.34.0

data/spec/integration/braintree/payment_method_spec.rb

@@ -108,6 +108,7 @@ describe Braintree::PaymentMethod do
       expect(apple_pay_card.payroll).not_to be_nil
       expect(apple_pay_card.prepaid).not_to be_nil
       expect(apple_pay_card.product_id).not_to be_nil
+      expect(apple_pay_card.is_device_token).to eq(true)
     end
 
     it "creates a payment method from a fake apple pay mpan nonce" do
@@ -126,8 +127,8 @@ describe Braintree::PaymentMethod do
       expect(apple_pay_card.bin).not_to be_nil
       expect(apple_pay_card.token).to eq(token)
       expect(apple_pay_card.card_type).to eq(Braintree::ApplePayCard::CardType::Visa)
-      expect(apple_pay_card.payment_instrument_name).to eq("Visa 8886")
-      expect(apple_pay_card.source_description).to eq("Visa 8886")
+      expect(apple_pay_card.payment_instrument_name).to eq("Visa 2006")
+      expect(apple_pay_card.source_description).to eq("Visa 2006")
       expect(apple_pay_card.default).to eq(true)
       expect(apple_pay_card.image_url).to match(/apple_pay/)
       expect(apple_pay_card.expiration_month.to_i).to be > 0
@@ -143,6 +144,7 @@ describe Braintree::PaymentMethod do
       expect(apple_pay_card.prepaid).not_to be_nil
       expect(apple_pay_card.product_id).not_to be_nil
       expect(apple_pay_card.merchant_token_identifier).not_to be_nil
+      expect(apple_pay_card.is_device_token).not_to be_nil
       expect(apple_pay_card.source_card_last4).not_to be_nil
     end
 
@@ -205,9 +207,9 @@ describe Braintree::PaymentMethod do
       expect(google_pay_card.image_url).to match(/android_pay/)
       expect(google_pay_card.is_network_tokenized?).to eq(true)
       expect(google_pay_card.source_card_type).to eq(Braintree::CreditCard::CardType::MasterCard)
-      expect(google_pay_card.source_card_last_4).to eq("4444")
+      expect(google_pay_card.source_card_last_4).to eq("0005")
       expect(google_pay_card.google_transaction_id).to eq("google_transaction_id")
-      expect(google_pay_card.source_description).to eq("MasterCard 4444")
+      expect(google_pay_card.source_description).to eq("MasterCard 0005")
       expect(google_pay_card.customer_id).to eq(customer.id)
       expect(google_pay_card.commercial).not_to be_nil
       expect(google_pay_card.country_of_issuance).not_to be_nil
@@ -671,6 +673,30 @@ describe Braintree::PaymentMethod do
       end
     end
 
+      it "includes ani response when account information inquiry is sent in options" do
+          customer = Braintree::Customer.create!
+          nonce = nonce_for_new_payment_method(
+            :credit_card => {
+              :cvv => "123",
+              :number => Braintree::Test::CreditCardNumbers::Visa,
+              :expiration_date => "05/2029",
+            },
+          )
+          result = Braintree::PaymentMethod.create(
+            :payment_method_nonce => nonce,
+            :customer_id => customer.id,
+            :options => {
+              :verify_card => true,
+              :account_information_inquiry => "send_data",
+            },
+          )
+
+          expect(result).to be_success
+          verification = result.payment_method.verification
+          expect(verification.ani_first_name_response_code).not_to be_nil
+          expect(verification.ani_last_name_response_code).not_to be_nil
+      end
+
     context "account_type" do
       it "verifies card with account_type debit" do
         nonce = nonce_for_new_payment_method(
@@ -1228,8 +1254,9 @@ describe Braintree::PaymentMethod do
         expect(apple_pay_card.image_url).to match(/apple_pay/)
         expect(apple_pay_card.expiration_month.to_i).to be > 0
         expect(apple_pay_card.expiration_year.to_i).to be > 0
-        expect(apple_pay_card.source_description).to eq("Visa 8886")
+        expect(apple_pay_card.source_description).to eq("Visa 2006")
         expect(apple_pay_card.customer_id).to eq(customer.id)
+        expect(apple_pay_card.is_device_token).to eq(false)
         apple_pay_card.merchant_token_identifier == "DNITHE302308980427388297"
         apple_pay_card.source_card_last4 == "2006"
       end
@@ -1310,9 +1337,9 @@ describe Braintree::PaymentMethod do
         expect(google_pay_card.image_url).to match(/android_pay/)
         expect(google_pay_card.is_network_tokenized?).to eq(true)
         expect(google_pay_card.source_card_type).to eq(Braintree::CreditCard::CardType::MasterCard)
-        expect(google_pay_card.source_card_last_4).to eq("4444")
+        expect(google_pay_card.source_card_last_4).to eq("0005")
         expect(google_pay_card.google_transaction_id).to eq("google_transaction_id")
-        expect(google_pay_card.source_description).to eq("MasterCard 4444")
+        expect(google_pay_card.source_description).to eq("MasterCard 0005")
         expect(google_pay_card.customer_id).to eq(customer.id)
       end
     end
@@ -1588,6 +1615,29 @@ describe Braintree::PaymentMethod do
         end
       end
 
+      it "includes ani response after updating the options with account information inquiry" do
+        customer = Braintree::Customer.create!
+        credit_card = Braintree::CreditCard.create!(
+          :customer_id => customer.id,
+          :cvv => "123",
+          :number => Braintree::Test::CreditCardNumbers::Visa,
+          :expiration_date => "05/2032",
+        )
+        update_result = Braintree::PaymentMethod.update(
+          credit_card.token,
+          :options => {
+            :verify_card => true,
+            :account_information_inquiry => "send_data",
+          },
+        )
+
+        expect(update_result).to be_success
+        verification = update_result.payment_method.verification
+        expect(verification.ani_first_name_response_code).not_to be_nil
+        expect(verification.ani_last_name_response_code).not_to be_nil
+      end
+
+
       context "verification_currency_iso_code" do
         it "validates verification_currency_iso_code and updates the credit card " do
           customer = Braintree::Customer.create!

data/spec/integration/braintree/payment_method_us_bank_account_spec.rb

@@ -32,7 +32,6 @@ describe Braintree::PaymentMethod do
           expect(us_bank_account.account_holder_name).to eq("John Doe")
           expect(us_bank_account.bank_name).to match(/CHASE/)
           expect(us_bank_account.default).to eq(true)
-          expect(us_bank_account.ach_mandate.text).to eq("cl mandate text")
           expect(us_bank_account.ach_mandate.accepted_at).to be_a Time
 
           expect(us_bank_account.verifications.count).to eq(0)
@@ -100,7 +99,6 @@ describe Braintree::PaymentMethod do
           expect(us_bank_account.account_holder_name).to eq("Dan Schulman")
           expect(us_bank_account.bank_name).to match(/Wells Fargo/)
           expect(us_bank_account.default).to eq(true)
-          expect(us_bank_account.ach_mandate.text).to eq("example mandate text")
           expect(us_bank_account.ach_mandate.accepted_at).to be_a Time
 
           expect(us_bank_account.verifications.count).to eq(1)
@@ -135,7 +133,6 @@ describe Braintree::PaymentMethod do
           expect(us_bank_account.account_holder_name).to eq("John Doe")
           expect(us_bank_account.bank_name).to match(/CHASE/)
           expect(us_bank_account.default).to eq(true)
-          expect(us_bank_account.ach_mandate.text).to eq("cl mandate text")
           expect(us_bank_account.ach_mandate.accepted_at).to be_a Time
 
           expect(us_bank_account.verifications.count).to eq(1)

data/spec/integration/braintree/paypal_payment_resource_spec.rb

@@ -0,0 +1,141 @@
+require File.expand_path(File.dirname(__FILE__) + "/../spec_helper")
+require File.expand_path(File.dirname(__FILE__) + "/client_api/spec_helper")
+
+describe Braintree::PayPalPaymentResource do
+
+    describe "self.update" do
+        it "successfully updates a payment resource" do
+            nonce = nonce_for_paypal_account(
+                :intent => "order",
+                :payment_token => "fake-paypal-payment-token",
+                :payer_id => "fake-paypal-payer-id",
+              )
+
+            result = Braintree::PayPalPaymentResource.update(
+                    :amount => BigDecimal("55.00"),
+                    :amount_breakdown => {
+                        :discount => BigDecimal("15.00"),
+                        :handling =>  BigDecimal("0.00"),
+                        :insurance =>  BigDecimal("5.00"),
+                        :item_total =>  BigDecimal("45.00"),
+                        :shipping =>  BigDecimal("10.00"),
+                        :shipping_discount =>  BigDecimal("0.00"),
+                        :tax_total =>  BigDecimal("10.00"),
+                    },
+                    :currency_iso_code => "USD",
+                    :custom_field => "0437",
+                    :description => "This is a test",
+                    :line_items => [{
+                        :description => "Shoes",
+                        :image_url => "https://example.com/products/23434/pic.png",
+                        :kind => "debit",
+                        :name => "Name #1",
+                        :product_code => "23434",
+                        :quantity => "1",
+                        :total_amount =>  BigDecimal("45.00"),
+                        :unit_amount =>  BigDecimal("45.00"),
+                        :unit_tax_amount =>  BigDecimal("10.00"),
+                        :url =>  "https://example.com/products/23434",
+                    }],
+                    :order_id => "order-123456789",
+                    :payee_email => "bt_buyer_us@paypal.com",
+                    :payment_method_nonce => nonce,
+                    :shipping => {
+                        :country_name => "United States",
+                        :country_code_alpha2 => "US",
+                        :country_code_alpha3 => "USA",
+                        :country_code_numeric => "484",
+                        :extended_address => "Apt. #1",
+                        :first_name => "John",
+                        :international_phone => {
+                            :country_code => "1",
+                            :national_number => "4081111111",
+                        },
+                        :last_name => "Doe",
+                        :locality => "Chicago",
+                        :postal_code => "60618",
+                        :region => "IL",
+                        :street_address => "123 Division Street",
+                    },
+                    :shipping_options => [{
+                        :amount =>  BigDecimal("10.00"),
+                        :id => "option1",
+                        :label => "fast",
+                        :selected => true,
+                        :type =>  "SHIPPING"
+                    }],
+            )
+
+            expect(result.success?).to eq(true)
+            expect(result.payment_method_nonce).not_to be_nil
+            expect(result.payment_method_nonce.nonce).not_to be_nil
+        end
+
+        it "returns validation errors" do
+            nonce = nonce_for_paypal_account(
+                :intent => "order",
+                :payment_token => "fake-paypal-payment-token",
+                :payer_id => "fake-paypal-payer-id",
+              )
+
+              result = Braintree::PayPalPaymentResource.update(
+                :amount => BigDecimal("55.00"),
+                :amount_breakdown => {
+                    :discount => BigDecimal("15.00"),
+                    :handling =>  BigDecimal("0.00"),
+                    :insurance =>  BigDecimal("5.00"),
+                    :item_total =>  BigDecimal("45.00"),
+                    :shipping =>  BigDecimal("10.00"),
+                    :shipping_discount =>  BigDecimal("0.00"),
+                    :tax_total =>  BigDecimal("10.00"),
+                },
+                :currency_iso_code => "USD",
+                :custom_field => "0437",
+                :description => "This is a test",
+                :line_items => [{
+                    :description => "Shoes",
+                    :image_url => "https://example.com/products/23434/pic.png",
+                    :kind => "debit",
+                    :name => "Name #1",
+                    :product_code => "23434",
+                    :quantity => "1",
+                    :total_amount =>  BigDecimal("45.00"),
+                    :unit_amount =>  BigDecimal("45.00"),
+                    :unit_tax_amount =>  BigDecimal("10.00"),
+                    :url =>  "https://example.com/products/23434",
+                }],
+                :order_id => "order-123456789",
+                :payee_email => "bt_buyer_us@paypal",
+                :payment_method_nonce => nonce,
+                :shipping => {
+                    :country_name => "United States",
+                    :country_code_alpha2 => "US",
+                    :country_code_alpha3 => "USA",
+                    :country_code_numeric => "484",
+                    :extended_address => "Apt. #1",
+                    :first_name => "John",
+                    :international_phone => {
+                        :country_code => "1",
+                        :national_number => "4081111111",
+                    },
+                    :last_name => "Doe",
+                    :locality => "Chicago",
+                    :postal_code => "60618",
+                    :region => "IL",
+                    :street_address => "123 Division Street",
+                },
+                :shipping_options => [{
+                    :amount =>  BigDecimal("10.00"),
+                    :id => "option1",
+                    :label => "fast",
+                    :selected => true,
+                    :type =>  "SHIPPING"
+                }],
+            )
+
+            expect(result.success?).to eq(false)
+            errors = result.errors.for(:paypal_payment_resource)
+            expect(errors.on(:payee_email)[0].code).to eq(Braintree::ErrorCodes::PayPalPaymentResource::InvalidEmail)
+        end
+    end
+end

data/spec/integration/braintree/transaction_payment_facilitator_spec.rb

@@ -0,0 +1,119 @@
+require File.expand_path(File.dirname(__FILE__) + "/../spec_helper")
+require File.expand_path(File.dirname(__FILE__) + "/client_api/spec_helper")
+
+describe Braintree::Transaction do
+
+  describe "self.sale" do
+
+    it "should create a transaction with sub merchant and payment facilitator for a payfac merchant" do
+      transaction_params = {
+        :type => "sale",
+        :amount => "100.00",
+        :merchant_account_id => SpecHelper::CardProcessorBRLPayFacMerchantAccountId,
+        :credit_card => {
+          :number => "4111111111111111",
+          :expiration_date => "06/2026",
+          :cvv => "123",
+        },
+        :descriptor => {
+          :name => "companynme12*product12",
+          :phone => "1232344444",
+          :url => "example.com",
+        },
+        :billing => {
+          :first_name => "Bob James",
+          :country_code_alpha2 => "CA",
+          :extended_address => "",
+          :locality => "Trois-Rivires",
+          :region => "QC",
+          :postal_code => "G8Y 156",
+          :street_address => "2346 Boul Lane",
+        },
+        :payment_facilitator => {
+          :payment_facilitator_id => "98765432109",
+          :sub_merchant => {
+            :reference_number => "123456789012345",
+            :tax_id => "99112233445577",
+            :legal_name => "Fooda",
+            :address => {
+              :street_address => "10880 Ibitinga",
+              :locality => "Araraquara",
+              :region => "SP",
+              :country_code_alpha2 => "BR",
+              :postal_code => "13525000",
+              :international_phone => {
+                :country_code => "55",
+                :national_number => "9876543210",
+              },
+            },
+          },
+        },
+        :options => {
+          :store_in_vault_on_success => true,
+        },
+      }
+
+      result = Braintree::Transaction.sale(transaction_params)
+      expect(result.success?).to eq(true)
+      expect(result.transaction.status).to eq(Braintree::Transaction::Status::Authorized)
+    end
+
+    it "should fail on transaction with payment facilitator and non brazil merchant" do
+      transaction_params = {
+        :type => "sale",
+        :amount => "100.00",
+        :credit_card => {
+          :number => "4111111111111111",
+          :expiration_date => "06/2026",
+          :cvv => "123",
+        },
+        :descriptor => {
+          :name => "companynme12*product12",
+          :phone => "1232344444",
+          :url => "example.com",
+        },
+        :billing => {
+          :first_name => "Bob James",
+          :country_code_alpha2 => "CA",
+          :extended_address => "",
+          :locality => "Trois-Rivires",
+          :region => "QC",
+          :postal_code => "G8Y 156",
+          :street_address => "2346 Boul Lane",
+        },
+        :payment_facilitator => {
+          :payment_facilitator_id => "98765432109",
+          :sub_merchant => {
+            :reference_number => "123456789012345",
+            :tax_id => "99112233445577",
+            :legal_name => "Fooda",
+            :address => {
+              :street_address => "10880 Ibitinga",
+              :locality => "Araraquara",
+              :region => "SP",
+              :country_code_alpha2 => "BR",
+              :postal_code => "13525000",
+              :international_phone => {
+                :country_code => "55",
+                :national_number => "9876543210",
+              },
+            },
+          },
+        },
+        :options => {
+          :store_in_vault_on_success => true,
+        },
+      }
+
+      ezp_gateway = Braintree::Gateway.new(
+        :environment => :development,
+        :merchant_id => "pp_credit_ezp_merchant",
+        :public_key => "pp_credit_ezp_merchant_public_key",
+        :private_key => "pp_credit_ezp_merchant_private_key",
+      )
+
+      result = ezp_gateway.transaction.sale(transaction_params)
+      expect(result.errors.for(:transaction).first.code).to eq(Braintree::ErrorCodes::PaymentFacilitator::PaymentFacilitatorNotApplicable)
+    end
+  end
+end

data/spec/integration/braintree/transaction_search_spec.rb

@@ -11,7 +11,8 @@ describe Braintree::Transaction, "search" do
       expect(collection.maximum_size).to eq(0)
     end
 
-    it "can search on text fields" do
+    #Disabling test until we have more stable CI
+    xit "can search on text fields" do
       first_name = "Tim_#{rand(10**10)}"
       token = "creditcard_#{rand(10**10)}"
       customer_id = "customer_#{rand(10**10)}"
@@ -130,7 +131,8 @@ describe Braintree::Transaction, "search" do
       expect(collection.first.id).to eq(transaction.id)
     end
 
-    it "searches on users" do
+    #Disabling test until we have more stable CI
+    xit "searches on users" do
       transaction = Braintree::Transaction.sale!(
         :amount => Braintree::Test::TransactionAmounts::Authorize,
         :payment_method_nonce => Braintree::Test::Nonce::PayPalBillingAgreement,
@@ -174,6 +176,16 @@ describe Braintree::Transaction, "search" do
       expect(collection.first.id).to eq(transaction_id)
     end
 
+    it "searches on reason_codes for 3 items" do
+      reason_code = ["R01", "R02"]
+
+      collection = Braintree::Transaction.search do |search|
+        search.reason_code.in reason_code
+      end
+
+      expect(collection.maximum_size).to eq(3)
+    end
+
     it "searches on reason_code" do
       transaction_id = "ach_txn_ret1"
       reason_code = "R01"
@@ -181,10 +193,23 @@ describe Braintree::Transaction, "search" do
       collection = Braintree::Transaction.search do |search|
         search.reason_code.in reason_code
       end
+      item = collection.find { |t| t.id == transaction_id }
+      expect(item.ach_return_code).to eq("R01")
+      expect(item.ach_return_responses.first[:reason_code]).to eq("R01")
+    end
 
-      expect(collection.maximum_size).to eq(1)
-      expect(collection.first.id).to eq(transaction_id)
-      expect(collection.first.ach_return_responses.first[:reason_code]).to eq("R01")
+    it "searches on rejections reason_code" do
+      transaction_id = "ach_txn_ret3"
+      reason_code = "RJCT"
+
+      collection = Braintree::Transaction.search do |search|
+        search.reason_code.in reason_code
+      end
+      item = collection.find { |t| t.id == transaction_id }
+      expect(item.ach_return_code).to eq("RJCT")
+      expect(item.ach_reject_reason).to eq("Bank accounts located outside of the U.S. are not supported.")
+      expect(item.ach_return_responses.first[:reason_code]).to eq("RJCT")
+      expect(item.ach_return_responses.first[:reject_reason]).to eq("Bank accounts located outside of the U.S. are not supported.")
     end
 
     it "searches on reason_codes" do
@@ -194,7 +219,7 @@ describe Braintree::Transaction, "search" do
         search.reason_code.is reason_code
       end
 
-      expect(collection.maximum_size).to eq(2)
+      expect(collection.maximum_size).to eq(6)
     end
 
     context "multiple value fields" do
@@ -588,28 +613,6 @@ describe Braintree::Transaction, "search" do
         expect(collection.first.id).to eq(transaction_id)
       end
 
-      it "searches on reason_codes for 2 items" do
-        reason_code = ["R01", "R02"]
-
-        collection = Braintree::Transaction.search do |search|
-          search.reason_code.in reason_code
-        end
-
-        expect(collection.maximum_size).to eq(2)
-      end
-
-      it "searches on a reason_code" do
-        reason_code = ["R01"]
-        transaction_id = "ach_txn_ret1"
-
-        collection = Braintree::Transaction.search do |search|
-          search.reason_code.in reason_code
-        end
-
-        expect(collection.maximum_size).to eq(1)
-        expect(collection.first.id).to eq(transaction_id)
-      end
-
       xit "searches on debit_network" do
         transaction = Braintree::Transaction.sale!(
           :amount => Braintree::Test::TransactionAmounts::Authorize,
@@ -853,7 +856,7 @@ describe Braintree::Transaction, "search" do
             search.ach_return_responses_created_at.between(DateTime.now - 1.0, DateTime.now + 1.0)
           end
 
-          expect(date_search.maximum_size).to eq(2)
+          expect(date_search.maximum_size).to be >= 1
         end
 
         it "it does not find records not within date range of the custom field" do
@@ -1002,7 +1005,7 @@ describe Braintree::Transaction, "search" do
           }
         end
 
-        it "searches on dispute_date in UTC" do
+        xit "searches on dispute_date in UTC" do
           collection = Braintree::Transaction.search do |search|
             search.id.is @disputed_transaction.id
             search.dispute_date.between(
@@ -1039,7 +1042,7 @@ describe Braintree::Transaction, "search" do
           expect(collection.first.id).to eq(@disputed_transaction.id)
         end
 
-        it "searches on dispute_date in local time" do
+        xit "searches on dispute_date in local time" do
           now = @disputed_time.localtime("-06:00")
 
           collection = Braintree::Transaction.search do |search|
@@ -1069,7 +1072,7 @@ describe Braintree::Transaction, "search" do
           expect(collection.maximum_size).to eq(1)
         end
 
-        it "searches on dispute_date with date ranges" do
+        xit "searches on dispute_date with date ranges" do
           collection = Braintree::Transaction.search do |search|
             search.id.is @disputed_transaction.id
             search.dispute_date.between(
@@ -1375,7 +1378,8 @@ describe Braintree::Transaction, "search" do
       end
     end
 
-    it "returns multiple results" do
+    #Disabling until we have a more stable CI
+    xit "returns multiple results" do
       collection = Braintree::Transaction.search
       expect(collection.maximum_size).to be > 100
 
@@ -1510,6 +1514,7 @@ describe Braintree::Transaction, "search" do
 
       collection = Braintree::Transaction.search do |search|
         search.payment_instrument_type.in ["MetaCheckout"]
+        search.ids.in [meta_checkout_card_transaction.id, meta_checkout_token_transaction.id]
       end
 
       collection.maximum_size.should == 2