braintree 4.20.0 → 4.22.0

data/spec/unit/braintree/customer_spec.rb

@@ -16,6 +16,7 @@ describe Braintree::Customer do
         :first_name => "Patrick",
         :last_name => "Smith",
         :phone => "802-483-5932",
+        :international_phone => {:country_code => "1", :national_number => "3121234567"},
         :website => "patrick.smith.com",
         :created_at => Time.now,
         :updated_at => Time.now,
@@ -27,6 +28,7 @@ describe Braintree::Customer do
       expect(output).to include(%q(first_name: "Patrick"))
       expect(output).to include(%q(last_name: "Smith"))
       expect(output).to include(%q(phone: "802-483-5932"))
+      expect(output).to include(%q(international_phone: {:country_code=>"1", :national_number=>"3121234567"}))
       expect(output).to include(%q(website: "patrick.smith.com"))
       expect(output).to include(%q(addresses: []))
       expect(output).to include(%q(credit_cards: []))
@@ -82,6 +84,7 @@ describe Braintree::Customer do
         :fax,
         :first_name,
         :id,
+        {:international_phone=>[:country_code, :national_number]},
         :last_name,
         :phone,
         :website,
@@ -111,6 +114,7 @@ describe Braintree::Customer do
             :country_name,
             :extended_address,
             :first_name,
+            {:international_phone=>[:country_code, :national_number]},
             :last_name,
             :locality,
             :phone_number,
@@ -154,6 +158,7 @@ describe Braintree::Customer do
               :country_name,
               :extended_address,
               :first_name,
+              {:international_phone=>[:country_code, :national_number]},
               :last_name,
               :locality,
               :phone_number,
@@ -176,6 +181,7 @@ describe Braintree::Customer do
         :fax,
         :first_name,
         :id,
+        {:international_phone=>[:country_code, :national_number]},
         :last_name,
         :phone,
         :website,
@@ -215,6 +221,7 @@ describe Braintree::Customer do
             :country_name,
             :extended_address,
             :first_name,
+            {:international_phone=>[:country_code, :national_number]},
             :last_name,
             :locality,
             :phone_number,
@@ -253,6 +260,7 @@ describe Braintree::Customer do
               :country_name,
               :extended_address,
               :first_name,
+              {:international_phone=>[:country_code, :national_number]},
               :last_name,
               :locality,
               :phone_number,

data/spec/unit/braintree/error_result_spec.rb

@@ -38,7 +38,7 @@ describe Braintree::ErrorResult do
         :verification => {},
         :transaction => nil,
       )
-      expect(result.inspect).to include("credit_card_verification: #<Braintree::CreditCardVerification status: ")
+      expect(result.inspect).to include("credit_card_verification: #<Braintree::CreditCardVerification amount: ")
     end
 
     it "does not include the credit_card_verification if there isn't one" do

data/spec/unit/braintree/local_payment_completed_spec.rb

@@ -12,8 +12,11 @@ describe Braintree::LocalPaymentCompleted do
   describe "self._new" do
     it "initializes the object with the appropriate attributes set" do
       params = {
-        payment_id: "a-payment-id",
+        bic: "a-bic",
+        iban_last_chars: "1234",
         payer_id: "a-payer-id",
+        payer_name: "John Doe",
+        payment_id: "a-payment-id",
         payment_method_nonce: "a-nonce",
         transaction: {
           id: "a-transaction-id",
@@ -24,25 +27,34 @@ describe Braintree::LocalPaymentCompleted do
       }
       local_payment_completed = Braintree::LocalPaymentCompleted._new(params)
 
-      expect(local_payment_completed.payment_id).to eq("a-payment-id")
+      expect(local_payment_completed.bic).to eq("a-bic")
+      expect(local_payment_completed.iban_last_chars).to eq("1234")
       expect(local_payment_completed.payer_id).to eq("a-payer-id")
+      expect(local_payment_completed.payer_name).to eq("John Doe")
+      expect(local_payment_completed.payment_id).to eq("a-payment-id")
       expect(local_payment_completed.payment_method_nonce).to eq("a-nonce")
-      expect(local_payment_completed.transaction.id).to eq("a-transaction-id")
       expect(local_payment_completed.transaction.amount).to eq(31.0)
+      expect(local_payment_completed.transaction.id).to eq("a-transaction-id")
       expect(local_payment_completed.transaction.order_id).to eq("an-order-id")
       expect(local_payment_completed.transaction.status).to eq(Braintree::Transaction::Status::Authorized)
     end
 
     it "initializes the object with the appropriate attributes set if no transaction is provided" do
       params = {
-        payment_id: "a-payment-id",
+        bic: "a-bic",
+        iban_last_chars: "1234",
         payer_id: "a-payer-id",
+        payer_name: "John Doe",
+        payment_id: "a-payment-id",
         payment_method_nonce: "a-nonce",
       }
       local_payment_completed = Braintree::LocalPaymentCompleted._new(params)
 
-      expect(local_payment_completed.payment_id).to eq("a-payment-id")
+      expect(local_payment_completed.bic).to eq("a-bic")
+      expect(local_payment_completed.iban_last_chars).to eq("1234")
       expect(local_payment_completed.payer_id).to eq("a-payer-id")
+      expect(local_payment_completed.payer_name).to eq("John Doe")
+      expect(local_payment_completed.payment_id).to eq("a-payment-id")
       expect(local_payment_completed.payment_method_nonce).to eq("a-nonce")
       expect(local_payment_completed.transaction).to be_nil
     end

data/spec/unit/braintree/package_tracking_spec.rb

@@ -1,5 +1,6 @@
 require File.expand_path(File.dirname(__FILE__) + "/../spec_helper")
 
+# NEXT_MAJOR_VERSION Remove paypal_tracking_id assertions, use paypal_tracker_id going forward
 describe "Package Tracking Unit Tests" do
     describe "creates and validates requests" do
         let(:gateway) do
@@ -39,8 +40,8 @@ describe "Package Tracking Unit Tests" do
           transaction = Braintree::Transaction._new(
             :gateway,
             :shipments => [
-              {:id => "id1", :carrier => "UPS", :tracking_number => "tracking_number_1", :paypal_tracking_id => "pp_tracking_number_1"},
-              {:id => "id2", :carrier => "FEDEX", :tracking_number => "tracking_number_2", :paypal_tracking_id => "pp_tracking_number_2"}
+              {:id => "id1", :carrier => "UPS", :tracking_number => "tracking_number_1", :paypal_tracking_id => "pp_tracking_number_1", :paypal_tracker_id => "pp_tracking_number_1"},
+              {:id => "id2", :carrier => "FEDEX", :tracking_number => "tracking_number_2", :paypal_tracking_id => "pp_tracking_number_2", :paypal_tracker_id => "pp_tracking_number_2"}
             ],
           )
           expect(transaction.packages.size).to eq(2)
@@ -48,11 +49,13 @@ describe "Package Tracking Unit Tests" do
           expect(transaction.packages[0].carrier).to eq("UPS")
           expect(transaction.packages[0].tracking_number).to eq("tracking_number_1")
           expect(transaction.packages[0].paypal_tracking_id).to eq("pp_tracking_number_1")
+          expect(transaction.packages[0].paypal_tracker_id).to eq("pp_tracking_number_1")
 
           expect(transaction.packages[1].id).to eq("id2")
           expect(transaction.packages[1].carrier).to eq("FEDEX")
           expect(transaction.packages[1].tracking_number).to eq("tracking_number_2")
           expect(transaction.packages[1].paypal_tracking_id).to eq("pp_tracking_number_2")
+          expect(transaction.packages[1].paypal_tracker_id).to eq("pp_tracking_number_2")
         end
 
         it "doesn't blow up if no shipments are present in the transaction response" do

data/spec/unit/braintree/paypal_account_spec.rb

@@ -41,4 +41,13 @@ describe Braintree::PayPalAccount do
       expect(paypal_account.updated_at).to eq(now)
     end
   end
+
+  describe "edit_paypal_vault_id" do
+    it "exposes edit_paypal_vault_id" do
+      mock_edit_paypal_vault_id = "ENCR-BA-ID1"
+      paypal_account = Braintree::PayPalAccount._new(:gateway, :edit_paypal_vault_id => mock_edit_paypal_vault_id)
+
+      expect(paypal_account.edit_paypal_vault_id).to eq(mock_edit_paypal_vault_id)
+    end
+  end
 end

data/spec/unit/braintree/transaction/customer_details_spec.rb

@@ -11,9 +11,10 @@ describe Braintree::Transaction::CustomerDetails do
         :company => "Smith Co.",
         :website => "http://www.example.com",
         :phone => "6145551234",
+        :international_phone => {:country_code=>"1", :national_number=>"3121234567"},
         :fax => "3125551234",
       )
-      expect(details.inspect).to eq(%(#<id: "id", first_name: "Amy", last_name: "Smith", email: "amy.smith@example.com", company: "Smith Co.", website: "http://www.example.com", phone: "6145551234", fax: "3125551234">))
+      expect(details.inspect).to eq(%(#<id: "id", first_name: "Amy", last_name: "Smith", email: "amy.smith@example.com", company: "Smith Co.", website: "http://www.example.com", phone: "6145551234", international_phone: {:country_code=>\"1\", :national_number=>\"3121234567\"}, fax: "3125551234">))
     end
   end
 end

data/spec/unit/braintree/transaction_gateway_spec.rb

@@ -33,36 +33,45 @@ describe Braintree::TransactionGateway do
     # three_d_secure_token has been deprecated in favor of three_d_secure_authentication_id
     it "creates a transaction gateway signature" do
       expect(Braintree::TransactionGateway._create_signature).to match([
-        :amount, :billing_address_id, :channel, :customer_id, :device_data, :discount_amount,
+        :amount, :billing_address_id, :channel, :currency_iso_code, :customer_id, :device_data,
+        :discount_amount, :exchange_rate_quote_id, :foreign_retailer,
         :merchant_account_id, :order_id, :payment_method_nonce, :payment_method_token,
         :product_sku, :purchase_order_number, :service_fee_amount, :shared_billing_address_id,
         :shared_customer_id, :shared_payment_method_nonce, :shared_payment_method_token,
-        :shared_shipping_address_id, :shipping_address_id, :shipping_amount,
+        :shared_shipping_address_id, :shipping_address_id, :shipping_amount, :shipping_tax_amount,
         :ships_from_postal_code, :tax_amount, :tax_exempt, :three_d_secure_authentication_id,:three_d_secure_token, #Deprecated
-        :transaction_source, :type, :venmo_sdk_payment_method_code, #Deprecated
-        :sca_exemption, :currency_iso_code, :exchange_rate_quote_id,
-        {:line_items => [:commodity_code, :description, :discount_amount, :image_url, :kind, :name, :product_code, :quantity, :tax_amount, :total_amount, :unit_amount, :unit_of_measure, :unit_tax_amount, :upc_code, :upc_type, :url]},
-        {:risk_data => [:customer_browser, :customer_device_id, :customer_ip, :customer_location_zip, :customer_tenure]},
-        {:credit_card => [:token, :cardholder_name, :cvv, :expiration_date, :expiration_month, :expiration_year, :number, {:payment_reader_card_details => [:encrypted_card_data, :key_serial_number]}, {:network_tokenization_attributes => [:cryptogram, :ecommerce_indicator, :token_requestor_id]}]},
-        {:customer => [:id, :company, :email, :fax, :first_name, :last_name, :phone, :website]},
+        :transaction_source, :type, :venmo_sdk_payment_method_code, # Deprecated
+        :sca_exemption,
+        {:apple_pay_card => [:number, :cardholder_name, :cryptogram, :expiration_month, :expiration_year, :eci_indicator]},
         {
           :billing => Braintree::AddressGateway._shared_signature
         },
-        {
-          :shipping => Braintree::AddressGateway._shared_signature + [:shipping_method],
-        },
-        {
-          :three_d_secure_pass_thru => [
-            :eci_flag,
-            :cavv,
-            :xid,
-            :three_d_secure_version,
-            :authentication_response,
-            :directory_response,
-            :cavv_algorithm,
-            :ds_transaction_id,
-          ]
-        },
+        {:credit_card => [:token, :cardholder_name, :cvv, :expiration_date, :expiration_month, :expiration_year, :number, {:payment_reader_card_details => [:encrypted_card_data, :key_serial_number]}, {:network_tokenization_attributes => [:cryptogram, :ecommerce_indicator, :token_requestor_id]}]},
+        {:customer => [:id, :company, :email, :fax, :first_name, :last_name, :phone, :website]},
+        {:custom_fields => :_any_key_},
+        {:descriptor => [:name, :phone, :url]},
+        {:external_vault => [
+          :status,
+          :previous_network_transaction_id,
+        ]},
+        {:google_pay_card => [:number, :cryptogram, :google_transaction_id, :expiration_month, :expiration_year, :source_card_type, :source_card_last_four, :eci_indicator]},
+        {:industry => [
+          :industry_type,
+          {:data => [
+            :country_code, :date_of_birth, :folio_number, :check_in_date, :check_out_date, :travel_package, :lodging_check_in_date, :lodging_check_out_date, :departure_date, :lodging_name, :room_rate, :room_tax,
+            :passenger_first_name, :passenger_last_name, :passenger_middle_initial, :passenger_title, :issued_date, :travel_agency_name, :travel_agency_code, :ticket_number,
+            :issuing_carrier_code, :customer_code, :fare_amount, :fee_amount, :tax_amount, :restricted_ticket, :no_show, :advanced_deposit, :fire_safe, :property_phone, :ticket_issuer_address, :arrival_date,
+            {:legs => [
+              :conjunction_ticket, :exchange_ticket, :coupon_number, :service_class, :carrier_code, :fare_basis_code, :flight_number, :departure_date, :departure_airport_code, :departure_time,
+              :arrival_airport_code, :arrival_time, :stopover_permitted, :fare_amount, :fee_amount, :tax_amount, :endorsement_or_restrictions,
+            ]},
+            {:additional_charges => [
+              :kind, :amount,
+            ]},
+          ]},
+        ]},
+        {:installments => [:count]},
+        {:line_items => [:commodity_code, :description, :discount_amount, :image_url, :kind, :name, :product_code, :quantity, :tax_amount, :total_amount, :unit_amount, :unit_of_measure, :unit_tax_amount, :upc_code, :upc_type, :url]},
         {:options => [
           :hold_in_escrow,
           :store_in_vault,
@@ -70,7 +79,7 @@ describe Braintree::TransactionGateway do
           :submit_for_settlement,
           :add_billing_address_to_payment_method,
           :store_shipping_address_in_vault,
-          :venmo_sdk_session, #Deprecated
+          :venmo_sdk_session, # Deprecated
           :payee_id,
           :payee_email,
           :skip_advanced_fraud_checking,
@@ -84,31 +93,23 @@ describe Braintree::TransactionGateway do
           {:credit_card => [:account_type, :process_debit_as_credit]},
         ]
         },
-        {:external_vault => [
-          :status,
-          :previous_network_transaction_id,
-        ]},
-        {:custom_fields => :_any_key_},
-        {:descriptor => [:name, :phone, :url]},
         {:paypal_account => [:email, :token, :paypal_data, :payee_id, :payee_email, :payer_id, :payment_id]},
-        {:industry => [
-          :industry_type,
-          {:data => [
-            :country_code, :date_of_birth, :folio_number, :check_in_date, :check_out_date, :travel_package, :lodging_check_in_date, :lodging_check_out_date, :departure_date, :lodging_name, :room_rate, :room_tax,
-            :passenger_first_name, :passenger_last_name, :passenger_middle_initial, :passenger_title, :issued_date, :travel_agency_name, :travel_agency_code, :ticket_number,
-            :issuing_carrier_code, :customer_code, :fare_amount, :fee_amount, :tax_amount, :restricted_ticket, :no_show, :advanced_deposit, :fire_safe, :property_phone, :ticket_issuer_address, :arrival_date,
-            {:legs => [
-              :conjunction_ticket, :exchange_ticket, :coupon_number, :service_class, :carrier_code, :fare_basis_code, :flight_number, :departure_date, :departure_airport_code, :departure_time,
-              :arrival_airport_code, :arrival_time, :stopover_permitted, :fare_amount, :fee_amount, :tax_amount, :endorsement_or_restrictions,
-            ]},
-            {:additional_charges => [
-              :kind, :amount,
-            ]},
-          ]},
-        ]},
-        {:apple_pay_card => [:number, :cardholder_name, :cryptogram, :expiration_month, :expiration_year, :eci_indicator]},
-        {:google_pay_card => [:number, :cryptogram, :google_transaction_id, :expiration_month, :expiration_year, :source_card_type, :source_card_last_four, :eci_indicator]},
-        {:installments => [:count]},
+        {:risk_data => [:customer_browser, :customer_device_id, :customer_ip, :customer_location_zip, :customer_tenure]},
+        {
+          :shipping => Braintree::AddressGateway._shared_signature + [:shipping_method],
+        },
+        {
+          :three_d_secure_pass_thru => [
+            :eci_flag,
+            :cavv,
+            :xid,
+            :three_d_secure_version,
+            :authentication_response,
+            :directory_response,
+            :cavv_algorithm,
+            :ds_transaction_id,
+          ]
+        },
       ])
     end
 
@@ -136,9 +137,14 @@ describe Braintree::TransactionGateway do
         :tax_exempt,
         :discount_amount,
         :shipping_amount,
+        :shipping_tax_amount,
         :ships_from_postal_code,
         :line_items => [:commodity_code, :description, :discount_amount, :image_url, :kind, :name, :product_code, :quantity, :tax_amount, :total_amount, :unit_amount, :unit_of_measure, :unit_tax_amount, :upc_code, :upc_type, :url],
       ])
     end
+
+    it "creates transaction gateway submit for partial settlement signature" do
+       expect(Braintree::TransactionGateway._submit_for_partial_settlement_signature).to include(:final_capture)
+    end
   end
 end

data/spec/unit/braintree/webhook_notification_spec.rb

@@ -941,4 +941,16 @@ describe Braintree::WebhookNotification do
       end.to raise_error(Braintree::InvalidChallenge, /challenge contains non-hex characters/)
     end
   end
+
+  describe "refund failed" do
+    it "builds a sample notification for refund failed" do
+      sample_notification = Braintree::WebhookTesting.sample_notification(
+        Braintree::WebhookNotification::Kind::RefundFailed,
+        "my_id",
+      )
+      notification = Braintree::WebhookNotification.parse(sample_notification[:bt_signature], sample_notification[:bt_payload])
+      expect(notification.kind.should).to eq(Braintree::WebhookNotification::Kind::RefundFailed)
+      expect(notification.transaction.id).to eq("my_id")
+    end
+  end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: braintree
 version: !ruby/object:Gem::Version
-  version: 4.20.0
+  version: 4.22.0
 platform: ruby
 authors:
 - Braintree
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2024-03-26 00:00:00.000000000 Z
+date: 2024-09-20 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: builder