braintree 4.15.0 → 4.17.0

data/lib/braintree/credit_card_verification_gateway.rb

@@ -47,22 +47,39 @@ module Braintree
     def self._create_signature
       [
         {:credit_card => [
-          :cardholder_name, :cvv, :expiration_date, :expiration_month, :expiration_year,
-          :number, {:billing_address => AddressGateway._shared_signature}
+          {:billing_address => AddressGateway._shared_signature},
+          :cardholder_name,
+          :cvv,
+          :expiration_date,
+          :expiration_month,
+          :expiration_year,
+          :number,
+        ]},
+        {:external_vault => [
+          :previous_network_transaction_id,
+          :status,
         ]},
         :intended_transaction_source,
-        {:options => [:amount, :merchant_account_id, :account_type]},
+        {:options => [
+          :account_type,
+          :amount,
+          :merchant_account_id,
+        ]},
         :payment_method_nonce,
+        {:risk_data => [
+          :customer_browser,
+          :customer_ip,
+        ]},
         :three_d_secure_authentication_id,
         {:three_d_secure_pass_thru => [
-            :eci_flag,
-            :cavv,
-            :xid,
-            :three_d_secure_version,
-            :authentication_response,
-            :directory_response,
-            :cavv_algorithm,
-            :ds_transaction_id,
+          :authentication_response,
+          :cavv,
+          :cavv_algorithm,
+          :directory_response,
+          :ds_transaction_id,
+          :eci_flag,
+          :three_d_secure_version,
+          :xid,
         ]},
       ]
     end

data/lib/braintree/credit_card_verification_search.rb

@@ -1,5 +1,5 @@
 module Braintree
-  class CreditCardVerificationSearch < AdvancedSearch # :nodoc:
+  class CreditCardVerificationSearch < AdvancedSearch
      text_fields(
        :billing_address_details_postal_code,
        :credit_card_cardholder_name,

data/lib/braintree/customer.rb

@@ -67,7 +67,6 @@ module Braintree
       Configuration.gateway.customer.search(&block)
     end
 
-    # Returns a ResourceCollection of transactions for the customer with the given +customer_id+.
     def self.transactions(*args)
       Configuration.gateway.customer.transactions(*args)
     end
@@ -80,7 +79,7 @@ module Braintree
       Configuration.gateway.customer.update!(*args)
     end
 
-    def initialize(gateway, attributes) # :nodoc:
+    def initialize(gateway, attributes)
       @gateway = gateway
       set_instance_variables_from_hash(attributes)
       @credit_cards = (@credit_cards || []).map { |pm| CreditCard._new gateway, pm }
@@ -105,7 +104,6 @@ module Braintree
       return_object_or_raise(:transaction) { credit(transaction_attributes) }
     end
 
-    # Returns the customer's default payment method.
     def default_payment_method
       payment_methods.find { |payment_instrument| payment_instrument.default? }
     end
@@ -114,7 +112,6 @@ module Braintree
       @gateway.customer.delete(id)
     end
 
-    # Returns the customer's payment methods
     def payment_methods
       @credit_cards +
         @paypal_accounts +
@@ -127,7 +124,7 @@ module Braintree
         @sepa_direct_debit_accounts
     end
 
-    def inspect # :nodoc:
+    def inspect
       first = [:id]
       last = [:addresses, :credit_cards, :paypal_accounts, :tax_identifiers]
       order = first + (self.class._attributes - first - last) + last
@@ -137,7 +134,6 @@ module Braintree
       "#<#{self.class} #{nice_attributes.join(', ')}>"
     end
 
-    # Returns a ResourceCollection of transactions for the customer.
     def transactions(options = {})
       @gateway.customer.transactions(id, options)
     end
@@ -146,18 +142,18 @@ module Braintree
       protected :new
     end
 
-    def self._new(*args) # :nodoc:
+    def self._new(*args)
       self.new(*args)
     end
 
-    def self._attributes # :nodoc:
+    def self._attributes
       [
         :addresses, :company, :credit_cards, :email, :fax, :first_name, :id, :last_name, :phone, :website,
         :created_at, :updated_at, :tax_identifiers
       ]
     end
 
-    def self._now_timestamp # :nodoc:
+    def self._now_timestamp
       Time.now.to_i
     end
   end

data/lib/braintree/customer_gateway.rb

@@ -1,5 +1,5 @@
 module Braintree
-  class CustomerGateway # :nodoc:
+  class CustomerGateway
     include BaseModule
 
     def initialize(gateway)
@@ -60,7 +60,7 @@ module Braintree
       return_object_or_raise(:customer) { update(*args) }
     end
 
-    def self._create_signature # :nodoc:
+    def self._create_signature
       credit_card_signature = CreditCardGateway._create_signature - [:customer_id]
       paypal_account_signature = PayPalAccountGateway._create_nested_signature
       paypal_options_shipping_signature = AddressGateway._shared_signature
@@ -86,7 +86,7 @@ module Braintree
       ]
     end
 
-    def _do_create(path, params=nil) # :nodoc:
+    def _do_create(path, params=nil)
       response = @config.http.post("#{@config.base_merchant_path}#{path}", params)
       if response[:customer]
         SuccessfulResult.new(:customer => Customer._new(@gateway, response[:customer]))
@@ -97,7 +97,7 @@ module Braintree
       end
     end
 
-    def _do_update(http_verb, path, params) # :nodoc:
+    def _do_update(http_verb, path, params)
       response = @config.http.send(http_verb, "#{@config.base_merchant_path}#{path}", params)
       if response[:customer]
         SuccessfulResult.new(:customer => Customer._new(@gateway, response[:customer]))
@@ -108,14 +108,14 @@ module Braintree
       end
     end
 
-    def _fetch_customers(search, ids) # :nodoc:
+    def _fetch_customers(search, ids)
       search.ids.in ids
       response = @config.http.post("#{@config.base_merchant_path}/customers/advanced_search", {:search => search.to_hash})
       attributes = response[:customers]
       Util.extract_attribute_as_array(attributes, :customer).map { |attrs| Customer._new(@gateway, attrs) }
     end
 
-    def _fetch_transactions(customer_id, ids) # :nodoc:
+    def _fetch_transactions(customer_id, ids)
       response = @config.http.post("#{@config.base_merchant_path}/customers/#{customer_id}/transactions", :search => {:ids => ids})
       attributes = response[:credit_card_transactions]
       Util.extract_attribute_as_array(attributes, :transaction).map do |transaction_attributes|
@@ -123,7 +123,7 @@ module Braintree
       end
     end
 
-    def self._update_signature # :nodoc:
+    def self._update_signature
       credit_card_signature = CreditCardGateway._update_signature - [:customer_id]
       credit_card_options = credit_card_signature.find { |item| item.respond_to?(:keys) && item.keys == [:options] }
       credit_card_options[:options] << :update_existing_token

data/lib/braintree/customer_search.rb

@@ -1,5 +1,5 @@
 module Braintree
-  class CustomerSearch < AdvancedSearch # :nodoc:
+  class CustomerSearch < AdvancedSearch
     text_fields(
       :address_country_name,
       :address_extended_address,

data/lib/braintree/descriptor.rb

@@ -1,5 +1,5 @@
 module Braintree
-  class Descriptor # :nodoc:
+  class Descriptor
     include BaseModule
 
     attr_reader :name

data/lib/braintree/digest.rb

@@ -1,5 +1,5 @@
 module Braintree
-  module Digest # :nodoc:
+  module Digest
     def self.hexdigest(private_key, string)
       _hmac_sha1(private_key, string)
     end

data/lib/braintree/disbursement.rb

@@ -20,7 +20,7 @@ module Braintree
 
     alias_method :success?, :success
 
-    def initialize(gateway, attributes) # :nodoc:
+    def initialize(gateway, attributes)
       @gateway = gateway
       set_instance_variables_from_hash(attributes)
       @amount = Util.to_big_decimal(amount)
@@ -34,10 +34,10 @@ module Braintree
       end
     end
 
-    def inspect # :nodoc:
+    def inspect
       nice_attributes = self.class._inspect_attributes.map { |attr| "#{attr}: #{send(attr).inspect}" }
       nice_attributes << "amount: #{self.amount.to_s("F").inspect}"
-      nice_attributes << "disbursement_date: #{self.disbursement_date.to_s}"
+      nice_attributes << "disbursement_date: #{self.disbursement_date}"
       "#<#{self.class} #{nice_attributes.join(', ')}>"
     end
 
@@ -51,12 +51,12 @@ module Braintree
 
     class << self
       protected :new
-      def _new(*args) # :nodoc:
+      def _new(*args)
         self.new(*args)
       end
     end
 
-    def self._inspect_attributes # :nodoc:
+    def self._inspect_attributes
       [:id, :exception_message, :follow_up_action, :merchant_account, :transaction_ids, :retry, :success]
     end
   end

data/lib/braintree/discount_gateway.rb

@@ -1,5 +1,5 @@
 module Braintree
-  class DiscountGateway # :nodoc
+  class DiscountGateway
     def initialize(gateway)
       @gateway = gateway
       @config = gateway.config

data/lib/braintree/dispute/evidence.rb

@@ -1,6 +1,6 @@
 module Braintree
   class Dispute
-    class Evidence # :nodoc:
+    class Evidence
       include BaseModule
 
       attr_reader :category,

data/lib/braintree/dispute/paypal_message.rb

@@ -1,6 +1,6 @@
 module Braintree
   class Dispute
-    class PayPalMessage # :nodoc:
+    class PayPalMessage
       include BaseModule
 
       attr_reader :message,

data/lib/braintree/dispute/status_history.rb

@@ -1,6 +1,6 @@
 module Braintree
   class Dispute
-    class StatusHistory # :nodoc:
+    class StatusHistory
       include BaseModule
 
       attr_reader :disbursement_date

data/lib/braintree/dispute/transaction.rb

@@ -1,6 +1,6 @@
 module Braintree
   class Dispute
-    class Transaction # :nodoc:
+    class Transaction
       include BaseModule
 
       attr_reader :amount

data/lib/braintree/dispute/transaction_details.rb

@@ -1,6 +1,6 @@
 module Braintree
   class Dispute
-    class TransactionDetails # :nodoc:
+    class TransactionDetails
       include BaseModule
 
       attr_reader :amount

data/lib/braintree/dispute.rb

@@ -1,5 +1,5 @@
 module Braintree
-  class Dispute # :nodoc:
+  class Dispute
     include BaseModule
     include Braintree::Util::IdEquality
 
@@ -97,7 +97,7 @@ module Braintree
 
     class << self
       protected :new
-      def _new(*args) # :nodoc:
+      def _new(*args)
         self.new(*args)
       end
     end
@@ -130,7 +130,7 @@ module Braintree
       Configuration.gateway.dispute.search(&block)
     end
 
-    def initialize(attributes) # :nodoc:
+    def initialize(attributes)
       set_instance_variables_from_hash(attributes)
       @date_opened = Date.parse(date_opened) unless date_opened.nil?
       @date_won = Date.parse(date_won) unless date_won.nil?

data/lib/braintree/dispute_gateway.rb

@@ -1,5 +1,5 @@
 module Braintree
-  class DisputeGateway # :nodoc:
+  class DisputeGateway
     def initialize(gateway)
       @gateway = gateway
       @config = gateway.config

data/lib/braintree/dispute_search.rb

@@ -1,5 +1,5 @@
 module Braintree
-  class DisputeSearch < AdvancedSearch # :nodoc:
+  class DisputeSearch < AdvancedSearch
     text_fields(
       :case_number,
       :customer_id,

data/lib/braintree/document_upload.rb

@@ -23,13 +23,13 @@ module Braintree
       Configuration.gateway.document_upload.create!(*args)
     end
 
-    def initialize(attributes) # :nodoc:
+    def initialize(attributes)
       set_instance_variables_from_hash(attributes)
     end
 
     class << self
       protected :new
-      def _new(*args) # :nodoc:
+      def _new(*args)
         self.new(*args)
       end
     end

data/lib/braintree/document_upload_gateway.rb

@@ -1,5 +1,5 @@
 module Braintree
-  class DocumentUploadGateway # :nodoc:
+  class DocumentUploadGateway
     include BaseModule
 
     def initialize(gateway)
@@ -17,14 +17,14 @@ module Braintree
       return_object_or_raise(:document_upload) { create(*args) }
     end
 
-    def self._create_signature # :nodoc:
+    def self._create_signature
       [
         :kind,
         :file
       ]
     end
 
-    def _do_create(path, params, file) # :nodoc:
+    def _do_create(path, params, file)
       response = @config.http.post("#{@config.base_merchant_path}#{path}", params, file)
       if response[:document_upload]
         SuccessfulResult.new(:document_upload => DocumentUpload._new(response[:document_upload]))

data/lib/braintree/enriched_customer_data.rb

@@ -5,7 +5,7 @@ module Braintree
     attr_reader :fields_updated
     attr_reader :profile_data
 
-    def initialize(attributes) # :nodoc:
+    def initialize(attributes)
       set_instance_variables_from_hash(attributes)
       @profile_data = VenmoProfileData._new(attributes[:profile_data])
     end
@@ -14,7 +14,7 @@ module Braintree
       protected :new
     end
 
-    def self._new(*args) # :nodoc:
+    def self._new(*args)
       self.new(*args)
     end
   end

data/lib/braintree/error_result.rb

@@ -10,7 +10,7 @@ module Braintree
     attr_reader :transaction
     attr_reader :verification
 
-    def initialize(gateway, data) # :nodoc:
+    def initialize(gateway, data)
       @gateway = gateway
       @params = data[:params]
       @credit_card_verification = CreditCardVerification._new(data[:verification]) if data[:verification]
@@ -22,7 +22,7 @@ module Braintree
       @errors = Errors.new(data[:errors])
     end
 
-    def inspect # :nodoc:
+    def inspect
       if @credit_card_verification
         verification_inspect = " credit_card_verification: #{@credit_card_verification.inspect}"
       end
@@ -32,7 +32,6 @@ module Braintree
       "#<#{self.class} params:{...} errors:<#{@errors._inner_inspect}>#{verification_inspect}#{transaction_inspect}>"
     end
 
-    # Always returns false.
     def success?
       false
     end

data/lib/braintree/errors.rb

@@ -2,7 +2,7 @@ module Braintree
   class Errors
     include Enumerable
 
-    def initialize(data = {}) # :nodoc:
+    def initialize(data = {})
       @errors = ValidationErrorCollection.new(data.merge(:errors => []))
     end
 
@@ -14,7 +14,7 @@ module Braintree
       @errors.for(scope)
     end
 
-    def inspect # :nodoc:
+    def inspect
       "#<#{self.class} #{_inner_inspect}>"
     end
 
@@ -25,7 +25,7 @@ module Braintree
       @errors.deep_size
     end
 
-    def _inner_inspect # :nodoc:
+    def _inner_inspect
       @errors._inner_inspect
     end
   end

data/lib/braintree/exceptions.rb

@@ -1,5 +1,4 @@
-module Braintree # :nodoc:
-  # Super class for all Braintree exceptions.
+module Braintree
   class BraintreeError < ::StandardError; end
 
   class AuthenticationError < BraintreeError; end

data/lib/braintree/exchange_rate.rb

@@ -1,8 +1,8 @@
 module Braintree
   class ExchangeRate
-    include BaseModule # :nodoc:
+    include BaseModule
 
-    def initialize(gateway, attributes) # :nodoc:
+    def initialize(gateway, attributes)
       set_instance_variables_from_hash(attributes)
     end
 

data/lib/braintree/exchange_rate_quote.rb

@@ -1,6 +1,6 @@
 module Braintree
   class ExchangeRateQuote
-    include BaseModule # :nodoc:
+    include BaseModule
 
     attr_reader :attrs
     attr_reader :base_amount
@@ -11,12 +11,12 @@ module Braintree
     attr_reader :refreshes_at
     attr_reader :trade_rate
 
-    def initialize(attributes) # :nodoc:
+    def initialize(attributes)
       @attrs = attributes.keys
       set_instance_variables_from_hash(attributes)
     end
 
-    def inspect # :nodoc:
+    def inspect
       inspected_attributes = @attrs.map { |attr| "#{attr}:#{send(attr).inspect}" }
       "#<#{self.class} #{inspected_attributes.join(" ")}>"
     end

data/lib/braintree/exchange_rate_quote_gateway.rb

@@ -1,5 +1,5 @@
 module Braintree
-  class ExchangeRateQuoteGateway # :nodoc
+  class ExchangeRateQuoteGateway
     def initialize(gateway)
       @gateway = gateway
     end

data/lib/braintree/exchange_rate_quote_input.rb

@@ -1,6 +1,6 @@
 module Braintree
   class ExchangeRateQuoteInput
-    include BaseModule # :nodoc:
+    include BaseModule
 
     attr_reader :attrs
     attr_reader :base_currency
@@ -8,12 +8,12 @@ module Braintree
     attr_reader :markup
     attr_reader :quote_currency
 
-    def initialize(attributes) # :nodoc:
+    def initialize(attributes)
       @attrs = attributes.keys
       set_instance_variables_from_hash(attributes)
     end
 
-    def inspect # :nodoc:
+    def inspect
       inspected_attributes = @attrs.map { |attr| "#{attr}:#{send(attr).inspect}" }
       "#<#{self.class} #{inspected_attributes.join(" ")}>"
     end

data/lib/braintree/exchange_rate_quote_request.rb

@@ -1,16 +1,16 @@
 module Braintree
   class ExchangeRateQuoteRequest
-    include BaseModule # :nodoc:
+    include BaseModule
 
     attr_reader :quotes
 
-    def initialize(attributes) # :nodoc:
+    def initialize(attributes)
       @attrs = attributes.keys
       set_instance_variables_from_hash(attributes)
       @quotes = (@quotes || []).map { |quote_hash| ExchangeRateQuoteInput.new(quote_hash) }
     end
 
-    def inspect # :nodoc:
+    def inspect
       inspected_attributes = @attrs.map { |attr| "#{attr}:#{send(attr).inspect}" }
       "#<#{self.class} #{inspected_attributes.join(" ")}>"
     end

data/lib/braintree/exchange_rate_quote_response.rb

@@ -1,16 +1,16 @@
 module Braintree
   class ExchangeRateQuoteResponse
-    include BaseModule # :nodoc:
+    include BaseModule
 
     attr_reader :quotes
 
-    def initialize(attributes) # :nodoc:
+    def initialize(attributes)
       @attrs = attributes.keys
       set_instance_variables_from_hash(attributes)
       @quotes = (@quotes || []).map { |quote_hash| ExchangeRateQuote.new(quote_hash) }
     end
 
-    def inspect # :nodoc:
+    def inspect
       inspected_attributes = @attrs.map { |attr| "#{attr}:#{send(attr).inspect}" }
       "#<#{self.class} #{inspected_attributes.join(" ")}>"
     end

data/lib/braintree/facilitated_details.rb

@@ -1,5 +1,5 @@
 module Braintree
-  class FacilitatedDetails # :nodoc:
+  class FacilitatedDetails
     include BaseModule
 
     attr_reader :merchant_id

data/lib/braintree/facilitator_details.rb

@@ -1,5 +1,5 @@
 module Braintree
-  class FacilitatorDetails # :nodoc:
+  class FacilitatorDetails
     include BaseModule
 
     attr_reader :oauth_application_client_id

data/lib/braintree/google_pay_card.rb

@@ -1,6 +1,6 @@
 module Braintree
   class GooglePayCard
-    include BaseModule # :nodoc:
+    include BaseModule
 
     attr_reader :bin
     attr_reader :commercial
@@ -28,7 +28,7 @@ module Braintree
     attr_reader :virtual_card_last_4
     attr_reader :virtual_card_type
 
-    def initialize(gateway, attributes) # :nodoc:
+    def initialize(gateway, attributes)
       @gateway = gateway
       set_instance_variables_from_hash(attributes)
       @subscriptions = (@subscriptions || []).map { |subscription_hash| Subscription._new(@gateway, subscription_hash) }
@@ -54,7 +54,7 @@ module Braintree
       protected :new
     end
 
-    def self._new(*args) # :nodoc:
+    def self._new(*args)
       self.new(*args)
     end
   end

data/lib/braintree/granted_payment_instrument_update.rb

@@ -15,7 +15,7 @@ module Braintree
 
     class << self
       protected :new
-      def _new(*args) # :nodoc:
+      def _new(*args)
         self.new(*args)
       end
     end

data/lib/braintree/graphql_client.rb

@@ -1,5 +1,5 @@
 module Braintree
-  class GraphQLClient < Http # :nodoc:
+  class GraphQLClient < Http
 
     def initialize(config)
       @config = config

data/lib/braintree/http.rb

@@ -1,5 +1,5 @@
 module Braintree
-  class Http # :nodoc:
+  class Http
 
     LINE_FEED = "\r\n"
 
@@ -7,8 +7,8 @@ module Braintree
       @config = config
     end
 
-    def delete(_path, query_params = {})
-      path = _path + _build_query_string(query_params)
+    def delete(path, query_params = {})
+      full_path = path + _build_query_string(query_params)
       response = _http_do Net::HTTP::Delete, path
       if response.code.to_i == 200 || response.code.to_i == 204
         true
@@ -19,8 +19,8 @@ module Braintree
       end
     end
 
-    def get(_path, query_params = {})
-      path = _path + _build_query_string(query_params)
+    def get(path, query_params = {})
+      full_path = path + _build_query_string(query_params)
       response = _http_do Net::HTTP::Get, path
       if response.code.to_i == 200 || response.code.to_i == 422
         Xml.hash_from_xml(_body(response))