braintree 4.15.0 → 4.16.0

data/lib/braintree/transaction_review.rb

@@ -10,7 +10,7 @@ module Braintree
 
     class << self
       protected :new
-      def _new(*args) # :nodoc:
+      def _new(*args)
         self.new(*args)
       end
     end

data/lib/braintree/transaction_search.rb

@@ -1,5 +1,5 @@
 module Braintree
-  class TransactionSearch < AdvancedSearch # :nodoc:
+  class TransactionSearch < AdvancedSearch
     text_fields(
       :billing_company,
       :billing_country_name,

data/lib/braintree/unknown_payment_method.rb

@@ -19,7 +19,7 @@ module Braintree
       "https://assets.braintreegateway.com/payment_method_logo/unknown.png"
     end
 
-    def self._new(*args) # :nodoc:
+    def self._new(*args)
       self.new(*args)
     end
   end

data/lib/braintree/us_bank_account.rb

@@ -14,7 +14,7 @@ module Braintree
     attr_reader :verifications
     attr_reader :verified
 
-    def initialize(gateway, attributes) # :nodoc:
+    def initialize(gateway, attributes)
       @gateway = gateway
       set_instance_variables_from_hash(attributes)
       @ach_mandate = AchMandate.new(attributes[:ach_mandate]) if attributes[:ach_mandate]
@@ -34,7 +34,7 @@ module Braintree
       protected :new
     end
 
-    def self._new(*args) # :nodoc:
+    def self._new(*args)
       self.new(*args)
     end
 

data/lib/braintree/us_bank_account_verification.rb

@@ -22,33 +22,41 @@ module Braintree
       All = [IndependentCheck, NetworkCheck, TokenizedCheck, MicroTransfers]
     end
 
+    module VerificationAddOns
+      CustomerVerification = "customer_verification"
+
+      All = [CustomerVerification]
+    end
+
+    attr_reader :additional_processor_response
+    attr_reader :created_at
+    attr_reader :gateway_rejection_reason
     attr_reader :id
-    attr_reader :status
-    attr_reader :verification_determined_at
-    attr_reader :verification_method
+    attr_reader :merchant_account_id
     attr_reader :processor_response_code
     attr_reader :processor_response_text
-    attr_reader :merchant_account_id
-    attr_reader :gateway_rejection_reason
+    attr_reader :status
     attr_reader :us_bank_account
-    attr_reader :created_at
+    attr_reader :verification_determined_at
+    attr_reader :verification_method
 
-    def initialize(attributes) # :nodoc:
+    def initialize(attributes)
       set_instance_variables_from_hash(attributes)
     end
 
-    def inspect # :nodoc:
+    def inspect
       attr_order = [
-        :status,
-        :processor_response_code,
-        :processor_response_text,
-        :merchant_account_id,
+        :additional_processor_response,
+        :created_at,
         :gateway_rejection_reason,
         :id,
+        :merchant_account_id,
+        :processor_response_code,
+        :processor_response_text,
+        :status,
         :us_bank_account,
-        :verification_method,
         :verification_determined_at,
-        :created_at
+        :verification_method
       ]
 
       formatted_attrs = attr_order.map do |attr|
@@ -62,7 +70,7 @@ module Braintree
       protected :new
     end
 
-    def self._new(*args) # :nodoc:
+    def self._new(*args)
       self.new(*args)
     end
 

data/lib/braintree/us_bank_account_verification_search.rb

@@ -1,5 +1,5 @@
 module Braintree
-  class UsBankAccountVerificationSearch < AdvancedSearch # :nodoc:
+  class UsBankAccountVerificationSearch < AdvancedSearch
      text_fields(
        :id,
        :account_holder_name,

data/lib/braintree/util.rb

@@ -1,5 +1,5 @@
 module Braintree
-  module Util # :nodoc:
+  module Util
     def self.extract_attribute_as_array(hash, attribute)
       raise UnexpectedError.new("Unprocessable entity due to an invalid request") if hash.nil?
       value = hash.has_key?(attribute) ? hash.delete(attribute) : []
@@ -195,14 +195,14 @@ module Braintree
     end
 
     module IdEquality
-      def ==(other) # :nodoc:
+      def ==(other)
         return false unless other.is_a?(self.class)
         id == other.id
       end
     end
 
     module TokenEquality
-      def ==(other) # :nodoc:
+      def ==(other)
         return false unless other.is_a?(self.class)
         token == other.token
       end

data/lib/braintree/validation_error.rb

@@ -18,7 +18,7 @@ module Braintree
       set_instance_variables_from_hash error_hash
     end
 
-    def inspect # :nodoc:
+    def inspect
       "#<#{self.class} (#{code}) #{message}>"
     end
   end

data/lib/braintree/validation_error_collection.rb

@@ -2,7 +2,7 @@ module Braintree
   class ValidationErrorCollection
     include Enumerable
 
-    def initialize(data) # :nodoc:
+    def initialize(data)
       return if !data.is_a? Hash
       @errors = (data[:errors] || {}).map { |hash| Braintree::ValidationError.new(hash) }
       @nested = {}
@@ -42,7 +42,7 @@ module Braintree
       self.for("index_#{index}".to_sym)
     end
 
-    def inspect # :nodoc:
+    def inspect
       "#<#{self.class} errors#{_inner_inspect}>"
     end
 
@@ -61,7 +61,7 @@ module Braintree
       @errors.size
     end
 
-    def _inner_inspect(scope = []) # :nodoc:
+    def _inner_inspect(scope = [])
       all = []
       scope_string = scope.join("/")
       if @errors.any?

data/lib/braintree/venmo_account.rb

@@ -1,6 +1,6 @@
 module Braintree
   class VenmoAccount
-    include BaseModule # :nodoc:
+    include BaseModule
 
     attr_reader :created_at
     attr_reader :customer_id
@@ -13,7 +13,7 @@ module Braintree
     attr_reader :username
     attr_reader :venmo_user_id
 
-    def initialize(gateway, attributes) # :nodoc:
+    def initialize(gateway, attributes)
       @gateway = gateway
       set_instance_variables_from_hash(attributes)
       @subscriptions = (@subscriptions || []).map { |subscription_hash| Subscription._new(@gateway, subscription_hash) }
@@ -27,7 +27,7 @@ module Braintree
       protected :new
     end
 
-    def self._new(*args) # :nodoc:
+    def self._new(*args)
       self.new(*args)
     end
   end

data/lib/braintree/venmo_profile_data.rb

@@ -2,13 +2,15 @@ module Braintree
   class VenmoProfileData
     include BaseModule
 
-    attr_reader :username
+    attr_reader :billing_address
+    attr_reader :email
     attr_reader :first_name
     attr_reader :last_name
     attr_reader :phone_number
-    attr_reader :email
+    attr_reader :shipping_address
+    attr_reader :username
 
-    def initialize(attributes) # :nodoc:
+    def initialize(attributes)
       set_instance_variables_from_hash(attributes)
     end
 
@@ -16,7 +18,7 @@ module Braintree
       protected :new
     end
 
-    def self._new(*args) # :nodoc:
+    def self._new(*args)
       self.new(*args)
     end
   end

data/lib/braintree/version.rb

@@ -1,7 +1,7 @@
 module Braintree
   module Version
     Major = 4
-    Minor = 15
+    Minor = 16
     Tiny = 0
 
     String = "#{Major}.#{Minor}.#{Tiny}"

data/lib/braintree/visa_checkout_card.rb

@@ -1,6 +1,6 @@
 module Braintree
   class VisaCheckoutCard
-    include BaseModule # :nodoc:
+    include BaseModule
     include Braintree::Util::TokenEquality
 
     attr_reader :billing_address
@@ -30,7 +30,7 @@ module Braintree
     attr_reader :updated_at
     attr_reader :verification
 
-    def initialize(gateway, attributes) # :nodoc:
+    def initialize(gateway, attributes)
       @gateway = gateway
       set_instance_variables_from_hash(attributes)
       @billing_address = attributes[:billing_address] ? Address._new(@gateway, attributes[:billing_address]) : nil
@@ -39,8 +39,8 @@ module Braintree
     end
 
     def _most_recent_verification(attributes)
-      verification = (attributes[:verifications] || []).sort_by { |verification| verification[:created_at] }.reverse.first
-      CreditCardVerification._new(verification) if verification
+      sorted_verifications = (attributes[:verifications] || []).sort_by { |verification| verification[:created_at] }.reverse.first
+      CreditCardVerification._new(sorted_verifications) if sorted_verifications
     end
 
     def default?
@@ -56,7 +56,7 @@ module Braintree
       @expired
     end
 
-    def inspect # :nodoc:
+    def inspect
       first = [:token]
       order = first + (self.class._attributes - first)
       nice_attributes = order.map do |attr|
@@ -73,7 +73,7 @@ module Braintree
       protected :new
     end
 
-    def self._attributes # :nodoc:
+    def self._attributes
       [
         :billing_address, :bin, :card_type, :cardholder_name, :created_at,
         :customer_id, :customer_location, :expiration_month, :expiration_year,
@@ -83,7 +83,7 @@ module Braintree
       ]
     end
 
-    def self._new(*args) # :nodoc:
+    def self._new(*args)
       self.new(*args)
     end
   end

data/lib/braintree/webhook_notification.rb

@@ -92,7 +92,7 @@ module Braintree
       Configuration.gateway.webhook_notification.verify(*args)
     end
 
-    def initialize(gateway, attributes) # :nodoc:
+    def initialize(gateway, attributes)
       @gateway = gateway
       set_instance_variables_from_hash(attributes)
       @error_result = ErrorResult.new(gateway, @subject[:api_error_response]) if @subject.has_key?(:api_error_response)
@@ -135,7 +135,7 @@ module Braintree
 
     class << self
       protected :new
-      def _new(*args) # :nodoc:
+      def _new(*args)
         self.new(*args)
       end
     end

data/lib/braintree/webhook_notification_gateway.rb

@@ -1,5 +1,5 @@
 module Braintree
-  class WebhookNotificationGateway # :nodoc:
+  class WebhookNotificationGateway
     def initialize(gateway)
       @gateway = gateway
       @config = gateway.config
@@ -36,8 +36,8 @@ module Braintree
       public_key, signature = _matching_signature_pair(signature_string)
       raise InvalidSignature, "no matching public key" if public_key.nil?
 
-      signature_matches = [payload, payload + "\n"].any? do |payload|
-        payload_signature = Braintree::Digest.hexdigest(@config.private_key, payload)
+      signature_matches = [payload, payload + "\n"].any? do |_payload|
+        payload_signature = Braintree::Digest.hexdigest(@config.private_key, _payload)
         Braintree::Digest.secure_compare(signature, payload_signature)
       end
       raise InvalidSignature, "signature does not match payload - one has been modified" unless signature_matches

data/lib/braintree/webhook_testing.rb

@@ -1,5 +1,5 @@
 module Braintree
-  class WebhookTesting # :nodoc:
+  class WebhookTesting
     def self.sample_notification(*args)
       Configuration.gateway.webhook_testing.sample_notification(*args)
     end

data/lib/braintree/webhook_testing_gateway.rb

@@ -1,5 +1,5 @@
 module Braintree
-  class WebhookTestingGateway # :nodoc:
+  class WebhookTestingGateway
     def initialize(gateway)
       @gateway = gateway
       @config = gateway.config

data/lib/braintree/xml/generator.rb

@@ -2,7 +2,7 @@
 # under the MIT license, copyright (c) 2005-2009 David Heinemeier Hansson
 module Braintree
   module Xml
-    module Generator # :nodoc:
+    module Generator
       XML_TYPE_NAMES = {
         "Fixnum"     => "integer",
         "Bignum"     => "integer",

data/lib/braintree/xml/libxml.rb

@@ -2,7 +2,7 @@
 # under the MIT license, copyright (c) 2005-2009 David Heinemeier Hansson
 module Braintree
   module Xml
-    module Libxml # :nodoc:
+    module Libxml
       LIB_XML_LIMIT = 30000000
 
       def self.parse(xml_string)

data/lib/braintree/xml/parser.rb

@@ -1,10 +1,10 @@
 # Portions of this code were copied and modified from Ruby on Rails, released
 # under the MIT license, copyright (c) 2005-2009 David Heinemeier Hansson
 module Braintree
-  module Xml # :nodoc:
+  module Xml
     CONTENT_ROOT = "__content__"
 
-    module Parser # :nodoc:
+    module Parser
       XML_PARSING = {
         "datetime" => Proc.new { |time| ::Time.parse(time).utc },
         "integer"  => Proc.new { |integer| integer.to_i },

data/lib/braintree/xml/rexml.rb

@@ -1,8 +1,8 @@
 # Portions of this code were copied and modified from Ruby on Rails, released
 # under the MIT license, copyright (c) 2005-2009 David Heinemeier Hansson
 module Braintree
-  module Xml # :nodoc:
-    module Rexml # :nodoc:
+  module Xml
+    module Rexml
 
       CONTENT_KEY = "__content__".freeze
 

data/lib/braintree/xml.rb

@@ -1,5 +1,5 @@
 module Braintree
-  module Xml # :nodoc:
+  module Xml
     def self.hash_from_xml(xml)
       Parser.hash_from_xml(xml)
     end

data/lib/braintree.rb

@@ -3,7 +3,6 @@ require "bigdecimal"
 require "cgi"
 require "date"
 require "digest/sha1"
-require "enumerator"
 require "forwardable"
 require "logger"
 require "net/http"
@@ -91,6 +90,8 @@ require "braintree/merchant_account/individual_details"
 require "braintree/merchant_account/business_details"
 require "braintree/merchant_account/funding_details"
 require "braintree/merchant_account/address_details"
+require "braintree/meta_checkout_card"
+require "braintree/meta_checkout_token"
 require "braintree/oauth_gateway"
 require "braintree/oauth_credentials"
 require "braintree/payment_instrument_type"
@@ -153,6 +154,8 @@ require "braintree/transaction/installment/adjustment"
 require "braintree/transaction/payment_receipt"
 require "braintree/transaction/payment_receipt/card_present_data.rb"
 require "braintree/transaction/payment_receipt/merchant_address.rb"
+require "braintree/transaction/meta_checkout_card_details"
+require "braintree/transaction/meta_checkout_token_details"
 require "braintree/transaction/paypal_details"
 require "braintree/transaction/paypal_here_details"
 require "braintree/transaction/samsung_pay_card_details"

data/spec/integration/braintree/dispute_search_spec.rb

@@ -24,7 +24,6 @@ describe Braintree::Dispute, "search" do
         :number => Braintree::Test::CreditCardNumbers::Disputes::Chargeback,
       },
       :customer_id => customer.id,
-      :merchant_account_id => "14LaddersLLC_instant",
       :options => {
         :submit_for_settlement => true,
       },

data/spec/integration/braintree/payment_method_nonce_spec.rb

@@ -91,6 +91,26 @@ describe Braintree::PaymentMethodNonce do
       expect(nonce.details.payer_info).to be_nil
     end
 
+    it "return meta_checkout_card_details nonce if exist" do
+      result = Braintree::PaymentMethodNonce.find(Braintree::Test::Nonce::MetaCheckoutCard)
+      nonce = result.payment_method_nonce
+      nonce.details.bin.should == "401288"
+      nonce.details.last_two.should == "81"
+      nonce.details.card_type.should == "Visa"
+      nonce.details.expiration_year.should == "2024"
+      nonce.details.expiration_month.should == "12"
+    end
+
+    it "return meta_checkout_token_details nonce if exist" do
+      result = Braintree::PaymentMethodNonce.find(Braintree::Test::Nonce::MetaCheckoutToken)
+      nonce = result.payment_method_nonce
+      nonce.details.bin.should == "401288"
+      nonce.details.last_two.should == "81"
+      nonce.details.card_type.should == "Visa"
+      nonce.details.expiration_year.should == "2024"
+      nonce.details.expiration_month.should == "12"
+    end
+
     it "return paypal details if details exist" do
       result = Braintree::PaymentMethodNonce.find("fake-paypal-one-time-nonce")
       nonce = result.payment_method_nonce

data/spec/integration/braintree/payment_method_us_bank_account_spec.rb

@@ -78,6 +78,78 @@ describe Braintree::PaymentMethod do
             expect(Braintree::PaymentMethod.find(us_bank_account.token)).to be_a(Braintree::UsBankAccount)
           end
         end
+
+        it "succeeds and verifies with verification_add_ons for NetworkCheck with fake nonce" do
+          customer = Braintree::Customer.create.customer
+          result = Braintree::PaymentMethod.create(
+            :payment_method_nonce => Braintree::Test::Nonce::UsBankAccount,
+            :customer_id => customer.id,
+            :options => {
+              :us_bank_account_verification_method => Braintree::UsBankAccountVerification::VerificationMethod::NetworkCheck,
+              :verification_add_ons => Braintree::UsBankAccountVerification::VerificationAddOns::CustomerVerification,
+              :verification_merchant_account_id => SpecHelper::AnotherUsBankMerchantAccountId,
+            },
+          )
+
+          expect(result).to be_success
+          us_bank_account = result.payment_method
+          expect(us_bank_account).to be_a(Braintree::UsBankAccount)
+          expect(us_bank_account.routing_number).to eq("123456789")
+          expect(us_bank_account.last_4).to eq("0000")
+          expect(us_bank_account.account_type).to eq("checking")
+          expect(us_bank_account.account_holder_name).to eq("Dan Schulman")
+          expect(us_bank_account.bank_name).to match(/Wells Fargo/)
+          expect(us_bank_account.default).to eq(true)
+          expect(us_bank_account.ach_mandate.text).to eq("example mandate text")
+          expect(us_bank_account.ach_mandate.accepted_at).to be_a Time
+
+          expect(us_bank_account.verifications.count).to eq(1)
+          expect(us_bank_account.verifications.first.status).to eq(Braintree::UsBankAccountVerification::Status::Verified)
+          expect(us_bank_account.verifications.first.verification_method).to eq(Braintree::UsBankAccountVerification::VerificationMethod::NetworkCheck)
+          expect(us_bank_account.verifications.first.id).not_to be_empty
+          expect(us_bank_account.verifications.first.verification_determined_at).to be_a Time
+          expect(us_bank_account.verifications.first.processor_response_code).to eq("1000")
+          expect(us_bank_account.verified).to eq(true)
+
+          expect(Braintree::PaymentMethod.find(us_bank_account.token)).to be_a(Braintree::UsBankAccount)
+        end
+
+        it "returns additional processor response for failed NetworkCheck" do
+          customer = Braintree::Customer.create.customer
+          invalid_nonce = generate_non_plaid_us_bank_account_nonce(account_number = "1000000005")
+          result = Braintree::PaymentMethod.create(
+            :payment_method_nonce => invalid_nonce,
+            :customer_id => customer.id,
+            :options => {
+              :us_bank_account_verification_method => Braintree::UsBankAccountVerification::VerificationMethod::NetworkCheck,
+              :verification_merchant_account_id => SpecHelper::AnotherUsBankMerchantAccountId,
+            },
+          )
+
+          expect(result).to be_success
+          us_bank_account = result.payment_method
+          expect(us_bank_account).to be_a(Braintree::UsBankAccount)
+          expect(us_bank_account.routing_number).to eq("021000021")
+          expect(us_bank_account.last_4).to eq("0005")
+          expect(us_bank_account.account_type).to eq("checking")
+          expect(us_bank_account.account_holder_name).to eq("John Doe")
+          expect(us_bank_account.bank_name).to match(/CHASE/)
+          expect(us_bank_account.default).to eq(true)
+          expect(us_bank_account.ach_mandate.text).to eq("cl mandate text")
+          expect(us_bank_account.ach_mandate.accepted_at).to be_a Time
+
+          expect(us_bank_account.verifications.count).to eq(1)
+          expect(us_bank_account.verifications.first.status).to eq(Braintree::UsBankAccountVerification::Status::ProcessorDeclined)
+          expect(us_bank_account.verifications.first.verification_method).to eq(Braintree::UsBankAccountVerification::VerificationMethod::NetworkCheck)
+          expect(us_bank_account.verifications.first.id).not_to be_empty
+          expect(us_bank_account.verifications.first.verification_determined_at).to be_a Time
+          expect(us_bank_account.verifications.first.processor_response_code).to eq("2061")
+          expect(us_bank_account.verifications.first.additional_processor_response).to eq("Invalid routing number")
+
+          expect(us_bank_account.verified).to eq(false)
+
+          expect(Braintree::PaymentMethod.find(us_bank_account.token)).to be_a(Braintree::UsBankAccount)
+        end
       end
 
       it "fails with invalid nonce" do

data/spec/integration/braintree/transaction_search_spec.rb

@@ -1494,6 +1494,33 @@ describe Braintree::Transaction, "search" do
         }.to raise_error(Braintree::UnexpectedError)
       end
     end
+
+    it "searches by payment instrument type meta checkout" do
+      meta_checkout_card_transaction = Braintree::Transaction.sale!(
+        :amount => Braintree::Test::TransactionAmounts::Authorize,
+        :options => {
+          :submit_for_settlement => true
+        },
+        :payment_method_nonce => Braintree::Test::Nonce::MetaCheckoutCard,
+      )
+
+      meta_checkout_token_transaction = Braintree::Transaction.sale!(
+        :amount => Braintree::Test::TransactionAmounts::Authorize,
+        :options => {
+          :submit_for_settlement => true
+        },
+        :payment_method_nonce => Braintree::Test::Nonce::MetaCheckoutToken,
+      )
+
+      collection = Braintree::Transaction.search do |search|
+        search.payment_instrument_type.in ["MetaCheckout"]
+      end
+
+      collection.maximum_size.should == 2
+      txn_ids = collection.map(&:id)
+      expect(txn_ids).to include(meta_checkout_card_transaction.id)
+      expect(txn_ids).to include(meta_checkout_token_transaction.id)
+    end
   end
 
   context "pagination" do