braintree 4.14.0 → 4.18.0

data/spec/integration/braintree/credit_card_verification_search_spec.rb

@@ -6,7 +6,7 @@ describe Braintree::CreditCardVerification, "search" do
       search.credit_card_cardholder_name.is "thisnameisnotreal"
     end
 
-    collection.maximum_size.should == 0
+    expect(collection.maximum_size).to eq(0)
   end
 
   it "can search on text fields" do
@@ -33,14 +33,14 @@ describe Braintree::CreditCardVerification, "search" do
         search.id.is verification.id
         search.send(criterion).is value
       end
-      collection.maximum_size.should == 1
-      collection.first.id.should == verification.id
+      expect(collection.maximum_size).to eq(1)
+      expect(collection.first.id).to eq(verification.id)
 
       collection = Braintree::CreditCardVerification.search do |search|
         search.id.is verification.id
         search.send(criterion).is("invalid_attribute")
       end
-      collection.should be_empty
+      expect(collection).to be_empty
     end
 
     collection = Braintree::CreditCardVerification.search do |search|
@@ -50,8 +50,8 @@ describe Braintree::CreditCardVerification, "search" do
       end
     end
 
-    collection.maximum_size.should == 1
-    collection.first.id.should == verification.id
+    expect(collection.maximum_size).to eq(1)
+    expect(collection.first.id).to eq(verification.id)
   end
 
   describe "multiple value fields" do
@@ -84,7 +84,7 @@ describe Braintree::CreditCardVerification, "search" do
         search.ids.in verification_id1, verification_id2
       end
 
-      collection.maximum_size.should == 2
+      expect(collection.maximum_size).to eq(2)
     end
   end
 
@@ -112,24 +112,24 @@ describe Braintree::CreditCardVerification, "search" do
         )
       end
 
-      collection.maximum_size.should == 1
-      collection.first.id.should == verification.id
+      expect(collection.maximum_size).to eq(1)
+      expect(collection.first.id).to eq(verification.id)
 
       collection = Braintree::CreditCardVerification.search do |search|
         search.id.is verification.id
         search.created_at >= created_at - 1
       end
 
-      collection.maximum_size.should == 1
-      collection.first.id.should == verification.id
+      expect(collection.maximum_size).to eq(1)
+      expect(collection.first.id).to eq(verification.id)
 
       collection = Braintree::CreditCardVerification.search do |search|
         search.id.is verification.id
         search.created_at <= created_at + 1
       end
 
-      collection.maximum_size.should == 1
-      collection.first.id.should == verification.id
+      expect(collection.maximum_size).to eq(1)
+      expect(collection.first.id).to eq(verification.id)
 
       collection = Braintree::CreditCardVerification.search do |search|
         search.id.is verification.id
@@ -139,15 +139,15 @@ describe Braintree::CreditCardVerification, "search" do
         )
       end
 
-      collection.maximum_size.should == 0
+      expect(collection.maximum_size).to eq(0)
 
       collection = Braintree::CreditCardVerification.search do |search|
         search.id.is verification.id
         search.created_at.is created_at
       end
 
-      collection.maximum_size.should == 1
-      collection.first.id.should == verification.id
+      expect(collection.maximum_size).to eq(1)
+      expect(collection.first.id).to eq(verification.id)
     end
   end
 

data/spec/integration/braintree/credit_card_verification_spec.rb

@@ -17,12 +17,12 @@ describe Braintree::CreditCardVerification, "search" do
 
       result = Braintree::CreditCardVerification.create(verification_params)
 
-      result.should be_success
-      result.credit_card_verification.id.should =~ /^\w{6,}$/
-      result.credit_card_verification.status.should == Braintree::CreditCardVerification::Status::Verified
-      result.credit_card_verification.processor_response_code.should == "1000"
-      result.credit_card_verification.processor_response_text.should == "Approved"
-      result.credit_card_verification.processor_response_type.should == Braintree::ProcessorResponseTypes::Approved
+      expect(result).to be_success
+      expect(result.credit_card_verification.id).to match(/^\w{6,}$/)
+      expect(result.credit_card_verification.status).to eq(Braintree::CreditCardVerification::Status::Verified)
+      expect(result.credit_card_verification.processor_response_code).to eq("1000")
+      expect(result.credit_card_verification.processor_response_text).to eq("Approved")
+      expect(result.credit_card_verification.processor_response_type).to eq(Braintree::ProcessorResponseTypes::Approved)
       expect(result.credit_card_verification.network_transaction_id).not_to be_nil
     end
 
@@ -48,6 +48,51 @@ describe Braintree::CreditCardVerification, "search" do
       expect(result.credit_card_verification.processor_response_type).to eq(Braintree::ProcessorResponseTypes::Approved)
     end
 
+    it "creates a new verification from external vault param" do
+      verification_params = {
+        :credit_card => {
+            :expiration_date => "05/2029",
+            :number => Braintree::Test::CreditCardNumbers::Visa,
+        },
+        :external_vault => {
+            :status => "will_vault"
+        }
+      }
+
+      result = Braintree::CreditCardVerification.create(verification_params)
+
+      expect(result).to be_success
+      expect(result.credit_card_verification.id).to match(/^\w{6,}$/)
+      expect(result.credit_card_verification.status).to eq(Braintree::CreditCardVerification::Status::Verified)
+      expect(result.credit_card_verification.processor_response_code).to eq("1000")
+      expect(result.credit_card_verification.processor_response_text).to eq("Approved")
+      expect(result.credit_card_verification.processor_response_type).to eq(Braintree::ProcessorResponseTypes::Approved)
+      expect(result.credit_card_verification.network_transaction_id).not_to be_nil
+    end
+
+    it "creates a new verification from risk data param" do
+      verification_params = {
+        :credit_card => {
+            :expiration_date => "05/2029",
+            :number => Braintree::Test::CreditCardNumbers::Visa,
+        },
+        :risk_data => {
+            :customer_browser => "IE7",
+            :customer_ip => "192.168.0.1"
+        }
+      }
+
+      result = Braintree::CreditCardVerification.create(verification_params)
+
+      expect(result).to be_success
+      expect(result.credit_card_verification.id).to match(/^\w{6,}$/)
+      expect(result.credit_card_verification.status).to eq(Braintree::CreditCardVerification::Status::Verified)
+      expect(result.credit_card_verification.processor_response_code).to eq("1000")
+      expect(result.credit_card_verification.processor_response_text).to eq("Approved")
+      expect(result.credit_card_verification.processor_response_type).to eq(Braintree::ProcessorResponseTypes::Approved)
+      expect(result.credit_card_verification.network_transaction_id).not_to be_nil
+    end
+
     it "returns processor response code and text as well as the additional processor response if declined" do
       verification_params = {
         :credit_card => {
@@ -61,12 +106,12 @@ describe Braintree::CreditCardVerification, "search" do
 
       result = Braintree::CreditCardVerification.create(verification_params)
 
-      result.success?.should == false
-      result.credit_card_verification.id.should =~ /^\w{6,}$/
-      result.credit_card_verification.status.should == Braintree::CreditCardVerification::Status::ProcessorDeclined
-      result.credit_card_verification.processor_response_code.should == "2000"
-      result.credit_card_verification.processor_response_text.should == "Do Not Honor"
-      result.credit_card_verification.processor_response_type.should == Braintree::ProcessorResponseTypes::SoftDeclined
+      expect(result.success?).to eq(false)
+      expect(result.credit_card_verification.id).to match(/^\w{6,}$/)
+      expect(result.credit_card_verification.status).to eq(Braintree::CreditCardVerification::Status::ProcessorDeclined)
+      expect(result.credit_card_verification.processor_response_code).to eq("2000")
+      expect(result.credit_card_verification.processor_response_text).to eq("Do Not Honor")
+      expect(result.credit_card_verification.processor_response_type).to eq(Braintree::ProcessorResponseTypes::SoftDeclined)
     end
 
     it "returns validation errors" do
@@ -82,8 +127,8 @@ describe Braintree::CreditCardVerification, "search" do
 
       result = Braintree::CreditCardVerification.create(verification_params)
 
-      result.success?.should == false
-      result.errors.for(:verification).for(:options).first.code.should == Braintree::ErrorCodes::Verification::Options::AmountCannotBeNegative
+      expect(result.success?).to eq(false)
+      expect(result.errors.for(:verification).for(:options).first.code).to eq(Braintree::ErrorCodes::Verification::Options::AmountCannotBeNegative)
     end
 
     it "returns account type with debit" do
@@ -98,8 +143,8 @@ describe Braintree::CreditCardVerification, "search" do
         },
       )
 
-      result.success?.should == true
-      result.credit_card_verification.credit_card[:account_type].should == "debit"
+      expect(result.success?).to eq(true)
+      expect(result.credit_card_verification.credit_card[:account_type]).to eq("debit")
     end
 
     it "returns account type with credit" do
@@ -114,8 +159,8 @@ describe Braintree::CreditCardVerification, "search" do
         },
       )
 
-      result.success?.should == true
-      result.credit_card_verification.credit_card[:account_type].should == "credit"
+      expect(result.success?).to eq(true)
+      expect(result.credit_card_verification.credit_card[:account_type]).to eq("credit")
     end
 
     it "errors with unsupported account type" do
@@ -129,8 +174,8 @@ describe Braintree::CreditCardVerification, "search" do
         },
       )
 
-      result.success?.should == false
-      result.errors.for(:verification).for(:options).on(:account_type)[0].code.should == Braintree::ErrorCodes::Verification::Options::AccountTypeNotSupported
+      expect(result.success?).to eq(false)
+      expect(result.errors.for(:verification).for(:options).on(:account_type)[0].code).to eq(Braintree::ErrorCodes::Verification::Options::AccountTypeNotSupported)
     end
 
     it "errors with invalid account type" do
@@ -145,8 +190,8 @@ describe Braintree::CreditCardVerification, "search" do
         },
       )
 
-      result.success?.should == false
-      result.errors.for(:verification).for(:options).on(:account_type)[0].code.should == Braintree::ErrorCodes::Verification::Options::AccountTypeIsInvalid
+      expect(result.success?).to eq(false)
+      expect(result.errors.for(:verification).for(:options).on(:account_type)[0].code).to eq(Braintree::ErrorCodes::Verification::Options::AccountTypeIsInvalid)
     end
   end
 
@@ -162,8 +207,8 @@ describe Braintree::CreditCardVerification, "search" do
       credit_card_verification = Braintree::Customer.create(:credit_card => credit_card_params).credit_card_verification
       found_verification = Braintree::CreditCardVerification.find(credit_card_verification.id)
 
-      found_verification.should == credit_card_verification
-      found_verification.graphql_id.should_not be_nil
+      expect(found_verification).to eq(credit_card_verification)
+      expect(found_verification.graphql_id).not_to be_nil
     end
 
     it "raises a NotFoundError exception if verification cannot be found" do
@@ -215,7 +260,7 @@ describe Braintree::CreditCardVerification, "search" do
         search.status.in credit_card_verification.status
       end
 
-      found_verifications.should include(credit_card_verification)
+      expect(found_verifications).to include(credit_card_verification)
     end
 
     it "searches and finds verifications using customer fields" do
@@ -231,7 +276,7 @@ describe Braintree::CreditCardVerification, "search" do
         search.payment_method_token.is credit_card.token
       end
 
-      found_verifications.count.should eq(1)
+      expect(found_verifications.count).to eq(1)
     end
 
     describe "card type indicators" do
@@ -256,7 +301,7 @@ describe Braintree::CreditCardVerification, "search" do
         verification_id = search_results.first.id
 
         found_verification = Braintree::CreditCardVerification.find(verification_id)
-        found_verification.credit_card[:prepaid].should == Braintree::CreditCard::Prepaid::Yes
+        expect(found_verification.credit_card[:prepaid]).to eq(Braintree::CreditCard::Prepaid::Yes)
       end
     end
   end
@@ -276,12 +321,12 @@ describe Braintree::CreditCardVerification, "search" do
 
       result = Braintree::CreditCardVerification.create(verification_params)
 
-      result.should be_success
-      result.credit_card_verification.id.should =~ /^\w{6,}$/
-      result.credit_card_verification.status.should == Braintree::CreditCardVerification::Status::Verified
-      result.credit_card_verification.processor_response_code.should == "1000"
-      result.credit_card_verification.processor_response_text.should == "Approved"
-      result.credit_card_verification.processor_response_type.should == Braintree::ProcessorResponseTypes::Approved
+      expect(result).to be_success
+      expect(result.credit_card_verification.id).to match(/^\w{6,}$/)
+      expect(result.credit_card_verification.status).to eq(Braintree::CreditCardVerification::Status::Verified)
+      expect(result.credit_card_verification.processor_response_code).to eq("1000")
+      expect(result.credit_card_verification.processor_response_text).to eq("Approved")
+      expect(result.credit_card_verification.processor_response_type).to eq(Braintree::ProcessorResponseTypes::Approved)
       expect(result.credit_card_verification.network_transaction_id).not_to be_nil
     end
   end
@@ -309,12 +354,12 @@ describe Braintree::CreditCardVerification, "search" do
 
       result = Braintree::CreditCardVerification.create(verification_params)
 
-      result.should be_success
-      result.credit_card_verification.id.should =~ /^\w{6,}$/
-      result.credit_card_verification.status.should == Braintree::CreditCardVerification::Status::Verified
-      result.credit_card_verification.processor_response_code.should == "1000"
-      result.credit_card_verification.processor_response_text.should == "Approved"
-      result.credit_card_verification.processor_response_type.should == Braintree::ProcessorResponseTypes::Approved
+      expect(result).to be_success
+      expect(result.credit_card_verification.id).to match(/^\w{6,}$/)
+      expect(result.credit_card_verification.status).to eq(Braintree::CreditCardVerification::Status::Verified)
+      expect(result.credit_card_verification.processor_response_code).to eq("1000")
+      expect(result.credit_card_verification.processor_response_text).to eq("Approved")
+      expect(result.credit_card_verification.processor_response_type).to eq(Braintree::ProcessorResponseTypes::Approved)
       expect(result.credit_card_verification.network_transaction_id).not_to be_nil
     end
 
@@ -326,7 +371,7 @@ describe Braintree::CreditCardVerification, "search" do
           :expiration_year => "2099",
         },
       )
-      nonce.should_not be_nil
+      expect(nonce).not_to be_nil
 
       verification_params = {
         :credit_card => {
@@ -341,12 +386,12 @@ describe Braintree::CreditCardVerification, "search" do
 
       result = Braintree::CreditCardVerification.create(verification_params)
 
-      result.should be_success
-      result.credit_card_verification.id.should =~ /^\w{6,}$/
-      result.credit_card_verification.status.should == Braintree::CreditCardVerification::Status::Verified
-      result.credit_card_verification.processor_response_code.should == "1000"
-      result.credit_card_verification.processor_response_text.should == "Approved"
-      result.credit_card_verification.processor_response_type.should == Braintree::ProcessorResponseTypes::Approved
+      expect(result).to be_success
+      expect(result.credit_card_verification.id).to match(/^\w{6,}$/)
+      expect(result.credit_card_verification.status).to eq(Braintree::CreditCardVerification::Status::Verified)
+      expect(result.credit_card_verification.processor_response_code).to eq("1000")
+      expect(result.credit_card_verification.processor_response_text).to eq("Approved")
+      expect(result.credit_card_verification.processor_response_type).to eq(Braintree::ProcessorResponseTypes::Approved)
       expect(result.credit_card_verification.network_transaction_id).not_to be_nil
     end
 
@@ -360,7 +405,7 @@ describe Braintree::CreditCardVerification, "search" do
           :amount => "10.00",
         },
         :three_d_secure_pass_thru => {
-          :eci_flag => "02",
+          :eci_flag => "05",
           :cavv => "some_cavv",
           :xid => "some_xid",
           :three_d_secure_version => "1.0.2",
@@ -373,12 +418,12 @@ describe Braintree::CreditCardVerification, "search" do
 
       result = Braintree::CreditCardVerification.create(verification_params)
 
-      result.should be_success
-      result.credit_card_verification.id.should =~ /^\w{6,}$/
-      result.credit_card_verification.status.should == Braintree::CreditCardVerification::Status::Verified
-      result.credit_card_verification.processor_response_code.should == "1000"
-      result.credit_card_verification.processor_response_text.should == "Approved"
-      result.credit_card_verification.processor_response_type.should == Braintree::ProcessorResponseTypes::Approved
+      expect(result).to be_success
+      expect(result.credit_card_verification.id).to match(/^\w{6,}$/)
+      expect(result.credit_card_verification.status).to eq(Braintree::CreditCardVerification::Status::Verified)
+      expect(result.credit_card_verification.processor_response_code).to eq("1000")
+      expect(result.credit_card_verification.processor_response_text).to eq("Approved")
+      expect(result.credit_card_verification.processor_response_type).to eq(Braintree::ProcessorResponseTypes::Approved)
       expect(result.credit_card_verification.network_transaction_id).not_to be_nil
     end
   end

data/spec/integration/braintree/customer_search_spec.rb

@@ -8,7 +8,7 @@ describe Braintree::Transaction, "search" do
         search.first_name.is "thisnameisnotreal"
       end
 
-      collection.maximum_size.should == 0
+      expect(collection.maximum_size).to eq(0)
     end
 
     it "can search on text fields" do
@@ -69,14 +69,14 @@ describe Braintree::Transaction, "search" do
           search.send(criterion).is value
         end
 
-        collection.maximum_size.should == 1
-        collection.first.id.should == customer.id
+        expect(collection.maximum_size).to eq(1)
+        expect(collection.first.id).to eq(customer.id)
 
         collection = Braintree::Customer.search do |search|
           search.id.is customer.id
           search.send(criterion).is("invalid_attribute")
         end
-        collection.should be_empty
+        expect(collection).to be_empty
       end
 
       collection = Braintree::Customer.search do |search|
@@ -86,8 +86,8 @@ describe Braintree::Transaction, "search" do
         end
       end
 
-      collection.maximum_size.should == 1
-      collection.first.id.should == customer.id
+      expect(collection.maximum_size).to eq(1)
+      expect(collection.first.id).to eq(customer.id)
     end
 
     it "can find duplicate credit cards for a give payment method token " do
@@ -111,8 +111,8 @@ describe Braintree::Transaction, "search" do
         search.payment_method_token_with_duplicates.is jim.credit_cards.first.token
       end
 
-      collection.should include(jim)
-      collection.should include(joe)
+      expect(collection).to include(jim)
+      expect(collection).to include(joe)
     end
 
     it "can search by created_at" do
@@ -122,7 +122,7 @@ describe Braintree::Transaction, "search" do
       )
 
       created_at = customer.created_at
-      created_at.should be_utc
+      expect(created_at).to be_utc
 
       collection = Braintree::Customer.search do |search|
         search.company.is company
@@ -132,24 +132,24 @@ describe Braintree::Transaction, "search" do
         )
       end
 
-      collection.maximum_size.should == 1
-      collection.first.id.should == customer.id
+      expect(collection.maximum_size).to eq(1)
+      expect(collection.first.id).to eq(customer.id)
 
       collection = Braintree::Customer.search do |search|
         search.company.is customer.company
         search.created_at >= created_at - 1
       end
 
-      collection.maximum_size.should == 1
-      collection.first.company.should == customer.company
+      expect(collection.maximum_size).to eq(1)
+      expect(collection.first.company).to eq(customer.company)
 
       collection = Braintree::Customer.search do |search|
         search.company.is customer.company
         search.created_at <= created_at + 1
       end
 
-      collection.maximum_size.should == 1
-      collection.first.company.should == customer.company
+      expect(collection.maximum_size).to eq(1)
+      expect(collection.first.company).to eq(customer.company)
 
       collection = Braintree::Customer.search do |search|
         search.company.is customer.company
@@ -159,15 +159,15 @@ describe Braintree::Transaction, "search" do
         )
       end
 
-      collection.maximum_size.should == 0
+      expect(collection.maximum_size).to eq(0)
 
       collection = Braintree::Customer.search do |search|
         search.company.is customer.company
         search.created_at.is created_at
       end
 
-      collection.maximum_size.should == 1
-      collection.first.company.should == customer.company
+      expect(collection.maximum_size).to eq(1)
+      expect(collection.first.company).to eq(customer.company)
     end
   end
 
@@ -189,7 +189,7 @@ describe Braintree::Transaction, "search" do
       search.id.is customer_id
     end
 
-    collection.maximum_size.should == 1
-    collection.first.should == customer
+    expect(collection.maximum_size).to eq(1)
+    expect(collection.first).to eq(customer)
   end
 end