braintree 3.1.0 → 4.1.0

data/spec/unit/braintree/customer_spec.rb

@@ -3,7 +3,7 @@ require File.expand_path(File.dirname(__FILE__) + "/../spec_helper")
 describe Braintree::Customer do
   describe "inspect" do
     it "includes the id first" do
-      output = Braintree::Customer._new(:gateway, {:first_name => 'Dan', :id => '1234'}).inspect
+      output = Braintree::Customer._new(:gateway, {:first_name => "Dan", :id => "1234"}).inspect
       output.should include("#<Braintree::Customer id: \"1234\",")
     end
 
@@ -18,7 +18,7 @@ describe Braintree::Customer do
         :phone => "802-483-5932",
         :website => "patrick.smith.com",
         :created_at => Time.now,
-        :updated_at => Time.now
+        :updated_at => Time.now,
       )
       output = customer.inspect
       output.should include(%q(company: "Company"))
@@ -31,6 +31,7 @@ describe Braintree::Customer do
       output.should include(%q(addresses: []))
       output.should include(%q(credit_cards: []))
       output.should include(%q(paypal_accounts: []))
+      output.should include(%q(tax_identifiers: []))
       output.should include(%Q(created_at: #{customer.created_at.inspect}))
       output.should include(%Q(updated_at: #{customer.updated_at.inspect}))
     end
@@ -75,7 +76,7 @@ describe Braintree::Customer do
 
   describe "self.create_signature" do
     it "should be what we expect" do
-      Braintree::CustomerGateway._create_signature.should == [
+      expect(Braintree::CustomerGateway._create_signature).to match([
         :company,
         :email,
         :fax,
@@ -100,7 +101,7 @@ describe Braintree::Customer do
           :device_data,
           :payment_method_nonce,
           {:external_vault=>[:network_transaction_id]},
-          {:options => [:make_default, :verification_merchant_account_id, :verify_card, :verification_amount, :venmo_sdk_session, :fail_on_duplicate_payment_method, :verification_account_type]},
+          {:options => match_array([:make_default, :skip_advanced_fraud_checking, :verification_merchant_account_id, :verify_card, :verification_amount, :venmo_sdk_session, :fail_on_duplicate_payment_method, :verification_account_type, :verification_currency_iso_code])},
           {:billing_address => [
             :company,
             :country_code_alpha2,
@@ -133,6 +134,10 @@ describe Braintree::Customer do
           :billing_agreement_id,
           {:options => [:make_default]},
         ]},
+        {:tax_identifiers => [
+          :country_code,
+          :identifier
+        ]},
         {:options =>
           [:paypal => [
             :payee_email,
@@ -158,13 +163,13 @@ describe Braintree::Customer do
           ]]
         },
         {:custom_fields => :_any_key_}
-      ]
+      ])
     end
   end
 
   describe "self.update_signature" do
     it "should be what we expect" do
-      Braintree::CustomerGateway._update_signature.should == [
+      expect(Braintree::CustomerGateway._update_signature).to match([
         :company,
         :email,
         :fax,
@@ -189,16 +194,18 @@ describe Braintree::Customer do
           :device_data,
           :payment_method_nonce,
           {:external_vault=>[:network_transaction_id]},
-          {:options => [
+          {:options => match_array([
             :make_default,
+            :skip_advanced_fraud_checking,
             :verification_merchant_account_id,
             :verify_card,
             :verification_amount,
             :venmo_sdk_session,
             :fail_on_duplicate_payment_method,
             :verification_account_type,
+            :verification_currency_iso_code,
             :update_existing_token
-          ]},
+          ])},
           {:billing_address => [
             :company,
             :country_code_alpha2,
@@ -226,6 +233,10 @@ describe Braintree::Customer do
             :ds_transaction_id,
           ]},
         ]},
+        {:tax_identifiers => [
+          :country_code,
+          :identifier
+        ]},
         {:options =>
           [:paypal => [
             :payee_email,
@@ -251,7 +262,7 @@ describe Braintree::Customer do
           ]]
         },
         {:custom_fields => :_any_key_}
-      ]
+      ])
     end
   end
 
@@ -289,7 +300,7 @@ describe Braintree::Customer do
         :paypal_accounts => [
           {:token => "paypal_1"},
           {:token => "paypal_2"}
-        ]
+        ],
       )
 
       customer.credit_cards.size.should == 2

data/spec/unit/braintree/disbursement_spec.rb

@@ -28,18 +28,18 @@ describe Braintree::Disbursement do
         :exception_message => "invalid_account_number",
         :follow_up_action => "update",
         :retry => false,
-        :success => false
+        :success => false,
       )
 
       disbursement.inspect.should include('id: "123456"')
       disbursement.inspect.should include('amount: "100.0"')
       disbursement.inspect.should include('exception_message: "invalid_account_number"')
-      disbursement.inspect.should include('disbursement_date: 2013-04-10')
+      disbursement.inspect.should include("disbursement_date: 2013-04-10")
       disbursement.inspect.should include('follow_up_action: "update"')
-      disbursement.inspect.should include('merchant_account: #<Braintree::MerchantAccount: ')
+      disbursement.inspect.should include("merchant_account: #<Braintree::MerchantAccount: ")
       disbursement.inspect.should include('transaction_ids: ["sub_merchant_transaction"]')
-      disbursement.inspect.should include('retry: false')
-      disbursement.inspect.should include('success: false')
+      disbursement.inspect.should include("retry: false")
+      disbursement.inspect.should include("success: false")
     end
   end
 
@@ -56,7 +56,7 @@ describe Braintree::Disbursement do
           :status => "active"
         },
         :success => false,
-        :disbursement_date => "2013-04-10"
+        :disbursement_date => "2013-04-10",
       )
       disbursement.success?.should == false
 
@@ -71,7 +71,7 @@ describe Braintree::Disbursement do
           :status => "active"
         },
         :success => true,
-        :disbursement_date => "2013-04-10"
+        :disbursement_date => "2013-04-10",
       )
       disbursement.success?.should == true
     end

data/spec/unit/braintree/dispute_search_spec.rb

@@ -41,6 +41,7 @@ describe Braintree::DisputeSearch do
   end
 
   [
+    :chargeback_protection_level,
     :kind,
     :reason,
     :status,

data/spec/unit/braintree/dispute_spec.rb

@@ -46,7 +46,14 @@ describe Braintree::Dispute do
         :order_id => nil,
         :purchase_order_number => "po",
         :payment_instrument_subtype => "Visa",
-      }
+      },
+      :paypal_messages => [
+        {
+          :message => "message",
+          :sender => "seller",
+          :sent_at => Time.utc(2009, 3, 9, 10, 50, 39),
+        }
+      ]
     }
   end
 
@@ -137,13 +144,13 @@ describe Braintree::Dispute do
       it "does not raise an exception if the optional parameters are valid" do
         Braintree::Http.stub(:new).and_return double.as_null_object
         expect do
-          Braintree::Dispute.add_file_evidence("dispute_id", { category: "GENERAL", document_id: "document_id" })
+          Braintree::Dispute.add_file_evidence("dispute_id", {category: "GENERAL", document_id: "document_id"})
         end.to_not raise_error
       end
 
       it "raises an exception if the optional params contain invalid keys" do
         expect do
-          Braintree::Dispute.add_file_evidence("dispute_id", { random_param: "" })
+          Braintree::Dispute.add_file_evidence("dispute_id", {random_param: ""})
         end.to raise_error(ArgumentError)
       end
 
@@ -151,7 +158,7 @@ describe Braintree::Dispute do
         Braintree::Http.stub(:new).and_return double.as_null_object
 
         expect do
-          Braintree::Dispute.add_file_evidence("dispute_id", { category: 3, document_id: "document_id" })
+          Braintree::Dispute.add_file_evidence("dispute_id", {category: 3, document_id: "document_id"})
         end.to raise_error(ArgumentError)
       end
     end
@@ -200,31 +207,31 @@ describe Braintree::Dispute do
       it "does not raise an exception if the optional parameters are valid" do
         Braintree::Http.stub(:new).and_return double.as_null_object
         expect do
-          Braintree::Dispute.add_text_evidence("dispute_id", { content: "a", category: "", sequence_number: 3 })
+          Braintree::Dispute.add_text_evidence("dispute_id", {content: "a", category: "", sequence_number: 3})
         end.to_not raise_error
       end
 
       it "raises an exception if the optional params contain invalid keys" do
         expect do
-          Braintree::Dispute.add_text_evidence("dispute_id", { random_param: "" })
+          Braintree::Dispute.add_text_evidence("dispute_id", {random_param: ""})
         end.to raise_error(ArgumentError)
       end
 
       it "raises an exception if sequence_number is provided and not an integer" do
         expect do
-          Braintree::Dispute.add_text_evidence("dispute_id", { sequence_number: "abc" })
+          Braintree::Dispute.add_text_evidence("dispute_id", {sequence_number: "abc"})
         end.to raise_error(ArgumentError)
       end
 
       it "raises an exception if the param tag is not a string" do
         expect do
-          Braintree::Dispute.add_text_evidence("dispute_id", { tag: 3 })
+          Braintree::Dispute.add_text_evidence("dispute_id", {tag: 3})
         end.to raise_error(ArgumentError)
       end
 
       it "raises an exception if the param category is not a string" do
         expect do
-          Braintree::Dispute.add_text_evidence("dispute_id", { category: 3 })
+          Braintree::Dispute.add_text_evidence("dispute_id", {category: 3})
         end.to raise_error(ArgumentError)
       end
     end
@@ -348,6 +355,16 @@ describe Braintree::Dispute do
       evidence2.url.should == nil
     end
 
+    it "converts paypal_messages hash into an array of Dispute::PayPalMessage objects" do
+      dispute = Braintree::Dispute._new(attributes)
+
+      dispute.paypal_messages.length.should == 1
+      paypal_message_1 = dispute.paypal_messages.first
+      paypal_message_1.message.should == "message"
+      paypal_message_1.sender.should == "seller"
+      paypal_message_1.sent_at.should == Time.utc(2009, 3, 9, 10, 50, 39)
+    end
+
     it "handles nil evidence" do
       attributes.delete(:evidence)
 
@@ -356,6 +373,14 @@ describe Braintree::Dispute do
       dispute.evidence.should == nil
     end
 
+    it "handles nil paypal_messages" do
+      attributes.delete(:paypal_messages)
+
+      dispute = Braintree::Dispute._new(attributes)
+
+      dispute.paypal_messages.should == nil
+    end
+
     it "sets the older webhook fields for backwards compatibility" do
       dispute = Braintree::Dispute._new(attributes)
 

data/spec/unit/braintree/error_result_spec.rb

@@ -10,7 +10,7 @@ describe Braintree::ErrorResult do
           :params => "params",
           :errors => {:errors => []},
           :extra => "is ignored",
-          :message => "foo bar"
+          :message => "foo bar",
         )
       end.to_not raise_error
     end
@@ -36,7 +36,7 @@ describe Braintree::ErrorResult do
         :params => "params",
         :errors => {},
         :verification => {},
-        :transaction => nil
+        :transaction => nil,
       )
       result.inspect.should include("credit_card_verification: #<Braintree::CreditCardVerification status: ")
     end
@@ -47,7 +47,7 @@ describe Braintree::ErrorResult do
         :params => "params",
         :errors => {},
         :verification => nil,
-        :transaction => nil
+        :transaction => nil,
       )
       result.inspect.should_not include("credit_card_verification")
     end
@@ -58,7 +58,7 @@ describe Braintree::ErrorResult do
         :params => "params",
         :errors => {},
         :verification => nil,
-        :transaction => {}
+        :transaction => {},
       )
       result.inspect.should include("transaction: #<Braintree::Transaction id: ")
     end
@@ -69,7 +69,7 @@ describe Braintree::ErrorResult do
         :params => "params",
         :errors => {},
         :verification => nil,
-        :transaction => nil
+        :transaction => nil,
       )
       result.inspect.should_not include("transaction")
     end

data/spec/unit/braintree/errors_spec.rb

@@ -4,7 +4,7 @@ describe Braintree::Errors do
   describe "for" do
     it "accesses errors for the given scope" do
       errors = Braintree::Errors.new(
-        :level1 => {:errors => [{:code => "code1", :attribute => "attr", :message => "message"}]}
+        :level1 => {:errors => [{:code => "code1", :attribute => "attr", :message => "message"}]},
       )
       errors.for(:level1).size.should == 1
       errors.for(:level1)[0].code.should == "code1"
@@ -12,7 +12,7 @@ describe Braintree::Errors do
 
     it "returns nil if there are no errors at the given scope" do
       errors = Braintree::Errors.new(
-        :level1 => {:errors => [{:code => "code1", :attribute => "attr", :message => "message"}]}
+        :level1 => {:errors => [{:code => "code1", :attribute => "attr", :message => "message"}]},
       )
       errors.for(:no_errors_here).should == nil
     end
@@ -21,7 +21,7 @@ describe Braintree::Errors do
   describe "inspect" do
     it "is better than the default inspect" do
       errors = Braintree::Errors.new(
-        :level1 => {:errors => [{:code => "code1", :attribute => "attr", :message => "message"}]}
+        :level1 => {:errors => [{:code => "code1", :attribute => "attr", :message => "message"}]},
       )
       errors.inspect.should == "#<Braintree::Errors level1:[(code1) message]>"
     end
@@ -33,7 +33,7 @@ describe Braintree::Errors do
           :level2 => {
             :errors => [{:code => "code2", :attribute => "attr2", :message => "message2"}],
           }
-        }
+        },
       )
       errors.inspect.should == "#<Braintree::Errors level1:[(code1) message], level1/level2:[(code2) message2]>"
     end
@@ -48,7 +48,7 @@ describe Braintree::Errors do
               :errors => [{:code => "code3", :attribute => "attr3", :message => "message3"}],
             }
           }
-        }
+        },
       )
       errors.inspect.should == "#<Braintree::Errors level1:[(code1) message], level1/level2:[(code2) message2], level1/level2/level3:[(code3) message3]>"
     end
@@ -65,7 +65,7 @@ describe Braintree::Errors do
               {:code => "3", :attribute => "attr3", :message => "message3"}
             ],
           }
-        }
+        },
       )
       errors.map { |e| e.code }.sort.should == %w[1 2 3]
     end
@@ -74,7 +74,7 @@ describe Braintree::Errors do
   describe "size" do
     it "returns the number of validation errors at the first level if only has one level" do
       errors = Braintree::Errors.new(
-        :level1 => {:errors => [{:code => "1", :attribute => "attr", :message => "message"}]}
+        :level1 => {:errors => [{:code => "1", :attribute => "attr", :message => "message"}]},
       )
       errors.size.should == 1
     end
@@ -89,7 +89,7 @@ describe Braintree::Errors do
               {:code => "3", :attribute => "attr3", :message => "message3"}
             ],
           }
-        }
+        },
       )
       errors.size.should == 3
     end

data/spec/unit/braintree/http_spec.rb

@@ -67,7 +67,7 @@ END
         :proxy_address => "localhost",
         :proxy_port => 8080,
         :proxy_user => "user",
-        :proxy_pass => "test"
+        :proxy_pass => "test",
       )
 
       http = Braintree::Http.new(config)
@@ -75,7 +75,7 @@ END
         "Net::HTTP",
         :open_timeout= => nil,
         :read_timeout= => nil,
-        :start => nil
+        :start => nil,
       )
 
       Net::HTTP.should_receive(:new).with(nil, nil, "localhost", 8080, "user", "test").and_return(net_http_instance)
@@ -86,7 +86,7 @@ END
     it "accepts a partially specified proxy" do
       config = Braintree::Configuration.new(
         :proxy_address => "localhost",
-        :proxy_port => 8080
+        :proxy_port => 8080,
       )
 
       http = Braintree::Http.new(config)
@@ -94,7 +94,7 @@ END
         "Net::HTTP",
         :open_timeout= => nil,
         :read_timeout= => nil,
-        :start => nil
+        :start => nil,
       )
 
       Net::HTTP.should_receive(:new).with(nil, nil, "localhost", 8080, nil, nil).and_return(net_http_instance)
@@ -109,7 +109,7 @@ END
         "Net::HTTP",
         :open_timeout= => nil,
         :read_timeout= => nil,
-        :start => nil
+        :start => nil,
       )
 
       Net::HTTP.should_receive(:new).with(nil, nil).and_return(net_http_instance)

data/spec/unit/braintree/merchant_account_spec.rb

@@ -13,7 +13,7 @@ describe Braintree::MerchantAccount do
         nil,
         :id => "merchant_account",
         :status => "active",
-        :master_merchant_account => {:id => "master_merchant_account", :status => "active", :master_merchant_account => nil}
+        :master_merchant_account => {:id => "master_merchant_account", :status => "active", :master_merchant_account => nil},
       )
 
       master_merchant_account = "#<Braintree::MerchantAccount: id: \"master_merchant_account\", status: \"active\", master_merchant_account: nil>"

data/spec/unit/braintree/payment_method_nonce_details_payer_info_spec.rb

@@ -0,0 +1,31 @@
+require File.expand_path(File.dirname(__FILE__) + "/../../spec_helper")
+
+describe Braintree::PaymentMethodNonceDetailsPayerInfo do
+  let(:payment_method_nonce_details_payer_info) {
+    Braintree::PaymentMethodNonceDetailsPayerInfo.new(
+      :billing_agreement_id => "billing-agreement-id",
+      :country_code => "US",
+      :email => "test@example.com",
+      :first_name => "First",
+      :last_name => "Last",
+      :payer_id => "payer-id",
+    )
+  }
+
+  describe "#initialize" do
+    it "sets attributes" do
+      payment_method_nonce_details_payer_info.billing_agreement_id.should == "billing-agreement-id"
+      payment_method_nonce_details_payer_info.country_code.should == "US"
+      payment_method_nonce_details_payer_info.email.should == "test@example.com"
+      payment_method_nonce_details_payer_info.first_name.should == "First"
+      payment_method_nonce_details_payer_info.last_name.should == "Last"
+      payment_method_nonce_details_payer_info.payer_id.should == "payer-id"
+    end
+  end
+
+  describe "inspect" do
+    it "prints the attributes" do
+      payment_method_nonce_details_payer_info.inspect.should == %(#<PaymentMethodNonceDetailsPayerInfo billing_agreement_id: \"billing-agreement-id\", country_code: \"US\", email: \"test@example.com\", first_name: \"First\", last_name: \"Last\", payer_id: \"payer-id\">)
+    end
+  end
+end